Oct 31 21:44:21.599 INFO checking saterus/gilded-rose-rust against master#05812fa8c588473f03e3fa7cf59cd84f4f37c715 for pr-55538 Oct 31 21:44:21.601 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-55538/worker-3/master#05812fa8c588473f03e3fa7cf59cd84f4f37c715:/target:rw,Z" "-v" "/mnt/big/crater/work/local/test-source/worker-3/pr-55538/master#05812fa8c588473f03e3fa7cf59cd84f4f37c715:/source:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +05812fa8c588473f03e3fa7cf59cd84f4f37c715-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Oct 31 21:44:22.126 INFO blam! 85e4e4ebdb743ed5ad4d8bbec0f9ed821673fed981b447b6e5dcf034de895ff2 Oct 31 21:44:22.129 INFO running `"docker" "start" "-a" "85e4e4ebdb743ed5ad4d8bbec0f9ed821673fed981b447b6e5dcf034de895ff2"` Oct 31 21:44:23.976 INFO kablam! usermod: no changes Oct 31 21:44:24.040 INFO kablam! Checking gilded_rose v0.1.0 (/source) Oct 31 21:44:24.862 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.863 INFO kablam! --> src/main.rs:32:12 Oct 31 21:44:24.864 INFO kablam! | Oct 31 21:44:24.865 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Oct 31 21:44:24.865 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.866 INFO kablam! | Oct 31 21:44:24.866 INFO kablam! = note: #[warn(unused_parens)] on by default Oct 31 21:44:24.867 INFO kablam! Oct 31 21:44:24.868 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.868 INFO kablam! --> src/main.rs:34:16 Oct 31 21:44:24.869 INFO kablam! | Oct 31 21:44:24.870 INFO kablam! 34 | if (items[i].quality > 0) Oct 31 21:44:24.870 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.871 INFO kablam! Oct 31 21:44:24.871 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.872 INFO kablam! --> src/main.rs:36:20 Oct 31 21:44:24.873 INFO kablam! | Oct 31 21:44:24.873 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 31 21:44:24.874 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.874 INFO kablam! Oct 31 21:44:24.875 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.876 INFO kablam! --> src/main.rs:44:16 Oct 31 21:44:24.876 INFO kablam! | Oct 31 21:44:24.877 INFO kablam! 44 | if (items[i].quality < 50) Oct 31 21:44:24.877 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.878 INFO kablam! Oct 31 21:44:24.879 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.879 INFO kablam! --> src/main.rs:48:20 Oct 31 21:44:24.880 INFO kablam! | Oct 31 21:44:24.881 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Oct 31 21:44:24.881 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.882 INFO kablam! Oct 31 21:44:24.882 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.883 INFO kablam! --> src/main.rs:50:24 Oct 31 21:44:24.884 INFO kablam! | Oct 31 21:44:24.884 INFO kablam! 50 | if (items[i].sell_in < 11) Oct 31 21:44:24.885 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.885 INFO kablam! Oct 31 21:44:24.886 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.887 INFO kablam! --> src/main.rs:52:28 Oct 31 21:44:24.887 INFO kablam! | Oct 31 21:44:24.888 INFO kablam! 52 | if (items[i].quality < 50) Oct 31 21:44:24.889 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.889 INFO kablam! Oct 31 21:44:24.890 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.890 INFO kablam! --> src/main.rs:58:24 Oct 31 21:44:24.891 INFO kablam! | Oct 31 21:44:24.891 INFO kablam! 58 | if (items[i].sell_in < 6) Oct 31 21:44:24.892 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.893 INFO kablam! Oct 31 21:44:24.893 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.894 INFO kablam! --> src/main.rs:60:28 Oct 31 21:44:24.895 INFO kablam! | Oct 31 21:44:24.895 INFO kablam! 60 | if (items[i].quality < 50) Oct 31 21:44:24.896 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.896 INFO kablam! Oct 31 21:44:24.897 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.897 INFO kablam! --> src/main.rs:69:12 Oct 31 21:44:24.898 INFO kablam! | Oct 31 21:44:24.899 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 31 21:44:24.899 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.900 INFO kablam! Oct 31 21:44:24.901 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.901 INFO kablam! --> src/main.rs:74:12 Oct 31 21:44:24.902 INFO kablam! | Oct 31 21:44:24.902 INFO kablam! 74 | if (items[i].sell_in < 0) Oct 31 21:44:24.903 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.903 INFO kablam! Oct 31 21:44:24.904 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.905 INFO kablam! --> src/main.rs:76:16 Oct 31 21:44:24.906 INFO kablam! | Oct 31 21:44:24.906 INFO kablam! 76 | if (items[i].name != "Aged Brie") Oct 31 21:44:24.907 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.907 INFO kablam! Oct 31 21:44:24.908 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.908 INFO kablam! --> src/main.rs:78:20 Oct 31 21:44:24.909 INFO kablam! | Oct 31 21:44:24.910 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Oct 31 21:44:24.910 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.911 INFO kablam! Oct 31 21:44:24.912 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.912 INFO kablam! --> src/main.rs:80:24 Oct 31 21:44:24.913 INFO kablam! | Oct 31 21:44:24.913 INFO kablam! 80 | if (items[i].quality > 0) Oct 31 21:44:24.914 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.914 INFO kablam! Oct 31 21:44:24.915 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.916 INFO kablam! --> src/main.rs:82:28 Oct 31 21:44:24.916 INFO kablam! | Oct 31 21:44:24.917 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 31 21:44:24.918 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.918 INFO kablam! Oct 31 21:44:24.919 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.919 INFO kablam! --> src/main.rs:95:20 Oct 31 21:44:24.920 INFO kablam! | Oct 31 21:44:24.921 INFO kablam! 95 | if (items[i].quality < 50) Oct 31 21:44:24.921 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.922 INFO kablam! Oct 31 21:44:24.925 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.925 INFO kablam! --> src/main.rs:32:12 Oct 31 21:44:24.926 INFO kablam! | Oct 31 21:44:24.927 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Oct 31 21:44:24.927 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.928 INFO kablam! | Oct 31 21:44:24.928 INFO kablam! = note: #[warn(unused_parens)] on by default Oct 31 21:44:24.929 INFO kablam! Oct 31 21:44:24.929 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.930 INFO kablam! --> src/main.rs:34:16 Oct 31 21:44:24.931 INFO kablam! | Oct 31 21:44:24.931 INFO kablam! 34 | if (items[i].quality > 0) Oct 31 21:44:24.932 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.932 INFO kablam! Oct 31 21:44:24.933 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.934 INFO kablam! --> src/main.rs:36:20 Oct 31 21:44:24.934 INFO kablam! | Oct 31 21:44:24.935 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 31 21:44:24.935 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.935 INFO kablam! Oct 31 21:44:24.935 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.935 INFO kablam! --> src/main.rs:44:16 Oct 31 21:44:24.935 INFO kablam! | Oct 31 21:44:24.935 INFO kablam! 44 | if (items[i].quality < 50) Oct 31 21:44:24.935 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.935 INFO kablam! Oct 31 21:44:24.935 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.935 INFO kablam! --> src/main.rs:48:20 Oct 31 21:44:24.935 INFO kablam! | Oct 31 21:44:24.935 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Oct 31 21:44:24.936 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.936 INFO kablam! Oct 31 21:44:24.936 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:50:24 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 50 | if (items[i].sell_in < 11) Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:52:28 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 52 | if (items[i].quality < 50) Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:58:24 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 58 | if (items[i].sell_in < 6) Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:60:28 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 60 | if (items[i].quality < 50) Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:69:12 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:74:12 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 74 | if (items[i].sell_in < 0) Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:76:16 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 76 | if (items[i].name != "Aged Brie") Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:78:20 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:80:24 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 80 | if (items[i].quality > 0) Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:82:28 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:24.941 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 31 21:44:24.941 INFO kablam! --> src/main.rs:95:20 Oct 31 21:44:24.941 INFO kablam! | Oct 31 21:44:24.941 INFO kablam! 95 | if (items[i].quality < 50) Oct 31 21:44:24.941 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 31 21:44:24.941 INFO kablam! Oct 31 21:44:25.021 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Oct 31 21:44:25.021 INFO kablam! --> src/main.rs:28:1 Oct 31 21:44:25.021 INFO kablam! | Oct 31 21:44:25.021 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Oct 31 21:44:25.021 INFO kablam! 29 | | { Oct 31 21:44:25.021 INFO kablam! 30 | | for i in 0..items.len() Oct 31 21:44:25.021 INFO kablam! 31 | | { Oct 31 21:44:25.021 INFO kablam! ... | Oct 31 21:44:25.021 INFO kablam! 101 | | } Oct 31 21:44:25.021 INFO kablam! 102 | | } Oct 31 21:44:25.021 INFO kablam! | |_^ Oct 31 21:44:25.021 INFO kablam! | Oct 31 21:44:25.023 INFO kablam! = note: #[warn(non_snake_case)] on by default Oct 31 21:44:25.023 INFO kablam! Oct 31 21:44:25.092 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Oct 31 21:44:25.093 INFO kablam! --> src/main.rs:28:1 Oct 31 21:44:25.093 INFO kablam! | Oct 31 21:44:25.093 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Oct 31 21:44:25.093 INFO kablam! 29 | | { Oct 31 21:44:25.093 INFO kablam! 30 | | for i in 0..items.len() Oct 31 21:44:25.093 INFO kablam! 31 | | { Oct 31 21:44:25.093 INFO kablam! ... | Oct 31 21:44:25.093 INFO kablam! 101 | | } Oct 31 21:44:25.093 INFO kablam! 102 | | } Oct 31 21:44:25.095 INFO kablam! | |_^ Oct 31 21:44:25.095 INFO kablam! | Oct 31 21:44:25.095 INFO kablam! = note: #[warn(non_snake_case)] on by default Oct 31 21:44:25.095 INFO kablam! Oct 31 21:44:25.120 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.11s Oct 31 21:44:25.123 INFO kablam! su: No module specific data is present Oct 31 21:44:25.989 INFO running `"docker" "rm" "-f" "85e4e4ebdb743ed5ad4d8bbec0f9ed821673fed981b447b6e5dcf034de895ff2"` Oct 31 21:44:26.164 INFO blam! 85e4e4ebdb743ed5ad4d8bbec0f9ed821673fed981b447b6e5dcf034de895ff2