Oct 12 14:19:11.661 INFO checking saterus/gilded-rose-rust against master#5af0bb83044c3fb43d59ad5f49ee5ae1a293901f for pr-54977 Oct 12 14:19:11.661 INFO running `"docker" "create" "-v" "/mnt/big/crater/./work/local/target-dirs/pr-54977/worker-1/master#5af0bb83044c3fb43d59ad5f49ee5ae1a293901f:/target:rw,Z" "-v" "/mnt/big/crater/./work/local/test-source/worker-1/pr-54977/master#5af0bb83044c3fb43d59ad5f49ee5ae1a293901f:/source:ro,Z" "-v" "/mnt/big/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/mnt/big/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/source" "-e" "USER_ID=1000" "-e" "CMD=cargo +5af0bb83044c3fb43d59ad5f49ee5ae1a293901f-alt check --frozen --all --all-targets" "-e" "CARGO_TARGET_DIR=/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/cargo-home" "-e" "RUSTUP_HOME=/rustup-home" "-m" "1536M" "--network" "none" "crater"` Oct 12 14:19:11.952 INFO blam! 95a8763f813449d412183216c05904ba560099055b26df5c0c454601ffb141d1 Oct 12 14:19:11.958 INFO running `"docker" "start" "-a" "95a8763f813449d412183216c05904ba560099055b26df5c0c454601ffb141d1"` Oct 12 14:19:12.457 INFO kablam! usermod: no changes Oct 12 14:19:12.481 INFO kablam! Checking gilded_rose v0.1.0 (/source) Oct 12 14:19:12.873 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.873 INFO kablam! --> src/main.rs:32:12 Oct 12 14:19:12.873 INFO kablam! | Oct 12 14:19:12.873 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Oct 12 14:19:12.873 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Oct 12 14:19:12.873 INFO kablam! | Oct 12 14:19:12.873 INFO kablam! = note: #[warn(unused_parens)] on by default Oct 12 14:19:12.873 INFO kablam! help: remove these parentheses Oct 12 14:19:12.873 INFO kablam! | Oct 12 14:19:12.873 INFO kablam! 32 | if items[i].name != "Aged Brie" && Oct 12 14:19:12.873 INFO kablam! 33 | items[i].name != "Backstage passes to a TAFKAL80ETC concert" Oct 12 14:19:12.873 INFO kablam! | Oct 12 14:19:12.873 INFO kablam! Oct 12 14:19:12.873 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.873 INFO kablam! --> src/main.rs:34:16 Oct 12 14:19:12.873 INFO kablam! | Oct 12 14:19:12.873 INFO kablam! 34 | if (items[i].quality > 0) Oct 12 14:19:12.873 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.873 INFO kablam! Oct 12 14:19:12.874 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.874 INFO kablam! --> src/main.rs:36:20 Oct 12 14:19:12.874 INFO kablam! | Oct 12 14:19:12.874 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 12 14:19:12.874 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.874 INFO kablam! Oct 12 14:19:12.874 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.874 INFO kablam! --> src/main.rs:44:16 Oct 12 14:19:12.874 INFO kablam! | Oct 12 14:19:12.874 INFO kablam! 44 | if (items[i].quality < 50) Oct 12 14:19:12.874 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.874 INFO kablam! Oct 12 14:19:12.874 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.874 INFO kablam! --> src/main.rs:48:20 Oct 12 14:19:12.874 INFO kablam! | Oct 12 14:19:12.874 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Oct 12 14:19:12.874 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.874 INFO kablam! Oct 12 14:19:12.874 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.874 INFO kablam! --> src/main.rs:50:24 Oct 12 14:19:12.874 INFO kablam! | Oct 12 14:19:12.874 INFO kablam! 50 | if (items[i].sell_in < 11) Oct 12 14:19:12.874 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.874 INFO kablam! Oct 12 14:19:12.874 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.874 INFO kablam! --> src/main.rs:52:28 Oct 12 14:19:12.874 INFO kablam! | Oct 12 14:19:12.874 INFO kablam! 52 | if (items[i].quality < 50) Oct 12 14:19:12.874 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.874 INFO kablam! Oct 12 14:19:12.875 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.875 INFO kablam! --> src/main.rs:58:24 Oct 12 14:19:12.875 INFO kablam! | Oct 12 14:19:12.875 INFO kablam! 58 | if (items[i].sell_in < 6) Oct 12 14:19:12.875 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.875 INFO kablam! Oct 12 14:19:12.875 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.875 INFO kablam! --> src/main.rs:60:28 Oct 12 14:19:12.875 INFO kablam! | Oct 12 14:19:12.875 INFO kablam! 60 | if (items[i].quality < 50) Oct 12 14:19:12.875 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.875 INFO kablam! Oct 12 14:19:12.875 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.875 INFO kablam! --> src/main.rs:69:12 Oct 12 14:19:12.875 INFO kablam! | Oct 12 14:19:12.875 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 12 14:19:12.875 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.875 INFO kablam! Oct 12 14:19:12.875 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.875 INFO kablam! --> src/main.rs:74:12 Oct 12 14:19:12.875 INFO kablam! | Oct 12 14:19:12.875 INFO kablam! 74 | if (items[i].sell_in < 0) Oct 12 14:19:12.875 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.875 INFO kablam! Oct 12 14:19:12.875 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.875 INFO kablam! --> src/main.rs:76:16 Oct 12 14:19:12.875 INFO kablam! | Oct 12 14:19:12.875 INFO kablam! 76 | if (items[i].name != "Aged Brie") Oct 12 14:19:12.875 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.875 INFO kablam! Oct 12 14:19:12.875 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.875 INFO kablam! --> src/main.rs:78:20 Oct 12 14:19:12.875 INFO kablam! | Oct 12 14:19:12.875 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Oct 12 14:19:12.875 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.875 INFO kablam! Oct 12 14:19:12.875 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.875 INFO kablam! --> src/main.rs:80:24 Oct 12 14:19:12.875 INFO kablam! | Oct 12 14:19:12.876 INFO kablam! 80 | if (items[i].quality > 0) Oct 12 14:19:12.876 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.876 INFO kablam! Oct 12 14:19:12.876 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.876 INFO kablam! --> src/main.rs:82:28 Oct 12 14:19:12.876 INFO kablam! | Oct 12 14:19:12.876 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 12 14:19:12.876 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.876 INFO kablam! Oct 12 14:19:12.876 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.876 INFO kablam! --> src/main.rs:95:20 Oct 12 14:19:12.876 INFO kablam! | Oct 12 14:19:12.876 INFO kablam! 95 | if (items[i].quality < 50) Oct 12 14:19:12.876 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.876 INFO kablam! Oct 12 14:19:12.923 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Oct 12 14:19:12.923 INFO kablam! --> src/main.rs:28:1 Oct 12 14:19:12.923 INFO kablam! | Oct 12 14:19:12.923 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Oct 12 14:19:12.923 INFO kablam! 29 | | { Oct 12 14:19:12.923 INFO kablam! 30 | | for i in 0..items.len() Oct 12 14:19:12.923 INFO kablam! 31 | | { Oct 12 14:19:12.923 INFO kablam! ... | Oct 12 14:19:12.923 INFO kablam! 101 | | } Oct 12 14:19:12.923 INFO kablam! 102 | | } Oct 12 14:19:12.923 INFO kablam! | |_^ Oct 12 14:19:12.923 INFO kablam! | Oct 12 14:19:12.923 INFO kablam! = note: #[warn(non_snake_case)] on by default Oct 12 14:19:12.923 INFO kablam! Oct 12 14:19:12.952 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.952 INFO kablam! --> src/main.rs:32:12 Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Oct 12 14:19:12.952 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! = note: #[warn(unused_parens)] on by default Oct 12 14:19:12.952 INFO kablam! help: remove these parentheses Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! 32 | if items[i].name != "Aged Brie" && Oct 12 14:19:12.952 INFO kablam! 33 | items[i].name != "Backstage passes to a TAFKAL80ETC concert" Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! Oct 12 14:19:12.952 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.952 INFO kablam! --> src/main.rs:34:16 Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! 34 | if (items[i].quality > 0) Oct 12 14:19:12.952 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.952 INFO kablam! Oct 12 14:19:12.952 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.952 INFO kablam! --> src/main.rs:36:20 Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 12 14:19:12.952 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.952 INFO kablam! Oct 12 14:19:12.952 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.952 INFO kablam! --> src/main.rs:44:16 Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! 44 | if (items[i].quality < 50) Oct 12 14:19:12.952 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.952 INFO kablam! Oct 12 14:19:12.952 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.952 INFO kablam! --> src/main.rs:48:20 Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Oct 12 14:19:12.952 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.952 INFO kablam! Oct 12 14:19:12.952 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.952 INFO kablam! --> src/main.rs:50:24 Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! 50 | if (items[i].sell_in < 11) Oct 12 14:19:12.952 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.952 INFO kablam! Oct 12 14:19:12.952 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.952 INFO kablam! --> src/main.rs:52:28 Oct 12 14:19:12.952 INFO kablam! | Oct 12 14:19:12.952 INFO kablam! 52 | if (items[i].quality < 50) Oct 12 14:19:12.953 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.953 INFO kablam! Oct 12 14:19:12.953 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.953 INFO kablam! --> src/main.rs:58:24 Oct 12 14:19:12.953 INFO kablam! | Oct 12 14:19:12.953 INFO kablam! 58 | if (items[i].sell_in < 6) Oct 12 14:19:12.953 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.953 INFO kablam! Oct 12 14:19:12.953 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.953 INFO kablam! --> src/main.rs:60:28 Oct 12 14:19:12.953 INFO kablam! | Oct 12 14:19:12.953 INFO kablam! 60 | if (items[i].quality < 50) Oct 12 14:19:12.953 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.953 INFO kablam! Oct 12 14:19:12.953 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.953 INFO kablam! --> src/main.rs:69:12 Oct 12 14:19:12.953 INFO kablam! | Oct 12 14:19:12.953 INFO kablam! 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 12 14:19:12.953 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.953 INFO kablam! Oct 12 14:19:12.953 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.953 INFO kablam! --> src/main.rs:74:12 Oct 12 14:19:12.954 INFO kablam! | Oct 12 14:19:12.954 INFO kablam! 74 | if (items[i].sell_in < 0) Oct 12 14:19:12.954 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.954 INFO kablam! Oct 12 14:19:12.954 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.954 INFO kablam! --> src/main.rs:76:16 Oct 12 14:19:12.954 INFO kablam! | Oct 12 14:19:12.954 INFO kablam! 76 | if (items[i].name != "Aged Brie") Oct 12 14:19:12.954 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.954 INFO kablam! Oct 12 14:19:12.954 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.954 INFO kablam! --> src/main.rs:78:20 Oct 12 14:19:12.954 INFO kablam! | Oct 12 14:19:12.954 INFO kablam! 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Oct 12 14:19:12.954 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.954 INFO kablam! Oct 12 14:19:12.954 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.954 INFO kablam! --> src/main.rs:80:24 Oct 12 14:19:12.954 INFO kablam! | Oct 12 14:19:12.954 INFO kablam! 80 | if (items[i].quality > 0) Oct 12 14:19:12.954 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.954 INFO kablam! Oct 12 14:19:12.954 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.954 INFO kablam! --> src/main.rs:82:28 Oct 12 14:19:12.954 INFO kablam! | Oct 12 14:19:12.954 INFO kablam! 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Oct 12 14:19:12.954 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.954 INFO kablam! Oct 12 14:19:12.954 INFO kablam! warning: unnecessary parentheses around `if` condition Oct 12 14:19:12.954 INFO kablam! --> src/main.rs:95:20 Oct 12 14:19:12.954 INFO kablam! | Oct 12 14:19:12.954 INFO kablam! 95 | if (items[i].quality < 50) Oct 12 14:19:12.954 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Oct 12 14:19:12.954 INFO kablam! Oct 12 14:19:13.026 INFO kablam! warning: function `UpdateQuality` should have a snake case name such as `update_quality` Oct 12 14:19:13.026 INFO kablam! --> src/main.rs:28:1 Oct 12 14:19:13.026 INFO kablam! | Oct 12 14:19:13.026 INFO kablam! 28 | / fn UpdateQuality(items: &mut [Item]) Oct 12 14:19:13.026 INFO kablam! 29 | | { Oct 12 14:19:13.026 INFO kablam! 30 | | for i in 0..items.len() Oct 12 14:19:13.026 INFO kablam! 31 | | { Oct 12 14:19:13.026 INFO kablam! ... | Oct 12 14:19:13.026 INFO kablam! 101 | | } Oct 12 14:19:13.026 INFO kablam! 102 | | } Oct 12 14:19:13.026 INFO kablam! | |_^ Oct 12 14:19:13.026 INFO kablam! | Oct 12 14:19:13.026 INFO kablam! = note: #[warn(non_snake_case)] on by default Oct 12 14:19:13.026 INFO kablam! Oct 12 14:19:13.041 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 0.57s Oct 12 14:19:13.042 INFO kablam! su: No module specific data is present Oct 12 14:19:13.333 INFO running `"docker" "rm" "-f" "95a8763f813449d412183216c05904ba560099055b26df5c0c454601ffb141d1"` Oct 12 14:19:13.441 INFO blam! 95a8763f813449d412183216c05904ba560099055b26df5c0c454601ffb141d1