Sep 19 16:29:33.986 INFO checking benbrunton/les against master#1e21c9a297a9fe668d62887a3a6a4add8e717b17 for pr-54352 Sep 19 16:29:33.986 INFO running: cargo +1e21c9a297a9fe668d62887a3a6a4add8e717b17-alt check --frozen --all --all-targets Sep 19 16:29:33.986 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-0/pr-54352/master#1e21c9a297a9fe668d62887a3a6a4add8e717b17:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-54352/worker-0/master#1e21c9a297a9fe668d62887a3a6a4add8e717b17:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "CMD=cargo +1e21c9a297a9fe668d62887a3a6a4add8e717b17-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-m" "1536M" "crater"` Sep 19 16:29:34.187 INFO blam! 98d323c12a740462b5285c6d8b38eefed9819fd3b7d2ae439c8319e5e6370627 Sep 19 16:29:34.189 INFO running `"docker" "start" "-a" "98d323c12a740462b5285c6d8b38eefed9819fd3b7d2ae439c8319e5e6370627"` Sep 19 16:29:36.169 INFO kablam! usermod: no changes Sep 19 16:29:36.341 INFO kablam! Checking terminal_size v0.1.7 Sep 19 16:29:36.692 INFO kablam! Checking les v0.2.1 (/source) Sep 19 16:29:37.170 INFO kablam! warning: unused import: `std::io::stdout` Sep 19 16:29:37.170 INFO kablam! --> src/main.rs:8:5 Sep 19 16:29:37.170 INFO kablam! | Sep 19 16:29:37.170 INFO kablam! 8 | use std::io::stdout; Sep 19 16:29:37.170 INFO kablam! | ^^^^^^^^^^^^^^^ Sep 19 16:29:37.170 INFO kablam! | Sep 19 16:29:37.170 INFO kablam! = note: #[warn(unused_imports)] on by default Sep 19 16:29:37.170 INFO kablam! Sep 19 16:29:37.170 INFO kablam! warning: unused import: `std::io::Write` Sep 19 16:29:37.171 INFO kablam! --> src/les/mod.rs:2:5 Sep 19 16:29:37.171 INFO kablam! | Sep 19 16:29:37.171 INFO kablam! 2 | use std::io::Write; Sep 19 16:29:37.171 INFO kablam! | ^^^^^^^^^^^^^^ Sep 19 16:29:37.171 INFO kablam! Sep 19 16:29:37.171 INFO kablam! warning: unused import: `decorate::Decorate` Sep 19 16:29:37.171 INFO kablam! --> src/les/mod.rs:4:5 Sep 19 16:29:37.171 INFO kablam! | Sep 19 16:29:37.171 INFO kablam! 4 | use decorate::Decorate; Sep 19 16:29:37.171 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Sep 19 16:29:37.171 INFO kablam! Sep 19 16:29:37.171 INFO kablam! warning: unused import: `paintitems::PaintItems` Sep 19 16:29:37.171 INFO kablam! --> src/les/mod.rs:5:5 Sep 19 16:29:37.171 INFO kablam! | Sep 19 16:29:37.171 INFO kablam! 5 | use paintitems::PaintItems; Sep 19 16:29:37.171 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Sep 19 16:29:37.171 INFO kablam! Sep 19 16:29:37.172 INFO kablam! warning: unused imports: `Stdout`, `stdout` Sep 19 16:29:37.172 INFO kablam! --> src/io/mod.rs:1:15 Sep 19 16:29:37.172 INFO kablam! | Sep 19 16:29:37.172 INFO kablam! 1 | use std::io::{Stdout,stdout}; Sep 19 16:29:37.172 INFO kablam! | ^^^^^^ ^^^^^^ Sep 19 16:29:37.172 INFO kablam! Sep 19 16:29:37.172 INFO kablam! warning: unused import: `min` Sep 19 16:29:37.172 INFO kablam! --> src/io/mod.rs:2:16 Sep 19 16:29:37.172 INFO kablam! | Sep 19 16:29:37.172 INFO kablam! 2 | use std::cmp::{min,max}; Sep 19 16:29:37.172 INFO kablam! | ^^^ Sep 19 16:29:37.172 INFO kablam! Sep 19 16:29:37.173 INFO kablam! warning: unused import: `std::str::FromStr` Sep 19 16:29:37.173 INFO kablam! --> src/decorate/mod.rs:8:5 Sep 19 16:29:37.173 INFO kablam! | Sep 19 16:29:37.174 INFO kablam! 8 | use std::str::FromStr; Sep 19 16:29:37.174 INFO kablam! | ^^^^^^^^^^^^^^^^^ Sep 19 16:29:37.174 INFO kablam! Sep 19 16:29:37.234 INFO kablam! warning: unused import: `std::io::stdout` Sep 19 16:29:37.234 INFO kablam! --> src/main.rs:8:5 Sep 19 16:29:37.235 INFO kablam! | Sep 19 16:29:37.235 INFO kablam! 8 | use std::io::stdout; Sep 19 16:29:37.235 INFO kablam! | ^^^^^^^^^^^^^^^ Sep 19 16:29:37.235 INFO kablam! | Sep 19 16:29:37.236 INFO kablam! = note: #[warn(unused_imports)] on by default Sep 19 16:29:37.236 INFO kablam! Sep 19 16:29:37.236 INFO kablam! warning: unused import: `std::io::Write` Sep 19 16:29:37.236 INFO kablam! --> src/les/mod.rs:2:5 Sep 19 16:29:37.237 INFO kablam! | Sep 19 16:29:37.237 INFO kablam! 2 | use std::io::Write; Sep 19 16:29:37.237 INFO kablam! | ^^^^^^^^^^^^^^ Sep 19 16:29:37.237 INFO kablam! Sep 19 16:29:37.238 INFO kablam! warning: unused import: `decorate::Decorate` Sep 19 16:29:37.238 INFO kablam! --> src/les/mod.rs:4:5 Sep 19 16:29:37.238 INFO kablam! | Sep 19 16:29:37.239 INFO kablam! 4 | use decorate::Decorate; Sep 19 16:29:37.239 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Sep 19 16:29:37.239 INFO kablam! Sep 19 16:29:37.239 INFO kablam! warning: unused import: `paintitems::PaintItems` Sep 19 16:29:37.240 INFO kablam! --> src/les/mod.rs:5:5 Sep 19 16:29:37.240 INFO kablam! | Sep 19 16:29:37.240 INFO kablam! 5 | use paintitems::PaintItems; Sep 19 16:29:37.241 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Sep 19 16:29:37.241 INFO kablam! Sep 19 16:29:37.241 INFO kablam! warning: unused import: `std` Sep 19 16:29:37.241 INFO kablam! --> src/les/mod.rs:43:9 Sep 19 16:29:37.242 INFO kablam! | Sep 19 16:29:37.242 INFO kablam! 43 | use std; Sep 19 16:29:37.242 INFO kablam! | ^^^ Sep 19 16:29:37.243 INFO kablam! Sep 19 16:29:37.243 INFO kablam! warning: unused imports: `Stdout`, `stdout` Sep 19 16:29:37.243 INFO kablam! --> src/io/mod.rs:1:15 Sep 19 16:29:37.244 INFO kablam! | Sep 19 16:29:37.244 INFO kablam! 1 | use std::io::{Stdout,stdout}; Sep 19 16:29:37.244 INFO kablam! | ^^^^^^ ^^^^^^ Sep 19 16:29:37.244 INFO kablam! Sep 19 16:29:37.245 INFO kablam! warning: unused import: `min` Sep 19 16:29:37.245 INFO kablam! --> src/io/mod.rs:2:16 Sep 19 16:29:37.245 INFO kablam! | Sep 19 16:29:37.246 INFO kablam! 2 | use std::cmp::{min,max}; Sep 19 16:29:37.246 INFO kablam! | ^^^ Sep 19 16:29:37.246 INFO kablam! Sep 19 16:29:37.247 INFO kablam! warning: unused import: `std::str::FromStr` Sep 19 16:29:37.247 INFO kablam! --> src/decorate/mod.rs:8:5 Sep 19 16:29:37.247 INFO kablam! | Sep 19 16:29:37.247 INFO kablam! 8 | use std::str::FromStr; Sep 19 16:29:37.248 INFO kablam! | ^^^^^^^^^^^^^^^^^ Sep 19 16:29:37.248 INFO kablam! Sep 19 16:29:37.526 INFO kablam! warning: unused variable: `inodes_count` Sep 19 16:29:37.526 INFO kablam! --> src/io/mod.rs:27:13 Sep 19 16:29:37.527 INFO kablam! | Sep 19 16:29:37.527 INFO kablam! 27 | let inodes_count = inodes.len(); Sep 19 16:29:37.528 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Sep 19 16:29:37.528 INFO kablam! | Sep 19 16:29:37.528 INFO kablam! = note: #[warn(unused_variables)] on by default Sep 19 16:29:37.529 INFO kablam! Sep 19 16:29:37.529 INFO kablam! warning: value assigned to `prev_item_length` is never read Sep 19 16:29:37.530 INFO kablam! --> src/io/mod.rs:73:21 Sep 19 16:29:37.530 INFO kablam! | Sep 19 16:29:37.530 INFO kablam! 73 | let mut prev_item_length = 0; Sep 19 16:29:37.530 INFO kablam! | ^^^^^^^^^^^^^^^^ Sep 19 16:29:37.531 INFO kablam! | Sep 19 16:29:37.531 INFO kablam! = note: #[warn(unused_assignments)] on by default Sep 19 16:29:37.531 INFO kablam! Sep 19 16:29:37.563 INFO kablam! warning: variable does not need to be mutable Sep 19 16:29:37.564 INFO kablam! --> src/io/mod.rs:120:13 Sep 19 16:29:37.564 INFO kablam! | Sep 19 16:29:37.564 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Sep 19 16:29:37.565 INFO kablam! | ----^^^^^^^^^^^^^ Sep 19 16:29:37.565 INFO kablam! | | Sep 19 16:29:37.565 INFO kablam! | help: remove this `mut` Sep 19 16:29:37.566 INFO kablam! | Sep 19 16:29:37.566 INFO kablam! = note: #[warn(unused_mut)] on by default Sep 19 16:29:37.566 INFO kablam! Sep 19 16:29:37.594 INFO kablam! warning: field is never used: `path` Sep 19 16:29:37.595 INFO kablam! --> src/fs/mod.rs:92:5 Sep 19 16:29:37.595 INFO kablam! | Sep 19 16:29:37.595 INFO kablam! 92 | path: String Sep 19 16:29:37.595 INFO kablam! | ^^^^^^^^^^^^ Sep 19 16:29:37.595 INFO kablam! | Sep 19 16:29:37.596 INFO kablam! = note: #[warn(dead_code)] on by default Sep 19 16:29:37.596 INFO kablam! Sep 19 16:29:37.596 INFO kablam! warning: method is never used: `get_path` Sep 19 16:29:37.596 INFO kablam! --> src/fs/mod.rs:117:5 Sep 19 16:29:37.597 INFO kablam! | Sep 19 16:29:37.597 INFO kablam! 117 | pub fn get_path(&self) -> String { Sep 19 16:29:37.597 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sep 19 16:29:37.598 INFO kablam! Sep 19 16:29:37.598 INFO kablam! warning: comparison is useless due to type limits Sep 19 16:29:37.598 INFO kablam! --> src/paintitems/mod.rs:25:41 Sep 19 16:29:37.598 INFO kablam! | Sep 19 16:29:37.598 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Sep 19 16:29:37.598 INFO kablam! | ^^^^^^^^^ Sep 19 16:29:37.598 INFO kablam! | Sep 19 16:29:37.598 INFO kablam! = note: #[warn(unused_comparisons)] on by default Sep 19 16:29:37.598 INFO kablam! Sep 19 16:29:37.666 INFO kablam! warning: unused variable: `decorator` Sep 19 16:29:37.666 INFO kablam! --> src/les/mod.rs:53:13 Sep 19 16:29:37.666 INFO kablam! | Sep 19 16:29:37.666 INFO kablam! 53 | let decorator = decorate::Decorate::new(None); Sep 19 16:29:37.666 INFO kablam! | ^^^^^^^^^ help: consider using `_decorator` instead Sep 19 16:29:37.666 INFO kablam! | Sep 19 16:29:37.666 INFO kablam! = note: #[warn(unused_variables)] on by default Sep 19 16:29:37.666 INFO kablam! Sep 19 16:29:37.666 INFO kablam! warning: unused variable: `inodes_count` Sep 19 16:29:37.666 INFO kablam! --> src/io/mod.rs:27:13 Sep 19 16:29:37.666 INFO kablam! | Sep 19 16:29:37.666 INFO kablam! 27 | let inodes_count = inodes.len(); Sep 19 16:29:37.666 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Sep 19 16:29:37.666 INFO kablam! Sep 19 16:29:37.666 INFO kablam! warning: value assigned to `prev_item_length` is never read Sep 19 16:29:37.666 INFO kablam! --> src/io/mod.rs:73:21 Sep 19 16:29:37.666 INFO kablam! | Sep 19 16:29:37.666 INFO kablam! 73 | let mut prev_item_length = 0; Sep 19 16:29:37.666 INFO kablam! | ^^^^^^^^^^^^^^^^ Sep 19 16:29:37.666 INFO kablam! | Sep 19 16:29:37.666 INFO kablam! = note: #[warn(unused_assignments)] on by default Sep 19 16:29:37.666 INFO kablam! Sep 19 16:29:37.698 INFO kablam! warning: variable does not need to be mutable Sep 19 16:29:37.698 INFO kablam! --> src/io/mod.rs:120:13 Sep 19 16:29:37.698 INFO kablam! | Sep 19 16:29:37.698 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Sep 19 16:29:37.698 INFO kablam! | ----^^^^^^^^^^^^^ Sep 19 16:29:37.698 INFO kablam! | | Sep 19 16:29:37.698 INFO kablam! | help: remove this `mut` Sep 19 16:29:37.698 INFO kablam! | Sep 19 16:29:37.698 INFO kablam! = note: #[warn(unused_mut)] on by default Sep 19 16:29:37.698 INFO kablam! Sep 19 16:29:37.730 INFO kablam! warning: field is never used: `path` Sep 19 16:29:37.730 INFO kablam! --> src/fs/mod.rs:92:5 Sep 19 16:29:37.730 INFO kablam! | Sep 19 16:29:37.730 INFO kablam! 92 | path: String Sep 19 16:29:37.730 INFO kablam! | ^^^^^^^^^^^^ Sep 19 16:29:37.730 INFO kablam! | Sep 19 16:29:37.730 INFO kablam! = note: #[warn(dead_code)] on by default Sep 19 16:29:37.730 INFO kablam! Sep 19 16:29:37.730 INFO kablam! warning: method is never used: `get_path` Sep 19 16:29:37.730 INFO kablam! --> src/fs/mod.rs:117:5 Sep 19 16:29:37.730 INFO kablam! | Sep 19 16:29:37.730 INFO kablam! 117 | pub fn get_path(&self) -> String { Sep 19 16:29:37.730 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sep 19 16:29:37.730 INFO kablam! Sep 19 16:29:37.734 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Sep 19 16:29:37.734 INFO kablam! --> src/style/mod.rs:67:13 Sep 19 16:29:37.734 INFO kablam! | Sep 19 16:29:37.734 INFO kablam! 67 | let licenseItem = PaintItem{ Sep 19 16:29:37.734 INFO kablam! | ^^^^^^^^^^^ Sep 19 16:29:37.734 INFO kablam! | Sep 19 16:29:37.734 INFO kablam! = note: #[warn(non_snake_case)] on by default Sep 19 16:29:37.734 INFO kablam! Sep 19 16:29:37.734 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Sep 19 16:29:37.734 INFO kablam! --> src/style/mod.rs:83:13 Sep 19 16:29:37.734 INFO kablam! | Sep 19 16:29:37.734 INFO kablam! 83 | let licenseItem = PaintItem{ Sep 19 16:29:37.734 INFO kablam! | ^^^^^^^^^^^ Sep 19 16:29:37.734 INFO kablam! Sep 19 16:29:37.734 INFO kablam! warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item` Sep 19 16:29:37.734 INFO kablam! --> src/decorate/mod.rs:201:5 Sep 19 16:29:37.734 INFO kablam! | Sep 19 16:29:37.734 INFO kablam! 201 | / fn it_returns_a_Paint_Item() { Sep 19 16:29:37.734 INFO kablam! 202 | | Sep 19 16:29:37.734 INFO kablam! 203 | | let file = File::new( Sep 19 16:29:37.734 INFO kablam! 204 | | String::from("filename"), Sep 19 16:29:37.734 INFO kablam! ... | Sep 19 16:29:37.734 INFO kablam! 222 | | assert_eq!(paint_item, expected_result); Sep 19 16:29:37.734 INFO kablam! 223 | | } Sep 19 16:29:37.734 INFO kablam! | |_____^ Sep 19 16:29:37.735 INFO kablam! Sep 19 16:29:37.735 INFO kablam! warning: comparison is useless due to type limits Sep 19 16:29:37.735 INFO kablam! --> src/paintitems/mod.rs:25:41 Sep 19 16:29:37.735 INFO kablam! | Sep 19 16:29:37.735 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Sep 19 16:29:37.735 INFO kablam! | ^^^^^^^^^ Sep 19 16:29:37.735 INFO kablam! | Sep 19 16:29:37.735 INFO kablam! = note: #[warn(unused_comparisons)] on by default Sep 19 16:29:37.735 INFO kablam! Sep 19 16:29:37.806 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.61s Sep 19 16:29:37.807 INFO kablam! su: No module specific data is present Sep 19 16:29:39.244 INFO running `"docker" "rm" "-f" "98d323c12a740462b5285c6d8b38eefed9819fd3b7d2ae439c8319e5e6370627"` Sep 19 16:29:39.361 INFO blam! 98d323c12a740462b5285c6d8b38eefed9819fd3b7d2ae439c8319e5e6370627