Dec 17 16:05:28.670 INFO checking saterus/gilded-rose-rust against try#0b8c5828f68d7b2840b81fa51239346dc97fef5a for pr-54252 Dec 17 16:05:28.670 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-54252/worker-4/try#0b8c5828f68d7b2840b81fa51239346dc97fef5a:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/pr-54252/sources/try#0b8c5828f68d7b2840b81fa51239346dc97fef5a/gh/saterus/gilded-rose-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+0b8c5828f68d7b2840b81fa51239346dc97fef5a-alt" "check" "--frozen" "--all" "--all-targets"` Dec 17 16:05:28.945 INFO [stdout] 01ffd58a28df72086a84c83a5a0be2324dc3f43eb64cdfec1edd94c5eb27c12d Dec 17 16:05:28.948 INFO running `"docker" "start" "-a" "01ffd58a28df72086a84c83a5a0be2324dc3f43eb64cdfec1edd94c5eb27c12d"` Dec 17 16:05:29.980 INFO [stderr] Checking gilded_rose v0.1.0 (/opt/crater/workdir) Dec 17 16:05:30.387 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.388 INFO [stderr] --> src/main.rs:32:12 Dec 17 16:05:30.388 INFO [stderr] | Dec 17 16:05:30.388 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.388 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.388 INFO [stderr] | Dec 17 16:05:30.388 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 17 16:05:30.388 INFO [stderr] Dec 17 16:05:30.388 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.388 INFO [stderr] --> src/main.rs:34:16 Dec 17 16:05:30.388 INFO [stderr] | Dec 17 16:05:30.388 INFO [stderr] 34 | if (items[i].quality > 0) Dec 17 16:05:30.388 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.388 INFO [stderr] Dec 17 16:05:30.388 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.388 INFO [stderr] --> src/main.rs:36:20 Dec 17 16:05:30.388 INFO [stderr] | Dec 17 16:05:30.388 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.388 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.388 INFO [stderr] Dec 17 16:05:30.388 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.388 INFO [stderr] --> src/main.rs:44:16 Dec 17 16:05:30.388 INFO [stderr] | Dec 17 16:05:30.388 INFO [stderr] 44 | if (items[i].quality < 50) Dec 17 16:05:30.388 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.388 INFO [stderr] Dec 17 16:05:30.388 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.388 INFO [stderr] --> src/main.rs:48:20 Dec 17 16:05:30.388 INFO [stderr] | Dec 17 16:05:30.388 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.388 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.388 INFO [stderr] Dec 17 16:05:30.388 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.388 INFO [stderr] --> src/main.rs:50:24 Dec 17 16:05:30.389 INFO [stderr] | Dec 17 16:05:30.389 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 17 16:05:30.389 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.389 INFO [stderr] Dec 17 16:05:30.389 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.389 INFO [stderr] --> src/main.rs:52:28 Dec 17 16:05:30.389 INFO [stderr] | Dec 17 16:05:30.389 INFO [stderr] 52 | if (items[i].quality < 50) Dec 17 16:05:30.389 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.389 INFO [stderr] Dec 17 16:05:30.389 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.389 INFO [stderr] --> src/main.rs:58:24 Dec 17 16:05:30.389 INFO [stderr] | Dec 17 16:05:30.389 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 17 16:05:30.389 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.389 INFO [stderr] Dec 17 16:05:30.389 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.389 INFO [stderr] --> src/main.rs:60:28 Dec 17 16:05:30.389 INFO [stderr] | Dec 17 16:05:30.389 INFO [stderr] 60 | if (items[i].quality < 50) Dec 17 16:05:30.389 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.389 INFO [stderr] Dec 17 16:05:30.389 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.389 INFO [stderr] --> src/main.rs:69:12 Dec 17 16:05:30.389 INFO [stderr] | Dec 17 16:05:30.389 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.390 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.390 INFO [stderr] Dec 17 16:05:30.390 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.390 INFO [stderr] --> src/main.rs:74:12 Dec 17 16:05:30.390 INFO [stderr] | Dec 17 16:05:30.390 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 17 16:05:30.390 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.390 INFO [stderr] Dec 17 16:05:30.390 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.390 INFO [stderr] --> src/main.rs:76:16 Dec 17 16:05:30.390 INFO [stderr] | Dec 17 16:05:30.390 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 17 16:05:30.390 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.390 INFO [stderr] Dec 17 16:05:30.390 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.390 INFO [stderr] --> src/main.rs:78:20 Dec 17 16:05:30.390 INFO [stderr] | Dec 17 16:05:30.390 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.390 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.390 INFO [stderr] Dec 17 16:05:30.390 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.390 INFO [stderr] --> src/main.rs:80:24 Dec 17 16:05:30.390 INFO [stderr] | Dec 17 16:05:30.390 INFO [stderr] 80 | if (items[i].quality > 0) Dec 17 16:05:30.390 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.390 INFO [stderr] Dec 17 16:05:30.390 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.390 INFO [stderr] --> src/main.rs:82:28 Dec 17 16:05:30.391 INFO [stderr] | Dec 17 16:05:30.391 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.391 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.391 INFO [stderr] Dec 17 16:05:30.391 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.391 INFO [stderr] --> src/main.rs:95:20 Dec 17 16:05:30.391 INFO [stderr] | Dec 17 16:05:30.391 INFO [stderr] 95 | if (items[i].quality < 50) Dec 17 16:05:30.391 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.391 INFO [stderr] Dec 17 16:05:30.446 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 17 16:05:30.447 INFO [stderr] --> src/main.rs:28:1 Dec 17 16:05:30.447 INFO [stderr] | Dec 17 16:05:30.447 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 17 16:05:30.447 INFO [stderr] 29 | | { Dec 17 16:05:30.447 INFO [stderr] 30 | | for i in 0..items.len() Dec 17 16:05:30.447 INFO [stderr] 31 | | { Dec 17 16:05:30.447 INFO [stderr] ... | Dec 17 16:05:30.447 INFO [stderr] 101 | | } Dec 17 16:05:30.447 INFO [stderr] 102 | | } Dec 17 16:05:30.447 INFO [stderr] | |_^ Dec 17 16:05:30.447 INFO [stderr] | Dec 17 16:05:30.447 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 17 16:05:30.447 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:32:12 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:34:16 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 34 | if (items[i].quality > 0) Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:36:20 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:44:16 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 44 | if (items[i].quality < 50) Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:48:20 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:50:24 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:52:28 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 52 | if (items[i].quality < 50) Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:58:24 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:60:28 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 60 | if (items[i].quality < 50) Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:69:12 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:74:12 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:76:16 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:78:20 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.545 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.545 INFO [stderr] Dec 17 16:05:30.545 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.545 INFO [stderr] --> src/main.rs:80:24 Dec 17 16:05:30.545 INFO [stderr] | Dec 17 16:05:30.545 INFO [stderr] 80 | if (items[i].quality > 0) Dec 17 16:05:30.546 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.546 INFO [stderr] Dec 17 16:05:30.546 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.546 INFO [stderr] --> src/main.rs:82:28 Dec 17 16:05:30.546 INFO [stderr] | Dec 17 16:05:30.546 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.546 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.546 INFO [stderr] Dec 17 16:05:30.546 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.546 INFO [stderr] --> src/main.rs:95:20 Dec 17 16:05:30.546 INFO [stderr] | Dec 17 16:05:30.546 INFO [stderr] 95 | if (items[i].quality < 50) Dec 17 16:05:30.546 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.546 INFO [stderr] Dec 17 16:05:30.610 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 17 16:05:30.610 INFO [stderr] --> src/main.rs:28:1 Dec 17 16:05:30.610 INFO [stderr] | Dec 17 16:05:30.610 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 17 16:05:30.610 INFO [stderr] 29 | | { Dec 17 16:05:30.610 INFO [stderr] 30 | | for i in 0..items.len() Dec 17 16:05:30.610 INFO [stderr] 31 | | { Dec 17 16:05:30.610 INFO [stderr] ... | Dec 17 16:05:30.610 INFO [stderr] 101 | | } Dec 17 16:05:30.610 INFO [stderr] 102 | | } Dec 17 16:05:30.611 INFO [stderr] | |_^ Dec 17 16:05:30.611 INFO [stderr] | Dec 17 16:05:30.611 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 17 16:05:30.611 INFO [stderr] Dec 17 16:05:30.668 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.71s Dec 17 16:05:31.477 INFO running `"docker" "inspect" "01ffd58a28df72086a84c83a5a0be2324dc3f43eb64cdfec1edd94c5eb27c12d"` Dec 17 16:05:31.712 INFO running `"docker" "rm" "-f" "01ffd58a28df72086a84c83a5a0be2324dc3f43eb64cdfec1edd94c5eb27c12d"` Dec 17 16:05:32.028 INFO [stdout] 01ffd58a28df72086a84c83a5a0be2324dc3f43eb64cdfec1edd94c5eb27c12d