Dec 17 10:49:56.843 INFO checking zovt/advent-of-code-2017 against master#96d1334e567237b1507cd277938e7ae2de75ff51 for pr-54252 Dec 17 10:49:56.843 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-54252/worker-7/master#96d1334e567237b1507cd277938e7ae2de75ff51:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/pr-54252/sources/master#96d1334e567237b1507cd277938e7ae2de75ff51/gh/zovt/advent-of-code-2017:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+96d1334e567237b1507cd277938e7ae2de75ff51-alt" "check" "--frozen" "--all" "--all-targets"` Dec 17 10:49:57.360 INFO [stdout] e2aef9949a1b5e2b64e3d7b3c5be235b699d7efc12fd43dfab88639d0ff90ece Dec 17 10:49:57.363 INFO running `"docker" "start" "-a" "e2aef9949a1b5e2b64e3d7b3c5be235b699d7efc12fd43dfab88639d0ff90ece"` Dec 17 10:49:59.556 INFO [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently Dec 17 10:49:59.556 INFO [stderr] disables Cargo from automatically inferring other binary targets. Dec 17 10:49:59.556 INFO [stderr] This inference behavior will change in the Rust 2018 edition and the following Dec 17 10:49:59.556 INFO [stderr] files will be included as a binary target: Dec 17 10:49:59.556 INFO [stderr] Dec 17 10:49:59.556 INFO [stderr] * /opt/crater/workdir/src/main.rs Dec 17 10:49:59.556 INFO [stderr] Dec 17 10:49:59.556 INFO [stderr] This is likely to break cargo build or cargo test as these files may not be Dec 17 10:49:59.556 INFO [stderr] ready to be compiled as a binary target today. You can future-proof yourself Dec 17 10:49:59.556 INFO [stderr] and disable this warning by adding `autobins = false` to your [package] Dec 17 10:49:59.556 INFO [stderr] section. You may also move the files to a location where Cargo would not Dec 17 10:49:59.556 INFO [stderr] automatically infer them to be a target, such as in subfolders. Dec 17 10:49:59.556 INFO [stderr] Dec 17 10:49:59.556 INFO [stderr] For more information on this warning you can consult Dec 17 10:49:59.556 INFO [stderr] https://github.com/rust-lang/cargo/issues/5330 Dec 17 10:49:59.589 INFO [stderr] Checking advent-of-code v0.1.0 (/opt/crater/workdir) Dec 17 10:49:59.980 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 10:49:59.980 INFO [stderr] --> src/day3/one.rs:43:15 Dec 17 10:49:59.980 INFO [stderr] | Dec 17 10:49:59.980 INFO [stderr] 43 | let num = if (num > ring_half) { Dec 17 10:49:59.980 INFO [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 10:49:59.980 INFO [stderr] | Dec 17 10:49:59.980 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 17 10:49:59.980 INFO [stderr] Dec 17 10:50:01.260 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 10:50:01.261 INFO [stderr] --> src/day3/one.rs:43:15 Dec 17 10:50:01.261 INFO [stderr] | Dec 17 10:50:01.261 INFO [stderr] 43 | let num = if (num > ring_half) { Dec 17 10:50:01.262 INFO [stderr] | ^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 10:50:01.272 INFO [stderr] | Dec 17 10:50:01.272 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 17 10:50:01.273 INFO [stderr] Dec 17 10:50:02.200 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 10:50:02.200 INFO [stderr] --> src/day3/two.rs:39:6 Dec 17 10:50:02.200 INFO [stderr] | Dec 17 10:50:02.200 INFO [stderr] 39 | if (r.0 - 1 == -r.1 && self == SpiralDirection::Right) { Dec 17 10:50:02.200 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 10:50:02.268 INFO [stderr] | Dec 17 10:50:02.268 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 17 10:50:02.268 INFO [stderr] Dec 17 10:50:02.268 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 10:50:02.268 INFO [stderr] --> src/day3/two.rs:41:13 Dec 17 10:50:02.268 INFO [stderr] | Dec 17 10:50:02.268 INFO [stderr] 41 | } else if (r.0.abs() == r.1.abs() && self != SpiralDirection::Right) { Dec 17 10:50:02.268 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 10:50:02.268 INFO [stderr] Dec 17 10:50:02.324 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 10:50:02.324 INFO [stderr] --> src/day3/two.rs:39:6 Dec 17 10:50:02.324 INFO [stderr] | Dec 17 10:50:02.324 INFO [stderr] 39 | if (r.0 - 1 == -r.1 && self == SpiralDirection::Right) { Dec 17 10:50:02.324 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 10:50:02.324 INFO [stderr] | Dec 17 10:50:02.324 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 17 10:50:02.324 INFO [stderr] Dec 17 10:50:02.324 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 10:50:02.324 INFO [stderr] --> src/day3/two.rs:41:13 Dec 17 10:50:02.324 INFO [stderr] | Dec 17 10:50:02.324 INFO [stderr] 41 | } else if (r.0.abs() == r.1.abs() && self != SpiralDirection::Right) { Dec 17 10:50:02.324 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 10:50:02.324 INFO [stderr] Dec 17 10:50:02.651 INFO [stderr] warning: variable does not need to be mutable Dec 17 10:50:02.651 INFO [stderr] --> src/day3/two.rs:86:6 Dec 17 10:50:02.651 INFO [stderr] | Dec 17 10:50:02.651 INFO [stderr] 86 | let mut spiral_coord_iter = SpiralCoordIter { Dec 17 10:50:02.651 INFO [stderr] | ----^^^^^^^^^^^^^^^^^ Dec 17 10:50:02.651 INFO [stderr] | | Dec 17 10:50:02.651 INFO [stderr] | help: remove this `mut` Dec 17 10:50:02.651 INFO [stderr] | Dec 17 10:50:02.651 INFO [stderr] = note: #[warn(unused_mut)] on by default Dec 17 10:50:02.651 INFO [stderr] Dec 17 10:50:02.775 INFO [stderr] warning: variable does not need to be mutable Dec 17 10:50:02.775 INFO [stderr] --> src/day3/two.rs:86:6 Dec 17 10:50:02.775 INFO [stderr] | Dec 17 10:50:02.775 INFO [stderr] 86 | let mut spiral_coord_iter = SpiralCoordIter { Dec 17 10:50:02.775 INFO [stderr] | ----^^^^^^^^^^^^^^^^^ Dec 17 10:50:02.775 INFO [stderr] | | Dec 17 10:50:02.775 INFO [stderr] | help: remove this `mut` Dec 17 10:50:02.775 INFO [stderr] | Dec 17 10:50:02.775 INFO [stderr] = note: #[warn(unused_mut)] on by default Dec 17 10:50:02.775 INFO [stderr] Dec 17 10:50:02.844 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.32s Dec 17 10:50:03.702 INFO running `"docker" "inspect" "e2aef9949a1b5e2b64e3d7b3c5be235b699d7efc12fd43dfab88639d0ff90ece"` Dec 17 10:50:04.026 INFO running `"docker" "rm" "-f" "e2aef9949a1b5e2b64e3d7b3c5be235b699d7efc12fd43dfab88639d0ff90ece"` Dec 17 10:50:04.332 INFO [stdout] e2aef9949a1b5e2b64e3d7b3c5be235b699d7efc12fd43dfab88639d0ff90ece