Dec 17 16:05:28.883 INFO checking saterus/gilded-rose-rust against master#96d1334e567237b1507cd277938e7ae2de75ff51 for pr-54252 Dec 17 16:05:28.883 INFO running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/pr-54252/worker-3/master#96d1334e567237b1507cd277938e7ae2de75ff51:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/pr-54252/sources/master#96d1334e567237b1507cd277938e7ae2de75ff51/gh/saterus/gilded-rose-rust:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+96d1334e567237b1507cd277938e7ae2de75ff51-alt" "check" "--frozen" "--all" "--all-targets"` Dec 17 16:05:29.065 INFO [stdout] dcc19b2da7c4862b6921a5acc1ffaa8e25c723afcc4626f5ced2b1adc39a79af Dec 17 16:05:29.067 INFO running `"docker" "start" "-a" "dcc19b2da7c4862b6921a5acc1ffaa8e25c723afcc4626f5ced2b1adc39a79af"` Dec 17 16:05:30.304 INFO [stderr] Checking gilded_rose v0.1.0 (/opt/crater/workdir) Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:32:12 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:34:16 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 34 | if (items[i].quality > 0) Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:36:20 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:44:16 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 44 | if (items[i].quality < 50) Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:48:20 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:50:24 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:52:28 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 52 | if (items[i].quality < 50) Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:58:24 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:60:28 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 60 | if (items[i].quality < 50) Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:69:12 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:74:12 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:76:16 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:78:20 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.845 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.845 INFO [stderr] Dec 17 16:05:30.845 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.845 INFO [stderr] --> src/main.rs:80:24 Dec 17 16:05:30.845 INFO [stderr] | Dec 17 16:05:30.845 INFO [stderr] 80 | if (items[i].quality > 0) Dec 17 16:05:30.846 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.846 INFO [stderr] Dec 17 16:05:30.846 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.846 INFO [stderr] --> src/main.rs:82:28 Dec 17 16:05:30.846 INFO [stderr] | Dec 17 16:05:30.846 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.846 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.846 INFO [stderr] Dec 17 16:05:30.846 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.846 INFO [stderr] --> src/main.rs:95:20 Dec 17 16:05:30.846 INFO [stderr] | Dec 17 16:05:30.846 INFO [stderr] 95 | if (items[i].quality < 50) Dec 17 16:05:30.846 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.846 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:32:12 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 32 | if (items[i].name != "Aged Brie" && items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] = note: #[warn(unused_parens)] on by default Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:34:16 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 34 | if (items[i].quality > 0) Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:36:20 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 36 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:44:16 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 44 | if (items[i].quality < 50) Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:48:20 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 48 | if (items[i].name == "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:50:24 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 50 | if (items[i].sell_in < 11) Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:52:28 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 52 | if (items[i].quality < 50) Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:58:24 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 58 | if (items[i].sell_in < 6) Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:60:28 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 60 | if (items[i].quality < 50) Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:69:12 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 69 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:74:12 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 74 | if (items[i].sell_in < 0) Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:76:16 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 76 | if (items[i].name != "Aged Brie") Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:78:20 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 78 | if (items[i].name != "Backstage passes to a TAFKAL80ETC concert") Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:80:24 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.865 INFO [stderr] 80 | if (items[i].quality > 0) Dec 17 16:05:30.865 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.865 INFO [stderr] Dec 17 16:05:30.865 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.865 INFO [stderr] --> src/main.rs:82:28 Dec 17 16:05:30.865 INFO [stderr] | Dec 17 16:05:30.866 INFO [stderr] 82 | if (items[i].name != "Sulfuras, Hand of Ragnaros") Dec 17 16:05:30.866 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.866 INFO [stderr] Dec 17 16:05:30.866 INFO [stderr] warning: unnecessary parentheses around `if` condition Dec 17 16:05:30.866 INFO [stderr] --> src/main.rs:95:20 Dec 17 16:05:30.866 INFO [stderr] | Dec 17 16:05:30.866 INFO [stderr] 95 | if (items[i].quality < 50) Dec 17 16:05:30.866 INFO [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Dec 17 16:05:30.866 INFO [stderr] Dec 17 16:05:30.908 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 17 16:05:30.908 INFO [stderr] --> src/main.rs:28:1 Dec 17 16:05:30.908 INFO [stderr] | Dec 17 16:05:30.908 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 17 16:05:30.908 INFO [stderr] 29 | | { Dec 17 16:05:30.908 INFO [stderr] 30 | | for i in 0..items.len() Dec 17 16:05:30.908 INFO [stderr] 31 | | { Dec 17 16:05:30.908 INFO [stderr] ... | Dec 17 16:05:30.908 INFO [stderr] 101 | | } Dec 17 16:05:30.908 INFO [stderr] 102 | | } Dec 17 16:05:30.908 INFO [stderr] | |_^ Dec 17 16:05:30.908 INFO [stderr] | Dec 17 16:05:30.908 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 17 16:05:30.908 INFO [stderr] Dec 17 16:05:30.936 INFO [stderr] warning: function `UpdateQuality` should have a snake case name such as `update_quality` Dec 17 16:05:30.936 INFO [stderr] --> src/main.rs:28:1 Dec 17 16:05:30.936 INFO [stderr] | Dec 17 16:05:30.936 INFO [stderr] 28 | / fn UpdateQuality(items: &mut [Item]) Dec 17 16:05:30.936 INFO [stderr] 29 | | { Dec 17 16:05:30.936 INFO [stderr] 30 | | for i in 0..items.len() Dec 17 16:05:30.936 INFO [stderr] 31 | | { Dec 17 16:05:30.936 INFO [stderr] ... | Dec 17 16:05:30.936 INFO [stderr] 101 | | } Dec 17 16:05:30.936 INFO [stderr] 102 | | } Dec 17 16:05:30.936 INFO [stderr] | |_^ Dec 17 16:05:30.936 INFO [stderr] | Dec 17 16:05:30.936 INFO [stderr] = note: #[warn(non_snake_case)] on by default Dec 17 16:05:30.936 INFO [stderr] Dec 17 16:05:30.987 INFO [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.69s Dec 17 16:05:31.530 INFO running `"docker" "inspect" "dcc19b2da7c4862b6921a5acc1ffaa8e25c723afcc4626f5ced2b1adc39a79af"` Dec 17 16:05:31.866 INFO running `"docker" "rm" "-f" "dcc19b2da7c4862b6921a5acc1ffaa8e25c723afcc4626f5ced2b1adc39a79af"` Dec 17 16:05:32.202 INFO [stdout] dcc19b2da7c4862b6921a5acc1ffaa8e25c723afcc4626f5ced2b1adc39a79af