Sep 10 04:52:24.655 INFO checking benbrunton/les against try#3a2610c2a16575649896925631bf8cec4f4b1961 for pr-54090 Sep 10 04:52:24.655 INFO running: cargo +3a2610c2a16575649896925631bf8cec4f4b1961-alt check --frozen --all --all-targets Sep 10 04:52:24.655 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-2/pr-54090/try#3a2610c2a16575649896925631bf8cec4f4b1961:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-54090/worker-2/try#3a2610c2a16575649896925631bf8cec4f4b1961:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "CMD=cargo +3a2610c2a16575649896925631bf8cec4f4b1961-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "-m" "2G" "crater"` Sep 10 04:52:24.876 INFO blam! a5edd3703f467d89797bc75946634ea32335b1829ac635c03de5b819c37c3ac2 Sep 10 04:52:24.878 INFO running `"docker" "start" "-a" "a5edd3703f467d89797bc75946634ea32335b1829ac635c03de5b819c37c3ac2"` Sep 10 04:52:27.229 INFO kablam! usermod: no changes Sep 10 04:52:27.386 INFO kablam! Checking les v0.2.1 (file:///source) Sep 10 04:52:27.662 INFO kablam! warning: unused import: `std::io::stdout` Sep 10 04:52:27.662 INFO kablam! --> src/main.rs:8:5 Sep 10 04:52:27.662 INFO kablam! | Sep 10 04:52:27.662 INFO kablam! 8 | use std::io::stdout; Sep 10 04:52:27.662 INFO kablam! | ^^^^^^^^^^^^^^^ Sep 10 04:52:27.666 INFO kablam! | Sep 10 04:52:27.666 INFO kablam! = note: #[warn(unused_imports)] on by default Sep 10 04:52:27.666 INFO kablam! Sep 10 04:52:27.667 INFO kablam! warning: unused import: `std::io::Write` Sep 10 04:52:27.667 INFO kablam! --> src/les/mod.rs:2:5 Sep 10 04:52:27.667 INFO kablam! | Sep 10 04:52:27.667 INFO kablam! 2 | use std::io::Write; Sep 10 04:52:27.667 INFO kablam! | ^^^^^^^^^^^^^^ Sep 10 04:52:27.667 INFO kablam! Sep 10 04:52:27.667 INFO kablam! warning: unused import: `decorate::Decorate` Sep 10 04:52:27.667 INFO kablam! --> src/les/mod.rs:4:5 Sep 10 04:52:27.667 INFO kablam! | Sep 10 04:52:27.667 INFO kablam! 4 | use decorate::Decorate; Sep 10 04:52:27.667 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Sep 10 04:52:27.667 INFO kablam! Sep 10 04:52:27.668 INFO kablam! warning: unused import: `paintitems::PaintItems` Sep 10 04:52:27.668 INFO kablam! --> src/les/mod.rs:5:5 Sep 10 04:52:27.668 INFO kablam! | Sep 10 04:52:27.668 INFO kablam! 5 | use paintitems::PaintItems; Sep 10 04:52:27.668 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Sep 10 04:52:27.668 INFO kablam! Sep 10 04:52:27.669 INFO kablam! warning: unused imports: `Stdout`, `stdout` Sep 10 04:52:27.669 INFO kablam! --> src/io/mod.rs:1:15 Sep 10 04:52:27.669 INFO kablam! | Sep 10 04:52:27.669 INFO kablam! 1 | use std::io::{Stdout,stdout}; Sep 10 04:52:27.669 INFO kablam! | ^^^^^^ ^^^^^^ Sep 10 04:52:27.669 INFO kablam! Sep 10 04:52:27.669 INFO kablam! warning: unused import: `min` Sep 10 04:52:27.669 INFO kablam! --> src/io/mod.rs:2:16 Sep 10 04:52:27.669 INFO kablam! | Sep 10 04:52:27.669 INFO kablam! 2 | use std::cmp::{min,max}; Sep 10 04:52:27.669 INFO kablam! | ^^^ Sep 10 04:52:27.669 INFO kablam! Sep 10 04:52:27.670 INFO kablam! warning: unused import: `std::str::FromStr` Sep 10 04:52:27.670 INFO kablam! --> src/decorate/mod.rs:8:5 Sep 10 04:52:27.670 INFO kablam! | Sep 10 04:52:27.670 INFO kablam! 8 | use std::str::FromStr; Sep 10 04:52:27.670 INFO kablam! | ^^^^^^^^^^^^^^^^^ Sep 10 04:52:27.670 INFO kablam! Sep 10 04:52:27.815 INFO kablam! warning: unused import: `std::io::stdout` Sep 10 04:52:27.815 INFO kablam! --> src/main.rs:8:5 Sep 10 04:52:27.815 INFO kablam! | Sep 10 04:52:27.815 INFO kablam! 8 | use std::io::stdout; Sep 10 04:52:27.815 INFO kablam! | ^^^^^^^^^^^^^^^ Sep 10 04:52:27.815 INFO kablam! | Sep 10 04:52:27.815 INFO kablam! = note: #[warn(unused_imports)] on by default Sep 10 04:52:27.815 INFO kablam! Sep 10 04:52:27.815 INFO kablam! warning: unused import: `std::io::Write` Sep 10 04:52:27.815 INFO kablam! --> src/les/mod.rs:2:5 Sep 10 04:52:27.815 INFO kablam! | Sep 10 04:52:27.815 INFO kablam! 2 | use std::io::Write; Sep 10 04:52:27.815 INFO kablam! | ^^^^^^^^^^^^^^ Sep 10 04:52:27.815 INFO kablam! Sep 10 04:52:27.815 INFO kablam! warning: unused import: `decorate::Decorate` Sep 10 04:52:27.815 INFO kablam! --> src/les/mod.rs:4:5 Sep 10 04:52:27.815 INFO kablam! | Sep 10 04:52:27.815 INFO kablam! 4 | use decorate::Decorate; Sep 10 04:52:27.815 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Sep 10 04:52:27.815 INFO kablam! Sep 10 04:52:27.815 INFO kablam! warning: unused import: `paintitems::PaintItems` Sep 10 04:52:27.815 INFO kablam! --> src/les/mod.rs:5:5 Sep 10 04:52:27.815 INFO kablam! | Sep 10 04:52:27.815 INFO kablam! 5 | use paintitems::PaintItems; Sep 10 04:52:27.815 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Sep 10 04:52:27.815 INFO kablam! Sep 10 04:52:27.815 INFO kablam! warning: unused import: `std` Sep 10 04:52:27.815 INFO kablam! --> src/les/mod.rs:43:9 Sep 10 04:52:27.815 INFO kablam! | Sep 10 04:52:27.815 INFO kablam! 43 | use std; Sep 10 04:52:27.815 INFO kablam! | ^^^ Sep 10 04:52:27.815 INFO kablam! Sep 10 04:52:27.816 INFO kablam! warning: unused imports: `Stdout`, `stdout` Sep 10 04:52:27.816 INFO kablam! --> src/io/mod.rs:1:15 Sep 10 04:52:27.816 INFO kablam! | Sep 10 04:52:27.816 INFO kablam! 1 | use std::io::{Stdout,stdout}; Sep 10 04:52:27.816 INFO kablam! | ^^^^^^ ^^^^^^ Sep 10 04:52:27.816 INFO kablam! Sep 10 04:52:27.816 INFO kablam! warning: unused import: `min` Sep 10 04:52:27.816 INFO kablam! --> src/io/mod.rs:2:16 Sep 10 04:52:27.816 INFO kablam! | Sep 10 04:52:27.816 INFO kablam! 2 | use std::cmp::{min,max}; Sep 10 04:52:27.816 INFO kablam! | ^^^ Sep 10 04:52:27.816 INFO kablam! Sep 10 04:52:27.816 INFO kablam! warning: unused import: `std::str::FromStr` Sep 10 04:52:27.816 INFO kablam! --> src/decorate/mod.rs:8:5 Sep 10 04:52:27.816 INFO kablam! | Sep 10 04:52:27.816 INFO kablam! 8 | use std::str::FromStr; Sep 10 04:52:27.816 INFO kablam! | ^^^^^^^^^^^^^^^^^ Sep 10 04:52:27.816 INFO kablam! Sep 10 04:52:27.906 INFO kablam! warning: unused variable: `inodes_count` Sep 10 04:52:27.906 INFO kablam! --> src/io/mod.rs:27:13 Sep 10 04:52:27.906 INFO kablam! | Sep 10 04:52:27.906 INFO kablam! 27 | let inodes_count = inodes.len(); Sep 10 04:52:27.906 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Sep 10 04:52:27.906 INFO kablam! | Sep 10 04:52:27.906 INFO kablam! = note: #[warn(unused_variables)] on by default Sep 10 04:52:27.906 INFO kablam! Sep 10 04:52:27.906 INFO kablam! warning: value assigned to `prev_item_length` is never read Sep 10 04:52:27.906 INFO kablam! --> src/io/mod.rs:73:21 Sep 10 04:52:27.906 INFO kablam! | Sep 10 04:52:27.906 INFO kablam! 73 | let mut prev_item_length = 0; Sep 10 04:52:27.906 INFO kablam! | ^^^^^^^^^^^^^^^^ Sep 10 04:52:27.906 INFO kablam! | Sep 10 04:52:27.906 INFO kablam! = note: #[warn(unused_assignments)] on by default Sep 10 04:52:27.906 INFO kablam! Sep 10 04:52:27.953 INFO kablam! warning: variable does not need to be mutable Sep 10 04:52:27.953 INFO kablam! --> src/io/mod.rs:120:13 Sep 10 04:52:27.953 INFO kablam! | Sep 10 04:52:27.953 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Sep 10 04:52:27.953 INFO kablam! | ----^^^^^^^^^^^^^ Sep 10 04:52:27.953 INFO kablam! | | Sep 10 04:52:27.953 INFO kablam! | help: remove this `mut` Sep 10 04:52:27.958 INFO kablam! | Sep 10 04:52:27.958 INFO kablam! = note: #[warn(unused_mut)] on by default Sep 10 04:52:27.958 INFO kablam! Sep 10 04:52:27.987 INFO kablam! warning: field is never used: `path` Sep 10 04:52:27.987 INFO kablam! --> src/fs/mod.rs:92:5 Sep 10 04:52:27.987 INFO kablam! | Sep 10 04:52:27.987 INFO kablam! 92 | path: String Sep 10 04:52:27.987 INFO kablam! | ^^^^^^^^^^^^ Sep 10 04:52:27.988 INFO kablam! | Sep 10 04:52:27.988 INFO kablam! = note: #[warn(dead_code)] on by default Sep 10 04:52:27.988 INFO kablam! Sep 10 04:52:27.988 INFO kablam! warning: method is never used: `get_path` Sep 10 04:52:27.988 INFO kablam! --> src/fs/mod.rs:117:5 Sep 10 04:52:27.988 INFO kablam! | Sep 10 04:52:27.988 INFO kablam! 117 | pub fn get_path(&self) -> String { Sep 10 04:52:27.988 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sep 10 04:52:27.989 INFO kablam! Sep 10 04:52:27.993 INFO kablam! warning: comparison is useless due to type limits Sep 10 04:52:27.993 INFO kablam! --> src/paintitems/mod.rs:25:41 Sep 10 04:52:27.993 INFO kablam! | Sep 10 04:52:27.993 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Sep 10 04:52:27.993 INFO kablam! | ^^^^^^^^^ Sep 10 04:52:28.006 INFO kablam! | Sep 10 04:52:28.006 INFO kablam! = note: #[warn(unused_comparisons)] on by default Sep 10 04:52:28.007 INFO kablam! Sep 10 04:52:28.194 INFO kablam! warning: unused variable: `decorator` Sep 10 04:52:28.194 INFO kablam! --> src/les/mod.rs:53:13 Sep 10 04:52:28.194 INFO kablam! | Sep 10 04:52:28.194 INFO kablam! 53 | let decorator = decorate::Decorate::new(None); Sep 10 04:52:28.194 INFO kablam! | ^^^^^^^^^ help: consider using `_decorator` instead Sep 10 04:52:28.194 INFO kablam! | Sep 10 04:52:28.194 INFO kablam! = note: #[warn(unused_variables)] on by default Sep 10 04:52:28.194 INFO kablam! Sep 10 04:52:28.194 INFO kablam! warning: unused variable: `inodes_count` Sep 10 04:52:28.194 INFO kablam! --> src/io/mod.rs:27:13 Sep 10 04:52:28.194 INFO kablam! | Sep 10 04:52:28.194 INFO kablam! 27 | let inodes_count = inodes.len(); Sep 10 04:52:28.194 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Sep 10 04:52:28.194 INFO kablam! Sep 10 04:52:28.194 INFO kablam! warning: value assigned to `prev_item_length` is never read Sep 10 04:52:28.194 INFO kablam! --> src/io/mod.rs:73:21 Sep 10 04:52:28.194 INFO kablam! | Sep 10 04:52:28.194 INFO kablam! 73 | let mut prev_item_length = 0; Sep 10 04:52:28.194 INFO kablam! | ^^^^^^^^^^^^^^^^ Sep 10 04:52:28.194 INFO kablam! | Sep 10 04:52:28.194 INFO kablam! = note: #[warn(unused_assignments)] on by default Sep 10 04:52:28.194 INFO kablam! Sep 10 04:52:28.231 INFO kablam! warning: variable does not need to be mutable Sep 10 04:52:28.231 INFO kablam! --> src/io/mod.rs:120:13 Sep 10 04:52:28.231 INFO kablam! | Sep 10 04:52:28.231 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Sep 10 04:52:28.231 INFO kablam! | ----^^^^^^^^^^^^^ Sep 10 04:52:28.231 INFO kablam! | | Sep 10 04:52:28.231 INFO kablam! | help: remove this `mut` Sep 10 04:52:28.231 INFO kablam! | Sep 10 04:52:28.231 INFO kablam! = note: #[warn(unused_mut)] on by default Sep 10 04:52:28.231 INFO kablam! Sep 10 04:52:28.291 INFO kablam! warning: field is never used: `path` Sep 10 04:52:28.291 INFO kablam! --> src/fs/mod.rs:92:5 Sep 10 04:52:28.291 INFO kablam! | Sep 10 04:52:28.291 INFO kablam! 92 | path: String Sep 10 04:52:28.291 INFO kablam! | ^^^^^^^^^^^^ Sep 10 04:52:28.291 INFO kablam! | Sep 10 04:52:28.291 INFO kablam! = note: #[warn(dead_code)] on by default Sep 10 04:52:28.291 INFO kablam! Sep 10 04:52:28.291 INFO kablam! warning: method is never used: `get_path` Sep 10 04:52:28.291 INFO kablam! --> src/fs/mod.rs:117:5 Sep 10 04:52:28.291 INFO kablam! | Sep 10 04:52:28.291 INFO kablam! 117 | pub fn get_path(&self) -> String { Sep 10 04:52:28.291 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sep 10 04:52:28.291 INFO kablam! Sep 10 04:52:28.293 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Sep 10 04:52:28.293 INFO kablam! --> src/style/mod.rs:67:13 Sep 10 04:52:28.294 INFO kablam! | Sep 10 04:52:28.294 INFO kablam! 67 | let licenseItem = PaintItem{ Sep 10 04:52:28.294 INFO kablam! | ^^^^^^^^^^^ Sep 10 04:52:28.294 INFO kablam! | Sep 10 04:52:28.294 INFO kablam! = note: #[warn(non_snake_case)] on by default Sep 10 04:52:28.294 INFO kablam! Sep 10 04:52:28.294 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Sep 10 04:52:28.294 INFO kablam! --> src/style/mod.rs:83:13 Sep 10 04:52:28.294 INFO kablam! | Sep 10 04:52:28.294 INFO kablam! 83 | let licenseItem = PaintItem{ Sep 10 04:52:28.294 INFO kablam! | ^^^^^^^^^^^ Sep 10 04:52:28.294 INFO kablam! Sep 10 04:52:28.296 INFO kablam! warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item` Sep 10 04:52:28.296 INFO kablam! --> src/decorate/mod.rs:201:5 Sep 10 04:52:28.296 INFO kablam! | Sep 10 04:52:28.296 INFO kablam! 201 | / fn it_returns_a_Paint_Item() { Sep 10 04:52:28.296 INFO kablam! 202 | | Sep 10 04:52:28.296 INFO kablam! 203 | | let file = File::new( Sep 10 04:52:28.296 INFO kablam! 204 | | String::from("filename"), Sep 10 04:52:28.296 INFO kablam! ... | Sep 10 04:52:28.296 INFO kablam! 222 | | assert_eq!(paint_item, expected_result); Sep 10 04:52:28.296 INFO kablam! 223 | | } Sep 10 04:52:28.296 INFO kablam! | |_____^ Sep 10 04:52:28.296 INFO kablam! Sep 10 04:52:28.296 INFO kablam! warning: comparison is useless due to type limits Sep 10 04:52:28.296 INFO kablam! --> src/paintitems/mod.rs:25:41 Sep 10 04:52:28.296 INFO kablam! | Sep 10 04:52:28.296 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Sep 10 04:52:28.296 INFO kablam! | ^^^^^^^^^ Sep 10 04:52:28.296 INFO kablam! | Sep 10 04:52:28.296 INFO kablam! = note: #[warn(unused_comparisons)] on by default Sep 10 04:52:28.296 INFO kablam! Sep 10 04:52:28.367 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.11s Sep 10 04:52:28.378 INFO kablam! su: No module specific data is present Sep 10 04:52:29.995 INFO running `"docker" "rm" "-f" "a5edd3703f467d89797bc75946634ea32335b1829ac635c03de5b819c37c3ac2"` Sep 10 04:52:30.100 INFO blam! a5edd3703f467d89797bc75946634ea32335b1829ac635c03de5b819c37c3ac2