Sep 17 13:32:27.485 INFO checking benbrunton/les against master#cb6d2dfa8923902b0992a1522dc4a45a9d3ba690 for pr-54033 Sep 17 13:32:27.485 INFO running: cargo +cb6d2dfa8923902b0992a1522dc4a45a9d3ba690-alt check --frozen --all --all-targets Sep 17 13:32:27.485 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-5/pr-54033/master#cb6d2dfa8923902b0992a1522dc4a45a9d3ba690:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-54033/worker-5/master#cb6d2dfa8923902b0992a1522dc4a45a9d3ba690:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "CMD=cargo +cb6d2dfa8923902b0992a1522dc4a45a9d3ba690-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-m" "1536M" "crater"` Sep 17 13:32:27.913 INFO blam! f1cdf1f19ebd1ad8be2ab3d925b1ba0bc27c5b7cdbbf338c71e716ac02218612 Sep 17 13:32:27.915 INFO running `"docker" "start" "-a" "f1cdf1f19ebd1ad8be2ab3d925b1ba0bc27c5b7cdbbf338c71e716ac02218612"` Sep 17 13:32:30.311 INFO kablam! usermod: no changes Sep 17 13:32:30.471 INFO kablam! Checking terminal_size v0.1.7 Sep 17 13:32:30.780 INFO kablam! Checking les v0.2.1 (/source) Sep 17 13:32:31.270 INFO kablam! warning: unused import: `std::io::stdout` Sep 17 13:32:31.270 INFO kablam! --> src/main.rs:8:5 Sep 17 13:32:31.270 INFO kablam! | Sep 17 13:32:31.270 INFO kablam! 8 | use std::io::stdout; Sep 17 13:32:31.270 INFO kablam! | ^^^^^^^^^^^^^^^ Sep 17 13:32:31.270 INFO kablam! | Sep 17 13:32:31.270 INFO kablam! = note: #[warn(unused_imports)] on by default Sep 17 13:32:31.270 INFO kablam! Sep 17 13:32:31.270 INFO kablam! warning: unused import: `std::io::Write` Sep 17 13:32:31.270 INFO kablam! --> src/les/mod.rs:2:5 Sep 17 13:32:31.270 INFO kablam! | Sep 17 13:32:31.270 INFO kablam! 2 | use std::io::Write; Sep 17 13:32:31.270 INFO kablam! | ^^^^^^^^^^^^^^ Sep 17 13:32:31.270 INFO kablam! Sep 17 13:32:31.270 INFO kablam! warning: unused import: `decorate::Decorate` Sep 17 13:32:31.270 INFO kablam! --> src/les/mod.rs:4:5 Sep 17 13:32:31.270 INFO kablam! | Sep 17 13:32:31.270 INFO kablam! 4 | use decorate::Decorate; Sep 17 13:32:31.270 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Sep 17 13:32:31.270 INFO kablam! Sep 17 13:32:31.270 INFO kablam! warning: unused import: `paintitems::PaintItems` Sep 17 13:32:31.270 INFO kablam! --> src/les/mod.rs:5:5 Sep 17 13:32:31.270 INFO kablam! | Sep 17 13:32:31.270 INFO kablam! 5 | use paintitems::PaintItems; Sep 17 13:32:31.270 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Sep 17 13:32:31.270 INFO kablam! Sep 17 13:32:31.275 INFO kablam! warning: unused imports: `Stdout`, `stdout` Sep 17 13:32:31.275 INFO kablam! --> src/io/mod.rs:1:15 Sep 17 13:32:31.275 INFO kablam! | Sep 17 13:32:31.275 INFO kablam! 1 | use std::io::{Stdout,stdout}; Sep 17 13:32:31.275 INFO kablam! | ^^^^^^ ^^^^^^ Sep 17 13:32:31.275 INFO kablam! Sep 17 13:32:31.275 INFO kablam! warning: unused import: `min` Sep 17 13:32:31.275 INFO kablam! --> src/io/mod.rs:2:16 Sep 17 13:32:31.275 INFO kablam! | Sep 17 13:32:31.275 INFO kablam! 2 | use std::cmp::{min,max}; Sep 17 13:32:31.275 INFO kablam! | ^^^ Sep 17 13:32:31.275 INFO kablam! Sep 17 13:32:31.275 INFO kablam! warning: unused import: `std::str::FromStr` Sep 17 13:32:31.275 INFO kablam! --> src/decorate/mod.rs:8:5 Sep 17 13:32:31.275 INFO kablam! | Sep 17 13:32:31.275 INFO kablam! 8 | use std::str::FromStr; Sep 17 13:32:31.275 INFO kablam! | ^^^^^^^^^^^^^^^^^ Sep 17 13:32:31.275 INFO kablam! Sep 17 13:32:31.282 INFO kablam! warning: unused import: `std::io::stdout` Sep 17 13:32:31.282 INFO kablam! --> src/main.rs:8:5 Sep 17 13:32:31.282 INFO kablam! | Sep 17 13:32:31.282 INFO kablam! 8 | use std::io::stdout; Sep 17 13:32:31.282 INFO kablam! | ^^^^^^^^^^^^^^^ Sep 17 13:32:31.282 INFO kablam! | Sep 17 13:32:31.282 INFO kablam! = note: #[warn(unused_imports)] on by default Sep 17 13:32:31.282 INFO kablam! Sep 17 13:32:31.282 INFO kablam! warning: unused import: `std::io::Write` Sep 17 13:32:31.282 INFO kablam! --> src/les/mod.rs:2:5 Sep 17 13:32:31.282 INFO kablam! | Sep 17 13:32:31.282 INFO kablam! 2 | use std::io::Write; Sep 17 13:32:31.282 INFO kablam! | ^^^^^^^^^^^^^^ Sep 17 13:32:31.282 INFO kablam! Sep 17 13:32:31.283 INFO kablam! warning: unused import: `decorate::Decorate` Sep 17 13:32:31.283 INFO kablam! --> src/les/mod.rs:4:5 Sep 17 13:32:31.283 INFO kablam! | Sep 17 13:32:31.283 INFO kablam! 4 | use decorate::Decorate; Sep 17 13:32:31.283 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Sep 17 13:32:31.283 INFO kablam! Sep 17 13:32:31.283 INFO kablam! warning: unused import: `paintitems::PaintItems` Sep 17 13:32:31.283 INFO kablam! --> src/les/mod.rs:5:5 Sep 17 13:32:31.283 INFO kablam! | Sep 17 13:32:31.283 INFO kablam! 5 | use paintitems::PaintItems; Sep 17 13:32:31.283 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Sep 17 13:32:31.283 INFO kablam! Sep 17 13:32:31.283 INFO kablam! warning: unused import: `std` Sep 17 13:32:31.283 INFO kablam! --> src/les/mod.rs:43:9 Sep 17 13:32:31.283 INFO kablam! | Sep 17 13:32:31.283 INFO kablam! 43 | use std; Sep 17 13:32:31.283 INFO kablam! | ^^^ Sep 17 13:32:31.283 INFO kablam! Sep 17 13:32:31.291 INFO kablam! warning: unused imports: `Stdout`, `stdout` Sep 17 13:32:31.291 INFO kablam! --> src/io/mod.rs:1:15 Sep 17 13:32:31.291 INFO kablam! | Sep 17 13:32:31.291 INFO kablam! 1 | use std::io::{Stdout,stdout}; Sep 17 13:32:31.291 INFO kablam! | ^^^^^^ ^^^^^^ Sep 17 13:32:31.291 INFO kablam! Sep 17 13:32:31.291 INFO kablam! warning: unused import: `min` Sep 17 13:32:31.291 INFO kablam! --> src/io/mod.rs:2:16 Sep 17 13:32:31.291 INFO kablam! | Sep 17 13:32:31.291 INFO kablam! 2 | use std::cmp::{min,max}; Sep 17 13:32:31.291 INFO kablam! | ^^^ Sep 17 13:32:31.291 INFO kablam! Sep 17 13:32:31.292 INFO kablam! warning: unused import: `std::str::FromStr` Sep 17 13:32:31.292 INFO kablam! --> src/decorate/mod.rs:8:5 Sep 17 13:32:31.292 INFO kablam! | Sep 17 13:32:31.292 INFO kablam! 8 | use std::str::FromStr; Sep 17 13:32:31.292 INFO kablam! | ^^^^^^^^^^^^^^^^^ Sep 17 13:32:31.292 INFO kablam! Sep 17 13:32:31.547 INFO kablam! warning: unused variable: `inodes_count` Sep 17 13:32:31.547 INFO kablam! --> src/io/mod.rs:27:13 Sep 17 13:32:31.547 INFO kablam! | Sep 17 13:32:31.547 INFO kablam! 27 | let inodes_count = inodes.len(); Sep 17 13:32:31.547 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Sep 17 13:32:31.547 INFO kablam! | Sep 17 13:32:31.547 INFO kablam! = note: #[warn(unused_variables)] on by default Sep 17 13:32:31.547 INFO kablam! Sep 17 13:32:31.547 INFO kablam! warning: value assigned to `prev_item_length` is never read Sep 17 13:32:31.547 INFO kablam! --> src/io/mod.rs:73:21 Sep 17 13:32:31.547 INFO kablam! | Sep 17 13:32:31.547 INFO kablam! 73 | let mut prev_item_length = 0; Sep 17 13:32:31.547 INFO kablam! | ^^^^^^^^^^^^^^^^ Sep 17 13:32:31.547 INFO kablam! | Sep 17 13:32:31.547 INFO kablam! = note: #[warn(unused_assignments)] on by default Sep 17 13:32:31.547 INFO kablam! Sep 17 13:32:31.619 INFO kablam! warning: variable does not need to be mutable Sep 17 13:32:31.619 INFO kablam! --> src/io/mod.rs:120:13 Sep 17 13:32:31.619 INFO kablam! | Sep 17 13:32:31.619 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Sep 17 13:32:31.619 INFO kablam! | ----^^^^^^^^^^^^^ Sep 17 13:32:31.619 INFO kablam! | | Sep 17 13:32:31.619 INFO kablam! | help: remove this `mut` Sep 17 13:32:31.619 INFO kablam! | Sep 17 13:32:31.619 INFO kablam! = note: #[warn(unused_mut)] on by default Sep 17 13:32:31.619 INFO kablam! Sep 17 13:32:31.631 INFO kablam! warning: unused variable: `decorator` Sep 17 13:32:31.631 INFO kablam! --> src/les/mod.rs:53:13 Sep 17 13:32:31.631 INFO kablam! | Sep 17 13:32:31.631 INFO kablam! 53 | let decorator = decorate::Decorate::new(None); Sep 17 13:32:31.631 INFO kablam! | ^^^^^^^^^ help: consider using `_decorator` instead Sep 17 13:32:31.631 INFO kablam! | Sep 17 13:32:31.631 INFO kablam! = note: #[warn(unused_variables)] on by default Sep 17 13:32:31.631 INFO kablam! Sep 17 13:32:31.631 INFO kablam! warning: unused variable: `inodes_count` Sep 17 13:32:31.631 INFO kablam! --> src/io/mod.rs:27:13 Sep 17 13:32:31.631 INFO kablam! | Sep 17 13:32:31.631 INFO kablam! 27 | let inodes_count = inodes.len(); Sep 17 13:32:31.631 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Sep 17 13:32:31.631 INFO kablam! Sep 17 13:32:31.631 INFO kablam! warning: value assigned to `prev_item_length` is never read Sep 17 13:32:31.631 INFO kablam! --> src/io/mod.rs:73:21 Sep 17 13:32:31.631 INFO kablam! | Sep 17 13:32:31.631 INFO kablam! 73 | let mut prev_item_length = 0; Sep 17 13:32:31.631 INFO kablam! | ^^^^^^^^^^^^^^^^ Sep 17 13:32:31.631 INFO kablam! | Sep 17 13:32:31.631 INFO kablam! = note: #[warn(unused_assignments)] on by default Sep 17 13:32:31.631 INFO kablam! Sep 17 13:32:31.655 INFO kablam! warning: field is never used: `path` Sep 17 13:32:31.655 INFO kablam! --> src/fs/mod.rs:92:5 Sep 17 13:32:31.655 INFO kablam! | Sep 17 13:32:31.655 INFO kablam! 92 | path: String Sep 17 13:32:31.655 INFO kablam! | ^^^^^^^^^^^^ Sep 17 13:32:31.655 INFO kablam! | Sep 17 13:32:31.655 INFO kablam! = note: #[warn(dead_code)] on by default Sep 17 13:32:31.655 INFO kablam! Sep 17 13:32:31.655 INFO kablam! warning: method is never used: `get_path` Sep 17 13:32:31.655 INFO kablam! --> src/fs/mod.rs:117:5 Sep 17 13:32:31.655 INFO kablam! | Sep 17 13:32:31.655 INFO kablam! 117 | pub fn get_path(&self) -> String { Sep 17 13:32:31.655 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sep 17 13:32:31.655 INFO kablam! Sep 17 13:32:31.667 INFO kablam! warning: variable does not need to be mutable Sep 17 13:32:31.667 INFO kablam! --> src/io/mod.rs:120:13 Sep 17 13:32:31.667 INFO kablam! | Sep 17 13:32:31.667 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Sep 17 13:32:31.667 INFO kablam! | ----^^^^^^^^^^^^^ Sep 17 13:32:31.667 INFO kablam! | | Sep 17 13:32:31.667 INFO kablam! | help: remove this `mut` Sep 17 13:32:31.667 INFO kablam! | Sep 17 13:32:31.667 INFO kablam! = note: #[warn(unused_mut)] on by default Sep 17 13:32:31.667 INFO kablam! Sep 17 13:32:31.671 INFO kablam! warning: comparison is useless due to type limits Sep 17 13:32:31.671 INFO kablam! --> src/paintitems/mod.rs:25:41 Sep 17 13:32:31.671 INFO kablam! | Sep 17 13:32:31.671 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Sep 17 13:32:31.671 INFO kablam! | ^^^^^^^^^ Sep 17 13:32:31.671 INFO kablam! | Sep 17 13:32:31.671 INFO kablam! = note: #[warn(unused_comparisons)] on by default Sep 17 13:32:31.671 INFO kablam! Sep 17 13:32:31.719 INFO kablam! warning: field is never used: `path` Sep 17 13:32:31.719 INFO kablam! --> src/fs/mod.rs:92:5 Sep 17 13:32:31.719 INFO kablam! | Sep 17 13:32:31.719 INFO kablam! 92 | path: String Sep 17 13:32:31.719 INFO kablam! | ^^^^^^^^^^^^ Sep 17 13:32:31.719 INFO kablam! | Sep 17 13:32:31.719 INFO kablam! = note: #[warn(dead_code)] on by default Sep 17 13:32:31.719 INFO kablam! Sep 17 13:32:31.719 INFO kablam! warning: method is never used: `get_path` Sep 17 13:32:31.719 INFO kablam! --> src/fs/mod.rs:117:5 Sep 17 13:32:31.719 INFO kablam! | Sep 17 13:32:31.719 INFO kablam! 117 | pub fn get_path(&self) -> String { Sep 17 13:32:31.719 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sep 17 13:32:31.719 INFO kablam! Sep 17 13:32:31.755 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Sep 17 13:32:31.755 INFO kablam! --> src/style/mod.rs:67:13 Sep 17 13:32:31.755 INFO kablam! | Sep 17 13:32:31.755 INFO kablam! 67 | let licenseItem = PaintItem{ Sep 17 13:32:31.755 INFO kablam! | ^^^^^^^^^^^ Sep 17 13:32:31.755 INFO kablam! | Sep 17 13:32:31.755 INFO kablam! = note: #[warn(non_snake_case)] on by default Sep 17 13:32:31.755 INFO kablam! Sep 17 13:32:31.755 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Sep 17 13:32:31.755 INFO kablam! --> src/style/mod.rs:83:13 Sep 17 13:32:31.755 INFO kablam! | Sep 17 13:32:31.755 INFO kablam! 83 | let licenseItem = PaintItem{ Sep 17 13:32:31.755 INFO kablam! | ^^^^^^^^^^^ Sep 17 13:32:31.755 INFO kablam! Sep 17 13:32:31.775 INFO kablam! warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item` Sep 17 13:32:31.775 INFO kablam! --> src/decorate/mod.rs:201:5 Sep 17 13:32:31.775 INFO kablam! | Sep 17 13:32:31.775 INFO kablam! 201 | / fn it_returns_a_Paint_Item() { Sep 17 13:32:31.775 INFO kablam! 202 | | Sep 17 13:32:31.775 INFO kablam! 203 | | let file = File::new( Sep 17 13:32:31.775 INFO kablam! 204 | | String::from("filename"), Sep 17 13:32:31.775 INFO kablam! ... | Sep 17 13:32:31.775 INFO kablam! 222 | | assert_eq!(paint_item, expected_result); Sep 17 13:32:31.775 INFO kablam! 223 | | } Sep 17 13:32:31.775 INFO kablam! | |_____^ Sep 17 13:32:31.775 INFO kablam! Sep 17 13:32:31.775 INFO kablam! warning: comparison is useless due to type limits Sep 17 13:32:31.775 INFO kablam! --> src/paintitems/mod.rs:25:41 Sep 17 13:32:31.775 INFO kablam! | Sep 17 13:32:31.775 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Sep 17 13:32:31.775 INFO kablam! | ^^^^^^^^^ Sep 17 13:32:31.775 INFO kablam! | Sep 17 13:32:31.775 INFO kablam! = note: #[warn(unused_comparisons)] on by default Sep 17 13:32:31.775 INFO kablam! Sep 17 13:32:31.815 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.46s Sep 17 13:32:31.823 INFO kablam! su: No module specific data is present Sep 17 13:32:33.277 INFO running `"docker" "rm" "-f" "f1cdf1f19ebd1ad8be2ab3d925b1ba0bc27c5b7cdbbf338c71e716ac02218612"` Sep 17 13:32:33.651 INFO blam! f1cdf1f19ebd1ad8be2ab3d925b1ba0bc27c5b7cdbbf338c71e716ac02218612