Sep 05 19:27:10.563 INFO checking benbrunton/les against master#1c2e17f4e3a2070a7f703f51e29c1c388ef703b6 for pr-53854 Sep 05 19:27:10.563 INFO running: cargo +1c2e17f4e3a2070a7f703f51e29c1c388ef703b6-alt check --frozen --all --all-targets Sep 05 19:27:10.564 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-5/pr-53854/master#1c2e17f4e3a2070a7f703f51e29c1c388ef703b6:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-53854/worker-5/master#1c2e17f4e3a2070a7f703f51e29c1c388ef703b6:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "CMD=cargo +1c2e17f4e3a2070a7f703f51e29c1c388ef703b6-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-m" "2G" "crater"` Sep 05 19:27:11.070 INFO blam! 7abe153b4b0b3dd1cc3b2aef6c32d35734d55d4c40739ff2dfc5ff05b3552eda Sep 05 19:27:11.078 INFO running `"docker" "start" "-a" "7abe153b4b0b3dd1cc3b2aef6c32d35734d55d4c40739ff2dfc5ff05b3552eda"` Sep 05 19:27:12.814 INFO kablam! usermod: no changes Sep 05 19:27:12.990 INFO kablam! Checking terminal_size v0.1.7 Sep 05 19:27:13.381 INFO kablam! Checking les v0.2.1 (file:///source) Sep 05 19:27:13.758 INFO kablam! warning: unused import: `std::io::stdout` Sep 05 19:27:13.758 INFO kablam! --> src/main.rs:8:5 Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.758 INFO kablam! 8 | use std::io::stdout; Sep 05 19:27:13.758 INFO kablam! | ^^^^^^^^^^^^^^^ Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.758 INFO kablam! = note: #[warn(unused_imports)] on by default Sep 05 19:27:13.758 INFO kablam! Sep 05 19:27:13.758 INFO kablam! warning: unused import: `std::io::Write` Sep 05 19:27:13.758 INFO kablam! --> src/les/mod.rs:2:5 Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.758 INFO kablam! 2 | use std::io::Write; Sep 05 19:27:13.758 INFO kablam! | ^^^^^^^^^^^^^^ Sep 05 19:27:13.758 INFO kablam! Sep 05 19:27:13.758 INFO kablam! warning: unused import: `decorate::Decorate` Sep 05 19:27:13.758 INFO kablam! --> src/les/mod.rs:4:5 Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.758 INFO kablam! 4 | use decorate::Decorate; Sep 05 19:27:13.758 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Sep 05 19:27:13.758 INFO kablam! Sep 05 19:27:13.758 INFO kablam! warning: unused import: `paintitems::PaintItems` Sep 05 19:27:13.758 INFO kablam! --> src/les/mod.rs:5:5 Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.758 INFO kablam! 5 | use paintitems::PaintItems; Sep 05 19:27:13.758 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Sep 05 19:27:13.758 INFO kablam! Sep 05 19:27:13.758 INFO kablam! warning: unused import: `std` Sep 05 19:27:13.758 INFO kablam! --> src/les/mod.rs:43:9 Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.758 INFO kablam! 43 | use std; Sep 05 19:27:13.758 INFO kablam! | ^^^ Sep 05 19:27:13.758 INFO kablam! Sep 05 19:27:13.758 INFO kablam! warning: unused imports: `Stdout`, `stdout` Sep 05 19:27:13.758 INFO kablam! --> src/io/mod.rs:1:15 Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.758 INFO kablam! 1 | use std::io::{Stdout,stdout}; Sep 05 19:27:13.758 INFO kablam! | ^^^^^^ ^^^^^^ Sep 05 19:27:13.758 INFO kablam! Sep 05 19:27:13.758 INFO kablam! warning: unused import: `min` Sep 05 19:27:13.758 INFO kablam! --> src/io/mod.rs:2:16 Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.758 INFO kablam! 2 | use std::cmp::{min,max}; Sep 05 19:27:13.758 INFO kablam! | ^^^ Sep 05 19:27:13.758 INFO kablam! Sep 05 19:27:13.758 INFO kablam! warning: unused import: `std::str::FromStr` Sep 05 19:27:13.758 INFO kablam! --> src/decorate/mod.rs:8:5 Sep 05 19:27:13.758 INFO kablam! | Sep 05 19:27:13.759 INFO kablam! 8 | use std::str::FromStr; Sep 05 19:27:13.759 INFO kablam! | ^^^^^^^^^^^^^^^^^ Sep 05 19:27:13.759 INFO kablam! Sep 05 19:27:13.786 INFO kablam! warning: unused import: `std::io::stdout` Sep 05 19:27:13.786 INFO kablam! --> src/main.rs:8:5 Sep 05 19:27:13.786 INFO kablam! | Sep 05 19:27:13.786 INFO kablam! 8 | use std::io::stdout; Sep 05 19:27:13.786 INFO kablam! | ^^^^^^^^^^^^^^^ Sep 05 19:27:13.786 INFO kablam! | Sep 05 19:27:13.786 INFO kablam! = note: #[warn(unused_imports)] on by default Sep 05 19:27:13.786 INFO kablam! Sep 05 19:27:13.786 INFO kablam! warning: unused import: `std::io::Write` Sep 05 19:27:13.786 INFO kablam! --> src/les/mod.rs:2:5 Sep 05 19:27:13.786 INFO kablam! | Sep 05 19:27:13.786 INFO kablam! 2 | use std::io::Write; Sep 05 19:27:13.786 INFO kablam! | ^^^^^^^^^^^^^^ Sep 05 19:27:13.786 INFO kablam! Sep 05 19:27:13.786 INFO kablam! warning: unused import: `decorate::Decorate` Sep 05 19:27:13.786 INFO kablam! --> src/les/mod.rs:4:5 Sep 05 19:27:13.786 INFO kablam! | Sep 05 19:27:13.786 INFO kablam! 4 | use decorate::Decorate; Sep 05 19:27:13.786 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Sep 05 19:27:13.786 INFO kablam! Sep 05 19:27:13.786 INFO kablam! warning: unused import: `paintitems::PaintItems` Sep 05 19:27:13.786 INFO kablam! --> src/les/mod.rs:5:5 Sep 05 19:27:13.786 INFO kablam! | Sep 05 19:27:13.786 INFO kablam! 5 | use paintitems::PaintItems; Sep 05 19:27:13.786 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Sep 05 19:27:13.786 INFO kablam! Sep 05 19:27:13.786 INFO kablam! warning: unused imports: `Stdout`, `stdout` Sep 05 19:27:13.786 INFO kablam! --> src/io/mod.rs:1:15 Sep 05 19:27:13.786 INFO kablam! | Sep 05 19:27:13.786 INFO kablam! 1 | use std::io::{Stdout,stdout}; Sep 05 19:27:13.786 INFO kablam! | ^^^^^^ ^^^^^^ Sep 05 19:27:13.786 INFO kablam! Sep 05 19:27:13.786 INFO kablam! warning: unused import: `min` Sep 05 19:27:13.786 INFO kablam! --> src/io/mod.rs:2:16 Sep 05 19:27:13.786 INFO kablam! | Sep 05 19:27:13.786 INFO kablam! 2 | use std::cmp::{min,max}; Sep 05 19:27:13.786 INFO kablam! | ^^^ Sep 05 19:27:13.786 INFO kablam! Sep 05 19:27:13.786 INFO kablam! warning: unused import: `std::str::FromStr` Sep 05 19:27:13.786 INFO kablam! --> src/decorate/mod.rs:8:5 Sep 05 19:27:13.786 INFO kablam! | Sep 05 19:27:13.786 INFO kablam! 8 | use std::str::FromStr; Sep 05 19:27:13.786 INFO kablam! | ^^^^^^^^^^^^^^^^^ Sep 05 19:27:13.786 INFO kablam! Sep 05 19:27:13.918 INFO kablam! warning: unused variable: `decorator` Sep 05 19:27:13.918 INFO kablam! --> src/les/mod.rs:53:13 Sep 05 19:27:13.918 INFO kablam! | Sep 05 19:27:13.918 INFO kablam! 53 | let decorator = decorate::Decorate::new(None); Sep 05 19:27:13.918 INFO kablam! | ^^^^^^^^^ help: consider using `_decorator` instead Sep 05 19:27:13.918 INFO kablam! | Sep 05 19:27:13.918 INFO kablam! = note: #[warn(unused_variables)] on by default Sep 05 19:27:13.918 INFO kablam! Sep 05 19:27:13.918 INFO kablam! warning: unused variable: `inodes_count` Sep 05 19:27:13.918 INFO kablam! --> src/io/mod.rs:27:13 Sep 05 19:27:13.918 INFO kablam! | Sep 05 19:27:13.918 INFO kablam! 27 | let inodes_count = inodes.len(); Sep 05 19:27:13.918 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Sep 05 19:27:13.918 INFO kablam! Sep 05 19:27:13.918 INFO kablam! warning: value assigned to `prev_item_length` is never read Sep 05 19:27:13.918 INFO kablam! --> src/io/mod.rs:73:21 Sep 05 19:27:13.918 INFO kablam! | Sep 05 19:27:13.918 INFO kablam! 73 | let mut prev_item_length = 0; Sep 05 19:27:13.918 INFO kablam! | ^^^^^^^^^^^^^^^^ Sep 05 19:27:13.918 INFO kablam! | Sep 05 19:27:13.918 INFO kablam! = note: #[warn(unused_assignments)] on by default Sep 05 19:27:13.918 INFO kablam! Sep 05 19:27:13.946 INFO kablam! warning: variable does not need to be mutable Sep 05 19:27:13.946 INFO kablam! --> src/io/mod.rs:120:13 Sep 05 19:27:13.946 INFO kablam! | Sep 05 19:27:13.946 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Sep 05 19:27:13.946 INFO kablam! | ----^^^^^^^^^^^^^ Sep 05 19:27:13.946 INFO kablam! | | Sep 05 19:27:13.946 INFO kablam! | help: remove this `mut` Sep 05 19:27:13.946 INFO kablam! | Sep 05 19:27:13.946 INFO kablam! = note: #[warn(unused_mut)] on by default Sep 05 19:27:13.946 INFO kablam! Sep 05 19:27:13.970 INFO kablam! warning: field is never used: `path` Sep 05 19:27:13.970 INFO kablam! --> src/fs/mod.rs:92:5 Sep 05 19:27:13.970 INFO kablam! | Sep 05 19:27:13.970 INFO kablam! 92 | path: String Sep 05 19:27:13.970 INFO kablam! | ^^^^^^^^^^^^ Sep 05 19:27:13.970 INFO kablam! | Sep 05 19:27:13.970 INFO kablam! = note: #[warn(dead_code)] on by default Sep 05 19:27:13.970 INFO kablam! Sep 05 19:27:13.970 INFO kablam! warning: method is never used: `get_path` Sep 05 19:27:13.970 INFO kablam! --> src/fs/mod.rs:117:5 Sep 05 19:27:13.970 INFO kablam! | Sep 05 19:27:13.970 INFO kablam! 117 | pub fn get_path(&self) -> String { Sep 05 19:27:13.970 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sep 05 19:27:13.970 INFO kablam! Sep 05 19:27:13.970 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Sep 05 19:27:13.970 INFO kablam! --> src/style/mod.rs:67:13 Sep 05 19:27:13.970 INFO kablam! | Sep 05 19:27:13.970 INFO kablam! 67 | let licenseItem = PaintItem{ Sep 05 19:27:13.970 INFO kablam! | ^^^^^^^^^^^ Sep 05 19:27:13.970 INFO kablam! | Sep 05 19:27:13.970 INFO kablam! = note: #[warn(non_snake_case)] on by default Sep 05 19:27:13.970 INFO kablam! Sep 05 19:27:13.970 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Sep 05 19:27:13.970 INFO kablam! --> src/style/mod.rs:83:13 Sep 05 19:27:13.970 INFO kablam! | Sep 05 19:27:13.970 INFO kablam! 83 | let licenseItem = PaintItem{ Sep 05 19:27:13.970 INFO kablam! | ^^^^^^^^^^^ Sep 05 19:27:13.970 INFO kablam! Sep 05 19:27:13.971 INFO kablam! warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item` Sep 05 19:27:13.971 INFO kablam! --> src/decorate/mod.rs:201:5 Sep 05 19:27:13.971 INFO kablam! | Sep 05 19:27:13.971 INFO kablam! 201 | / fn it_returns_a_Paint_Item() { Sep 05 19:27:13.971 INFO kablam! 202 | | Sep 05 19:27:13.971 INFO kablam! 203 | | let file = File::new( Sep 05 19:27:13.971 INFO kablam! 204 | | String::from("filename"), Sep 05 19:27:13.971 INFO kablam! ... | Sep 05 19:27:13.971 INFO kablam! 222 | | assert_eq!(paint_item, expected_result); Sep 05 19:27:13.971 INFO kablam! 223 | | } Sep 05 19:27:13.971 INFO kablam! | |_____^ Sep 05 19:27:13.971 INFO kablam! Sep 05 19:27:13.971 INFO kablam! warning: comparison is useless due to type limits Sep 05 19:27:13.971 INFO kablam! --> src/paintitems/mod.rs:25:41 Sep 05 19:27:13.971 INFO kablam! | Sep 05 19:27:13.971 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Sep 05 19:27:13.971 INFO kablam! | ^^^^^^^^^ Sep 05 19:27:13.971 INFO kablam! | Sep 05 19:27:13.971 INFO kablam! = note: #[warn(unused_comparisons)] on by default Sep 05 19:27:13.971 INFO kablam! Sep 05 19:27:14.142 INFO kablam! warning: unused variable: `inodes_count` Sep 05 19:27:14.142 INFO kablam! --> src/io/mod.rs:27:13 Sep 05 19:27:14.142 INFO kablam! | Sep 05 19:27:14.142 INFO kablam! 27 | let inodes_count = inodes.len(); Sep 05 19:27:14.142 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Sep 05 19:27:14.142 INFO kablam! | Sep 05 19:27:14.142 INFO kablam! = note: #[warn(unused_variables)] on by default Sep 05 19:27:14.142 INFO kablam! Sep 05 19:27:14.142 INFO kablam! warning: value assigned to `prev_item_length` is never read Sep 05 19:27:14.142 INFO kablam! --> src/io/mod.rs:73:21 Sep 05 19:27:14.142 INFO kablam! | Sep 05 19:27:14.142 INFO kablam! 73 | let mut prev_item_length = 0; Sep 05 19:27:14.142 INFO kablam! | ^^^^^^^^^^^^^^^^ Sep 05 19:27:14.142 INFO kablam! | Sep 05 19:27:14.142 INFO kablam! = note: #[warn(unused_assignments)] on by default Sep 05 19:27:14.142 INFO kablam! Sep 05 19:27:14.186 INFO kablam! warning: variable does not need to be mutable Sep 05 19:27:14.186 INFO kablam! --> src/io/mod.rs:120:13 Sep 05 19:27:14.186 INFO kablam! | Sep 05 19:27:14.186 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Sep 05 19:27:14.186 INFO kablam! | ----^^^^^^^^^^^^^ Sep 05 19:27:14.186 INFO kablam! | | Sep 05 19:27:14.186 INFO kablam! | help: remove this `mut` Sep 05 19:27:14.186 INFO kablam! | Sep 05 19:27:14.186 INFO kablam! = note: #[warn(unused_mut)] on by default Sep 05 19:27:14.186 INFO kablam! Sep 05 19:27:14.239 INFO kablam! warning: field is never used: `path` Sep 05 19:27:14.239 INFO kablam! --> src/fs/mod.rs:92:5 Sep 05 19:27:14.239 INFO kablam! | Sep 05 19:27:14.239 INFO kablam! 92 | path: String Sep 05 19:27:14.239 INFO kablam! | ^^^^^^^^^^^^ Sep 05 19:27:14.244 INFO kablam! | Sep 05 19:27:14.244 INFO kablam! = note: #[warn(dead_code)] on by default Sep 05 19:27:14.244 INFO kablam! Sep 05 19:27:14.244 INFO kablam! warning: method is never used: `get_path` Sep 05 19:27:14.244 INFO kablam! --> src/fs/mod.rs:117:5 Sep 05 19:27:14.244 INFO kablam! | Sep 05 19:27:14.244 INFO kablam! 117 | pub fn get_path(&self) -> String { Sep 05 19:27:14.244 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Sep 05 19:27:14.244 INFO kablam! Sep 05 19:27:14.244 INFO kablam! warning: comparison is useless due to type limits Sep 05 19:27:14.244 INFO kablam! --> src/paintitems/mod.rs:25:41 Sep 05 19:27:14.244 INFO kablam! | Sep 05 19:27:14.244 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Sep 05 19:27:14.244 INFO kablam! | ^^^^^^^^^ Sep 05 19:27:14.244 INFO kablam! | Sep 05 19:27:14.244 INFO kablam! = note: #[warn(unused_comparisons)] on by default Sep 05 19:27:14.244 INFO kablam! Sep 05 19:27:14.294 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.43s Sep 05 19:27:14.314 INFO kablam! su: No module specific data is present Sep 05 19:27:15.529 INFO running `"docker" "rm" "-f" "7abe153b4b0b3dd1cc3b2aef6c32d35734d55d4c40739ff2dfc5ff05b3552eda"` Sep 05 19:27:15.826 INFO blam! 7abe153b4b0b3dd1cc3b2aef6c32d35734d55d4c40739ff2dfc5ff05b3552eda