Sep 01 16:36:20.788 INFO checking benbrunton/les against master#1114ab684fbad001c4e580326d8eb4d8c4e917d3 for pr-53851
Sep 01 16:36:20.788 INFO running: cargo +1114ab684fbad001c4e580326d8eb4d8c4e917d3-alt check --frozen --all --all-targets
Sep 01 16:36:20.788 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-2/pr-53851/master#1114ab684fbad001c4e580326d8eb4d8c4e917d3:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-53851/worker-2/master#1114ab684fbad001c4e580326d8eb4d8c4e917d3:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=500" "-e" "CMD=cargo +1114ab684fbad001c4e580326d8eb4d8c4e917d3-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-m" "2G" "crater"`
Sep 01 16:36:21.006 INFO blam! ed7f7371675958f748243cb86be695068f99d2a095e70abef6d7d2eb4cf4bf37
Sep 01 16:36:21.008 INFO running `"docker" "start" "-a" "ed7f7371675958f748243cb86be695068f99d2a095e70abef6d7d2eb4cf4bf37"`
Sep 01 16:36:21.693 INFO kablam!     Checking terminal_size v0.1.7
Sep 01 16:36:22.048 INFO kablam!     Checking les v0.2.1 (file:///source)
Sep 01 16:36:22.486 INFO kablam! warning: unused import: `std::io::stdout`
Sep 01 16:36:22.486 INFO kablam!  --> src/main.rs:8:5
Sep 01 16:36:22.487 INFO kablam!   |
Sep 01 16:36:22.487 INFO kablam! 8 | use std::io::stdout;
Sep 01 16:36:22.487 INFO kablam!   |     ^^^^^^^^^^^^^^^
Sep 01 16:36:22.487 INFO kablam!   |
Sep 01 16:36:22.487 INFO kablam!   = note: #[warn(unused_imports)] on by default
Sep 01 16:36:22.487 INFO kablam! 
Sep 01 16:36:22.488 INFO kablam! warning: unused import: `std::io::Write`
Sep 01 16:36:22.488 INFO kablam!  --> src/les/mod.rs:2:5
Sep 01 16:36:22.488 INFO kablam!   |
Sep 01 16:36:22.488 INFO kablam! 2 | use std::io::Write;
Sep 01 16:36:22.488 INFO kablam!   |     ^^^^^^^^^^^^^^
Sep 01 16:36:22.488 INFO kablam! 
Sep 01 16:36:22.488 INFO kablam! warning: unused import: `decorate::Decorate`
Sep 01 16:36:22.488 INFO kablam!  --> src/les/mod.rs:4:5
Sep 01 16:36:22.488 INFO kablam!   |
Sep 01 16:36:22.488 INFO kablam! 4 | use decorate::Decorate;
Sep 01 16:36:22.488 INFO kablam!   |     ^^^^^^^^^^^^^^^^^^
Sep 01 16:36:22.488 INFO kablam! 
Sep 01 16:36:22.488 INFO kablam! warning: unused import: `paintitems::PaintItems`
Sep 01 16:36:22.488 INFO kablam!  --> src/les/mod.rs:5:5
Sep 01 16:36:22.488 INFO kablam!   |
Sep 01 16:36:22.488 INFO kablam! 5 | use paintitems::PaintItems;
Sep 01 16:36:22.488 INFO kablam!   |     ^^^^^^^^^^^^^^^^^^^^^^
Sep 01 16:36:22.488 INFO kablam! 
Sep 01 16:36:22.488 INFO kablam! warning: unused imports: `Stdout`, `stdout`
Sep 01 16:36:22.488 INFO kablam!  --> src/io/mod.rs:1:15
Sep 01 16:36:22.488 INFO kablam!   |
Sep 01 16:36:22.488 INFO kablam! 1 | use std::io::{Stdout,stdout};
Sep 01 16:36:22.488 INFO kablam!   |               ^^^^^^ ^^^^^^
Sep 01 16:36:22.488 INFO kablam! 
Sep 01 16:36:22.488 INFO kablam! warning: unused import: `min`
Sep 01 16:36:22.488 INFO kablam!  --> src/io/mod.rs:2:16
Sep 01 16:36:22.488 INFO kablam!   |
Sep 01 16:36:22.488 INFO kablam! 2 | use std::cmp::{min,max};
Sep 01 16:36:22.489 INFO kablam!   |                ^^^
Sep 01 16:36:22.489 INFO kablam! 
Sep 01 16:36:22.490 INFO kablam! warning: unused import: `std::str::FromStr`
Sep 01 16:36:22.490 INFO kablam!  --> src/decorate/mod.rs:8:5
Sep 01 16:36:22.490 INFO kablam!   |
Sep 01 16:36:22.490 INFO kablam! 8 | use std::str::FromStr;
Sep 01 16:36:22.490 INFO kablam!   |     ^^^^^^^^^^^^^^^^^
Sep 01 16:36:22.490 INFO kablam! 
Sep 01 16:36:22.527 INFO kablam! warning: unused import: `std::io::stdout`
Sep 01 16:36:22.528 INFO kablam!  --> src/main.rs:8:5
Sep 01 16:36:22.528 INFO kablam!   |
Sep 01 16:36:22.528 INFO kablam! 8 | use std::io::stdout;
Sep 01 16:36:22.528 INFO kablam!   |     ^^^^^^^^^^^^^^^
Sep 01 16:36:22.528 INFO kablam!   |
Sep 01 16:36:22.528 INFO kablam!   = note: #[warn(unused_imports)] on by default
Sep 01 16:36:22.528 INFO kablam! 
Sep 01 16:36:22.529 INFO kablam! warning: unused import: `std::io::Write`
Sep 01 16:36:22.529 INFO kablam!  --> src/les/mod.rs:2:5
Sep 01 16:36:22.529 INFO kablam!   |
Sep 01 16:36:22.529 INFO kablam! 2 | use std::io::Write;
Sep 01 16:36:22.529 INFO kablam!   |     ^^^^^^^^^^^^^^
Sep 01 16:36:22.529 INFO kablam! 
Sep 01 16:36:22.529 INFO kablam! warning: unused import: `decorate::Decorate`
Sep 01 16:36:22.529 INFO kablam!  --> src/les/mod.rs:4:5
Sep 01 16:36:22.529 INFO kablam!   |
Sep 01 16:36:22.529 INFO kablam! 4 | use decorate::Decorate;
Sep 01 16:36:22.529 INFO kablam!   |     ^^^^^^^^^^^^^^^^^^
Sep 01 16:36:22.529 INFO kablam! 
Sep 01 16:36:22.529 INFO kablam! warning: unused import: `paintitems::PaintItems`
Sep 01 16:36:22.529 INFO kablam!  --> src/les/mod.rs:5:5
Sep 01 16:36:22.529 INFO kablam!   |
Sep 01 16:36:22.529 INFO kablam! 5 | use paintitems::PaintItems;
Sep 01 16:36:22.529 INFO kablam!   |     ^^^^^^^^^^^^^^^^^^^^^^
Sep 01 16:36:22.529 INFO kablam! 
Sep 01 16:36:22.529 INFO kablam! warning: unused import: `std`
Sep 01 16:36:22.529 INFO kablam!   --> src/les/mod.rs:43:9
Sep 01 16:36:22.529 INFO kablam!    |
Sep 01 16:36:22.529 INFO kablam! 43 |     use std;
Sep 01 16:36:22.530 INFO kablam!    |         ^^^
Sep 01 16:36:22.530 INFO kablam! 
Sep 01 16:36:22.531 INFO kablam! warning: unused imports: `Stdout`, `stdout`
Sep 01 16:36:22.531 INFO kablam!  --> src/io/mod.rs:1:15
Sep 01 16:36:22.531 INFO kablam!   |
Sep 01 16:36:22.531 INFO kablam! 1 | use std::io::{Stdout,stdout};
Sep 01 16:36:22.531 INFO kablam!   |               ^^^^^^ ^^^^^^
Sep 01 16:36:22.531 INFO kablam! 
Sep 01 16:36:22.531 INFO kablam! warning: unused import: `min`
Sep 01 16:36:22.531 INFO kablam!  --> src/io/mod.rs:2:16
Sep 01 16:36:22.531 INFO kablam!   |
Sep 01 16:36:22.531 INFO kablam! 2 | use std::cmp::{min,max};
Sep 01 16:36:22.531 INFO kablam!   |                ^^^
Sep 01 16:36:22.531 INFO kablam! 
Sep 01 16:36:22.531 INFO kablam! warning: unused import: `std::str::FromStr`
Sep 01 16:36:22.531 INFO kablam!  --> src/decorate/mod.rs:8:5
Sep 01 16:36:22.531 INFO kablam!   |
Sep 01 16:36:22.531 INFO kablam! 8 | use std::str::FromStr;
Sep 01 16:36:22.531 INFO kablam!   |     ^^^^^^^^^^^^^^^^^
Sep 01 16:36:22.531 INFO kablam! 
Sep 01 16:36:22.833 INFO kablam! warning: unused variable: `inodes_count`
Sep 01 16:36:22.833 INFO kablam!   --> src/io/mod.rs:27:13
Sep 01 16:36:22.833 INFO kablam!    |
Sep 01 16:36:22.833 INFO kablam! 27 |         let inodes_count = inodes.len();
Sep 01 16:36:22.833 INFO kablam!    |             ^^^^^^^^^^^^ help: consider using `_inodes_count` instead
Sep 01 16:36:22.833 INFO kablam!    |
Sep 01 16:36:22.833 INFO kablam!    = note: #[warn(unused_variables)] on by default
Sep 01 16:36:22.834 INFO kablam! 
Sep 01 16:36:22.834 INFO kablam! warning: value assigned to `prev_item_length` is never read
Sep 01 16:36:22.834 INFO kablam!   --> src/io/mod.rs:73:21
Sep 01 16:36:22.834 INFO kablam!    |
Sep 01 16:36:22.834 INFO kablam! 73 |             let mut prev_item_length = 0;
Sep 01 16:36:22.834 INFO kablam!    |                     ^^^^^^^^^^^^^^^^
Sep 01 16:36:22.834 INFO kablam!    |
Sep 01 16:36:22.834 INFO kablam!    = note: #[warn(unused_assignments)] on by default
Sep 01 16:36:22.834 INFO kablam! 
Sep 01 16:36:22.889 INFO kablam! warning: variable does not need to be mutable
Sep 01 16:36:22.889 INFO kablam!    --> src/io/mod.rs:120:13
Sep 01 16:36:22.889 INFO kablam!     |
Sep 01 16:36:22.889 INFO kablam! 120 |         let mut visible_items = paint_items.get_visible();
Sep 01 16:36:22.889 INFO kablam!     |             ----^^^^^^^^^^^^^
Sep 01 16:36:22.889 INFO kablam!     |             |
Sep 01 16:36:22.889 INFO kablam!     |             help: remove this `mut`
Sep 01 16:36:22.890 INFO kablam!     |
Sep 01 16:36:22.890 INFO kablam!     = note: #[warn(unused_mut)] on by default
Sep 01 16:36:22.890 INFO kablam! 
Sep 01 16:36:22.928 INFO kablam! warning: field is never used: `path`
Sep 01 16:36:22.928 INFO kablam!   --> src/fs/mod.rs:92:5
Sep 01 16:36:22.928 INFO kablam!    |
Sep 01 16:36:22.928 INFO kablam! 92 |     path: String
Sep 01 16:36:22.928 INFO kablam!    |     ^^^^^^^^^^^^
Sep 01 16:36:22.928 INFO kablam!    |
Sep 01 16:36:22.928 INFO kablam!    = note: #[warn(dead_code)] on by default
Sep 01 16:36:22.928 INFO kablam! 
Sep 01 16:36:22.929 INFO kablam! warning: method is never used: `get_path`
Sep 01 16:36:22.929 INFO kablam!    --> src/fs/mod.rs:117:5
Sep 01 16:36:22.929 INFO kablam!     |
Sep 01 16:36:22.929 INFO kablam! 117 |     pub fn get_path(&self) -> String {
Sep 01 16:36:22.929 INFO kablam!     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Sep 01 16:36:22.929 INFO kablam! 
Sep 01 16:36:22.935 INFO kablam! warning: comparison is useless due to type limits
Sep 01 16:36:22.936 INFO kablam!   --> src/paintitems/mod.rs:25:41
Sep 01 16:36:22.936 INFO kablam!    |
Sep 01 16:36:22.936 INFO kablam! 25 |         if index >= self.items.len() || index < 0 {
Sep 01 16:36:22.936 INFO kablam!    |                                         ^^^^^^^^^
Sep 01 16:36:22.936 INFO kablam!    |
Sep 01 16:36:22.936 INFO kablam!    = note: #[warn(unused_comparisons)] on by default
Sep 01 16:36:22.936 INFO kablam! 
Sep 01 16:36:22.986 INFO kablam! warning: unused variable: `decorator`
Sep 01 16:36:22.986 INFO kablam!   --> src/les/mod.rs:53:13
Sep 01 16:36:22.986 INFO kablam!    |
Sep 01 16:36:22.986 INFO kablam! 53 |         let decorator = decorate::Decorate::new(None);
Sep 01 16:36:22.986 INFO kablam!    |             ^^^^^^^^^ help: consider using `_decorator` instead
Sep 01 16:36:22.986 INFO kablam!    |
Sep 01 16:36:22.986 INFO kablam!    = note: #[warn(unused_variables)] on by default
Sep 01 16:36:22.986 INFO kablam! 
Sep 01 16:36:22.987 INFO kablam! warning: unused variable: `inodes_count`
Sep 01 16:36:22.987 INFO kablam!   --> src/io/mod.rs:27:13
Sep 01 16:36:22.987 INFO kablam!    |
Sep 01 16:36:22.987 INFO kablam! 27 |         let inodes_count = inodes.len();
Sep 01 16:36:22.987 INFO kablam!    |             ^^^^^^^^^^^^ help: consider using `_inodes_count` instead
Sep 01 16:36:22.988 INFO kablam! 
Sep 01 16:36:22.988 INFO kablam! warning: value assigned to `prev_item_length` is never read
Sep 01 16:36:22.988 INFO kablam!   --> src/io/mod.rs:73:21
Sep 01 16:36:22.988 INFO kablam!    |
Sep 01 16:36:22.988 INFO kablam! 73 |             let mut prev_item_length = 0;
Sep 01 16:36:22.988 INFO kablam!    |                     ^^^^^^^^^^^^^^^^
Sep 01 16:36:22.988 INFO kablam!    |
Sep 01 16:36:22.988 INFO kablam!    = note: #[warn(unused_assignments)] on by default
Sep 01 16:36:22.988 INFO kablam! 
Sep 01 16:36:23.055 INFO kablam! warning: variable does not need to be mutable
Sep 01 16:36:23.056 INFO kablam!    --> src/io/mod.rs:120:13
Sep 01 16:36:23.056 INFO kablam!     |
Sep 01 16:36:23.056 INFO kablam! 120 |         let mut visible_items = paint_items.get_visible();
Sep 01 16:36:23.056 INFO kablam!     |             ----^^^^^^^^^^^^^
Sep 01 16:36:23.056 INFO kablam!     |             |
Sep 01 16:36:23.056 INFO kablam!     |             help: remove this `mut`
Sep 01 16:36:23.057 INFO kablam!     |
Sep 01 16:36:23.057 INFO kablam!     = note: #[warn(unused_mut)] on by default
Sep 01 16:36:23.057 INFO kablam! 
Sep 01 16:36:23.115 INFO kablam! warning: field is never used: `path`
Sep 01 16:36:23.115 INFO kablam!   --> src/fs/mod.rs:92:5
Sep 01 16:36:23.115 INFO kablam!    |
Sep 01 16:36:23.115 INFO kablam! 92 |     path: String
Sep 01 16:36:23.115 INFO kablam!    |     ^^^^^^^^^^^^
Sep 01 16:36:23.116 INFO kablam!    |
Sep 01 16:36:23.116 INFO kablam!    = note: #[warn(dead_code)] on by default
Sep 01 16:36:23.116 INFO kablam! 
Sep 01 16:36:23.117 INFO kablam! warning: method is never used: `get_path`
Sep 01 16:36:23.117 INFO kablam!    --> src/fs/mod.rs:117:5
Sep 01 16:36:23.117 INFO kablam!     |
Sep 01 16:36:23.117 INFO kablam! 117 |     pub fn get_path(&self) -> String {
Sep 01 16:36:23.117 INFO kablam!     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Sep 01 16:36:23.118 INFO kablam! 
Sep 01 16:36:23.123 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item`
Sep 01 16:36:23.123 INFO kablam!   --> src/style/mod.rs:67:13
Sep 01 16:36:23.123 INFO kablam!    |
Sep 01 16:36:23.123 INFO kablam! 67 |         let licenseItem = PaintItem{
Sep 01 16:36:23.123 INFO kablam!    |             ^^^^^^^^^^^
Sep 01 16:36:23.123 INFO kablam!    |
Sep 01 16:36:23.123 INFO kablam!    = note: #[warn(non_snake_case)] on by default
Sep 01 16:36:23.123 INFO kablam! 
Sep 01 16:36:23.124 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item`
Sep 01 16:36:23.124 INFO kablam!   --> src/style/mod.rs:83:13
Sep 01 16:36:23.124 INFO kablam!    |
Sep 01 16:36:23.124 INFO kablam! 83 |         let licenseItem = PaintItem{
Sep 01 16:36:23.124 INFO kablam!    |             ^^^^^^^^^^^
Sep 01 16:36:23.124 INFO kablam! 
Sep 01 16:36:23.130 INFO kablam! warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item`
Sep 01 16:36:23.130 INFO kablam!    --> src/decorate/mod.rs:201:5
Sep 01 16:36:23.130 INFO kablam!     |
Sep 01 16:36:23.130 INFO kablam! 201 | /     fn it_returns_a_Paint_Item() {
Sep 01 16:36:23.130 INFO kablam! 202 | |
Sep 01 16:36:23.130 INFO kablam! 203 | |         let file = File::new(
Sep 01 16:36:23.130 INFO kablam! 204 | |             String::from("filename"),
Sep 01 16:36:23.130 INFO kablam! ...   |
Sep 01 16:36:23.130 INFO kablam! 222 | |         assert_eq!(paint_item, expected_result);
Sep 01 16:36:23.130 INFO kablam! 223 | |     }
Sep 01 16:36:23.130 INFO kablam!     | |_____^
Sep 01 16:36:23.130 INFO kablam! 
Sep 01 16:36:23.132 INFO kablam! warning: comparison is useless due to type limits
Sep 01 16:36:23.132 INFO kablam!   --> src/paintitems/mod.rs:25:41
Sep 01 16:36:23.132 INFO kablam!    |
Sep 01 16:36:23.132 INFO kablam! 25 |         if index >= self.items.len() || index < 0 {
Sep 01 16:36:23.132 INFO kablam!    |                                         ^^^^^^^^^
Sep 01 16:36:23.133 INFO kablam!    |
Sep 01 16:36:23.133 INFO kablam!    = note: #[warn(unused_comparisons)] on by default
Sep 01 16:36:23.133 INFO kablam! 
Sep 01 16:36:23.162 INFO kablam!     Finished dev [unoptimized + debuginfo] target(s) in 1.54s
Sep 01 16:36:23.168 INFO kablam! su: No module specific data is present
Sep 01 16:36:23.615 INFO running `"docker" "rm" "-f" "ed7f7371675958f748243cb86be695068f99d2a095e70abef6d7d2eb4cf4bf37"`
Sep 01 16:36:23.779 INFO blam! ed7f7371675958f748243cb86be695068f99d2a095e70abef6d7d2eb4cf4bf37