Aug 29 20:24:48.461 INFO checking benbrunton/les against master#ede55518431154bc761f7b2438cce9078c162700 for pr-53707 Aug 29 20:24:48.461 INFO running: cargo +ede55518431154bc761f7b2438cce9078c162700-alt check --frozen --all --all-targets Aug 29 20:24:48.461 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-0/pr-53707/master#ede55518431154bc761f7b2438cce9078c162700:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-53707/worker-0/master#ede55518431154bc761f7b2438cce9078c162700:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=500" "-e" "CMD=cargo +ede55518431154bc761f7b2438cce9078c162700-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-m" "2G" "crater"` Aug 29 20:24:48.679 INFO blam! 22c61db669b876a9fa96ea1bbc5317ec592e9c5fe7155f622f9916ff2a84aa0c Aug 29 20:24:48.681 INFO running `"docker" "start" "-a" "22c61db669b876a9fa96ea1bbc5317ec592e9c5fe7155f622f9916ff2a84aa0c"` Aug 29 20:24:49.541 INFO kablam! Checking toml v0.4.5 Aug 29 20:24:49.541 INFO kablam! Checking terminal_size v0.1.7 Aug 29 20:24:52.325 INFO kablam! Checking les v0.2.1 (file:///source) Aug 29 20:24:52.728 INFO kablam! warning: unused import: `std::io::stdout` Aug 29 20:24:52.728 INFO kablam! --> src/main.rs:8:5 Aug 29 20:24:52.728 INFO kablam! | Aug 29 20:24:52.728 INFO kablam! 8 | use std::io::stdout; Aug 29 20:24:52.728 INFO kablam! | ^^^^^^^^^^^^^^^ Aug 29 20:24:52.728 INFO kablam! | Aug 29 20:24:52.728 INFO kablam! warning: unused import: `std::io::stdout` Aug 29 20:24:52.728 INFO kablam! --> src/main.rs:8:5 Aug 29 20:24:52.728 INFO kablam! | Aug 29 20:24:52.728 INFO kablam! 8 | use std::io::stdout; Aug 29 20:24:52.728 INFO kablam! | ^^^^^^^^^^^^^^^ Aug 29 20:24:52.728 INFO kablam! = note: #[warn(unused_imports)] on by default Aug 29 20:24:52.729 INFO kablam! Aug 29 20:24:52.729 INFO kablam! | Aug 29 20:24:52.729 INFO kablam! = note: #[warn(unused_imports)] on by default Aug 29 20:24:52.729 INFO kablam! Aug 29 20:24:52.729 INFO kablam! warning: unused import: `std::io::Write` Aug 29 20:24:52.729 INFO kablam! --> src/les/mod.rs:2:5 Aug 29 20:24:52.729 INFO kablam! | Aug 29 20:24:52.729 INFO kablam! 2 | use std::io::Write; Aug 29 20:24:52.729 INFO kablam! | ^^^^^^^^^^^^^^ Aug 29 20:24:52.729 INFO kablam! Aug 29 20:24:52.729 INFO kablam! warning: unused import: `std::io::Write` Aug 29 20:24:52.729 INFO kablam! --> src/les/mod.rs:2:5 Aug 29 20:24:52.729 INFO kablam! | Aug 29 20:24:52.729 INFO kablam! 2 | use std::io::Write; Aug 29 20:24:52.729 INFO kablam! | ^^^^^^^^^^^^^^ Aug 29 20:24:52.729 INFO kablam! Aug 29 20:24:52.729 INFO kablam! warning: unused import: `decorate::Decorate` Aug 29 20:24:52.729 INFO kablam! --> src/les/mod.rs:4:5 Aug 29 20:24:52.729 INFO kablam! | Aug 29 20:24:52.729 INFO kablam! 4 | use decorate::Decorate; Aug 29 20:24:52.729 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Aug 29 20:24:52.729 INFO kablam! Aug 29 20:24:52.729 INFO kablam! warning: unused import: `decorate::Decorate` Aug 29 20:24:52.729 INFO kablam! --> src/les/mod.rs:4:5 Aug 29 20:24:52.729 INFO kablam! | Aug 29 20:24:52.729 INFO kablam! 4 | use decorate::Decorate; Aug 29 20:24:52.729 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Aug 29 20:24:52.729 INFO kablam! Aug 29 20:24:52.729 INFO kablam! warning: unused import: `paintitems::PaintItems` Aug 29 20:24:52.729 INFO kablam! --> src/les/mod.rs:5:5 Aug 29 20:24:52.730 INFO kablam! | Aug 29 20:24:52.730 INFO kablam! 5 | use paintitems::PaintItems; Aug 29 20:24:52.730 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Aug 29 20:24:52.730 INFO kablam! Aug 29 20:24:52.730 INFO kablam! warning: unused import: `paintitems::PaintItems` Aug 29 20:24:52.730 INFO kablam! --> src/les/mod.rs:5:5 Aug 29 20:24:52.730 INFO kablam! | Aug 29 20:24:52.730 INFO kablam! 5 | use paintitems::PaintItems; Aug 29 20:24:52.730 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Aug 29 20:24:52.730 INFO kablam! Aug 29 20:24:52.730 INFO kablam! warning: unused import: `std` Aug 29 20:24:52.730 INFO kablam! --> src/les/mod.rs:43:9 Aug 29 20:24:52.730 INFO kablam! | Aug 29 20:24:52.730 INFO kablam! 43 | use std; Aug 29 20:24:52.730 INFO kablam! | ^^^ Aug 29 20:24:52.730 INFO kablam! Aug 29 20:24:52.730 INFO kablam! warning: unused imports: `Stdout`, `stdout` Aug 29 20:24:52.730 INFO kablam! --> src/io/mod.rs:1:15 Aug 29 20:24:52.730 INFO kablam! | Aug 29 20:24:52.730 INFO kablam! 1 | use std::io::{Stdout,stdout}; Aug 29 20:24:52.730 INFO kablam! | ^^^^^^ ^^^^^^ Aug 29 20:24:52.730 INFO kablam! Aug 29 20:24:52.730 INFO kablam! warning: unused import: `min` Aug 29 20:24:52.730 INFO kablam! --> src/io/mod.rs:2:16 Aug 29 20:24:52.730 INFO kablam! | Aug 29 20:24:52.730 INFO kablam! 2 | use std::cmp::{min,max}; Aug 29 20:24:52.730 INFO kablam! | ^^^ Aug 29 20:24:52.730 INFO kablam! Aug 29 20:24:52.730 INFO kablam! warning: unused imports: `Stdout`, `stdout` Aug 29 20:24:52.730 INFO kablam! --> src/io/mod.rs:1:15 Aug 29 20:24:52.730 INFO kablam! | Aug 29 20:24:52.731 INFO kablam! 1 | use std::io::{Stdout,stdout}; Aug 29 20:24:52.731 INFO kablam! | ^^^^^^ ^^^^^^ Aug 29 20:24:52.731 INFO kablam! Aug 29 20:24:52.731 INFO kablam! warning: unused import: `min` Aug 29 20:24:52.731 INFO kablam! --> src/io/mod.rs:2:16 Aug 29 20:24:52.731 INFO kablam! | Aug 29 20:24:52.731 INFO kablam! 2 | use std::cmp::{min,max}; Aug 29 20:24:52.731 INFO kablam! | ^^^ Aug 29 20:24:52.731 INFO kablam! Aug 29 20:24:52.731 INFO kablam! warning: unused import: `std::str::FromStr` Aug 29 20:24:52.731 INFO kablam! --> src/decorate/mod.rs:8:5 Aug 29 20:24:52.731 INFO kablam! | Aug 29 20:24:52.731 INFO kablam! 8 | use std::str::FromStr; Aug 29 20:24:52.731 INFO kablam! | ^^^^^^^^^^^^^^^^^ Aug 29 20:24:52.731 INFO kablam! Aug 29 20:24:52.731 INFO kablam! warning: unused import: `std::str::FromStr` Aug 29 20:24:52.731 INFO kablam! --> src/decorate/mod.rs:8:5 Aug 29 20:24:52.731 INFO kablam! | Aug 29 20:24:52.731 INFO kablam! 8 | use std::str::FromStr; Aug 29 20:24:52.731 INFO kablam! | ^^^^^^^^^^^^^^^^^ Aug 29 20:24:52.731 INFO kablam! Aug 29 20:24:53.105 INFO kablam! warning: unused variable: `inodes_count` Aug 29 20:24:53.105 INFO kablam! --> src/io/mod.rs:27:13 Aug 29 20:24:53.105 INFO kablam! | Aug 29 20:24:53.105 INFO kablam! 27 | let inodes_count = inodes.len(); Aug 29 20:24:53.105 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Aug 29 20:24:53.105 INFO kablam! | Aug 29 20:24:53.105 INFO kablam! = note: #[warn(unused_variables)] on by default Aug 29 20:24:53.105 INFO kablam! Aug 29 20:24:53.105 INFO kablam! warning: value assigned to `prev_item_length` is never read Aug 29 20:24:53.105 INFO kablam! --> src/io/mod.rs:73:21 Aug 29 20:24:53.105 INFO kablam! | Aug 29 20:24:53.105 INFO kablam! 73 | let mut prev_item_length = 0; Aug 29 20:24:53.105 INFO kablam! | ^^^^^^^^^^^^^^^^ Aug 29 20:24:53.105 INFO kablam! | Aug 29 20:24:53.106 INFO kablam! = note: #[warn(unused_assignments)] on by default Aug 29 20:24:53.106 INFO kablam! Aug 29 20:24:53.116 INFO kablam! warning: unused variable: `decorator` Aug 29 20:24:53.116 INFO kablam! --> src/les/mod.rs:53:13 Aug 29 20:24:53.116 INFO kablam! | Aug 29 20:24:53.116 INFO kablam! 53 | let decorator = decorate::Decorate::new(None); Aug 29 20:24:53.116 INFO kablam! | ^^^^^^^^^ help: consider using `_decorator` instead Aug 29 20:24:53.116 INFO kablam! | Aug 29 20:24:53.117 INFO kablam! = note: #[warn(unused_variables)] on by default Aug 29 20:24:53.117 INFO kablam! Aug 29 20:24:53.117 INFO kablam! warning: unused variable: `inodes_count` Aug 29 20:24:53.117 INFO kablam! --> src/io/mod.rs:27:13 Aug 29 20:24:53.117 INFO kablam! | Aug 29 20:24:53.117 INFO kablam! 27 | let inodes_count = inodes.len(); Aug 29 20:24:53.117 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Aug 29 20:24:53.117 INFO kablam! Aug 29 20:24:53.117 INFO kablam! warning: value assigned to `prev_item_length` is never read Aug 29 20:24:53.117 INFO kablam! --> src/io/mod.rs:73:21 Aug 29 20:24:53.117 INFO kablam! | Aug 29 20:24:53.117 INFO kablam! 73 | let mut prev_item_length = 0; Aug 29 20:24:53.117 INFO kablam! | ^^^^^^^^^^^^^^^^ Aug 29 20:24:53.117 INFO kablam! | Aug 29 20:24:53.117 INFO kablam! = note: #[warn(unused_assignments)] on by default Aug 29 20:24:53.118 INFO kablam! Aug 29 20:24:53.158 INFO kablam! warning: variable does not need to be mutable Aug 29 20:24:53.158 INFO kablam! --> src/io/mod.rs:120:13 Aug 29 20:24:53.158 INFO kablam! | Aug 29 20:24:53.158 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Aug 29 20:24:53.158 INFO kablam! | ----^^^^^^^^^^^^^ Aug 29 20:24:53.158 INFO kablam! | | Aug 29 20:24:53.158 INFO kablam! | help: remove this `mut` Aug 29 20:24:53.158 INFO kablam! | Aug 29 20:24:53.158 INFO kablam! = note: #[warn(unused_mut)] on by default Aug 29 20:24:53.158 INFO kablam! Aug 29 20:24:53.180 INFO kablam! warning: variable does not need to be mutable Aug 29 20:24:53.181 INFO kablam! --> src/io/mod.rs:120:13 Aug 29 20:24:53.181 INFO kablam! | Aug 29 20:24:53.181 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Aug 29 20:24:53.181 INFO kablam! | ----^^^^^^^^^^^^^ Aug 29 20:24:53.181 INFO kablam! | | Aug 29 20:24:53.181 INFO kablam! | help: remove this `mut` Aug 29 20:24:53.181 INFO kablam! | Aug 29 20:24:53.181 INFO kablam! = note: #[warn(unused_mut)] on by default Aug 29 20:24:53.181 INFO kablam! Aug 29 20:24:53.195 INFO kablam! warning: field is never used: `path` Aug 29 20:24:53.195 INFO kablam! --> src/fs/mod.rs:92:5 Aug 29 20:24:53.195 INFO kablam! | Aug 29 20:24:53.195 INFO kablam! 92 | path: String Aug 29 20:24:53.195 INFO kablam! | ^^^^^^^^^^^^ Aug 29 20:24:53.196 INFO kablam! | Aug 29 20:24:53.196 INFO kablam! = note: #[warn(dead_code)] on by default Aug 29 20:24:53.197 INFO kablam! Aug 29 20:24:53.197 INFO kablam! warning: method is never used: `get_path` Aug 29 20:24:53.197 INFO kablam! --> src/fs/mod.rs:117:5 Aug 29 20:24:53.197 INFO kablam! | Aug 29 20:24:53.197 INFO kablam! 117 | pub fn get_path(&self) -> String { Aug 29 20:24:53.197 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Aug 29 20:24:53.197 INFO kablam! Aug 29 20:24:53.207 INFO kablam! warning: comparison is useless due to type limits Aug 29 20:24:53.207 INFO kablam! --> src/paintitems/mod.rs:25:41 Aug 29 20:24:53.207 INFO kablam! | Aug 29 20:24:53.207 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Aug 29 20:24:53.207 INFO kablam! | ^^^^^^^^^ Aug 29 20:24:53.207 INFO kablam! | Aug 29 20:24:53.208 INFO kablam! = note: #[warn(unused_comparisons)] on by default Aug 29 20:24:53.208 INFO kablam! Aug 29 20:24:53.232 INFO kablam! warning: field is never used: `path` Aug 29 20:24:53.232 INFO kablam! --> src/fs/mod.rs:92:5 Aug 29 20:24:53.232 INFO kablam! | Aug 29 20:24:53.232 INFO kablam! 92 | path: String Aug 29 20:24:53.232 INFO kablam! | ^^^^^^^^^^^^ Aug 29 20:24:53.232 INFO kablam! | Aug 29 20:24:53.232 INFO kablam! = note: #[warn(dead_code)] on by default Aug 29 20:24:53.232 INFO kablam! Aug 29 20:24:53.232 INFO kablam! warning: method is never used: `get_path` Aug 29 20:24:53.233 INFO kablam! --> src/fs/mod.rs:117:5 Aug 29 20:24:53.233 INFO kablam! | Aug 29 20:24:53.233 INFO kablam! 117 | pub fn get_path(&self) -> String { Aug 29 20:24:53.233 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Aug 29 20:24:53.233 INFO kablam! Aug 29 20:24:53.236 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Aug 29 20:24:53.236 INFO kablam! --> src/style/mod.rs:67:13 Aug 29 20:24:53.236 INFO kablam! | Aug 29 20:24:53.236 INFO kablam! 67 | let licenseItem = PaintItem{ Aug 29 20:24:53.236 INFO kablam! | ^^^^^^^^^^^ Aug 29 20:24:53.237 INFO kablam! | Aug 29 20:24:53.237 INFO kablam! = note: #[warn(non_snake_case)] on by default Aug 29 20:24:53.237 INFO kablam! Aug 29 20:24:53.237 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Aug 29 20:24:53.237 INFO kablam! --> src/style/mod.rs:83:13 Aug 29 20:24:53.237 INFO kablam! | Aug 29 20:24:53.237 INFO kablam! 83 | let licenseItem = PaintItem{ Aug 29 20:24:53.237 INFO kablam! | ^^^^^^^^^^^ Aug 29 20:24:53.237 INFO kablam! Aug 29 20:24:53.241 INFO kablam! warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item` Aug 29 20:24:53.241 INFO kablam! --> src/decorate/mod.rs:201:5 Aug 29 20:24:53.241 INFO kablam! | Aug 29 20:24:53.242 INFO kablam! 201 | / fn it_returns_a_Paint_Item() { Aug 29 20:24:53.242 INFO kablam! 202 | | Aug 29 20:24:53.242 INFO kablam! 203 | | let file = File::new( Aug 29 20:24:53.242 INFO kablam! 204 | | String::from("filename"), Aug 29 20:24:53.242 INFO kablam! ... | Aug 29 20:24:53.242 INFO kablam! 222 | | assert_eq!(paint_item, expected_result); Aug 29 20:24:53.242 INFO kablam! 223 | | } Aug 29 20:24:53.242 INFO kablam! | |_____^ Aug 29 20:24:53.242 INFO kablam! Aug 29 20:24:53.242 INFO kablam! warning: comparison is useless due to type limits Aug 29 20:24:53.243 INFO kablam! --> src/paintitems/mod.rs:25:41 Aug 29 20:24:53.243 INFO kablam! | Aug 29 20:24:53.243 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Aug 29 20:24:53.243 INFO kablam! | ^^^^^^^^^ Aug 29 20:24:53.243 INFO kablam! | Aug 29 20:24:53.243 INFO kablam! = note: #[warn(unused_comparisons)] on by default Aug 29 20:24:53.243 INFO kablam! Aug 29 20:24:53.272 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 3.79s Aug 29 20:24:53.276 INFO kablam! su: No module specific data is present Aug 29 20:24:53.695 INFO running `"docker" "rm" "-f" "22c61db669b876a9fa96ea1bbc5317ec592e9c5fe7155f622f9916ff2a84aa0c"` Aug 29 20:24:53.832 INFO blam! 22c61db669b876a9fa96ea1bbc5317ec592e9c5fe7155f622f9916ff2a84aa0c