Aug 31 06:15:55.306 INFO checking benbrunton/les against master#d0d81b7fc1421859ba0218e8a437af29ae3b0967 for pr-53578 Aug 31 06:15:55.306 INFO running: cargo +d0d81b7fc1421859ba0218e8a437af29ae3b0967-alt check --frozen --all --all-targets Aug 31 06:15:55.306 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-2/pr-53578/master#d0d81b7fc1421859ba0218e8a437af29ae3b0967:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-53578/worker-2/master#d0d81b7fc1421859ba0218e8a437af29ae3b0967:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=500" "-e" "CMD=cargo +d0d81b7fc1421859ba0218e8a437af29ae3b0967-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-m" "2G" "crater"` Aug 31 06:15:55.461 INFO blam! dce24882e301051ae5550dc9f8bafc8f640ad149722df596a1ce09e574a18f87 Aug 31 06:15:55.464 INFO running `"docker" "start" "-a" "dce24882e301051ae5550dc9f8bafc8f640ad149722df596a1ce09e574a18f87"` Aug 31 06:15:56.075 INFO kablam! Checking terminal_size v0.1.7 Aug 31 06:15:56.444 INFO kablam! Checking les v0.2.1 (file:///source) Aug 31 06:15:56.772 INFO kablam! warning: unused import: `std::io::stdout` Aug 31 06:15:56.772 INFO kablam! --> src/main.rs:8:5 Aug 31 06:15:56.772 INFO kablam! | Aug 31 06:15:56.772 INFO kablam! 8 | use std::io::stdout; Aug 31 06:15:56.772 INFO kablam! | ^^^^^^^^^^^^^^^ Aug 31 06:15:56.772 INFO kablam! | Aug 31 06:15:56.772 INFO kablam! = note: #[warn(unused_imports)] on by default Aug 31 06:15:56.772 INFO kablam! Aug 31 06:15:56.772 INFO kablam! warning: unused import: `std::io::Write` Aug 31 06:15:56.772 INFO kablam! --> src/les/mod.rs:2:5 Aug 31 06:15:56.772 INFO kablam! | Aug 31 06:15:56.772 INFO kablam! 2 | use std::io::Write; Aug 31 06:15:56.772 INFO kablam! | ^^^^^^^^^^^^^^ Aug 31 06:15:56.772 INFO kablam! Aug 31 06:15:56.772 INFO kablam! warning: unused import: `decorate::Decorate` Aug 31 06:15:56.772 INFO kablam! --> src/les/mod.rs:4:5 Aug 31 06:15:56.772 INFO kablam! | Aug 31 06:15:56.772 INFO kablam! 4 | use decorate::Decorate; Aug 31 06:15:56.773 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Aug 31 06:15:56.773 INFO kablam! Aug 31 06:15:56.773 INFO kablam! warning: unused import: `paintitems::PaintItems` Aug 31 06:15:56.773 INFO kablam! --> src/les/mod.rs:5:5 Aug 31 06:15:56.773 INFO kablam! | Aug 31 06:15:56.773 INFO kablam! 5 | use paintitems::PaintItems; Aug 31 06:15:56.773 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Aug 31 06:15:56.773 INFO kablam! Aug 31 06:15:56.773 INFO kablam! warning: unused imports: `Stdout`, `stdout` Aug 31 06:15:56.773 INFO kablam! --> src/io/mod.rs:1:15 Aug 31 06:15:56.773 INFO kablam! | Aug 31 06:15:56.773 INFO kablam! 1 | use std::io::{Stdout,stdout}; Aug 31 06:15:56.773 INFO kablam! | ^^^^^^ ^^^^^^ Aug 31 06:15:56.773 INFO kablam! Aug 31 06:15:56.773 INFO kablam! warning: unused import: `min` Aug 31 06:15:56.773 INFO kablam! --> src/io/mod.rs:2:16 Aug 31 06:15:56.773 INFO kablam! | Aug 31 06:15:56.773 INFO kablam! 2 | use std::cmp::{min,max}; Aug 31 06:15:56.773 INFO kablam! | ^^^ Aug 31 06:15:56.773 INFO kablam! Aug 31 06:15:56.773 INFO kablam! warning: unused import: `std::str::FromStr` Aug 31 06:15:56.773 INFO kablam! --> src/decorate/mod.rs:8:5 Aug 31 06:15:56.773 INFO kablam! | Aug 31 06:15:56.774 INFO kablam! 8 | use std::str::FromStr; Aug 31 06:15:56.774 INFO kablam! | ^^^^^^^^^^^^^^^^^ Aug 31 06:15:56.774 INFO kablam! Aug 31 06:15:56.808 INFO kablam! warning: unused import: `std::io::stdout` Aug 31 06:15:56.808 INFO kablam! --> src/main.rs:8:5 Aug 31 06:15:56.808 INFO kablam! | Aug 31 06:15:56.808 INFO kablam! 8 | use std::io::stdout; Aug 31 06:15:56.808 INFO kablam! | ^^^^^^^^^^^^^^^ Aug 31 06:15:56.808 INFO kablam! | Aug 31 06:15:56.808 INFO kablam! = note: #[warn(unused_imports)] on by default Aug 31 06:15:56.808 INFO kablam! Aug 31 06:15:56.808 INFO kablam! warning: unused import: `std::io::Write` Aug 31 06:15:56.809 INFO kablam! --> src/les/mod.rs:2:5 Aug 31 06:15:56.809 INFO kablam! | Aug 31 06:15:56.809 INFO kablam! 2 | use std::io::Write; Aug 31 06:15:56.809 INFO kablam! | ^^^^^^^^^^^^^^ Aug 31 06:15:56.809 INFO kablam! Aug 31 06:15:56.809 INFO kablam! warning: unused import: `decorate::Decorate` Aug 31 06:15:56.809 INFO kablam! --> src/les/mod.rs:4:5 Aug 31 06:15:56.809 INFO kablam! | Aug 31 06:15:56.809 INFO kablam! 4 | use decorate::Decorate; Aug 31 06:15:56.809 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Aug 31 06:15:56.809 INFO kablam! Aug 31 06:15:56.809 INFO kablam! warning: unused import: `paintitems::PaintItems` Aug 31 06:15:56.809 INFO kablam! --> src/les/mod.rs:5:5 Aug 31 06:15:56.809 INFO kablam! | Aug 31 06:15:56.809 INFO kablam! 5 | use paintitems::PaintItems; Aug 31 06:15:56.809 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Aug 31 06:15:56.809 INFO kablam! Aug 31 06:15:56.809 INFO kablam! warning: unused import: `std` Aug 31 06:15:56.809 INFO kablam! --> src/les/mod.rs:43:9 Aug 31 06:15:56.809 INFO kablam! | Aug 31 06:15:56.809 INFO kablam! 43 | use std; Aug 31 06:15:56.809 INFO kablam! | ^^^ Aug 31 06:15:56.809 INFO kablam! Aug 31 06:15:56.810 INFO kablam! warning: unused imports: `Stdout`, `stdout` Aug 31 06:15:56.810 INFO kablam! --> src/io/mod.rs:1:15 Aug 31 06:15:56.810 INFO kablam! | Aug 31 06:15:56.810 INFO kablam! 1 | use std::io::{Stdout,stdout}; Aug 31 06:15:56.810 INFO kablam! | ^^^^^^ ^^^^^^ Aug 31 06:15:56.810 INFO kablam! Aug 31 06:15:56.810 INFO kablam! warning: unused import: `min` Aug 31 06:15:56.810 INFO kablam! --> src/io/mod.rs:2:16 Aug 31 06:15:56.810 INFO kablam! | Aug 31 06:15:56.810 INFO kablam! 2 | use std::cmp::{min,max}; Aug 31 06:15:56.810 INFO kablam! | ^^^ Aug 31 06:15:56.810 INFO kablam! Aug 31 06:15:56.810 INFO kablam! warning: unused import: `std::str::FromStr` Aug 31 06:15:56.811 INFO kablam! --> src/decorate/mod.rs:8:5 Aug 31 06:15:56.811 INFO kablam! | Aug 31 06:15:56.811 INFO kablam! 8 | use std::str::FromStr; Aug 31 06:15:56.811 INFO kablam! | ^^^^^^^^^^^^^^^^^ Aug 31 06:15:56.811 INFO kablam! Aug 31 06:15:57.117 INFO kablam! warning: unused variable: `inodes_count` Aug 31 06:15:57.117 INFO kablam! --> src/io/mod.rs:27:13 Aug 31 06:15:57.117 INFO kablam! | Aug 31 06:15:57.117 INFO kablam! 27 | let inodes_count = inodes.len(); Aug 31 06:15:57.117 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Aug 31 06:15:57.117 INFO kablam! | Aug 31 06:15:57.117 INFO kablam! = note: #[warn(unused_variables)] on by default Aug 31 06:15:57.117 INFO kablam! Aug 31 06:15:57.117 INFO kablam! warning: value assigned to `prev_item_length` is never read Aug 31 06:15:57.117 INFO kablam! --> src/io/mod.rs:73:21 Aug 31 06:15:57.117 INFO kablam! | Aug 31 06:15:57.117 INFO kablam! 73 | let mut prev_item_length = 0; Aug 31 06:15:57.117 INFO kablam! | ^^^^^^^^^^^^^^^^ Aug 31 06:15:57.118 INFO kablam! | Aug 31 06:15:57.118 INFO kablam! = note: #[warn(unused_assignments)] on by default Aug 31 06:15:57.118 INFO kablam! Aug 31 06:15:57.170 INFO kablam! warning: variable does not need to be mutable Aug 31 06:15:57.170 INFO kablam! --> src/io/mod.rs:120:13 Aug 31 06:15:57.170 INFO kablam! | Aug 31 06:15:57.170 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Aug 31 06:15:57.170 INFO kablam! | ----^^^^^^^^^^^^^ Aug 31 06:15:57.170 INFO kablam! | | Aug 31 06:15:57.171 INFO kablam! | help: remove this `mut` Aug 31 06:15:57.171 INFO kablam! | Aug 31 06:15:57.171 INFO kablam! = note: #[warn(unused_mut)] on by default Aug 31 06:15:57.171 INFO kablam! Aug 31 06:15:57.204 INFO kablam! warning: field is never used: `path` Aug 31 06:15:57.204 INFO kablam! --> src/fs/mod.rs:92:5 Aug 31 06:15:57.204 INFO kablam! | Aug 31 06:15:57.204 INFO kablam! 92 | path: String Aug 31 06:15:57.204 INFO kablam! | ^^^^^^^^^^^^ Aug 31 06:15:57.204 INFO kablam! | Aug 31 06:15:57.204 INFO kablam! = note: #[warn(dead_code)] on by default Aug 31 06:15:57.204 INFO kablam! Aug 31 06:15:57.204 INFO kablam! warning: method is never used: `get_path` Aug 31 06:15:57.205 INFO kablam! --> src/fs/mod.rs:117:5 Aug 31 06:15:57.205 INFO kablam! | Aug 31 06:15:57.205 INFO kablam! 117 | pub fn get_path(&self) -> String { Aug 31 06:15:57.205 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Aug 31 06:15:57.205 INFO kablam! Aug 31 06:15:57.206 INFO kablam! warning: unused variable: `decorator` Aug 31 06:15:57.206 INFO kablam! --> src/les/mod.rs:53:13 Aug 31 06:15:57.206 INFO kablam! | Aug 31 06:15:57.206 INFO kablam! 53 | let decorator = decorate::Decorate::new(None); Aug 31 06:15:57.206 INFO kablam! | ^^^^^^^^^ help: consider using `_decorator` instead Aug 31 06:15:57.206 INFO kablam! | Aug 31 06:15:57.206 INFO kablam! = note: #[warn(unused_variables)] on by default Aug 31 06:15:57.206 INFO kablam! Aug 31 06:15:57.206 INFO kablam! warning: unused variable: `inodes_count` Aug 31 06:15:57.206 INFO kablam! --> src/io/mod.rs:27:13 Aug 31 06:15:57.206 INFO kablam! | Aug 31 06:15:57.206 INFO kablam! 27 | let inodes_count = inodes.len(); Aug 31 06:15:57.206 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Aug 31 06:15:57.207 INFO kablam! Aug 31 06:15:57.207 INFO kablam! warning: value assigned to `prev_item_length` is never read Aug 31 06:15:57.207 INFO kablam! --> src/io/mod.rs:73:21 Aug 31 06:15:57.207 INFO kablam! | Aug 31 06:15:57.207 INFO kablam! 73 | let mut prev_item_length = 0; Aug 31 06:15:57.207 INFO kablam! | ^^^^^^^^^^^^^^^^ Aug 31 06:15:57.207 INFO kablam! | Aug 31 06:15:57.207 INFO kablam! = note: #[warn(unused_assignments)] on by default Aug 31 06:15:57.207 INFO kablam! Aug 31 06:15:57.212 INFO kablam! warning: comparison is useless due to type limits Aug 31 06:15:57.212 INFO kablam! --> src/paintitems/mod.rs:25:41 Aug 31 06:15:57.212 INFO kablam! | Aug 31 06:15:57.212 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Aug 31 06:15:57.212 INFO kablam! | ^^^^^^^^^ Aug 31 06:15:57.212 INFO kablam! | Aug 31 06:15:57.212 INFO kablam! = note: #[warn(unused_comparisons)] on by default Aug 31 06:15:57.212 INFO kablam! Aug 31 06:15:57.254 INFO kablam! warning: variable does not need to be mutable Aug 31 06:15:57.254 INFO kablam! --> src/io/mod.rs:120:13 Aug 31 06:15:57.254 INFO kablam! | Aug 31 06:15:57.254 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Aug 31 06:15:57.254 INFO kablam! | ----^^^^^^^^^^^^^ Aug 31 06:15:57.254 INFO kablam! | | Aug 31 06:15:57.254 INFO kablam! | help: remove this `mut` Aug 31 06:15:57.254 INFO kablam! | Aug 31 06:15:57.255 INFO kablam! = note: #[warn(unused_mut)] on by default Aug 31 06:15:57.255 INFO kablam! Aug 31 06:15:57.289 INFO kablam! warning: field is never used: `path` Aug 31 06:15:57.289 INFO kablam! --> src/fs/mod.rs:92:5 Aug 31 06:15:57.289 INFO kablam! | Aug 31 06:15:57.289 INFO kablam! 92 | path: String Aug 31 06:15:57.289 INFO kablam! | ^^^^^^^^^^^^ Aug 31 06:15:57.289 INFO kablam! | Aug 31 06:15:57.289 INFO kablam! = note: #[warn(dead_code)] on by default Aug 31 06:15:57.290 INFO kablam! Aug 31 06:15:57.290 INFO kablam! warning: method is never used: `get_path` Aug 31 06:15:57.290 INFO kablam! --> src/fs/mod.rs:117:5 Aug 31 06:15:57.290 INFO kablam! | Aug 31 06:15:57.290 INFO kablam! 117 | pub fn get_path(&self) -> String { Aug 31 06:15:57.290 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Aug 31 06:15:57.290 INFO kablam! Aug 31 06:15:57.293 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Aug 31 06:15:57.293 INFO kablam! --> src/style/mod.rs:67:13 Aug 31 06:15:57.293 INFO kablam! | Aug 31 06:15:57.293 INFO kablam! 67 | let licenseItem = PaintItem{ Aug 31 06:15:57.293 INFO kablam! | ^^^^^^^^^^^ Aug 31 06:15:57.293 INFO kablam! | Aug 31 06:15:57.293 INFO kablam! = note: #[warn(non_snake_case)] on by default Aug 31 06:15:57.293 INFO kablam! Aug 31 06:15:57.293 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Aug 31 06:15:57.293 INFO kablam! --> src/style/mod.rs:83:13 Aug 31 06:15:57.294 INFO kablam! | Aug 31 06:15:57.294 INFO kablam! 83 | let licenseItem = PaintItem{ Aug 31 06:15:57.294 INFO kablam! | ^^^^^^^^^^^ Aug 31 06:15:57.294 INFO kablam! Aug 31 06:15:57.297 INFO kablam! warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item` Aug 31 06:15:57.297 INFO kablam! --> src/decorate/mod.rs:201:5 Aug 31 06:15:57.297 INFO kablam! | Aug 31 06:15:57.297 INFO kablam! 201 | / fn it_returns_a_Paint_Item() { Aug 31 06:15:57.297 INFO kablam! 202 | | Aug 31 06:15:57.298 INFO kablam! 203 | | let file = File::new( Aug 31 06:15:57.298 INFO kablam! 204 | | String::from("filename"), Aug 31 06:15:57.298 INFO kablam! ... | Aug 31 06:15:57.298 INFO kablam! 222 | | assert_eq!(paint_item, expected_result); Aug 31 06:15:57.298 INFO kablam! 223 | | } Aug 31 06:15:57.298 INFO kablam! | |_____^ Aug 31 06:15:57.298 INFO kablam! Aug 31 06:15:57.298 INFO kablam! warning: comparison is useless due to type limits Aug 31 06:15:57.298 INFO kablam! --> src/paintitems/mod.rs:25:41 Aug 31 06:15:57.298 INFO kablam! | Aug 31 06:15:57.299 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Aug 31 06:15:57.299 INFO kablam! | ^^^^^^^^^ Aug 31 06:15:57.299 INFO kablam! | Aug 31 06:15:57.299 INFO kablam! = note: #[warn(unused_comparisons)] on by default Aug 31 06:15:57.299 INFO kablam! Aug 31 06:15:57.323 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.29s Aug 31 06:15:57.328 INFO kablam! su: No module specific data is present Aug 31 06:15:57.714 INFO running `"docker" "rm" "-f" "dce24882e301051ae5550dc9f8bafc8f640ad149722df596a1ce09e574a18f87"` Aug 31 06:15:57.855 INFO blam! dce24882e301051ae5550dc9f8bafc8f640ad149722df596a1ce09e574a18f87