Aug 17 03:38:02.765 INFO checking benbrunton/les against try#a5d98b025f62ace80fe9d2a15781f900fc42515e for pr-53426 Aug 17 03:38:02.765 INFO running: cargo +a5d98b025f62ace80fe9d2a15781f900fc42515e-alt check --frozen --all --all-targets Aug 17 03:38:02.765 INFO creating container for: cargo +a5d98b025f62ace80fe9d2a15781f900fc42515e-alt check --frozen --all --all-targets Aug 17 03:38:02.765 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-4/pr-53426/try#a5d98b025f62ace80fe9d2a15781f900fc42515e:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-53426/worker-4/try#a5d98b025f62ace80fe9d2a15781f900fc42515e:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=500" "-e" "CMD=cargo +a5d98b025f62ace80fe9d2a15781f900fc42515e-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=warn" "crater"` Aug 17 03:38:03.047 INFO blam! 5c6d18df21680f4ec53f693cccc1a30731bb71ec2849fa96135252ec89de207d Aug 17 03:38:03.049 INFO running `"docker" "start" "-a" "5c6d18df21680f4ec53f693cccc1a30731bb71ec2849fa96135252ec89de207d"` Aug 17 03:38:04.862 INFO kablam! Checking terminal_size v0.1.7 Aug 17 03:38:05.441 INFO kablam! Checking les v0.2.1 (file:///source) Aug 17 03:38:06.092 INFO kablam! warning: unused import: `std::io::stdout` Aug 17 03:38:06.092 INFO kablam! --> src/main.rs:8:5 Aug 17 03:38:06.092 INFO kablam! | Aug 17 03:38:06.092 INFO kablam! 8 | use std::io::stdout; Aug 17 03:38:06.092 INFO kablam! | ^^^^^^^^^^^^^^^ Aug 17 03:38:06.093 INFO kablam! | Aug 17 03:38:06.093 INFO kablam! = note: #[warn(unused_imports)] on by default Aug 17 03:38:06.094 INFO kablam! Aug 17 03:38:06.094 INFO kablam! warning: unused import: `std::io::Write` Aug 17 03:38:06.094 INFO kablam! --> src/les/mod.rs:2:5 Aug 17 03:38:06.094 INFO kablam! | Aug 17 03:38:06.094 INFO kablam! 2 | use std::io::Write; Aug 17 03:38:06.095 INFO kablam! | ^^^^^^^^^^^^^^ Aug 17 03:38:06.095 INFO kablam! Aug 17 03:38:06.096 INFO kablam! warning: unused import: `decorate::Decorate` Aug 17 03:38:06.096 INFO kablam! --> src/les/mod.rs:4:5 Aug 17 03:38:06.096 INFO kablam! | Aug 17 03:38:06.096 INFO kablam! 4 | use decorate::Decorate; Aug 17 03:38:06.096 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Aug 17 03:38:06.096 INFO kablam! Aug 17 03:38:06.097 INFO kablam! warning: unused import: `paintitems::PaintItems` Aug 17 03:38:06.097 INFO kablam! --> src/les/mod.rs:5:5 Aug 17 03:38:06.097 INFO kablam! | Aug 17 03:38:06.097 INFO kablam! 5 | use paintitems::PaintItems; Aug 17 03:38:06.097 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Aug 17 03:38:06.097 INFO kablam! Aug 17 03:38:06.098 INFO kablam! warning: unused import: `std` Aug 17 03:38:06.098 INFO kablam! --> src/les/mod.rs:43:9 Aug 17 03:38:06.098 INFO kablam! | Aug 17 03:38:06.098 INFO kablam! 43 | use std; Aug 17 03:38:06.098 INFO kablam! | ^^^ Aug 17 03:38:06.099 INFO kablam! Aug 17 03:38:06.100 INFO kablam! warning: unused imports: `Stdout`, `stdout` Aug 17 03:38:06.100 INFO kablam! --> src/io/mod.rs:1:15 Aug 17 03:38:06.100 INFO kablam! | Aug 17 03:38:06.100 INFO kablam! 1 | use std::io::{Stdout,stdout}; Aug 17 03:38:06.100 INFO kablam! | ^^^^^^ ^^^^^^ Aug 17 03:38:06.101 INFO kablam! Aug 17 03:38:06.101 INFO kablam! warning: unused import: `min` Aug 17 03:38:06.101 INFO kablam! --> src/io/mod.rs:2:16 Aug 17 03:38:06.101 INFO kablam! | Aug 17 03:38:06.101 INFO kablam! 2 | use std::cmp::{min,max}; Aug 17 03:38:06.101 INFO kablam! | ^^^ Aug 17 03:38:06.102 INFO kablam! Aug 17 03:38:06.103 INFO kablam! warning: unused import: `std::str::FromStr` Aug 17 03:38:06.103 INFO kablam! --> src/decorate/mod.rs:8:5 Aug 17 03:38:06.103 INFO kablam! | Aug 17 03:38:06.103 INFO kablam! 8 | use std::str::FromStr; Aug 17 03:38:06.103 INFO kablam! | ^^^^^^^^^^^^^^^^^ Aug 17 03:38:06.104 INFO kablam! Aug 17 03:38:06.167 INFO kablam! warning: unused import: `std::io::stdout` Aug 17 03:38:06.167 INFO kablam! --> src/main.rs:8:5 Aug 17 03:38:06.167 INFO kablam! | Aug 17 03:38:06.167 INFO kablam! 8 | use std::io::stdout; Aug 17 03:38:06.167 INFO kablam! | ^^^^^^^^^^^^^^^ Aug 17 03:38:06.167 INFO kablam! | Aug 17 03:38:06.167 INFO kablam! = note: #[warn(unused_imports)] on by default Aug 17 03:38:06.168 INFO kablam! Aug 17 03:38:06.168 INFO kablam! warning: unused import: `std::io::Write` Aug 17 03:38:06.169 INFO kablam! --> src/les/mod.rs:2:5 Aug 17 03:38:06.169 INFO kablam! | Aug 17 03:38:06.169 INFO kablam! 2 | use std::io::Write; Aug 17 03:38:06.169 INFO kablam! | ^^^^^^^^^^^^^^ Aug 17 03:38:06.169 INFO kablam! Aug 17 03:38:06.169 INFO kablam! warning: unused import: `decorate::Decorate` Aug 17 03:38:06.169 INFO kablam! --> src/les/mod.rs:4:5 Aug 17 03:38:06.169 INFO kablam! | Aug 17 03:38:06.169 INFO kablam! 4 | use decorate::Decorate; Aug 17 03:38:06.169 INFO kablam! | ^^^^^^^^^^^^^^^^^^ Aug 17 03:38:06.169 INFO kablam! Aug 17 03:38:06.169 INFO kablam! warning: unused import: `paintitems::PaintItems` Aug 17 03:38:06.169 INFO kablam! --> src/les/mod.rs:5:5 Aug 17 03:38:06.169 INFO kablam! | Aug 17 03:38:06.169 INFO kablam! 5 | use paintitems::PaintItems; Aug 17 03:38:06.169 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Aug 17 03:38:06.169 INFO kablam! Aug 17 03:38:06.169 INFO kablam! warning: unused imports: `Stdout`, `stdout` Aug 17 03:38:06.169 INFO kablam! --> src/io/mod.rs:1:15 Aug 17 03:38:06.169 INFO kablam! | Aug 17 03:38:06.169 INFO kablam! 1 | use std::io::{Stdout,stdout}; Aug 17 03:38:06.169 INFO kablam! | ^^^^^^ ^^^^^^ Aug 17 03:38:06.169 INFO kablam! Aug 17 03:38:06.169 INFO kablam! warning: unused import: `min` Aug 17 03:38:06.169 INFO kablam! --> src/io/mod.rs:2:16 Aug 17 03:38:06.170 INFO kablam! | Aug 17 03:38:06.170 INFO kablam! 2 | use std::cmp::{min,max}; Aug 17 03:38:06.170 INFO kablam! | ^^^ Aug 17 03:38:06.170 INFO kablam! Aug 17 03:38:06.171 INFO kablam! warning: unused import: `std::str::FromStr` Aug 17 03:38:06.171 INFO kablam! --> src/decorate/mod.rs:8:5 Aug 17 03:38:06.171 INFO kablam! | Aug 17 03:38:06.171 INFO kablam! 8 | use std::str::FromStr; Aug 17 03:38:06.171 INFO kablam! | ^^^^^^^^^^^^^^^^^ Aug 17 03:38:06.171 INFO kablam! Aug 17 03:38:06.989 INFO kablam! warning: unused variable: `decorator` Aug 17 03:38:06.989 INFO kablam! --> src/les/mod.rs:53:13 Aug 17 03:38:06.989 INFO kablam! | Aug 17 03:38:06.989 INFO kablam! 53 | let decorator = decorate::Decorate::new(None); Aug 17 03:38:06.989 INFO kablam! | ^^^^^^^^^ help: consider using `_decorator` instead Aug 17 03:38:06.989 INFO kablam! | Aug 17 03:38:06.989 INFO kablam! = note: #[warn(unused_variables)] on by default Aug 17 03:38:06.989 INFO kablam! Aug 17 03:38:06.990 INFO kablam! warning: unused variable: `inodes_count` Aug 17 03:38:06.990 INFO kablam! --> src/io/mod.rs:27:13 Aug 17 03:38:06.990 INFO kablam! | Aug 17 03:38:06.990 INFO kablam! 27 | let inodes_count = inodes.len(); Aug 17 03:38:06.991 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Aug 17 03:38:06.991 INFO kablam! Aug 17 03:38:06.991 INFO kablam! warning: value assigned to `prev_item_length` is never read Aug 17 03:38:06.991 INFO kablam! --> src/io/mod.rs:73:21 Aug 17 03:38:06.991 INFO kablam! | Aug 17 03:38:06.991 INFO kablam! 73 | let mut prev_item_length = 0; Aug 17 03:38:06.991 INFO kablam! | ^^^^^^^^^^^^^^^^ Aug 17 03:38:06.991 INFO kablam! | Aug 17 03:38:06.991 INFO kablam! = note: #[warn(unused_assignments)] on by default Aug 17 03:38:06.991 INFO kablam! Aug 17 03:38:07.013 INFO kablam! warning: unused variable: `inodes_count` Aug 17 03:38:07.013 INFO kablam! --> src/io/mod.rs:27:13 Aug 17 03:38:07.013 INFO kablam! | Aug 17 03:38:07.013 INFO kablam! 27 | let inodes_count = inodes.len(); Aug 17 03:38:07.013 INFO kablam! | ^^^^^^^^^^^^ help: consider using `_inodes_count` instead Aug 17 03:38:07.013 INFO kablam! | Aug 17 03:38:07.013 INFO kablam! = note: #[warn(unused_variables)] on by default Aug 17 03:38:07.013 INFO kablam! Aug 17 03:38:07.013 INFO kablam! warning: value assigned to `prev_item_length` is never read Aug 17 03:38:07.013 INFO kablam! --> src/io/mod.rs:73:21 Aug 17 03:38:07.014 INFO kablam! | Aug 17 03:38:07.014 INFO kablam! 73 | let mut prev_item_length = 0; Aug 17 03:38:07.014 INFO kablam! | ^^^^^^^^^^^^^^^^ Aug 17 03:38:07.014 INFO kablam! | Aug 17 03:38:07.014 INFO kablam! = note: #[warn(unused_assignments)] on by default Aug 17 03:38:07.014 INFO kablam! Aug 17 03:38:07.180 INFO kablam! warning: variable does not need to be mutable Aug 17 03:38:07.180 INFO kablam! --> src/io/mod.rs:120:13 Aug 17 03:38:07.180 INFO kablam! | Aug 17 03:38:07.180 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Aug 17 03:38:07.180 INFO kablam! | ----^^^^^^^^^^^^^ Aug 17 03:38:07.180 INFO kablam! | | Aug 17 03:38:07.180 INFO kablam! | help: remove this `mut` Aug 17 03:38:07.181 INFO kablam! | Aug 17 03:38:07.181 INFO kablam! = note: #[warn(unused_mut)] on by default Aug 17 03:38:07.181 INFO kablam! Aug 17 03:38:07.214 INFO kablam! warning: variable does not need to be mutable Aug 17 03:38:07.214 INFO kablam! --> src/io/mod.rs:120:13 Aug 17 03:38:07.214 INFO kablam! | Aug 17 03:38:07.214 INFO kablam! 120 | let mut visible_items = paint_items.get_visible(); Aug 17 03:38:07.214 INFO kablam! | ----^^^^^^^^^^^^^ Aug 17 03:38:07.214 INFO kablam! | | Aug 17 03:38:07.214 INFO kablam! | help: remove this `mut` Aug 17 03:38:07.214 INFO kablam! | Aug 17 03:38:07.214 INFO kablam! = note: #[warn(unused_mut)] on by default Aug 17 03:38:07.214 INFO kablam! Aug 17 03:38:07.288 INFO kablam! warning: field is never used: `path` Aug 17 03:38:07.288 INFO kablam! --> src/fs/mod.rs:92:5 Aug 17 03:38:07.288 INFO kablam! | Aug 17 03:38:07.289 INFO kablam! 92 | path: String Aug 17 03:38:07.289 INFO kablam! | ^^^^^^^^^^^^ Aug 17 03:38:07.289 INFO kablam! | Aug 17 03:38:07.289 INFO kablam! = note: #[warn(dead_code)] on by default Aug 17 03:38:07.289 INFO kablam! Aug 17 03:38:07.294 INFO kablam! warning: method is never used: `get_path` Aug 17 03:38:07.294 INFO kablam! --> src/fs/mod.rs:117:5 Aug 17 03:38:07.294 INFO kablam! | Aug 17 03:38:07.294 INFO kablam! 117 | pub fn get_path(&self) -> String { Aug 17 03:38:07.295 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Aug 17 03:38:07.295 INFO kablam! Aug 17 03:38:07.318 INFO kablam! warning: comparison is useless due to type limits Aug 17 03:38:07.318 INFO kablam! --> src/paintitems/mod.rs:25:41 Aug 17 03:38:07.318 INFO kablam! | Aug 17 03:38:07.318 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Aug 17 03:38:07.318 INFO kablam! | ^^^^^^^^^ Aug 17 03:38:07.318 INFO kablam! | Aug 17 03:38:07.318 INFO kablam! = note: #[warn(unused_comparisons)] on by default Aug 17 03:38:07.318 INFO kablam! Aug 17 03:38:07.371 INFO kablam! warning: field is never used: `path` Aug 17 03:38:07.371 INFO kablam! --> src/fs/mod.rs:92:5 Aug 17 03:38:07.371 INFO kablam! | Aug 17 03:38:07.371 INFO kablam! 92 | path: String Aug 17 03:38:07.372 INFO kablam! | ^^^^^^^^^^^^ Aug 17 03:38:07.372 INFO kablam! | Aug 17 03:38:07.372 INFO kablam! = note: #[warn(dead_code)] on by default Aug 17 03:38:07.372 INFO kablam! Aug 17 03:38:07.372 INFO kablam! warning: method is never used: `get_path` Aug 17 03:38:07.372 INFO kablam! --> src/fs/mod.rs:117:5 Aug 17 03:38:07.372 INFO kablam! | Aug 17 03:38:07.372 INFO kablam! 117 | pub fn get_path(&self) -> String { Aug 17 03:38:07.372 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Aug 17 03:38:07.372 INFO kablam! Aug 17 03:38:07.383 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Aug 17 03:38:07.383 INFO kablam! --> src/style/mod.rs:67:13 Aug 17 03:38:07.383 INFO kablam! | Aug 17 03:38:07.383 INFO kablam! 67 | let licenseItem = PaintItem{ Aug 17 03:38:07.383 INFO kablam! | ^^^^^^^^^^^ Aug 17 03:38:07.394 INFO kablam! | Aug 17 03:38:07.394 INFO kablam! = note: #[warn(non_snake_case)] on by default Aug 17 03:38:07.394 INFO kablam! Aug 17 03:38:07.395 INFO kablam! warning: variable `licenseItem` should have a snake case name such as `license_item` Aug 17 03:38:07.395 INFO kablam! --> src/style/mod.rs:83:13 Aug 17 03:38:07.395 INFO kablam! | Aug 17 03:38:07.395 INFO kablam! 83 | let licenseItem = PaintItem{ Aug 17 03:38:07.395 INFO kablam! | ^^^^^^^^^^^ Aug 17 03:38:07.395 INFO kablam! Aug 17 03:38:07.401 INFO kablam! warning: function `it_returns_a_Paint_Item` should have a snake case name such as `it_returns_a_paint_item` Aug 17 03:38:07.401 INFO kablam! --> src/decorate/mod.rs:201:5 Aug 17 03:38:07.401 INFO kablam! | Aug 17 03:38:07.401 INFO kablam! 201 | / fn it_returns_a_Paint_Item() { Aug 17 03:38:07.401 INFO kablam! 202 | | Aug 17 03:38:07.401 INFO kablam! 203 | | let file = File::new( Aug 17 03:38:07.401 INFO kablam! 204 | | String::from("filename"), Aug 17 03:38:07.401 INFO kablam! ... | Aug 17 03:38:07.401 INFO kablam! 222 | | assert_eq!(paint_item, expected_result); Aug 17 03:38:07.401 INFO kablam! 223 | | } Aug 17 03:38:07.401 INFO kablam! | |_____^ Aug 17 03:38:07.401 INFO kablam! Aug 17 03:38:07.402 INFO kablam! warning: comparison is useless due to type limits Aug 17 03:38:07.402 INFO kablam! --> src/paintitems/mod.rs:25:41 Aug 17 03:38:07.402 INFO kablam! | Aug 17 03:38:07.402 INFO kablam! 25 | if index >= self.items.len() || index < 0 { Aug 17 03:38:07.402 INFO kablam! | ^^^^^^^^^ Aug 17 03:38:07.402 INFO kablam! | Aug 17 03:38:07.402 INFO kablam! = note: #[warn(unused_comparisons)] on by default Aug 17 03:38:07.403 INFO kablam! Aug 17 03:38:07.472 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 3.34s Aug 17 03:38:07.486 INFO kablam! su: No module specific data is present Aug 17 03:38:08.011 INFO running `"docker" "rm" "-f" "5c6d18df21680f4ec53f693cccc1a30731bb71ec2849fa96135252ec89de207d"` Aug 17 03:38:08.192 INFO blam! 5c6d18df21680f4ec53f693cccc1a30731bb71ec2849fa96135252ec89de207d