Jul 11 14:09:14.848 INFO checking master-d/rust-pwned-passwords against master#ae5b629efd79de78e6ba7ef493c32857bd7f9cf9 for pr-52234 Jul 11 14:09:14.848 INFO running: cargo +ae5b629efd79de78e6ba7ef493c32857bd7f9cf9-alt check --frozen --all --all-targets Jul 11 14:09:14.849 INFO creating container for: cargo +ae5b629efd79de78e6ba7ef493c32857bd7f9cf9-alt check --frozen --all --all-targets Jul 11 14:09:14.849 INFO running `"docker" "create" "-v" "/home/ec2-user/crater/./work/local/test-source/worker-5/pr-52234/master#ae5b629efd79de78e6ba7ef493c32857bd7f9cf9:/source:ro,Z" "-v" "/home/ec2-user/crater/./work/local/target-dirs/pr-52234/worker-5/master#ae5b629efd79de78e6ba7ef493c32857bd7f9cf9:/target:rw,Z" "-v" "/home/ec2-user/crater/./work/local/cargo-home:/cargo-home:ro,Z" "-v" "/home/ec2-user/crater/./work/local/rustup-home:/rustup-home:ro,Z" "-e" "USER_ID=500" "-e" "CMD=cargo +ae5b629efd79de78e6ba7ef493c32857bd7f9cf9-alt check --frozen --all --all-targets" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "crater"` Jul 11 14:09:15.098 INFO blam! 03b04530077877ef3dd83780d06cb3b47c48d1a77f3260bc6ae5d589912b47c6 Jul 11 14:09:15.101 INFO running `"docker" "start" "-a" "03b04530077877ef3dd83780d06cb3b47c48d1a77f3260bc6ae5d589912b47c6"` Jul 11 14:09:16.219 INFO kablam! Checking sha1 v0.2.0 Jul 11 14:09:16.814 INFO kablam! Checking rust-pwned-passwords v0.1.0 (file:///source) Jul 11 14:09:16.994 INFO kablam! warning: unnecessary parentheses around `if` condition Jul 11 14:09:16.994 INFO kablam! --> src/main.rs:86:20 Jul 11 14:09:16.994 INFO kablam! | Jul 11 14:09:16.994 INFO kablam! 86 | if (cmp_hash == self.hash) { Jul 11 14:09:16.994 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Jul 11 14:09:16.994 INFO kablam! | Jul 11 14:09:16.994 INFO kablam! = note: #[warn(unused_parens)] on by default Jul 11 14:09:16.994 INFO kablam! Jul 11 14:09:16.995 INFO kablam! warning: unnecessary parentheses around `if` condition Jul 11 14:09:16.995 INFO kablam! --> src/main.rs:90:20 Jul 11 14:09:16.995 INFO kablam! | Jul 11 14:09:16.995 INFO kablam! 90 | if (cmp_hash > self.hash) { Jul 11 14:09:16.995 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Jul 11 14:09:16.995 INFO kablam! Jul 11 14:09:17.031 INFO kablam! warning: unnecessary parentheses around `if` condition Jul 11 14:09:17.031 INFO kablam! --> src/main.rs:86:20 Jul 11 14:09:17.031 INFO kablam! | Jul 11 14:09:17.031 INFO kablam! 86 | if (cmp_hash == self.hash) { Jul 11 14:09:17.031 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Jul 11 14:09:17.031 INFO kablam! | Jul 11 14:09:17.031 INFO kablam! = note: #[warn(unused_parens)] on by default Jul 11 14:09:17.031 INFO kablam! Jul 11 14:09:17.032 INFO kablam! warning: unnecessary parentheses around `if` condition Jul 11 14:09:17.032 INFO kablam! --> src/main.rs:90:20 Jul 11 14:09:17.032 INFO kablam! | Jul 11 14:09:17.032 INFO kablam! 90 | if (cmp_hash > self.hash) { Jul 11 14:09:17.032 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses Jul 11 14:09:17.032 INFO kablam! Jul 11 14:09:17.195 INFO kablam! warning: unused variable: `line` Jul 11 14:09:17.195 INFO kablam! --> src/main.rs:117:13 Jul 11 14:09:17.195 INFO kablam! | Jul 11 14:09:17.195 INFO kablam! 117 | let line = match line_br { Jul 11 14:09:17.195 INFO kablam! | ^^^^ help: consider using `_line` instead Jul 11 14:09:17.195 INFO kablam! | Jul 11 14:09:17.195 INFO kablam! = note: #[warn(unused_variables)] on by default Jul 11 14:09:17.195 INFO kablam! Jul 11 14:09:17.195 INFO kablam! warning: unused variable: `hf` Jul 11 14:09:17.195 INFO kablam! --> src/main.rs:120:25 Jul 11 14:09:17.195 INFO kablam! | Jul 11 14:09:17.195 INFO kablam! 120 | let mut hf = HashFile::new(line, true).expect("Error loading file"); Jul 11 14:09:17.195 INFO kablam! | ^^ help: consider using `_hf` instead Jul 11 14:09:17.195 INFO kablam! Jul 11 14:09:17.196 INFO kablam! warning: unused variable: `e` Jul 11 14:09:17.196 INFO kablam! --> src/main.rs:123:17 Jul 11 14:09:17.196 INFO kablam! | Jul 11 14:09:17.196 INFO kablam! 123 | Err(e) => panic!("{} {}", "Error reading line of update file", file_path) Jul 11 14:09:17.196 INFO kablam! | ^ help: consider using `_e` instead Jul 11 14:09:17.196 INFO kablam! Jul 11 14:09:17.197 INFO kablam! warning: unused variable: `e` Jul 11 14:09:17.197 INFO kablam! --> src/main.rs:32:21 Jul 11 14:09:17.197 INFO kablam! | Jul 11 14:09:17.197 INFO kablam! 32 | Err(e) => panic!("Could not create folder {}",dir) Jul 11 14:09:17.197 INFO kablam! | ^ help: consider using `_e` instead Jul 11 14:09:17.197 INFO kablam! Jul 11 14:09:17.218 INFO kablam! warning: unused variable: `line` Jul 11 14:09:17.218 INFO kablam! --> src/main.rs:117:13 Jul 11 14:09:17.218 INFO kablam! | Jul 11 14:09:17.218 INFO kablam! 117 | let line = match line_br { Jul 11 14:09:17.218 INFO kablam! | ^^^^ help: consider using `_line` instead Jul 11 14:09:17.218 INFO kablam! | Jul 11 14:09:17.218 INFO kablam! = note: #[warn(unused_variables)] on by default Jul 11 14:09:17.218 INFO kablam! Jul 11 14:09:17.218 INFO kablam! warning: unused variable: `hf` Jul 11 14:09:17.218 INFO kablam! --> src/main.rs:120:25 Jul 11 14:09:17.218 INFO kablam! | Jul 11 14:09:17.218 INFO kablam! 120 | let mut hf = HashFile::new(line, true).expect("Error loading file"); Jul 11 14:09:17.218 INFO kablam! | ^^ help: consider using `_hf` instead Jul 11 14:09:17.218 INFO kablam! Jul 11 14:09:17.219 INFO kablam! warning: unused variable: `e` Jul 11 14:09:17.219 INFO kablam! --> src/main.rs:123:17 Jul 11 14:09:17.219 INFO kablam! | Jul 11 14:09:17.219 INFO kablam! 123 | Err(e) => panic!("{} {}", "Error reading line of update file", file_path) Jul 11 14:09:17.219 INFO kablam! | ^ help: consider using `_e` instead Jul 11 14:09:17.219 INFO kablam! Jul 11 14:09:17.219 INFO kablam! warning: unused variable: `e` Jul 11 14:09:17.219 INFO kablam! --> src/main.rs:32:21 Jul 11 14:09:17.219 INFO kablam! | Jul 11 14:09:17.219 INFO kablam! 32 | Err(e) => panic!("Could not create folder {}",dir) Jul 11 14:09:17.219 INFO kablam! | ^ help: consider using `_e` instead Jul 11 14:09:17.219 INFO kablam! Jul 11 14:09:17.236 INFO kablam! warning: variable does not need to be mutable Jul 11 14:09:17.236 INFO kablam! --> src/main.rs:51:13 Jul 11 14:09:17.236 INFO kablam! | Jul 11 14:09:17.236 INFO kablam! 51 | let mut pos = self.size as i64/2; Jul 11 14:09:17.236 INFO kablam! | ----^^^ Jul 11 14:09:17.236 INFO kablam! | | Jul 11 14:09:17.236 INFO kablam! | help: remove this `mut` Jul 11 14:09:17.236 INFO kablam! | Jul 11 14:09:17.236 INFO kablam! = note: #[warn(unused_mut)] on by default Jul 11 14:09:17.236 INFO kablam! Jul 11 14:09:17.240 INFO kablam! warning: variable does not need to be mutable Jul 11 14:09:17.240 INFO kablam! --> src/main.rs:51:13 Jul 11 14:09:17.240 INFO kablam! | Jul 11 14:09:17.240 INFO kablam! 51 | let mut pos = self.size as i64/2; Jul 11 14:09:17.241 INFO kablam! | ----^^^ Jul 11 14:09:17.241 INFO kablam! | | Jul 11 14:09:17.241 INFO kablam! | help: remove this `mut` Jul 11 14:09:17.250 INFO kablam! | Jul 11 14:09:17.251 INFO kablam! = note: #[warn(unused_mut)] on by default Jul 11 14:09:17.251 INFO kablam! Jul 11 14:09:17.255 INFO kablam! warning: variable does not need to be mutable Jul 11 14:09:17.255 INFO kablam! --> src/main.rs:109:9 Jul 11 14:09:17.255 INFO kablam! | Jul 11 14:09:17.255 INFO kablam! 109 | let mut update_file = match fs::File::open(file_path) { Jul 11 14:09:17.255 INFO kablam! | ----^^^^^^^^^^^ Jul 11 14:09:17.255 INFO kablam! | | Jul 11 14:09:17.255 INFO kablam! | help: remove this `mut` Jul 11 14:09:17.255 INFO kablam! Jul 11 14:09:17.255 INFO kablam! warning: variable does not need to be mutable Jul 11 14:09:17.255 INFO kablam! --> src/main.rs:115:9 Jul 11 14:09:17.255 INFO kablam! | Jul 11 14:09:17.255 INFO kablam! 115 | let mut update_br = BufReader::new(update_file); Jul 11 14:09:17.255 INFO kablam! | ----^^^^^^^^^ Jul 11 14:09:17.256 INFO kablam! | | Jul 11 14:09:17.256 INFO kablam! | help: remove this `mut` Jul 11 14:09:17.256 INFO kablam! Jul 11 14:09:17.271 INFO kablam! warning: method is never used: `seek` Jul 11 14:09:17.271 INFO kablam! --> src/main.rs:50:5 Jul 11 14:09:17.271 INFO kablam! | Jul 11 14:09:17.271 INFO kablam! 50 | pub fn seek(&mut self) { Jul 11 14:09:17.271 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.271 INFO kablam! | Jul 11 14:09:17.271 INFO kablam! = note: #[warn(dead_code)] on by default Jul 11 14:09:17.271 INFO kablam! Jul 11 14:09:17.271 INFO kablam! warning: method is never used: `write_hash` Jul 11 14:09:17.271 INFO kablam! --> src/main.rs:64:5 Jul 11 14:09:17.271 INFO kablam! | Jul 11 14:09:17.271 INFO kablam! 64 | pub fn write_hash(&mut self, hash: &String) { Jul 11 14:09:17.271 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.271 INFO kablam! Jul 11 14:09:17.272 INFO kablam! warning: unused `std::result::Result` which must be used Jul 11 14:09:17.272 INFO kablam! --> src/main.rs:54:13 Jul 11 14:09:17.272 INFO kablam! | Jul 11 14:09:17.272 INFO kablam! 54 | self.file.seek(SeekFrom::Current(pos)); Jul 11 14:09:17.272 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.272 INFO kablam! | Jul 11 14:09:17.272 INFO kablam! = note: #[warn(unused_must_use)] on by default Jul 11 14:09:17.272 INFO kablam! = note: this `Result` may be an `Err` variant, which should be handled Jul 11 14:09:17.272 INFO kablam! Jul 11 14:09:17.272 INFO kablam! warning: unused `std::result::Result` which must be used Jul 11 14:09:17.272 INFO kablam! --> src/main.rs:59:9 Jul 11 14:09:17.272 INFO kablam! | Jul 11 14:09:17.272 INFO kablam! 59 | self.file.read_exact(&mut buf); Jul 11 14:09:17.272 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.272 INFO kablam! | Jul 11 14:09:17.272 INFO kablam! = note: this `Result` may be an `Err` variant, which should be handled Jul 11 14:09:17.272 INFO kablam! Jul 11 14:09:17.273 INFO kablam! warning: unused `std::result::Result` which must be used Jul 11 14:09:17.273 INFO kablam! --> src/main.rs:67:9 Jul 11 14:09:17.273 INFO kablam! | Jul 11 14:09:17.273 INFO kablam! 67 | self.file.write(line.as_bytes()); Jul 11 14:09:17.273 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.273 INFO kablam! | Jul 11 14:09:17.273 INFO kablam! = note: this `Result` may be an `Err` variant, which should be handled Jul 11 14:09:17.273 INFO kablam! Jul 11 14:09:17.273 INFO kablam! warning: unused `std::result::Result` which must be used Jul 11 14:09:17.273 INFO kablam! --> src/main.rs:82:17 Jul 11 14:09:17.273 INFO kablam! | Jul 11 14:09:17.273 INFO kablam! 82 | self.file.seek(SeekFrom::Current(seekto)); Jul 11 14:09:17.273 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.273 INFO kablam! | Jul 11 14:09:17.273 INFO kablam! = note: this `Result` may be an `Err` variant, which should be handled Jul 11 14:09:17.273 INFO kablam! Jul 11 14:09:17.277 INFO kablam! warning: variable does not need to be mutable Jul 11 14:09:17.277 INFO kablam! --> src/main.rs:109:9 Jul 11 14:09:17.277 INFO kablam! | Jul 11 14:09:17.277 INFO kablam! 109 | let mut update_file = match fs::File::open(file_path) { Jul 11 14:09:17.277 INFO kablam! | ----^^^^^^^^^^^ Jul 11 14:09:17.277 INFO kablam! | | Jul 11 14:09:17.277 INFO kablam! | help: remove this `mut` Jul 11 14:09:17.282 INFO kablam! Jul 11 14:09:17.283 INFO kablam! warning: variable does not need to be mutable Jul 11 14:09:17.283 INFO kablam! --> src/main.rs:115:9 Jul 11 14:09:17.283 INFO kablam! | Jul 11 14:09:17.283 INFO kablam! 115 | let mut update_br = BufReader::new(update_file); Jul 11 14:09:17.283 INFO kablam! | ----^^^^^^^^^ Jul 11 14:09:17.283 INFO kablam! | | Jul 11 14:09:17.283 INFO kablam! | help: remove this `mut` Jul 11 14:09:17.283 INFO kablam! Jul 11 14:09:17.298 INFO kablam! warning: method is never used: `seek` Jul 11 14:09:17.298 INFO kablam! --> src/main.rs:50:5 Jul 11 14:09:17.298 INFO kablam! | Jul 11 14:09:17.298 INFO kablam! 50 | pub fn seek(&mut self) { Jul 11 14:09:17.298 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.298 INFO kablam! | Jul 11 14:09:17.298 INFO kablam! = note: #[warn(dead_code)] on by default Jul 11 14:09:17.298 INFO kablam! Jul 11 14:09:17.299 INFO kablam! warning: method is never used: `write_hash` Jul 11 14:09:17.299 INFO kablam! --> src/main.rs:64:5 Jul 11 14:09:17.299 INFO kablam! | Jul 11 14:09:17.299 INFO kablam! 64 | pub fn write_hash(&mut self, hash: &String) { Jul 11 14:09:17.299 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.299 INFO kablam! Jul 11 14:09:17.300 INFO kablam! warning: unused `std::result::Result` which must be used Jul 11 14:09:17.300 INFO kablam! --> src/main.rs:54:13 Jul 11 14:09:17.300 INFO kablam! | Jul 11 14:09:17.300 INFO kablam! 54 | self.file.seek(SeekFrom::Current(pos)); Jul 11 14:09:17.300 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.301 INFO kablam! | Jul 11 14:09:17.301 INFO kablam! = note: #[warn(unused_must_use)] on by default Jul 11 14:09:17.301 INFO kablam! = note: this `Result` may be an `Err` variant, which should be handled Jul 11 14:09:17.301 INFO kablam! Jul 11 14:09:17.302 INFO kablam! warning: unused `std::result::Result` which must be used Jul 11 14:09:17.302 INFO kablam! --> src/main.rs:59:9 Jul 11 14:09:17.302 INFO kablam! | Jul 11 14:09:17.302 INFO kablam! 59 | self.file.read_exact(&mut buf); Jul 11 14:09:17.302 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.302 INFO kablam! | Jul 11 14:09:17.302 INFO kablam! = note: this `Result` may be an `Err` variant, which should be handled Jul 11 14:09:17.302 INFO kablam! Jul 11 14:09:17.315 INFO kablam! warning: unused `std::result::Result` which must be used Jul 11 14:09:17.315 INFO kablam! --> src/main.rs:67:9 Jul 11 14:09:17.315 INFO kablam! | Jul 11 14:09:17.315 INFO kablam! 67 | self.file.write(line.as_bytes()); Jul 11 14:09:17.315 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.315 INFO kablam! | Jul 11 14:09:17.315 INFO kablam! = note: this `Result` may be an `Err` variant, which should be handled Jul 11 14:09:17.315 INFO kablam! Jul 11 14:09:17.323 INFO kablam! warning: unused `std::result::Result` which must be used Jul 11 14:09:17.323 INFO kablam! --> src/main.rs:82:17 Jul 11 14:09:17.323 INFO kablam! | Jul 11 14:09:17.323 INFO kablam! 82 | self.file.seek(SeekFrom::Current(seekto)); Jul 11 14:09:17.323 INFO kablam! | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ Jul 11 14:09:17.323 INFO kablam! | Jul 11 14:09:17.323 INFO kablam! = note: this `Result` may be an `Err` variant, which should be handled Jul 11 14:09:17.323 INFO kablam! Jul 11 14:09:17.381 INFO kablam! Finished dev [unoptimized + debuginfo] target(s) in 1.27s Jul 11 14:09:17.383 INFO kablam! su: No module specific data is present Jul 11 14:09:18.118 INFO running `"docker" "rm" "-f" "03b04530077877ef3dd83780d06cb3b47c48d1a77f3260bc6ae5d589912b47c6"` Jul 11 14:09:18.408 INFO blam! 03b04530077877ef3dd83780d06cb3b47c48d1a77f3260bc6ae5d589912b47c6