[INFO] cloning repository https://github.com/azc3133/bennett-valley [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/azc3133/bennett-valley" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazc3133%2Fbennett-valley", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazc3133%2Fbennett-valley'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f950bcae4c37279dd778c3db01de39df532129e8 [INFO] checking azc3133/bennett-valley against eca445e5ae4a6679cc27d3a09106ce245e13a5a6 for pr-162478 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fazc3133%2Fbennett-valley" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-4-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/azc3133/bennett-valley [INFO] finished tweaking git repo https://github.com/azc3133/bennett-valley [INFO] tweaked toml for git repo https://github.com/azc3133/bennett-valley written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/azc3133/bennett-valley on toolchain eca445e5ae4a6679cc27d3a09106ce245e13a5a6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+eca445e5ae4a6679cc27d3a09106ce245e13a5a6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/azc3133/bennett-valley already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+eca445e5ae4a6679cc27d3a09106ce245e13a5a6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: binary `bennett_valley` should have a kebab-case name [INFO] [stderr] | [INFO] [stderr] 1 | /workspace/builds/worker-4-tc1/source/target/.../bennett_valley [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `cargo::non_kebab_case_bins` is set to `warn` by default [INFO] [stderr] help: to change the binary name to `bennett-valley`, convert `bin.name` [INFO] [stderr] --> Cargo.toml:2:8 [INFO] [stderr] | [INFO] [stderr] 2 - name = "bennett_valley" [INFO] [stderr] 2 + name = "bennett-valley" [INFO] [stderr] | [INFO] [stderr] warning: `bennett_valley` (manifest) generated 1 warning [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:8683fc1fc2eb5c9ac98e0d076ab094b2ffac7f99da555d2b6a2e27f346de2ec7" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5 [INFO] running `Command { std: "docker" "start" "53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5" "/opt/rustwide/cargo-home/bin/cargo" "+eca445e5ae4a6679cc27d3a09106ce245e13a5a6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5" "/opt/rustwide/cargo-home/bin/cargo" "+eca445e5ae4a6679cc27d3a09106ce245e13a5a6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] warning: binary `bennett_valley` should have a kebab-case name [INFO] [stderr] | [INFO] [stderr] 1 | /opt/rustwide/target/.../bennett_valley [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `cargo::non_kebab_case_bins` is set to `warn` by default [INFO] [stderr] help: to change the binary name to `bennett-valley`, convert `bin.name` [INFO] [stderr] --> Cargo.toml:2:8 [INFO] [stderr] | [INFO] [stderr] 2 - name = "bennett_valley" [INFO] [stderr] 2 + name = "bennett-valley" [INFO] [stderr] | [INFO] [stderr] warning: `bennett_valley` (manifest) generated 1 warning [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Checking simd-adler32 v0.3.9 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling libc v0.2.185 [INFO] [stderr] Compiling miniquad v0.4.8 [INFO] [stderr] Checking ttf-parser v0.21.1 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking quad-rand v0.2.3 [INFO] [stderr] Checking glam v0.27.0 [INFO] [stderr] Compiling macroquad_macro v0.1.8 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking miniz_oxide v0.8.9 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking flate2 v1.1.9 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking image v0.24.9 [INFO] [stderr] Checking fontdue v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking macroquad v0.4.14 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bennett_valley v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::render::camera::TILE_SIZE` [INFO] [stdout] --> src/render/renderer.rs:703:9 [INFO] [stdout] | [INFO] [stdout] 703 | use crate::render::camera::TILE_SIZE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::render::camera::TILE_SIZE` [INFO] [stdout] --> src/render/renderer.rs:703:9 [INFO] [stdout] | [INFO] [stdout] 703 | use crate::render::camera::TILE_SIZE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/render/player_view.rs:289:25 [INFO] [stdout] | [INFO] [stdout] 289 | let blink = ((t * 0.7).sin() > 0.97); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 289 - let blink = ((t * 0.7).sin() > 0.97); [INFO] [stdout] 289 + let blink = (t * 0.7).sin() > 0.97; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around assigned value [INFO] [stdout] --> src/render/player_view.rs:289:25 [INFO] [stdout] | [INFO] [stdout] 289 | let blink = ((t * 0.7).sin() > 0.97); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 289 - let blink = ((t * 0.7).sin() > 0.97); [INFO] [stdout] 289 + let blink = (t * 0.7).sin() > 0.97; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nudged` is assigned to, but never used [INFO] [stdout] --> src/game/state.rs:3647:21 [INFO] [stdout] | [INFO] [stdout] 3647 | let mut nudged = false; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_nudged` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `nudged` is never read [INFO] [stdout] --> src/game/state.rs:3657:25 [INFO] [stdout] | [INFO] [stdout] 3657 | nudged = true; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/game/save.rs:235:21 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn mp_join_room(code: &str) -> String { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `json` [INFO] [stdout] --> src/game/save.rs:247:22 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn mp_sync_state(json: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_json` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `json` [INFO] [stdout] --> src/game/save.rs:253:22 [INFO] [stdout] | [INFO] [stdout] 253 | pub fn mp_send_input(json: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_json` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/game/save.rs:313:19 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn play_sound(name: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sw` [INFO] [stdout] --> src/render/hud.rs:136:41 [INFO] [stdout] | [INFO] [stdout] 136 | fn draw_inventory_p2(state: &GameState, sw: f32, sh: f32) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_sw` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `nudged` is assigned to, but never used [INFO] [stdout] --> src/game/state.rs:3647:21 [INFO] [stdout] | [INFO] [stdout] 3647 | let mut nudged = false; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: consider using `_nudged` instead [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `nudged` is never read [INFO] [stdout] --> src/game/state.rs:3657:25 [INFO] [stdout] | [INFO] [stdout] 3657 | nudged = true; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `item_color` [INFO] [stdout] --> src/render/festival_view.rs:95:36 [INFO] [stdout] | [INFO] [stdout] 95 | let (bg_color, searched_color, item_color) = match kind { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_item_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/game/state.rs:4219:13 [INFO] [stdout] | [INFO] [stdout] 4219 | let mut state = test_state(); [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/game/farming.rs:503:13 [INFO] [stdout] | [INFO] [stdout] 503 | let mut map = test_farm_map(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `code` [INFO] [stdout] --> src/game/save.rs:235:21 [INFO] [stdout] | [INFO] [stdout] 235 | pub fn mp_join_room(code: &str) -> String { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_code` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `json` [INFO] [stdout] --> src/game/save.rs:247:22 [INFO] [stdout] | [INFO] [stdout] 247 | pub fn mp_sync_state(json: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_json` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `json` [INFO] [stdout] --> src/game/save.rs:253:22 [INFO] [stdout] | [INFO] [stdout] 253 | pub fn mp_send_input(json: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_json` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `name` [INFO] [stdout] --> src/game/save.rs:313:19 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn play_sound(name: &str) { [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_name` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `sw` [INFO] [stdout] --> src/render/hud.rs:136:41 [INFO] [stdout] | [INFO] [stdout] 136 | fn draw_inventory_p2(state: &GameState, sw: f32, sh: f32) { [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_sw` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `item_color` [INFO] [stdout] --> src/render/festival_view.rs:95:36 [INFO] [stdout] | [INFO] [stdout] 95 | let (bg_color, searched_color, item_color) = match kind { [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_item_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `url` [INFO] [stdout] --> src/main.rs:1036:17 [INFO] [stdout] | [INFO] [stdout] 1036 | let url = req.url; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_url` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `url` [INFO] [stdout] --> src/main.rs:1088:17 [INFO] [stdout] | [INFO] [stdout] 1088 | let url = req.url.clone(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `url` [INFO] [stdout] --> src/main.rs:1125:17 [INFO] [stdout] | [INFO] [stdout] 1125 | let url = format!("/api/memory?npc_id={}&text={}", mem.npc_id, url_encode(&mem.text)); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `acted` is never read [INFO] [stdout] --> src/main.rs:561:21 [INFO] [stdout] | [INFO] [stdout] 561 | acted = true; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `url` [INFO] [stdout] --> src/main.rs:1036:17 [INFO] [stdout] | [INFO] [stdout] 1036 | let url = req.url; [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_url` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `url` [INFO] [stdout] --> src/main.rs:1088:17 [INFO] [stdout] | [INFO] [stdout] 1088 | let url = req.url.clone(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `url` [INFO] [stdout] --> src/main.rs:1125:17 [INFO] [stdout] | [INFO] [stdout] 1125 | let url = format!("/api/memory?npc_id={}&text={}", mem.npc_id, url_encode(&mem.text)); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_url` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `acted` is never read [INFO] [stdout] --> src/main.rs:561:21 [INFO] [stdout] | [INFO] [stdout] 561 | acted = true; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 13.29s [INFO] running `Command { std: "docker" "inspect" "53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5", kill_on_drop: false }` [INFO] [stdout] 53a88d59b087187eb70e81219c9ca3e7553dd74c75e877d5af0b1385f06389c5