[INFO] cloning repository https://github.com/saintech/asteroids
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/saintech/asteroids" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaintech%2Fasteroids", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaintech%2Fasteroids'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] afe87cb8824bcb4eb91125feff0ac9a4c8e9ead7
[INFO] checking saintech/asteroids against 895980e0290783bb09b1ccf1b11f14eb09b10430 for pr-160186
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsaintech%2Fasteroids" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/saintech/asteroids
[INFO] finished tweaking git repo https://github.com/saintech/asteroids
[INFO] tweaked toml for git repo https://github.com/saintech/asteroids written to /workspace/builds/worker-4-tc2/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/saintech/asteroids on toolchain 895980e0290783bb09b1ccf1b11f14eb09b10430
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+895980e0290783bb09b1ccf1b11f14eb09b10430" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/saintech/asteroids already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+895980e0290783bb09b1ccf1b11f14eb09b10430" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:77db811e55d90add9212f6832c23229e3de5f1c1f9905e8cb07319ea15df73ac" "sleep" "infinity", kill_on_drop: false }`
[INFO] [stdout] 6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c
[INFO] running `Command { std: "docker" "start" "6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c" "/opt/rustwide/cargo-home/bin/cargo" "+895980e0290783bb09b1ccf1b11f14eb09b10430" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c" "/opt/rustwide/cargo-home/bin/cargo" "+895980e0290783bb09b1ccf1b11f14eb09b10430" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stderr]     Checking byteorder v1.4.3
[INFO] [stderr]    Compiling num-traits v0.2.14
[INFO] [stderr]    Compiling libc v0.2.119
[INFO] [stderr]    Compiling num-integer v0.1.44
[INFO] [stderr]    Compiling crc32fast v1.3.2
[INFO] [stderr]     Checking adler32 v1.2.0
[INFO] [stderr]    Compiling quad-alsa-sys v0.3.2
[INFO] [stderr]    Compiling num-rational v0.3.2
[INFO] [stderr]    Compiling num-iter v0.1.42
[INFO] [stderr]     Checking dasp_sample v0.11.0
[INFO] [stderr]    Compiling sapp-linux v0.1.14
[INFO] [stderr]    Compiling quad-snd v0.2.3
[INFO] [stderr]     Checking ahash v0.4.7
[INFO] [stderr]     Checking ttf-parser v0.12.3
[INFO] [stderr]     Checking bytemuck v1.8.0
[INFO] [stderr]     Checking smallvec v0.6.14
[INFO] [stderr]     Checking miniz_oxide v0.3.7
[INFO] [stderr]    Compiling macroquad_macro v0.1.7
[INFO] [stderr]     Checking bumpalo v3.9.1
[INFO] [stderr]     Checking quad-rand v0.2.1
[INFO] [stderr]     Checking glam v0.14.0
[INFO] [stderr]     Checking hashbrown v0.9.1
[INFO] [stderr]     Checking ogg v0.7.1
[INFO] [stderr]     Checking deflate v0.8.6
[INFO] [stderr]     Checking dasp_frame v0.11.0
[INFO] [stderr]     Checking lewton v0.9.4
[INFO] [stderr]     Checking png v0.16.8
[INFO] [stderr]     Checking fontdue v0.5.2
[INFO] [stderr]     Checking audrey v0.3.0
[INFO] [stderr]     Checking miniquad v0.3.0-alpha.45
[INFO] [stderr]     Checking image v0.23.14
[INFO] [stderr]     Checking macroquad v0.3.15
[INFO] [stderr]     Checking macroquad-canvas v0.3.0
[INFO] [stderr]     Checking macroquad-particles v0.1.1
[INFO] [stderr]     Checking asteroids v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement
[INFO] [stdout]  --> src/systems/collision.rs:8:21
[INFO] [stdout]   |
[INFO] [stdout] 8 |         for ship in &mut game.ship {
[INFO] [stdout]   |                     ^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]   |
[INFO] [stdout] 8 -         for ship in &mut game.ship {
[INFO] [stdout] 8 +         while let Some(ship) = &mut game.ship {
[INFO] [stdout]   |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]   |
[INFO] [stdout] 8 -         for ship in &mut game.ship {
[INFO] [stdout] 8 +         if let Some(ship) = &mut game.ship {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement
[INFO] [stdout]  --> src/systems/collision.rs:8:21
[INFO] [stdout]   |
[INFO] [stdout] 8 |         for ship in &mut game.ship {
[INFO] [stdout]   |                     ^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]   |
[INFO] [stdout] 8 -         for ship in &mut game.ship {
[INFO] [stdout] 8 +         while let Some(ship) = &mut game.ship {
[INFO] [stdout]   |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]   |
[INFO] [stdout] 8 -         for ship in &mut game.ship {
[INFO] [stdout] 8 +         if let Some(ship) = &mut game.ship {
[INFO] [stdout]   |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/systems/collision.rs:13:21
[INFO] [stdout]    |
[INFO] [stdout] 13 |         for ship in &mut game.ship {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 13 -         for ship in &mut game.ship {
[INFO] [stdout] 13 +         while let Some(ship) = &mut game.ship {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 13 -         for ship in &mut game.ship {
[INFO] [stdout] 13 +         if let Some(ship) = &mut game.ship {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/systems/collision.rs:13:21
[INFO] [stdout]    |
[INFO] [stdout] 13 |         for ship in &mut game.ship {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 13 -         for ship in &mut game.ship {
[INFO] [stdout] 13 +         while let Some(ship) = &mut game.ship {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 13 -         for ship in &mut game.ship {
[INFO] [stdout] 13 +         if let Some(ship) = &mut game.ship {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/systems/collision.rs:57:21
[INFO] [stdout]    |
[INFO] [stdout] 57 |         for ship in &mut game.ship {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 57 -         for ship in &mut game.ship {
[INFO] [stdout] 57 +         while let Some(ship) = &mut game.ship {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 57 -         for ship in &mut game.ship {
[INFO] [stdout] 57 +         if let Some(ship) = &mut game.ship {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&mut Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/systems/collision.rs:57:21
[INFO] [stdout]    |
[INFO] [stdout] 57 |         for ship in &mut game.ship {
[INFO] [stdout]    |                     ^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 57 -         for ship in &mut game.ship {
[INFO] [stdout] 57 +         while let Some(ship) = &mut game.ship {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 57 -         for ship in &mut game.ship {
[INFO] [stdout] 57 +         if let Some(ship) = &mut game.ship {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/systems/draw.rs:21:71
[INFO] [stdout]    |
[INFO] [stdout] 21 |             for entity::Ship { position, sprite, has_exhaust, .. } in &game.ship {
[INFO] [stdout]    |                                                                       ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 21 -             for entity::Ship { position, sprite, has_exhaust, .. } in &game.ship {
[INFO] [stdout] 21 +             while let Some(entity::Ship { position, sprite, has_exhaust, .. }) = &game.ship {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 21 -             for entity::Ship { position, sprite, has_exhaust, .. } in &game.ship {
[INFO] [stdout] 21 +             if let Some(entity::Ship { position, sprite, has_exhaust, .. }) = &game.ship {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]   --> src/systems/draw.rs:21:71
[INFO] [stdout]    |
[INFO] [stdout] 21 |             for entity::Ship { position, sprite, has_exhaust, .. } in &game.ship {
[INFO] [stdout]    |                                                                       ^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]    |
[INFO] [stdout] 21 -             for entity::Ship { position, sprite, has_exhaust, .. } in &game.ship {
[INFO] [stdout] 21 +             while let Some(entity::Ship { position, sprite, has_exhaust, .. }) = &game.ship {
[INFO] [stdout]    |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]    |
[INFO] [stdout] 21 -             for entity::Ship { position, sprite, has_exhaust, .. } in &game.ship {
[INFO] [stdout] 21 +             if let Some(entity::Ship { position, sprite, has_exhaust, .. }) = &game.ship {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 8.97s
[INFO] running `Command { std: "docker" "inspect" "6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c", kill_on_drop: false }`
[INFO] [stdout] 6026c18e60a67b753eda6f71023eabaef5132157cd8e31042d4a6ea0b4ee915c
