[INFO] fetching crate velr 0.2.22... [INFO] fixing velr-0.2.22 against try#5fed607fb5806ae20927e7e9193e3793c411ac20+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817 [INFO] extracting crate velr 0.2.22 into /workspace/builds/worker-1-tc2/source [INFO] started tweaking crates.io crate velr 0.2.22 [INFO] finished tweaking crates.io crate velr 0.2.22 [INFO] tweaked toml for crates.io crate velr 0.2.22 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate velr 0.2.22 on toolchain 5fed607fb5806ae20927e7e9193e3793c411ac20 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate velr 0.2.22 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:7cf07dcec6eec8f91d8fcff9552b5c74122c05467aaf1800be6da9d6f61e2ab2" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 127f4a588d22a4828807d249c62b741635d94a27f6cd29e79fd6af5b473b073f [INFO] running `Command { std: "docker" "start" "127f4a588d22a4828807d249c62b741635d94a27f6cd29e79fd6af5b473b073f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "127f4a588d22a4828807d249c62b741635d94a27f6cd29e79fd6af5b473b073f" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "127f4a588d22a4828807d249c62b741635d94a27f6cd29e79fd6af5b473b073f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "127f4a588d22a4828807d249c62b741635d94a27f6cd29e79fd6af5b473b073f" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Compiling shlex v2.0.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling serde_json v1.0.150 [INFO] [stderr] Checking constant_time_eq v0.4.2 [INFO] [stderr] Checking arrayref v0.3.9 [INFO] [stderr] Checking cpufeatures v0.3.0 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking libloading v0.8.9 [INFO] [stderr] Compiling cc v1.2.63 [INFO] [stderr] Checking velr-runtime-linux-x86_64 v0.2.22 [INFO] [stderr] Checking memchr v2.8.1 [INFO] [stderr] Checking itoa v1.0.18 [INFO] [stderr] Compiling blake3 v1.8.5 [INFO] [stderr] Checking velr v0.2.22 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/lib.rs (1 fix) [INFO] [stderr] Fixed src/api.rs (3 fixes) [INFO] [stderr] Fixed src/runtime.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:998:33 [INFO] [stdout] | [INFO] [stdout] 998 | while let Some(mut t) = st.next_table()? { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `t` calls a custom destructor [INFO] [stdout] | `t` will be dropped later as of Edition 2024 [INFO] [stdout] 999 | t.for_each_row(|_| Ok(()))?; [INFO] [stdout] 1000 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `t` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1606:33 [INFO] [stdout] | [INFO] [stdout] 1606 | while let Some(mut t) = st.next_table()? { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `t` calls a custom destructor [INFO] [stdout] | `t` will be dropped later as of Edition 2024 [INFO] [stdout] 1607 | t.for_each_row(|_| Ok(()))?; [INFO] [stdout] 1608 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `t` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:998:33 [INFO] [stdout] | [INFO] [stdout] 998 | while let Some(mut t) = st.next_table()? { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `t` calls a custom destructor [INFO] [stdout] | `t` will be dropped later as of Edition 2024 [INFO] [stdout] 999 | t.for_each_row(|_| Ok(()))?; [INFO] [stdout] 1000 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `t` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/lib.rs:1606:33 [INFO] [stdout] | [INFO] [stdout] 1606 | while let Some(mut t) = st.next_table()? { [INFO] [stdout] | ----- ^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `t` calls a custom destructor [INFO] [stdout] | `t` will be dropped later as of Edition 2024 [INFO] [stdout] 1607 | t.for_each_row(|_| Ok(()))?; [INFO] [stdout] 1608 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `t` invokes this custom destructor [INFO] [stdout] --> src/lib.rs:1370:1 [INFO] [stdout] | [INFO] [stdout] 1370 | impl Drop for TableResult { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.00s [INFO] [stderr] crater-edition-check: velr v0.2.22 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking velr v0.2.22 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `col_count` is never read [INFO] [stdout] --> src/lib.rs:1389:5 [INFO] [stdout] | [INFO] [stdout] 1387 | pub struct RowIter<'t> { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 1388 | rows: Option>, [INFO] [stdout] 1389 | col_count: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/runtime.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 75 | pub struct Runtime { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 81 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `col_count` is never read [INFO] [stdout] --> src/lib.rs:1389:5 [INFO] [stdout] | [INFO] [stdout] 1387 | pub struct RowIter<'t> { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] 1388 | rows: Option>, [INFO] [stdout] 1389 | col_count: usize, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `path` is never read [INFO] [stdout] --> src/runtime.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 75 | pub struct Runtime { [INFO] [stdout] | ------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 81 | pub path: PathBuf, [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.45s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "127f4a588d22a4828807d249c62b741635d94a27f6cd29e79fd6af5b473b073f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "127f4a588d22a4828807d249c62b741635d94a27f6cd29e79fd6af5b473b073f", kill_on_drop: false }` [INFO] [stdout] 127f4a588d22a4828807d249c62b741635d94a27f6cd29e79fd6af5b473b073f