[INFO] fetching crate smpp 0.1.2... [INFO] fixing smpp-0.1.2 against try#5fed607fb5806ae20927e7e9193e3793c411ac20+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817 [INFO] extracting crate smpp 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] started tweaking crates.io crate smpp 0.1.2 [INFO] finished tweaking crates.io crate smpp 0.1.2 [INFO] tweaked toml for crates.io crate smpp 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate smpp 0.1.2 on toolchain 5fed607fb5806ae20927e7e9193e3793c411ac20 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate smpp 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] a4c70a7ee03675d57e8fb65032b5a977b5f8c874746248ed1e1fbe83d3bf1288 [INFO] running `Command { std: "docker" "start" "a4c70a7ee03675d57e8fb65032b5a977b5f8c874746248ed1e1fbe83d3bf1288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "a4c70a7ee03675d57e8fb65032b5a977b5f8c874746248ed1e1fbe83d3bf1288" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a4c70a7ee03675d57e8fb65032b5a977b5f8c874746248ed1e1fbe83d3bf1288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "a4c70a7ee03675d57e8fb65032b5a977b5f8c874746248ed1e1fbe83d3bf1288" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2018 edition to 2021 [INFO] [stderr] note: Switching to Edition 2021 will enable the use of the version 2 feature resolver in Cargo. [INFO] [stderr] This may cause some dependencies to be built with fewer features enabled than previously. [INFO] [stderr] More information about the resolver changes may be found at https://doc.rust-lang.org/nightly/edition-guide/rust-2021/default-cargo-resolver.html [INFO] [stderr] When building the following dependencies, the given features will no longer be used: [INFO] [stderr] [INFO] [stderr] tokio v1.8.1 removed features: winapi [INFO] [stderr] [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling syn v1.0.73 [INFO] [stderr] Compiling libc v0.2.98 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Compiling futures-core v0.3.15 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling futures-task v0.3.15 [INFO] [stderr] Checking pin-project-lite v0.2.7 [INFO] [stderr] Compiling futures-channel v0.3.15 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Checking futures-sink v0.3.15 [INFO] [stderr] Checking instant v0.1.10 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking lock_api v0.4.4 [INFO] [stderr] Checking futures-io v0.3.15 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking slab v0.4.3 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling async-trait v0.1.50 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Compiling futures-macro v0.3.15 [INFO] [stderr] Compiling futures-util v0.3.15 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling tokio v1.8.1 [INFO] [stderr] Checking textwrap v0.12.1 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking os_str_bytes v2.4.0 [INFO] [stderr] Checking ascii v1.0.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking parking_lot_core v0.8.3 [INFO] [stderr] Checking mio v0.7.13 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking signal-hook-registry v1.4.0 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling tokio-macros v1.3.0 [INFO] [stderr] Compiling clap_derive v3.0.0-beta.2 [INFO] [stderr] Compiling num-derive v0.3.3 [INFO] [stderr] Checking clap v3.0.0-beta.2 [INFO] [stderr] Checking futures-executor v0.3.15 [INFO] [stderr] Checking futures v0.3.15 [INFO] [stderr] Checking smpp-pdu v0.1.4 [INFO] [stderr] Checking smpp v0.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2018 edition to 2021 [INFO] [stderr] Migrating src/bin/smsc.rs from 2018 edition to 2021 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 12.09s [INFO] [stderr] crater-edition-check: smpp v0.1.2 (/opt/rustwide/workdir) updating edition from 2018 to 2021 [INFO] [stderr] Compiling tokio v1.8.1 [INFO] [stderr] Checking smpp-pdu v0.1.4 [INFO] [stderr] Checking smpp v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `FailingRead` is never constructed [INFO] [stdout] --> src/unittest_utils.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct FailingRead {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `error` is never used [INFO] [stdout] --> src/unittest_utils.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl FailingRead { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 8 | fn error() -> io::Error { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 15.22s [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2018 edition to 2021 [INFO] [stderr] note: Switching to Edition 2021 will enable the use of the version 2 feature resolver in Cargo. [INFO] [stderr] This may cause some dependencies to be built with fewer features enabled than previously. [INFO] [stderr] More information about the resolver changes may be found at https://doc.rust-lang.org/nightly/edition-guide/rust-2021/default-cargo-resolver.html [INFO] [stderr] When building the following dependencies, the given features will no longer be used: [INFO] [stderr] [INFO] [stderr] tokio v1.8.1 removed features: winapi [INFO] [stderr] [INFO] [stderr] Checking smpp v0.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/smpp_connection.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:364:6 [INFO] [stdout] | [INFO] [stdout] 353 | let disconnect_guard = DisconnectGuard { [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | `disconnect_guard` calls a custom destructor [INFO] [stdout] | `disconnect_guard` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 365 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `disconnect_guard` invokes this custom destructor [INFO] [stdout] --> src/smsc/smsc.rs:338:5 [INFO] [stdout] | [INFO] [stdout] 338 | impl Drop for DisconnectGuard { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:462:52 [INFO] [stdout] | [INFO] [stdout] 459 | let mut logic = smsc_logic.lock().await; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `logic` calls a custom destructor [INFO] [stdout] | `logic` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | match logic.bind(body.bind_data()).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `logic` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/sync/mutex.rs:578:1 [INFO] [stdout] | [INFO] [stdout] 578 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:477:52 [INFO] [stdout] | [INFO] [stdout] 474 | let mut logic = smsc_logic.lock().await; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `logic` calls a custom destructor [INFO] [stdout] | `logic` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 477 | match logic.bind(body.bind_data()).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 487 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `logic` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/sync/mutex.rs:578:1 [INFO] [stdout] | [INFO] [stdout] 578 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:492:52 [INFO] [stdout] | [INFO] [stdout] 489 | let mut logic = smsc_logic.lock().await; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `logic` calls a custom destructor [INFO] [stdout] | `logic` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | match logic.bind(body.bind_data()).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 502 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `logic` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/sync/mutex.rs:578:1 [INFO] [stdout] | [INFO] [stdout] 578 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:197:15 [INFO] [stdout] | [INFO] [stdout] 197 | match listener.accept().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | / tokio::spawn(process_stream( [INFO] [stdout] 203 | | Arc::clone(&sem), [INFO] [stdout] 204 | | SmppConnection::new(tcp_stream, socket_addr), [INFO] [stdout] 205 | | config.clone(), [INFO] [stdout] 206 | | Arc::clone(&logic), [INFO] [stdout] 207 | | Arc::clone(&smsc), [INFO] [stdout] 208 | | )); [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |__________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/io/poll_evented.rs:203:1 [INFO] [stdout] | [INFO] [stdout] 203 | impl Drop for PollEvented { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/io/poll_evented.rs:203:1 [INFO] [stdout] | [INFO] [stdout] 203 | impl Drop for PollEvented { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/runtime/task/join.rs:241:1 [INFO] [stdout] | [INFO] [stdout] 241 | impl Drop for JoinHandle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:364:6 [INFO] [stdout] | [INFO] [stdout] 353 | let disconnect_guard = DisconnectGuard { [INFO] [stdout] | ---------------- [INFO] [stdout] | | [INFO] [stdout] | `disconnect_guard` calls a custom destructor [INFO] [stdout] | `disconnect_guard` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 364 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 365 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `disconnect_guard` invokes this custom destructor [INFO] [stdout] --> src/smsc/smsc.rs:338:5 [INFO] [stdout] | [INFO] [stdout] 338 | impl Drop for DisconnectGuard { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:462:52 [INFO] [stdout] | [INFO] [stdout] 459 | let mut logic = smsc_logic.lock().await; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `logic` calls a custom destructor [INFO] [stdout] | `logic` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 462 | match logic.bind(body.bind_data()).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 472 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `logic` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/sync/mutex.rs:578:1 [INFO] [stdout] | [INFO] [stdout] 578 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:477:52 [INFO] [stdout] | [INFO] [stdout] 474 | let mut logic = smsc_logic.lock().await; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `logic` calls a custom destructor [INFO] [stdout] | `logic` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 477 | match logic.bind(body.bind_data()).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 487 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `logic` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/sync/mutex.rs:578:1 [INFO] [stdout] | [INFO] [stdout] 578 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:492:52 [INFO] [stdout] | [INFO] [stdout] 489 | let mut logic = smsc_logic.lock().await; [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `logic` calls a custom destructor [INFO] [stdout] | `logic` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 492 | match logic.bind(body.bind_data()).await { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 502 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `logic` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/sync/mutex.rs:578:1 [INFO] [stdout] | [INFO] [stdout] 578 | impl Drop for MutexGuard<'_, T> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/smsc/smsc.rs:197:15 [INFO] [stdout] | [INFO] [stdout] 197 | match listener.accept().await { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `__awaitee` calls a custom destructor [INFO] [stdout] | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | / tokio::spawn(process_stream( [INFO] [stdout] 203 | | Arc::clone(&sem), [INFO] [stdout] 204 | | SmppConnection::new(tcp_stream, socket_addr), [INFO] [stdout] 205 | | config.clone(), [INFO] [stdout] 206 | | Arc::clone(&logic), [INFO] [stdout] 207 | | Arc::clone(&smsc), [INFO] [stdout] 208 | | )); [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |__________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/io/poll_evented.rs:203:1 [INFO] [stdout] | [INFO] [stdout] 203 | impl Drop for PollEvented { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/io/poll_evented.rs:203:1 [INFO] [stdout] | [INFO] [stdout] 203 | impl Drop for PollEvented { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/tokio-1.8.1/src/runtime/task/join.rs:241:1 [INFO] [stdout] | [INFO] [stdout] 241 | impl Drop for JoinHandle { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/bin/smsc.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.04s [INFO] [stderr] crater-edition-check: smpp v0.1.2 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking smpp v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `FailingRead` is never constructed [INFO] [stdout] --> src/unittest_utils.rs:5:12 [INFO] [stdout] | [INFO] [stdout] 5 | pub struct FailingRead {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `error` is never used [INFO] [stdout] --> src/unittest_utils.rs:8:8 [INFO] [stdout] | [INFO] [stdout] 7 | impl FailingRead { [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 8 | fn error() -> io::Error { [INFO] [stdout] | ^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.34s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "a4c70a7ee03675d57e8fb65032b5a977b5f8c874746248ed1e1fbe83d3bf1288", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a4c70a7ee03675d57e8fb65032b5a977b5f8c874746248ed1e1fbe83d3bf1288", kill_on_drop: false }` [INFO] [stdout] a4c70a7ee03675d57e8fb65032b5a977b5f8c874746248ed1e1fbe83d3bf1288