[INFO] fetching crate ray-tracer 0.1.0... [INFO] fixing ray-tracer-0.1.0 against try#5fed607fb5806ae20927e7e9193e3793c411ac20+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817 [INFO] extracting crate ray-tracer 0.1.0 into /workspace/builds/worker-6-tc2/source [INFO] started tweaking crates.io crate ray-tracer 0.1.0 [INFO] finished tweaking crates.io crate ray-tracer 0.1.0 [INFO] tweaked toml for crates.io crate ray-tracer 0.1.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate ray-tracer 0.1.0 on toolchain 5fed607fb5806ae20927e7e9193e3793c411ac20 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] [stderr] Adding rand v0.6.5 (available: v0.10.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] da974355a73a63c6cba60906581842a763fd13f37e7f2e5407f77962b2b66f8f [INFO] running `Command { std: "docker" "start" "da974355a73a63c6cba60906581842a763fd13f37e7f2e5407f77962b2b66f8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "da974355a73a63c6cba60906581842a763fd13f37e7f2e5407f77962b2b66f8f" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "da974355a73a63c6cba60906581842a763fd13f37e7f2e5407f77962b2b66f8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "da974355a73a63c6cba60906581842a763fd13f37e7f2e5407f77962b2b66f8f" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2018 edition to 2021 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking ray-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2018 edition to 2021 [INFO] [stderr] Fixed src/material/dielectric.rs (1 fix) [INFO] [stderr] Fixed src/actor/mod.rs (2 fixes) [INFO] [stderr] Fixed src/material/plain.rs (1 fix) [INFO] [stderr] Fixed src/texture/checker.rs (4 fixes) [INFO] [stderr] Fixed src/hitable/primitive/cube.rs (1 fix) [INFO] [stderr] Fixed src/material/lambertian.rs (1 fix) [INFO] [stderr] Fixed src/material/metal.rs (1 fix) [INFO] [stderr] Fixed src/renderer/mod.rs (3 fixes) [INFO] [stderr] Migrating tests/main.rs from 2018 edition to 2021 [INFO] [stderr] Fixed tests/main.rs (3 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.49s [INFO] [stderr] crater-edition-check: ray-tracer v0.1.0 (/opt/rustwide/workdir) updating edition from 2018 to 2021 [INFO] [stderr] Checking ray-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::ray::Ray` [INFO] [stdout] --> src/hit/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::ray::Ray; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::actor::Actor` [INFO] [stdout] --> src/hit/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::actor::Actor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/hitable/mod.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/hitable/primitive/cube.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::axis_to_index` [INFO] [stdout] --> src/hitable/primitive/cube.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::utils::axis_to_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/scene/mod.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | if (reflection < max_reflection) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - if (reflection < max_reflection) { [INFO] [stdout] 63 + if reflection < max_reflection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::u32` [INFO] [stdout] --> src/renderer/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::u32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/lambertian.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/metal.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/dielectric.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/tree/linear.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::boundingbox::BoundingBox` [INFO] [stdout] --> src/tree/linear.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::boundingbox::BoundingBox; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::ray::Ray` [INFO] [stdout] --> src/hit/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::ray::Ray; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::actor::Actor` [INFO] [stdout] --> src/hit/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::actor::Actor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/hitable/mod.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/hitable/primitive/cube.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::axis_to_index` [INFO] [stdout] --> src/hitable/primitive/cube.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::utils::axis_to_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/scene/mod.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | if (reflection < max_reflection) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - if (reflection < max_reflection) { [INFO] [stdout] 63 + if reflection < max_reflection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::u32` [INFO] [stdout] --> src/renderer/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::u32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/lambertian.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/metal.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/dielectric.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/tree/linear.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::boundingbox::BoundingBox` [INFO] [stdout] --> src/tree/linear.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::boundingbox::BoundingBox; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::hitable::Hitable` [INFO] [stdout] --> src/renderer/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::hitable::Hitable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `two` [INFO] [stdout] --> src/renderer/mod.rs:100:70 [INFO] [stdout] | [INFO] [stdout] 100 | fn get_ray(&self, i: usize, j: usize, camera: &dyn Camera, two: T) -> Ray [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_two` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `incident` [INFO] [stdout] --> src/material/lambertian.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | fn scatter(&self, incident: &Ray, hit: &Hit) -> Scatter { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_incident` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `two` [INFO] [stdout] --> src/texture/checker.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let two = T::from(2.0).unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width` and `height` are never read [INFO] [stdout] --> src/hitable/primitive/rectangle.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Rectangle [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | width: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 14 | width_axis: Axis, [INFO] [stdout] 15 | height: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `length`, `width`, and `height` are never read [INFO] [stdout] --> src/hitable/primitive/cube.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Cube [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | length: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 17 | width: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 18 | height: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::hitable::Hitable` [INFO] [stdout] --> src/renderer/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::hitable::Hitable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hit` [INFO] [stdout] --> src/hitable/primitive/sphere.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 146 | Some(hit) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_hit` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hit` [INFO] [stdout] --> src/hitable/primitive/sphere.rs:157:18 [INFO] [stdout] | [INFO] [stdout] 157 | Some(hit) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_hit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hit` [INFO] [stdout] --> src/hitable/primitive/rectangle.rs:206:21 [INFO] [stdout] | [INFO] [stdout] 206 | if let Some(hit) = rectangle.hit(&ray, 0.0, 100.0) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_hit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cube` [INFO] [stdout] --> src/hitable/primitive/cube.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | let cube = Cube::::new(length, width, height); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cube` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `width_axis` [INFO] [stdout] --> tests/main.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | let width_axis = Axis::X; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_width_axis` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `height_axis` [INFO] [stdout] --> tests/main.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | let height_axis = Axis::Y; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_height_axis` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `actor` [INFO] [stdout] --> tests/main.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | let actor = Actor:: { hitable: rectangle, material}; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_actor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hitable` [INFO] [stdout] --> tests/main.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | let hitable = Box::new(Translation::new(hitable, Vec3::from_array([0.0, width / 2.0, 0.0]))); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hitable` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ray` [INFO] [stdout] --> src/camera/perspective.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | let ray = camera.get_ray(-1.0, 0.0); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ray` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MULT` is never used [INFO] [stdout] --> tests/main.rs:29:7 [INFO] [stdout] | [INFO] [stdout] 29 | const MULT : usize = 40; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SAMPLING` is never used [INFO] [stdout] --> tests/main.rs:30:7 [INFO] [stdout] | [INFO] [stdout] 30 | const SAMPLING : usize = 4; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `REFLECTIONS` is never used [INFO] [stdout] --> tests/main.rs:31:7 [INFO] [stdout] | [INFO] [stdout] 31 | const REFLECTIONS : usize = 8; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `two` [INFO] [stdout] --> src/renderer/mod.rs:100:70 [INFO] [stdout] | [INFO] [stdout] 100 | fn get_ray(&self, i: usize, j: usize, camera: &dyn Camera, two: T) -> Ray [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `incident` [INFO] [stdout] --> src/material/lambertian.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | fn scatter(&self, incident: &Ray, hit: &Hit) -> Scatter { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_incident` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/boundingbox/mod.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | let mut direction = Vec3::new(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/boundingbox/mod.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | let mut direction = Vec3::new(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `two` [INFO] [stdout] --> src/texture/checker.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let two = T::from(2.0).unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width` and `height` are never read [INFO] [stdout] --> src/hitable/primitive/rectangle.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Rectangle [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | width: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 14 | width_axis: Axis, [INFO] [stdout] 15 | height: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `length`, `width`, and `height` are never read [INFO] [stdout] --> src/hitable/primitive/cube.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Cube [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | length: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 17 | width: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 18 | height: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.01s [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2018 edition to 2021 [INFO] [stderr] Checking ray-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tree/oct.rs:116:45 [INFO] [stdout] | [INFO] [stdout] 105 | let mut result : Option<(Rc>, Hit)> = None; [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | if let Some((actor, hit)) = child.get_hit(ray, t_min, t_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `result` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tree/binary.rs:132:45 [INFO] [stdout] | [INFO] [stdout] 121 | let mut result : Option<(Rc>, Hit)> = None; [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | if let Some((actor, hit)) = child.get_hit(ray, t_min, t_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `result` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tree/oct.rs:116:45 [INFO] [stdout] | [INFO] [stdout] 105 | let mut result : Option<(Rc>, Hit)> = None; [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 116 | if let Some((actor, hit)) = child.get_hit(ray, t_min, t_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `result` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/tree/binary.rs:132:45 [INFO] [stdout] | [INFO] [stdout] 121 | let mut result : Option<(Rc>, Hit)> = None; [INFO] [stdout] | ---------- [INFO] [stdout] | | [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 132 | if let Some((actor, hit)) = child.get_hit(ray, t_min, t_max) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `result` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/main.rs from 2021 edition to 2024 [INFO] [stderr] Fixed tests/main.rs (17 fixes) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.41s [INFO] [stderr] crater-edition-check: ray-tracer v0.1.0 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking ray-tracer v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `crate::ray::Ray` [INFO] [stdout] --> src/hit/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::ray::Ray; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::actor::Actor` [INFO] [stdout] --> src/hit/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::actor::Actor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/hitable/mod.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/hitable/primitive/cube.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::axis_to_index` [INFO] [stdout] --> src/hitable/primitive/cube.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::utils::axis_to_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/scene/mod.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | if (reflection < max_reflection) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - if (reflection < max_reflection) { [INFO] [stdout] 63 + if reflection < max_reflection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::u32` [INFO] [stdout] --> src/renderer/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::u32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/lambertian.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/metal.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/dielectric.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/tree/linear.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::boundingbox::BoundingBox` [INFO] [stdout] --> src/tree/linear.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::boundingbox::BoundingBox; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::ray::Ray` [INFO] [stdout] --> src/hit/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::ray::Ray; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::actor::Actor` [INFO] [stdout] --> src/hit/mod.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::actor::Actor; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/hitable/mod.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/hitable/primitive/cube.rs:2:5 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::utils::axis_to_index` [INFO] [stdout] --> src/hitable/primitive/cube.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | use crate::utils::axis_to_index; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/scene/mod.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 63 | if (reflection < max_reflection) { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 63 - if (reflection < max_reflection) { [INFO] [stdout] 63 + if reflection < max_reflection { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::u32` [INFO] [stdout] --> src/renderer/mod.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use std::u32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/lambertian.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/metal.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/material/dielectric.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::vector::Vec3` [INFO] [stdout] --> src/tree/linear.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::vector::Vec3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::boundingbox::BoundingBox` [INFO] [stdout] --> src/tree/linear.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 7 | use crate::boundingbox::BoundingBox; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::hitable::Hitable` [INFO] [stdout] --> src/renderer/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::hitable::Hitable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `two` [INFO] [stdout] --> src/renderer/mod.rs:100:70 [INFO] [stdout] | [INFO] [stdout] 100 | fn get_ray(&self, i: usize, j: usize, camera: &dyn Camera, two: T) -> Ray [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_two` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `incident` [INFO] [stdout] --> src/material/lambertian.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | fn scatter(&self, incident: &Ray, hit: &Hit) -> Scatter { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_incident` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `two` [INFO] [stdout] --> src/texture/checker.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let two = T::from(2.0).unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width` and `height` are never read [INFO] [stdout] --> src/hitable/primitive/rectangle.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Rectangle [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | width: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 14 | width_axis: Axis, [INFO] [stdout] 15 | height: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `length`, `width`, and `height` are never read [INFO] [stdout] --> src/hitable/primitive/cube.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Cube [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | length: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 17 | width: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 18 | height: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::hitable::Hitable` [INFO] [stdout] --> src/renderer/mod.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use crate::hitable::Hitable; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hit` [INFO] [stdout] --> src/hitable/primitive/sphere.rs:146:18 [INFO] [stdout] | [INFO] [stdout] 146 | Some(hit) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_hit` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hit` [INFO] [stdout] --> src/hitable/primitive/sphere.rs:157:18 [INFO] [stdout] | [INFO] [stdout] 157 | Some(hit) => { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_hit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hit` [INFO] [stdout] --> src/hitable/primitive/rectangle.rs:206:21 [INFO] [stdout] | [INFO] [stdout] 206 | if let Some(hit) = rectangle.hit(&ray, 0.0, 100.0) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_hit` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cube` [INFO] [stdout] --> src/hitable/primitive/cube.rs:90:13 [INFO] [stdout] | [INFO] [stdout] 90 | let cube = Cube::::new(length, width, height); [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_cube` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ray` [INFO] [stdout] --> src/camera/perspective.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | let ray = camera.get_ray(-1.0, 0.0); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ray` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `two` [INFO] [stdout] --> src/renderer/mod.rs:100:70 [INFO] [stdout] | [INFO] [stdout] 100 | fn get_ray(&self, i: usize, j: usize, camera: &dyn Camera, two: T) -> Ray [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `incident` [INFO] [stdout] --> src/material/lambertian.rs:32:23 [INFO] [stdout] | [INFO] [stdout] 32 | fn scatter(&self, incident: &Ray, hit: &Hit) -> Scatter { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_incident` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/boundingbox/mod.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | let mut direction = Vec3::new(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/boundingbox/mod.rs:247:17 [INFO] [stdout] | [INFO] [stdout] 247 | let mut direction = Vec3::new(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `two` [INFO] [stdout] --> src/texture/checker.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | let two = T::from(2.0).unwrap(); [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_two` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `width` and `height` are never read [INFO] [stdout] --> src/hitable/primitive/rectangle.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct Rectangle [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 13 | width: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 14 | width_axis: Axis, [INFO] [stdout] 15 | height: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `length`, `width`, and `height` are never read [INFO] [stdout] --> src/hitable/primitive/cube.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 13 | pub struct Cube [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 16 | length: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 17 | width: T, [INFO] [stdout] | ^^^^^ [INFO] [stdout] 18 | height: T, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `width_axis` [INFO] [stdout] --> tests/main.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | let width_axis = Axis::X; [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_width_axis` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `height_axis` [INFO] [stdout] --> tests/main.rs:103:9 [INFO] [stdout] | [INFO] [stdout] 103 | let height_axis = Axis::Y; [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_height_axis` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `actor` [INFO] [stdout] --> tests/main.rs:142:9 [INFO] [stdout] | [INFO] [stdout] 142 | let actor = Actor:: { hitable: rectangle, material}; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_actor` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `hitable` [INFO] [stdout] --> tests/main.rs:203:9 [INFO] [stdout] | [INFO] [stdout] 203 | let hitable = Box::new(Translation::new(hitable, Vec3::from_array([0.0, width / 2.0, 0.0]))); [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_hitable` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `MULT` is never used [INFO] [stdout] --> tests/main.rs:29:7 [INFO] [stdout] | [INFO] [stdout] 29 | const MULT : usize = 40; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `SAMPLING` is never used [INFO] [stdout] --> tests/main.rs:30:7 [INFO] [stdout] | [INFO] [stdout] 30 | const SAMPLING : usize = 4; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `REFLECTIONS` is never used [INFO] [stdout] --> tests/main.rs:31:7 [INFO] [stdout] | [INFO] [stdout] 31 | const REFLECTIONS : usize = 8; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.92s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "da974355a73a63c6cba60906581842a763fd13f37e7f2e5407f77962b2b66f8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da974355a73a63c6cba60906581842a763fd13f37e7f2e5407f77962b2b66f8f", kill_on_drop: false }` [INFO] [stdout] da974355a73a63c6cba60906581842a763fd13f37e7f2e5407f77962b2b66f8f