[INFO] fetching crate nautilus-sockets 0.1.1... [INFO] fixing nautilus-sockets-0.1.1 against try#5fed607fb5806ae20927e7e9193e3793c411ac20+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817 [INFO] extracting crate nautilus-sockets 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] started tweaking crates.io crate nautilus-sockets 0.1.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate nautilus-sockets 0.1.1 [INFO] tweaked toml for crates.io crate nautilus-sockets 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate nautilus-sockets 0.1.1 on toolchain 5fed607fb5806ae20927e7e9193e3793c411ac20 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate nautilus-sockets 0.1.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 9ee091f35aa3cb653eff797f702b415548405bc14395df2b9c22234aea67fe42 [INFO] running `Command { std: "docker" "start" "9ee091f35aa3cb653eff797f702b415548405bc14395df2b9c22234aea67fe42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "9ee091f35aa3cb653eff797f702b415548405bc14395df2b9c22234aea67fe42" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9ee091f35aa3cb653eff797f702b415548405bc14395df2b9c22234aea67fe42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "9ee091f35aa3cb653eff797f702b415548405bc14395df2b9c22234aea67fe42" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling anyhow v1.0.93 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking nautilus-sockets v0.1.1 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/client/mod.rs:162:33 [INFO] [stdout] | [INFO] [stdout] 137 | >::into_packet_delivery(delivery_type) [INFO] [stdout] | -------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let Ok(event) = Self::get_event_from_packet(&packet) else { [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | if let Err(e) = self.send_ack_packet(addr, &packet) { [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `e` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/mod.rs:238:33 [INFO] [stdout] | [INFO] [stdout] 213 | >::into_packet_delivery(delivery_type) [INFO] [stdout] | -------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | if let Err(e) = self.send_ack_packet(addr, &packet) { [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 243 | [INFO] [stdout] 244 | let Ok(event) = Self::get_event_from_packet(&packet) else { [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `e` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/client/mod.rs:162:33 [INFO] [stdout] | [INFO] [stdout] 137 | >::into_packet_delivery(delivery_type) [INFO] [stdout] | -------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | let Ok(event) = Self::get_event_from_packet(&packet) else { [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 162 | if let Err(e) = self.send_ack_packet(addr, &packet) { [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `e` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/server/mod.rs:238:33 [INFO] [stdout] | [INFO] [stdout] 213 | >::into_packet_delivery(delivery_type) [INFO] [stdout] | -------------------------------------------------------------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | if let Err(e) = self.send_ack_packet(addr, &packet) { [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 242 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 243 | [INFO] [stdout] 244 | let Ok(event) = Self::get_event_from_packet(&packet) else { [INFO] [stdout] | ------------------------------------ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `e` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.93/src/error.rs:597:1 [INFO] [stdout] | [INFO] [stdout] 597 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/chat/chat_client.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/godot/godot_server.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/chat/chat_server.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.63s [INFO] [stderr] crater-edition-check: nautilus-sockets v0.1.1 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking nautilus-sockets v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Any` [INFO] [stdout] --> src/persistent/storage.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | any::{Any, TypeId}, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Any` [INFO] [stdout] --> src/persistent/storage.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | any::{Any, TypeId}, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.17s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "9ee091f35aa3cb653eff797f702b415548405bc14395df2b9c22234aea67fe42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9ee091f35aa3cb653eff797f702b415548405bc14395df2b9c22234aea67fe42", kill_on_drop: false }` [INFO] [stdout] 9ee091f35aa3cb653eff797f702b415548405bc14395df2b9c22234aea67fe42