[INFO] fetching crate laser-dac 0.12.4... [INFO] fixing laser-dac-0.12.4 against try#5fed607fb5806ae20927e7e9193e3793c411ac20+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817 [INFO] extracting crate laser-dac 0.12.4 into /workspace/builds/worker-6-tc2/source [INFO] started tweaking crates.io crate laser-dac 0.12.4 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate laser-dac 0.12.4 [INFO] tweaked toml for crates.io crate laser-dac 0.12.4 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate laser-dac 0.12.4 on toolchain 5fed607fb5806ae20927e7e9193e3793c411ac20 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate laser-dac 0.12.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] e01364a343019b6c31e6d631cfbc945ae441baee0ac1200fb2dd31588a7863bb [INFO] running `Command { std: "docker" "start" "e01364a343019b6c31e6d631cfbc945ae441baee0ac1200fb2dd31588a7863bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e01364a343019b6c31e6d631cfbc945ae441baee0ac1200fb2dd31588a7863bb" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e01364a343019b6c31e6d631cfbc945ae441baee0ac1200fb2dd31588a7863bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e01364a343019b6c31e6d631cfbc945ae441baee0ac1200fb2dd31588a7863bb" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.178 [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Compiling unicode-ident v1.0.22 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling find-msvc-tools v0.1.5 [INFO] [stderr] Checking memchr v2.7.6 [INFO] [stderr] Checking bitflags v2.10.0 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Checking regex-syntax v0.8.8 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling nix v0.30.1 [INFO] [stderr] Compiling rusb v0.9.4 [INFO] [stderr] Compiling cc v1.2.49 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Compiling zmij v1.0.10 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Compiling cpal v0.15.3 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking clap_lex v0.7.6 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking dasp_sample v0.11.0 [INFO] [stderr] Compiling serde_json v1.0.148 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking clap_builder v4.5.53 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking jiff v0.2.17 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Compiling alsa-sys v0.3.1 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling libusb1-sys v0.7.0 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking if-addrs v0.15.0 [INFO] [stderr] Checking alsa v0.9.1 [INFO] [stderr] Checking ctrlc v3.5.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking env_filter v0.1.4 [INFO] [stderr] Checking env_logger v0.11.8 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking laser-dac v0.12.4 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Fixed src/presentation/session.rs (1 fix) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/protocols/lasercube_network/transport/worker.rs:153:19 [INFO] [stdout] | [INFO] [stdout] 153 | match rx.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | _reservation, [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | `_reservation` calls a custom destructor [INFO] [stdout] | `_reservation` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/protocols/lasercube_network/transport/state.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | impl Drop for HostQueueReservation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `_reservation` invokes this custom destructor [INFO] [stdout] --> src/protocols/lasercube_network/transport/state.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | impl Drop for HostQueueReservation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/protocols/avb/backend.rs:333:15 [INFO] [stdout] | [INFO] [stdout] 311 | let runtime = Arc::new(RuntimeState::new( [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `runtime` calls a custom destructor [INFO] [stdout] | `runtime` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | let (stop_tx, stop_rx) = mpsc::channel(); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `stop_tx` calls a custom destructor [INFO] [stdout] | `stop_tx` will be dropped later as of Edition 2024 [INFO] [stdout] 320 | let (init_tx, init_rx) = mpsc::channel(); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `init_rx` calls a custom destructor [INFO] [stdout] | `init_rx` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | match init_rx.recv_timeout(Duration::from_secs(5)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `runtime` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/crossbeam-queue-0.3.12/src/array_queue.rs:448:1 [INFO] [stdout] | [INFO] [stdout] 448 | impl Drop for ArrayQueue { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `stop_tx` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/mpmc/mod.rs:657:0 [INFO] [stdout] note: `init_rx` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/mpmc/mod.rs:1411:0 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/reconnect.rs:174:19 [INFO] [stdout] | [INFO] [stdout] 149 | let device = match policy.target.open_device() { [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 150 | Ok(d) => d, [INFO] [stdout] 151 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | let mut backend = match device.into_backend() { [INFO] [stdout] | ----------- --------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | `backend` calls a custom destructor [INFO] [stdout] | `backend` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | match backend.connect() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 175 | Ok(()) => {} [INFO] [stdout] 176 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `err` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `backend` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/protocols/lasercube_network/transport/worker.rs:153:19 [INFO] [stdout] | [INFO] [stdout] 153 | match rx.try_recv() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 158 | _reservation, [INFO] [stdout] | ------------ [INFO] [stdout] | | [INFO] [stdout] | `_reservation` calls a custom destructor [INFO] [stdout] | `_reservation` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 178 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> src/protocols/lasercube_network/transport/state.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | impl Drop for HostQueueReservation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `_reservation` invokes this custom destructor [INFO] [stdout] --> src/protocols/lasercube_network/transport/state.rs:58:1 [INFO] [stdout] | [INFO] [stdout] 58 | impl Drop for HostQueueReservation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/bench_transition.rs from 2021 edition to 2024 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/protocols/avb/backend.rs:333:15 [INFO] [stdout] | [INFO] [stdout] 311 | let runtime = Arc::new(RuntimeState::new( [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `runtime` calls a custom destructor [INFO] [stdout] | `runtime` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 319 | let (stop_tx, stop_rx) = mpsc::channel(); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `stop_tx` calls a custom destructor [INFO] [stdout] | `stop_tx` will be dropped later as of Edition 2024 [INFO] [stdout] 320 | let (init_tx, init_rx) = mpsc::channel(); [INFO] [stdout] | ------- [INFO] [stdout] | | [INFO] [stdout] | `init_rx` calls a custom destructor [INFO] [stdout] | `init_rx` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | match init_rx.recv_timeout(Duration::from_secs(5)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `runtime` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/crossbeam-queue-0.3.12/src/array_queue.rs:448:1 [INFO] [stdout] | [INFO] [stdout] 448 | impl Drop for ArrayQueue { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `stop_tx` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/mpmc/mod.rs:657:0 [INFO] [stdout] note: `init_rx` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/mpmc/mod.rs:1411:0 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/reconnect.rs:174:19 [INFO] [stdout] | [INFO] [stdout] 149 | let device = match policy.target.open_device() { [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] 150 | Ok(d) => d, [INFO] [stdout] 151 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 163 | let mut backend = match device.into_backend() { [INFO] [stdout] | ----------- --------------------- [INFO] [stdout] | | | [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | `backend` calls a custom destructor [INFO] [stdout] | `backend` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 174 | match backend.connect() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 175 | Ok(()) => {} [INFO] [stdout] 176 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#4` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `err` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `backend` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/stream/mod.rs:959:31 [INFO] [stdout] | [INFO] [stdout] 953 | self.handle_underrun(&req)?; [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 959 | match self.write_fill_points(n, &mut on_error) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 960 | Ok(()) => {} [INFO] [stdout] 961 | Err(e) if e.is_disconnected() && self.reconnect_policy.is_some() => { [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 972 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 975 | self.handle_underrun(&req)?; [INFO] [stdout] | --------------------------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating examples/stream.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/idn_e2e.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/transitions.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/audio.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/avb_file.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/reconnect.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/scope_xy.rs from 2021 edition to 2024 [INFO] [stderr] Migrating examples/frame.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.57s [INFO] [stderr] crater-edition-check: laser-dac v0.12.4 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking laser-dac v0.12.4 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 24.77s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "e01364a343019b6c31e6d631cfbc945ae441baee0ac1200fb2dd31588a7863bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e01364a343019b6c31e6d631cfbc945ae441baee0ac1200fb2dd31588a7863bb", kill_on_drop: false }` [INFO] [stdout] e01364a343019b6c31e6d631cfbc945ae441baee0ac1200fb2dd31588a7863bb