[INFO] fetching crate dbsdk-rs 0.1.19... [INFO] fixing dbsdk-rs-0.1.19 against try#5fed607fb5806ae20927e7e9193e3793c411ac20+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817 [INFO] extracting crate dbsdk-rs 0.1.19 into /workspace/builds/worker-6-tc2/source [INFO] started tweaking crates.io crate dbsdk-rs 0.1.19 [INFO] finished tweaking crates.io crate dbsdk-rs 0.1.19 [INFO] tweaked toml for crates.io crate dbsdk-rs 0.1.19 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate dbsdk-rs 0.1.19 on toolchain 5fed607fb5806ae20927e7e9193e3793c411ac20 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate dbsdk-rs 0.1.19 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] a313b950c634ce41ceae84d37870d2a43df281ddb4790eaa3090af6f83421f95 [INFO] running `Command { std: "docker" "start" "a313b950c634ce41ceae84d37870d2a43df281ddb4790eaa3090af6f83421f95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "a313b950c634ce41ceae84d37870d2a43df281ddb4790eaa3090af6f83421f95" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a313b950c634ce41ceae84d37870d2a43df281ddb4790eaa3090af6f83421f95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "a313b950c634ce41ceae84d37870d2a43df281ddb4790eaa3090af6f83421f95" "/opt/rustwide/cargo-home/bin/cargo" "+5fed607fb5806ae20927e7e9193e3793c411ac20" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Compiling unicode-ident v1.0.4 [INFO] [stderr] Compiling syn v1.0.100 [INFO] [stderr] Compiling thiserror v1.0.35 [INFO] [stderr] Compiling ucd-trie v0.1.5 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking bitmask v0.5.0 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Compiling thiserror-impl v1.0.35 [INFO] [stderr] Compiling dbsdk-vu-asm v0.1.0 [INFO] [stderr] Compiling pest v2.3.1 [INFO] [stderr] Compiling semver-parser v0.10.2 [INFO] [stderr] Compiling semver v0.11.0 [INFO] [stderr] Compiling rustc_version v0.3.3 [INFO] [stderr] Compiling field-offset v0.3.4 [INFO] [stderr] Checking dbsdk-rs v0.1.19 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/vdp.rs (1 fix) [INFO] [stderr] Fixed src/db_internal.rs (4 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/sounddriver.rs:280:17 [INFO] [stdout] | [INFO] [stdout] 280 | emitter_rc.read().unwrap().voice [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 281 | }; [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 282 | { [INFO] [stdout] 283 | let mut emref = emitter_rc.write().unwrap(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `emref` calls a custom destructor [INFO] [stdout] | `emref` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | let mut emref = emitter_rc.write().unwrap(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/poison/rwlock.rs:1118:0 [INFO] [stdout] note: `emref` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/poison/rwlock.rs:1128:0 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/poison/rwlock.rs:1128:0 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/sounddriver.rs:280:17 [INFO] [stdout] | [INFO] [stdout] 280 | emitter_rc.read().unwrap().voice [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] 281 | }; [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] 282 | { [INFO] [stdout] 283 | let mut emref = emitter_rc.write().unwrap(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | `emref` calls a custom destructor [INFO] [stdout] | `emref` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 296 | let mut emref = emitter_rc.write().unwrap(); [INFO] [stdout] | --------- [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/poison/rwlock.rs:1118:0 [INFO] [stdout] note: `emref` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/poison/rwlock.rs:1128:0 [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /rustc/5fed607fb5806ae20927e7e9193e3793c411ac20/library/std/src/sync/poison/rwlock.rs:1128:0 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.73s [INFO] [stderr] crater-edition-check: dbsdk-rs v0.1.19 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking dbsdk-rs v0.1.19 (/opt/rustwide/workdir) [INFO] [stdout] warning: `extern` declarations without an explicit ABI are deprecated [INFO] [stdout] --> src/db_internal.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | unsafe extern { [INFO] [stdout] | ^^^^^^ help: explicitly specify the "C" ABI: `extern "C"` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(missing_abi)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `extern` declarations without an explicit ABI are deprecated [INFO] [stdout] --> src/db_internal.rs:22:8 [INFO] [stdout] | [INFO] [stdout] 22 | unsafe extern { [INFO] [stdout] | ^^^^^^ help: explicitly specify the "C" ABI: `extern "C"` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(missing_abi)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.09s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "a313b950c634ce41ceae84d37870d2a43df281ddb4790eaa3090af6f83421f95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a313b950c634ce41ceae84d37870d2a43df281ddb4790eaa3090af6f83421f95", kill_on_drop: false }` [INFO] [stdout] a313b950c634ce41ceae84d37870d2a43df281ddb4790eaa3090af6f83421f95