[INFO] cloning repository https://github.com/norcalli/kgit-split [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/norcalli/kgit-split" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnorcalli%2Fkgit-split", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnorcalli%2Fkgit-split'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8bed58e887542f859d302270cef2a26ffd049467 [INFO] fixing norcalli/kgit-split against try#622891a4e29178280638a6b63a8908bde2c0c854+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fnorcalli%2Fkgit-split" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/norcalli/kgit-split [INFO] finished tweaking git repo https://github.com/norcalli/kgit-split [INFO] tweaked toml for git repo https://github.com/norcalli/kgit-split written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/norcalli/kgit-split on toolchain 622891a4e29178280638a6b63a8908bde2c0c854 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/norcalli/kgit-split already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3a6becf2bc8dde7f3fa57ede90e4f284e72d296796fc446bbb1e2c7cc0530151" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 0939b67baa33c09b3375390be74cd7380744410a316dcf69d220f2592af0225f [INFO] running `Command { std: "docker" "start" "0939b67baa33c09b3375390be74cd7380744410a316dcf69d220f2592af0225f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "0939b67baa33c09b3375390be74cd7380744410a316dcf69d220f2592af0225f" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0939b67baa33c09b3375390be74cd7380744410a316dcf69d220f2592af0225f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "0939b67baa33c09b3375390be74cd7380744410a316dcf69d220f2592af0225f" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Checking regex-syntax v0.6.26 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling once_cell v1.12.0 [INFO] [stderr] Compiling meowhash v0.3.0 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling aho-corasick v0.7.18 [INFO] [stderr] Checking termcolor v1.1.3 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking numtoa v0.1.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking termion v1.5.6 [INFO] [stderr] Checking itertools v0.10.3 [INFO] [stderr] Checking bpaf v0.4.4 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking regex v1.5.6 [INFO] [stderr] Checking env_logger v0.9.0 [INFO] [stderr] Compiling structmeta-derive v0.1.5 [INFO] [stderr] Compiling structmeta v0.1.5 [INFO] [stderr] Compiling parse-display-derive v0.5.5 [INFO] [stderr] Checking parse-display v0.5.5 [INFO] [stderr] Checking kgit-split v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Fixed src/main.rs (5 fixes) [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:655:62 [INFO] [stdout] | [INFO] [stdout] 619 | / render_hunk( [INFO] [stdout] 620 | | hunk, [INFO] [stdout] 621 | | (terminal_height as usize) [INFO] [stdout] 622 | | .saturating_sub(ui_state.messages.len() + 5) [INFO] [stdout] 623 | | ) [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 628 | for c in draw_buffer.drain(..) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | `iter` calls a custom destructor [INFO] [stdout] | `iter` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 655 | if let Ok(new_message) = edit(message) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 673 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 738 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 762 | let _ = spawn_with_input( [INFO] [stdout] | _____________________________________________- [INFO] [stdout] | |_____________________________________________| [INFO] [stdout] 763 | &mut sh(pager [INFO] [stdout] | ______________________________________________- [INFO] [stdout] | ______________________________________________| [INFO] [stdout] | | [INFO] [stdout] 764 | | .as_ref() [INFO] [stdout] 765 | | .map(|s| s.as_str()) [INFO] [stdout] 766 | | .unwrap_or_else(|| "less")), [INFO] [stdout] | | - [INFO] [stdout] | |_______________________________________________________________________| [INFO] [stdout] | |_______________________________________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 782 | | Ok(()) [INFO] [stdout] 783 | | }); [INFO] [stdout] | | - [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `iter` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/alloc/src/string.rs:3528:0 [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0 [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sys/process/unix/common/cstring_array.rs:79:0 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:733:47 [INFO] [stdout] | [INFO] [stdout] 733 | ... match edit(hunk_body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 738 | ... Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 743 | ... }; [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:733:47 [INFO] [stdout] | [INFO] [stdout] 619 | / render_hunk( [INFO] [stdout] 620 | | hunk, [INFO] [stdout] 621 | | (terminal_height as usize) [INFO] [stdout] 622 | | .saturating_sub(ui_state.messages.len() + 5) [INFO] [stdout] 623 | | ) [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 628 | for c in draw_buffer.drain(..) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | `iter` calls a custom destructor [INFO] [stdout] | `iter` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 733 | match edit(hunk_body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 738 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 743 | }; [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 762 | let _ = spawn_with_input( [INFO] [stdout] | _____________________________________________- [INFO] [stdout] | |_____________________________________________| [INFO] [stdout] 763 | &mut sh(pager [INFO] [stdout] | ______________________________________________- [INFO] [stdout] | ______________________________________________| [INFO] [stdout] | | [INFO] [stdout] 764 | | .as_ref() [INFO] [stdout] 765 | | .map(|s| s.as_str()) [INFO] [stdout] 766 | | .unwrap_or_else(|| "less")), [INFO] [stdout] | | - [INFO] [stdout] | |_______________________________________________________________________| [INFO] [stdout] | |_______________________________________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 782 | | Ok(()) [INFO] [stdout] 783 | | }); [INFO] [stdout] | | - [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `iter` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/alloc/src/string.rs:3528:0 [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0 [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sys/process/unix/common/cstring_array.rs:79:0 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:655:62 [INFO] [stdout] | [INFO] [stdout] 619 | / render_hunk( [INFO] [stdout] 620 | | hunk, [INFO] [stdout] 621 | | (terminal_height as usize) [INFO] [stdout] 622 | | .saturating_sub(ui_state.messages.len() + 5) [INFO] [stdout] 623 | | ) [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 628 | for c in draw_buffer.drain(..) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | `iter` calls a custom destructor [INFO] [stdout] | `iter` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 655 | if let Ok(new_message) = edit(message) { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 673 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 738 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 762 | let _ = spawn_with_input( [INFO] [stdout] | _____________________________________________- [INFO] [stdout] | |_____________________________________________| [INFO] [stdout] 763 | &mut sh(pager [INFO] [stdout] | ______________________________________________- [INFO] [stdout] | ______________________________________________| [INFO] [stdout] | | [INFO] [stdout] 764 | | .as_ref() [INFO] [stdout] 765 | | .map(|s| s.as_str()) [INFO] [stdout] 766 | | .unwrap_or_else(|| "less")), [INFO] [stdout] | | - [INFO] [stdout] | |_______________________________________________________________________| [INFO] [stdout] | |_______________________________________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 782 | | Ok(()) [INFO] [stdout] 783 | | }); [INFO] [stdout] | | - [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `iter` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/alloc/src/string.rs:3528:0 [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0 [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sys/process/unix/common/cstring_array.rs:79:0 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:733:47 [INFO] [stdout] | [INFO] [stdout] 733 | ... match edit(hunk_body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 738 | ... Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 743 | ... }; [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] note: `#1` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/main.rs:733:47 [INFO] [stdout] | [INFO] [stdout] 619 | / render_hunk( [INFO] [stdout] 620 | | hunk, [INFO] [stdout] 621 | | (terminal_height as usize) [INFO] [stdout] 622 | | .saturating_sub(ui_state.messages.len() + 5) [INFO] [stdout] 623 | | ) [INFO] [stdout] | | - [INFO] [stdout] | | | [INFO] [stdout] | |_____________________________________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 628 | for c in draw_buffer.drain(..) { [INFO] [stdout] | --------------------- [INFO] [stdout] | | [INFO] [stdout] | `iter` calls a custom destructor [INFO] [stdout] | `iter` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 733 | match edit(hunk_body) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#4` [INFO] [stdout] | up until Edition 2021 `#4` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 738 | Err(err) => { [INFO] [stdout] | --- [INFO] [stdout] | | [INFO] [stdout] | `err` calls a custom destructor [INFO] [stdout] | `err` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 743 | }; [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] ... [INFO] [stdout] 762 | let _ = spawn_with_input( [INFO] [stdout] | _____________________________________________- [INFO] [stdout] | |_____________________________________________| [INFO] [stdout] 763 | &mut sh(pager [INFO] [stdout] | ______________________________________________- [INFO] [stdout] | ______________________________________________| [INFO] [stdout] | | [INFO] [stdout] 764 | | .as_ref() [INFO] [stdout] 765 | | .map(|s| s.as_str()) [INFO] [stdout] 766 | | .unwrap_or_else(|| "less")), [INFO] [stdout] | | - [INFO] [stdout] | |_______________________________________________________________________| [INFO] [stdout] | |_______________________________________________________________________this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | `#3` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 782 | | Ok(()) [INFO] [stdout] 783 | | }); [INFO] [stdout] | | - [INFO] [stdout] | |______________________________________| [INFO] [stdout] | |______________________________________this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | `#2` will be dropped later as of Edition 2024 [INFO] [stdout] | [INFO] [stdout] note: `#4` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `iter` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/alloc/src/string.rs:3528:0 [INFO] [stdout] note: `err` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#2` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/anyhow-1.0.58/src/error.rs:568:1 [INFO] [stdout] | [INFO] [stdout] 568 | impl Drop for Error { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/os/fd/owned.rs:196:0 [INFO] [stdout] = note: `#3` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `#3` invokes this custom destructor [INFO] [stdout] --> /rustc/622891a4e29178280638a6b63a8908bde2c0c854/library/std/src/sys/process/unix/common/cstring_array.rs:79:0 [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.19s [INFO] [stderr] crater-edition-check: kgit-split v0.1.0 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking kgit-split v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `DisplayViaDebug` is never constructed [INFO] [stdout] --> src/fmt.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct DisplayViaDebug(pub T); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ThousandsUnsigned` is never constructed [INFO] [stdout] --> src/fmt.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | pub struct ThousandsUnsigned(pub u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ThousandsSigned` is never constructed [INFO] [stdout] --> src/fmt.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct ThousandsSigned(pub i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ThousandsFloat` is never constructed [INFO] [stdout] --> src/fmt.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct ThousandsFloat(pub f64); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `DisplayViaDebug` is never constructed [INFO] [stdout] --> src/fmt.rs:30:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub struct DisplayViaDebug(pub T); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ThousandsUnsigned` is never constructed [INFO] [stdout] --> src/fmt.rs:39:12 [INFO] [stdout] | [INFO] [stdout] 39 | pub struct ThousandsUnsigned(pub u64); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ThousandsSigned` is never constructed [INFO] [stdout] --> src/fmt.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 62 | pub struct ThousandsSigned(pub i64); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `ThousandsFloat` is never constructed [INFO] [stdout] --> src/fmt.rs:73:12 [INFO] [stdout] | [INFO] [stdout] 73 | pub struct ThousandsFloat(pub f64); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 23.82s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "0939b67baa33c09b3375390be74cd7380744410a316dcf69d220f2592af0225f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0939b67baa33c09b3375390be74cd7380744410a316dcf69d220f2592af0225f", kill_on_drop: false }` [INFO] [stdout] 0939b67baa33c09b3375390be74cd7380744410a316dcf69d220f2592af0225f