[INFO] cloning repository https://github.com/byte-padmanabhan/rust-workflow-library [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/byte-padmanabhan/rust-workflow-library" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbyte-padmanabhan%2Frust-workflow-library", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbyte-padmanabhan%2Frust-workflow-library'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1b1e9149eb7ef4985d41937a19d4b7b84ec31952 [INFO] fixing byte-padmanabhan/rust-workflow-library against try#622891a4e29178280638a6b63a8908bde2c0c854+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fbyte-padmanabhan%2Frust-workflow-library" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/byte-padmanabhan/rust-workflow-library [INFO] finished tweaking git repo https://github.com/byte-padmanabhan/rust-workflow-library [INFO] tweaked toml for git repo https://github.com/byte-padmanabhan/rust-workflow-library written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/byte-padmanabhan/rust-workflow-library on toolchain 622891a4e29178280638a6b63a8908bde2c0c854 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/byte-padmanabhan/rust-workflow-library already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3a6becf2bc8dde7f3fa57ede90e4f284e72d296796fc446bbb1e2c7cc0530151" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 785e96f9ef6860328fb1027bf7aa6d7849bec37d80990de09956b21f6c9f0114 [INFO] running `Command { std: "docker" "start" "785e96f9ef6860328fb1027bf7aa6d7849bec37d80990de09956b21f6c9f0114", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "785e96f9ef6860328fb1027bf7aa6d7849bec37d80990de09956b21f6c9f0114" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "785e96f9ef6860328fb1027bf7aa6d7849bec37d80990de09956b21f6c9f0114", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "785e96f9ef6860328fb1027bf7aa6d7849bec37d80990de09956b21f6c9f0114" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling libc v0.2.186 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking itoa v1.0.18 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking tokio v1.38.0 [INFO] [stderr] Checking automationlibrary v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Migrating src/lib.rs from 2021 edition to 2024 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/engine.rs:204:30 [INFO] [stdout] | [INFO] [stdout] 204 | while let Some(result) = set.join_next().await { [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | `__awaitee` calls a custom destructor [INFO] [stdout] | | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Err(e) => return Err((merged, WorkflowError::Custom(e.to_string()))), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 214 | } [INFO] [stdout] 215 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `result` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/engine.rs:204:30 [INFO] [stdout] | [INFO] [stdout] 204 | while let Some(result) = set.join_next().await { [INFO] [stdout] | ------ ^^^^^^^^^^^^^^^^----- [INFO] [stdout] | | | | [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#3` [INFO] [stdout] | | | up until Edition 2021 `#3` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | | | `#1` will be dropped later as of Edition 2024 [INFO] [stdout] | | this value will be stored in a temporary; let us call it `#2` [INFO] [stdout] | | up until Edition 2021 `#2` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] | | `__awaitee` calls a custom destructor [INFO] [stdout] | | `__awaitee` will be dropped later as of Edition 2024 [INFO] [stdout] | `result` calls a custom destructor [INFO] [stdout] | `result` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Err(e) => return Err((merged, WorkflowError::Custom(e.to_string()))), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 214 | } [INFO] [stdout] 215 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#2` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `result` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.54s [INFO] [stderr] crater-edition-check: automationlibrary v0.1.0 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking automationlibrary v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/engine.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FailureFn`, `FailureFuture`, `FailurePolicy`, and `StepFuture` [INFO] [stdout] --> src/workflow.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::step::{FailureFuture, FailureFn, FailurePolicy, ParallelSteps, Step, StepFuture}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Arc` and `Mutex` [INFO] [stdout] --> src/engine.rs:4:17 [INFO] [stdout] | [INFO] [stdout] 4 | use std::sync::{Arc, Mutex}; [INFO] [stdout] | ^^^ ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `FailureFn`, `FailureFuture`, `FailurePolicy`, and `StepFuture` [INFO] [stdout] --> src/workflow.rs:6:19 [INFO] [stdout] | [INFO] [stdout] 6 | use crate::step::{FailureFuture, FailureFn, FailurePolicy, ParallelSteps, Step, StepFuture}; [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^^^^^ ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/workflow.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct Workflow { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 43 | pub(crate) id: String, [INFO] [stdout] 44 | pub(crate) name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/main.rs:11:33 [INFO] [stdout] | [INFO] [stdout] 11 | .step("screen-resume", |ctx| async move { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `name` is never read [INFO] [stdout] --> src/workflow.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 42 | pub struct Workflow { [INFO] [stdout] | -------- field in this struct [INFO] [stdout] 43 | pub(crate) id: String, [INFO] [stdout] 44 | pub(crate) name: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/main.rs:11:33 [INFO] [stdout] | [INFO] [stdout] 11 | .step("screen-resume", |ctx| async move { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.89s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "785e96f9ef6860328fb1027bf7aa6d7849bec37d80990de09956b21f6c9f0114", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "785e96f9ef6860328fb1027bf7aa6d7849bec37d80990de09956b21f6c9f0114", kill_on_drop: false }` [INFO] [stdout] 785e96f9ef6860328fb1027bf7aa6d7849bec37d80990de09956b21f6c9f0114