[INFO] cloning repository https://github.com/arackhaen/leafhill_io_persistent_memory [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/arackhaen/leafhill_io_persistent_memory" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farackhaen%2Fleafhill_io_persistent_memory", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farackhaen%2Fleafhill_io_persistent_memory'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2cf2458f88579d92e524262fc804c417d589a475 [INFO] fixing arackhaen/leafhill_io_persistent_memory against try#622891a4e29178280638a6b63a8908bde2c0c854+cargoflags=-Zfix-edition=end=2015,2024 for pr-157817-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farackhaen%2Fleafhill_io_persistent_memory" "/workspace/builds/worker-3-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/arackhaen/leafhill_io_persistent_memory [INFO] finished tweaking git repo https://github.com/arackhaen/leafhill_io_persistent_memory [INFO] tweaked toml for git repo https://github.com/arackhaen/leafhill_io_persistent_memory written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/arackhaen/leafhill_io_persistent_memory on toolchain 622891a4e29178280638a6b63a8908bde2c0c854 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/arackhaen/leafhill_io_persistent_memory already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3a6becf2bc8dde7f3fa57ede90e4f284e72d296796fc446bbb1e2c7cc0530151" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 51c0edfcd88e7e136c5761c8d4936486da515c118bc9e4eafe95d8bb58139482 [INFO] running `Command { std: "docker" "start" "51c0edfcd88e7e136c5761c8d4936486da515c118bc9e4eafe95d8bb58139482", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "51c0edfcd88e7e136c5761c8d4936486da515c118bc9e4eafe95d8bb58139482" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "51c0edfcd88e7e136c5761c8d4936486da515c118bc9e4eafe95d8bb58139482", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=" "-e" "RUSTDOCFLAGS=" "-w" "/opt/rustwide/workdir" "--user" "0:0" "51c0edfcd88e7e136c5761c8d4936486da515c118bc9e4eafe95d8bb58139482" "/opt/rustwide/cargo-home/bin/cargo" "+622891a4e29178280638a6b63a8908bde2c0c854" "fix" "--allow-no-vcs" "--allow-dirty" "--frozen" "--all" "--all-targets" "--message-format=json" "-Zfix-edition=end=2015,2024", kill_on_drop: false }` [INFO] [stderr] crater-edition-check: migrating to next edition [INFO] [stderr] Migrating Cargo.toml from 2021 edition to 2024 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking subtle v2.6.1 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling find-msvc-tools v0.1.9 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Compiling shlex v1.3.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking unicode-normalization v0.1.25 [INFO] [stderr] Compiling cc v1.2.56 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking unicode-properties v0.1.4 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Checking memchr v2.8.0 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Checking pin-project-lite v0.2.16 [INFO] [stderr] Checking unicode-bidi v0.3.18 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Compiling pkg-config v0.3.32 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking stringprep v0.1.5 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking siphasher v1.0.2 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.2 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Compiling zmij v1.0.21 [INFO] [stderr] Compiling libsqlite3-sys v0.28.0 [INFO] [stderr] Checking anstyle-query v1.1.5 [INFO] [stderr] Checking anstyle v1.0.13 [INFO] [stderr] Checking lock_api v0.4.14 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking phf_shared v0.11.3 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking clap_lex v1.0.0 [INFO] [stderr] Compiling heck v0.5.0 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking phf v0.11.3 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking iana-time-zone v0.1.65 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.3.0 [INFO] [stderr] Checking itoa v1.0.17 [INFO] [stderr] Checking whoami v1.6.1 [INFO] [stderr] Checking percent-encoding v2.3.2 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking hashlink v0.9.1 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Checking postgres-protocol v0.6.7 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Checking postgres-types v0.2.8 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking chrono v0.4.44 [INFO] [stderr] Checking tokio-postgres v0.7.12 [INFO] [stderr] Checking rusqlite v0.31.0 [INFO] [stderr] Checking leafhill-persistent-memory v1.5.0 (/opt/rustwide/workdir) [INFO] [stderr] Migrating tests/archive_tests.rs from 2021 edition to 2024 [INFO] [stderr] Migrating tests/cli_tests.rs from 2021 edition to 2024 [INFO] [stderr] Migrating src/main.rs from 2021 edition to 2024 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:305:15 [INFO] [stdout] | [INFO] [stdout] 305 | match db.restore_memory(mem) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Err(e) => return Err(format!("Failed to restore memory {}: {}", mem.id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 309 | } [INFO] [stdout] 310 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:313:15 [INFO] [stdout] | [INFO] [stdout] 313 | match db.restore_conversation(entry) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Err(e) => return Err(format!("Failed to restore conversation {}: {}", entry.id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 317 | } [INFO] [stdout] 318 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 325 | match db.restore_task(task) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | Err(e) => return Err(format!("Failed to restore task {}: {}", task.id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 329 | } [INFO] [stdout] 330 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:333:15 [INFO] [stdout] | [INFO] [stdout] 333 | match db.restore_task_dep(*blocker_id, *blocked_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | Err(e) => return Err(format!("Failed to restore task dep ({}, {}): {}", blocker_id, blocked_id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 337 | } [INFO] [stdout] 338 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:341:15 [INFO] [stdout] | [INFO] [stdout] 341 | match db.restore_link(link) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Err(e) => return Err(format!("Failed to restore link {}: {}", link.id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 345 | } [INFO] [stdout] 346 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/hook.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 67 | let db = match Database::open(db_path) { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `db` calls a custom destructor [INFO] [stdout] | `db` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | if let Err(e) = db.log_conversation( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 72 | | &formatted_sid, "user", &prompt, [INFO] [stdout] 73 | | Some(project), Some("raw_user"), None, [INFO] [stdout] 74 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_____________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `db` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/rusqlite-0.31.0/src/lib.rs:384:1 [INFO] [stdout] | [INFO] [stdout] 384 | impl Drop for Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/hook.rs:93:29 [INFO] [stdout] | [INFO] [stdout] 89 | let db = match Database::open(db_path) { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `db` calls a custom destructor [INFO] [stdout] | `db` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | if let Err(e) = db.log_conversation( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 94 | | &formatted_sid, "assistant", &message, [INFO] [stdout] 95 | | Some(project), Some("raw_assistant"), None, [INFO] [stdout] 96 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_____________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `db` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/rusqlite-0.31.0/src/lib.rs:384:1 [INFO] [stdout] | [INFO] [stdout] 384 | impl Drop for Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/hook.rs:202:19 [INFO] [stdout] | [INFO] [stdout] 198 | let db = match Database::open(db_path) { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `db` calls a custom destructor [INFO] [stdout] | `db` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | match db.store_pre_compact_batch(&messages) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `db` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/rusqlite-0.31.0/src/lib.rs:384:1 [INFO] [stdout] | [INFO] [stdout] 384 | impl Drop for Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Migrating tests/mcp_tests.rs from 2021 edition to 2024 [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:305:15 [INFO] [stdout] | [INFO] [stdout] 305 | match db.restore_memory(mem) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 308 | Err(e) => return Err(format!("Failed to restore memory {}: {}", mem.id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 309 | } [INFO] [stdout] 310 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `--force-warn tail-expr-drop-order` implied by `--force-warn rust-2024-compatibility` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:313:15 [INFO] [stdout] | [INFO] [stdout] 313 | match db.restore_conversation(entry) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 316 | Err(e) => return Err(format!("Failed to restore conversation {}: {}", entry.id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 317 | } [INFO] [stdout] 318 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:325:15 [INFO] [stdout] | [INFO] [stdout] 325 | match db.restore_task(task) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 328 | Err(e) => return Err(format!("Failed to restore task {}: {}", task.id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 329 | } [INFO] [stdout] 330 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:333:15 [INFO] [stdout] | [INFO] [stdout] 333 | match db.restore_task_dep(*blocker_id, *blocked_id) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 336 | Err(e) => return Err(format!("Failed to restore task dep ({}, {}): {}", blocker_id, blocked_id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 337 | } [INFO] [stdout] 338 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/archive.rs:341:15 [INFO] [stdout] | [INFO] [stdout] 341 | match db.restore_link(link) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 344 | Err(e) => return Err(format!("Failed to restore link {}: {}", link.id, e)), [INFO] [stdout] | - [INFO] [stdout] | | [INFO] [stdout] | `e` calls a custom destructor [INFO] [stdout] | `e` will be dropped later as of Edition 2024 [INFO] [stdout] 345 | } [INFO] [stdout] 346 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: `e` may invoke a custom destructor because it contains a trait object [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/hook.rs:71:29 [INFO] [stdout] | [INFO] [stdout] 67 | let db = match Database::open(db_path) { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `db` calls a custom destructor [INFO] [stdout] | `db` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 71 | if let Err(e) = db.log_conversation( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 72 | | &formatted_sid, "user", &prompt, [INFO] [stdout] 73 | | Some(project), Some("raw_user"), None, [INFO] [stdout] 74 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_____________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 77 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `db` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/rusqlite-0.31.0/src/lib.rs:384:1 [INFO] [stdout] | [INFO] [stdout] 384 | impl Drop for Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/hook.rs:93:29 [INFO] [stdout] | [INFO] [stdout] 89 | let db = match Database::open(db_path) { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `db` calls a custom destructor [INFO] [stdout] | `db` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 93 | if let Err(e) = db.log_conversation( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 94 | | &formatted_sid, "assistant", &message, [INFO] [stdout] 95 | | Some(project), Some("raw_assistant"), None, [INFO] [stdout] 96 | | ) { [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_____________this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `db` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/rusqlite-0.31.0/src/lib.rs:384:1 [INFO] [stdout] | [INFO] [stdout] 384 | impl Drop for Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: relative drop order changing in Rust 2024 [INFO] [stdout] --> src/hook.rs:202:19 [INFO] [stdout] | [INFO] [stdout] 198 | let db = match Database::open(db_path) { [INFO] [stdout] | -- [INFO] [stdout] | | [INFO] [stdout] | `db` calls a custom destructor [INFO] [stdout] | `db` will be dropped later as of Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | match db.store_pre_compact_batch(&messages) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this value will be stored in a temporary; let us call it `#1` [INFO] [stdout] | up until Edition 2021 `#1` is dropped last but will be dropped earlier in Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | } [INFO] [stdout] | - now the temporary value is dropped here, before the local variables in the block or statement [INFO] [stdout] | [INFO] [stdout] = note: `#1` may invoke a custom destructor because it contains a trait object [INFO] [stdout] note: `db` invokes this custom destructor [INFO] [stdout] --> /opt/rustwide/cargo-home/registry/src/index.crates.io-1949cf8c6b5b557f/rusqlite-0.31.0/src/lib.rs:384:1 [INFO] [stdout] | [INFO] [stdout] 384 | impl Drop for Connection { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: most of the time, changing drop order is harmless; inspect the `impl Drop`s for side effects like releasing locks or sending messages [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 47.90s [INFO] [stderr] crater-edition-check: leafhill-persistent-memory v1.5.0 (/opt/rustwide/workdir) updating edition from 2021 to 2024 [INFO] [stderr] Checking leafhill-persistent-memory v1.5.0 (/opt/rustwide/workdir) [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 49.89s [INFO] [stderr] crater-edition-check all packages now at latest edition [INFO] [stderr] crater-edition-check: all finished [INFO] running `Command { std: "docker" "inspect" "51c0edfcd88e7e136c5761c8d4936486da515c118bc9e4eafe95d8bb58139482", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "51c0edfcd88e7e136c5761c8d4936486da515c118bc9e4eafe95d8bb58139482", kill_on_drop: false }` [INFO] [stdout] 51c0edfcd88e7e136c5761c8d4936486da515c118bc9e4eafe95d8bb58139482