[INFO] cloning repository https://github.com/TeaUponTweed/rusty-cryptonomicon [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/TeaUponTweed/rusty-cryptonomicon" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTeaUponTweed%2Frusty-cryptonomicon", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTeaUponTweed%2Frusty-cryptonomicon'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] f7eb5087cbaaacf06e5d8bec525412366443c245 [INFO] checking TeaUponTweed/rusty-cryptonomicon against master#029c9e18dd1f4668e1d42bb187c1c263dfe20093 for pr-157562 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FTeaUponTweed%2Frusty-cryptonomicon" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/TeaUponTweed/rusty-cryptonomicon [INFO] finished tweaking git repo https://github.com/TeaUponTweed/rusty-cryptonomicon [INFO] tweaked toml for git repo https://github.com/TeaUponTweed/rusty-cryptonomicon written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/TeaUponTweed/rusty-cryptonomicon on toolchain 029c9e18dd1f4668e1d42bb187c1c263dfe20093 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+029c9e18dd1f4668e1d42bb187c1c263dfe20093" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/TeaUponTweed/rusty-cryptonomicon already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+029c9e18dd1f4668e1d42bb187c1c263dfe20093" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde v1.0.91 [INFO] [stderr] Downloaded serde_derive v1.0.91 [INFO] [stderr] Downloaded graphlib v0.3.1 [INFO] [stderr] Downloaded proc-macro2 v0.4.29 [INFO] [stderr] Downloaded hex v0.3.2 [INFO] [stderr] Downloaded libc v0.2.54 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] 7af3787b34f49c6f7f319a405d5ce2da503304c81905f1802cbfdf03eb36f6b0 [INFO] running `Command { std: "docker" "start" "7af3787b34f49c6f7f319a405d5ce2da503304c81905f1802cbfdf03eb36f6b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "7af3787b34f49c6f7f319a405d5ce2da503304c81905f1802cbfdf03eb36f6b0" "/opt/rustwide/cargo-home/bin/cargo" "+029c9e18dd1f4668e1d42bb187c1c263dfe20093" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7af3787b34f49c6f7f319a405d5ce2da503304c81905f1802cbfdf03eb36f6b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "7af3787b34f49c6f7f319a405d5ce2da503304c81905f1802cbfdf03eb36f6b0" "/opt/rustwide/cargo-home/bin/cargo" "+029c9e18dd1f4668e1d42bb187c1c263dfe20093" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.54 [INFO] [stderr] Compiling autocfg v0.1.2 [INFO] [stderr] Checking rand_core v0.4.0 [INFO] [stderr] Compiling arrayvec v0.4.10 [INFO] [stderr] Checking nodrop v0.1.13 [INFO] [stderr] Compiling proc-macro2 v0.4.29 [INFO] [stderr] Checking cfg-if v0.1.7 [INFO] [stderr] Checking lazy_static v1.3.0 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Checking crossbeam-utils v0.2.2 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Compiling rayon-core v1.4.1 [INFO] [stderr] Checking memoffset v0.2.1 [INFO] [stderr] Compiling syn v0.15.34 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Compiling byteorder v1.3.1 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Compiling rayon v1.0.3 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling serde v1.0.91 [INFO] [stderr] Compiling ryu v0.2.8 [INFO] [stderr] Checking num_cpus v1.10.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking crossbeam-epoch v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Checking unicode-width v0.1.5 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking hex v0.3.2 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Compiling quote v0.6.12 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking bitflags v1.0.4 [INFO] [stderr] Checking crossbeam-deque v0.2.0 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Checking hashbrown v0.1.8 [INFO] [stderr] Checking graphlib v0.3.1 [INFO] [stderr] Compiling serde_derive v1.0.91 [INFO] [stderr] Checking serde_json v1.0.39 [INFO] [stderr] Checking cryptoptim v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/util.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | #[derive(Debug, Deserialize,Clone)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/util.rs:48:60 [INFO] [stdout] | [INFO] [stdout] 48 | let assets : HashSet<_> = trading_pairs.iter().map(|x| (x.base_asset.clone())).collect(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - let assets : HashSet<_> = trading_pairs.iter().map(|x| (x.base_asset.clone())).collect(); [INFO] [stdout] 48 + let assets : HashSet<_> = trading_pairs.iter().map(|x| x.base_asset.clone() ).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/rate.rs:46:71 [INFO] [stdout] | [INFO] [stdout] 46 | let mut path : Vec = data.path.iter().map(|x| (x.clone())).collect(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - let mut path : Vec = data.path.iter().map(|x| (x.clone())).collect(); [INFO] [stdout] 46 + let mut path : Vec = data.path.iter().map(|x| x.clone() ).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/net.rs:55:64 [INFO] [stdout] | [INFO] [stdout] 55 | let assets : HashSet<_> = trading_pairs.iter().map(|x| (x.base_asset.clone())).collect(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - let assets : HashSet<_> = trading_pairs.iter().map(|x| (x.base_asset.clone())).collect(); [INFO] [stdout] 55 + let assets : HashSet<_> = trading_pairs.iter().map(|x| x.base_asset.clone() ).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/util.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | #[derive(Debug, Deserialize,Clone)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/util.rs:48:60 [INFO] [stdout] | [INFO] [stdout] 48 | let assets : HashSet<_> = trading_pairs.iter().map(|x| (x.base_asset.clone())).collect(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 48 - let assets : HashSet<_> = trading_pairs.iter().map(|x| (x.base_asset.clone())).collect(); [INFO] [stdout] 48 + let assets : HashSet<_> = trading_pairs.iter().map(|x| x.base_asset.clone() ).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/rate.rs:46:71 [INFO] [stdout] | [INFO] [stdout] 46 | let mut path : Vec = data.path.iter().map(|x| (x.clone())).collect(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 46 - let mut path : Vec = data.path.iter().map(|x| (x.clone())).collect(); [INFO] [stdout] 46 + let mut path : Vec = data.path.iter().map(|x| x.clone() ).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/net.rs:55:64 [INFO] [stdout] | [INFO] [stdout] 55 | let assets : HashSet<_> = trading_pairs.iter().map(|x| (x.base_asset.clone())).collect(); [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - let assets : HashSet<_> = trading_pairs.iter().map(|x| (x.base_asset.clone())).collect(); [INFO] [stdout] 55 + let assets : HashSet<_> = trading_pairs.iter().map(|x| x.base_asset.clone() ).collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/util.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | #[derive(Debug, Deserialize,Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_TradingPair` [INFO] [stdout] 11 | #[serde(rename_all = "camelCase")] [INFO] [stdout] 12 | pub struct TradingPair { [INFO] [stdout] | ----------- `TradingPair` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/util.rs:10:17 [INFO] [stdout] | [INFO] [stdout] 10 | #[derive(Debug, Deserialize,Clone)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_TradingPair` [INFO] [stdout] 11 | #[serde(rename_all = "camelCase")] [INFO] [stdout] 12 | pub struct TradingPair { [INFO] [stdout] | ----------- `TradingPair` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.72s [INFO] running `Command { std: "docker" "inspect" "7af3787b34f49c6f7f319a405d5ce2da503304c81905f1802cbfdf03eb36f6b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7af3787b34f49c6f7f319a405d5ce2da503304c81905f1802cbfdf03eb36f6b0", kill_on_drop: false }` [INFO] [stdout] 7af3787b34f49c6f7f319a405d5ce2da503304c81905f1802cbfdf03eb36f6b0