[INFO] cloning repository https://github.com/fhaynes/iridium [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fhaynes/iridium" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhaynes%2Firidium", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhaynes%2Firidium'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 2cfad1c94d712a9899d6e0d39d373309965c2bff [INFO] checking fhaynes/iridium against master#cced03bfd61a304243a34504618ecec86c17063f for pr-157082 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffhaynes%2Firidium" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fhaynes/iridium [INFO] finished tweaking git repo https://github.com/fhaynes/iridium [INFO] tweaked toml for git repo https://github.com/fhaynes/iridium written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fhaynes/iridium on toolchain cced03bfd61a304243a34504618ecec86c17063f [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cced03bfd61a304243a34504618ecec86c17063f" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fhaynes/iridium already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cced03bfd61a304243a34504618ecec86c17063f" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: `iridium` (manifest) generated 1 warning [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand_core v0.2.2 [INFO] [stderr] Downloaded rand_core v0.3.0 [INFO] [stderr] Downloaded uuid v0.7.1 [INFO] [stderr] Downloaded thread-scoped v1.0.2 [INFO] [stderr] Downloaded redox_syscall v0.1.40 [INFO] [stderr] Downloaded failure_derive v0.1.3 [INFO] [stderr] Downloaded synstructure v0.10.1 [INFO] [stderr] Downloaded criterion-stats v0.2.5 [INFO] [stderr] Downloaded byteorder v1.2.7 [INFO] [stderr] Downloaded simplelog v0.5.3 [INFO] [stderr] Downloaded time v0.1.40 [INFO] [stderr] Downloaded rustc-demangle v0.1.9 [INFO] [stderr] Downloaded termcolor v1.0.4 [INFO] [stderr] Downloaded lazy_static v1.2.0 [INFO] [stderr] Downloaded wincolor v1.0.1 [INFO] [stderr] Downloaded either v1.5.0 [INFO] [stderr] Downloaded cfg-if v0.1.6 [INFO] [stderr] Downloaded itertools-num v0.1.2 [INFO] [stderr] Downloaded bincode v1.0.1 [INFO] [stderr] Downloaded criterion-plot v0.2.5 [INFO] [stderr] Downloaded num_cpus v1.8.0 [INFO] [stderr] Downloaded pest_derive v1.0.8 [INFO] [stderr] Downloaded quote v0.6.9 [INFO] [stderr] Downloaded winapi-util v0.1.1 [INFO] [stderr] Downloaded ucd-util v0.1.2 [INFO] [stderr] Downloaded humantime v1.1.1 [INFO] [stderr] Downloaded term v0.5.1 [INFO] [stderr] Downloaded pest v1.0.6 [INFO] [stderr] Downloaded backtrace v0.3.9 [INFO] [stderr] Downloaded cc v1.0.25 [INFO] [stderr] Downloaded serde_derive v1.0.80 [INFO] [stderr] Downloaded env_logger v0.5.13 [INFO] [stderr] Downloaded aho-corasick v0.6.9 [INFO] [stderr] Downloaded memchr v2.1.1 [INFO] [stderr] Downloaded walkdir v2.2.6 [INFO] [stderr] Downloaded ryu v0.2.6 [INFO] [stderr] Downloaded proc-macro2 v0.4.20 [INFO] [stderr] Downloaded yaml-rust v0.3.5 [INFO] [stderr] Downloaded handlebars v0.32.4 [INFO] [stderr] Downloaded failure v0.1.3 [INFO] [stderr] Downloaded serde v1.0.80 [INFO] [stderr] Downloaded serde_json v1.0.32 [INFO] [stderr] Downloaded rand v0.4.3 [INFO] [stderr] Downloaded itertools v0.7.8 [INFO] [stderr] Downloaded rand v0.5.5 [INFO] [stderr] Downloaded nom v4.1.1 [INFO] [stderr] Downloaded regex-syntax v0.6.2 [INFO] [stderr] Downloaded criterion v0.2.5 [INFO] [stderr] Downloaded libc v0.2.43 [INFO] [stderr] Downloaded regex v1.0.5 [INFO] [stderr] Downloaded backtrace-sys v0.1.24 [INFO] [stderr] Downloaded csv-core v0.1.4 [INFO] [stderr] Downloaded syn v0.15.18 [INFO] [stderr] Downloaded csv v1.0.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-m" "1610612736" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:3e793bdf10248eb2ddbd6b0faebed8155c11b4589982e2893733958d93e8d540" "sleep" "infinity", kill_on_drop: false }` [INFO] [stdout] e9d40a14fcff7d0283bd649f4eb41440d235c6499c5ae06b7f32e08029e7043e [INFO] running `Command { std: "docker" "start" "e9d40a14fcff7d0283bd649f4eb41440d235c6499c5ae06b7f32e08029e7043e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e9d40a14fcff7d0283bd649f4eb41440d235c6499c5ae06b7f32e08029e7043e" "/opt/rustwide/cargo-home/bin/cargo" "+cced03bfd61a304243a34504618ecec86c17063f" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9d40a14fcff7d0283bd649f4eb41440d235c6499c5ae06b7f32e08029e7043e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "exec" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-w" "/opt/rustwide/workdir" "--user" "0:0" "e9d40a14fcff7d0283bd649f4eb41440d235c6499c5ae06b7f32e08029e7043e" "/opt/rustwide/cargo-home/bin/cargo" "+cced03bfd61a304243a34504618ecec86c17063f" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stderr] warning: Cargo.toml: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: `iridium` (manifest) generated 1 warning [INFO] [stderr] Checking libc v0.2.43 [INFO] [stderr] Checking cfg-if v0.1.6 [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling proc-macro2 v0.4.20 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling num-traits v0.2.6 [INFO] [stderr] Compiling serde v1.0.80 [INFO] [stderr] Compiling regex v1.0.5 [INFO] [stderr] Checking ucd-util v0.1.2 [INFO] [stderr] Checking lazy_static v1.2.0 [INFO] [stderr] Checking byteorder v1.2.7 [INFO] [stderr] Checking utf8-ranges v1.0.2 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Checking quick-error v1.2.2 [INFO] [stderr] Compiling unicode-xid v0.0.4 [INFO] [stderr] Compiling ryu v0.2.6 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking regex-syntax v0.6.2 [INFO] [stderr] Checking rand_core v0.3.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling synom v0.11.3 [INFO] [stderr] Compiling quote v0.3.15 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking atty v0.2.11 [INFO] [stderr] Checking rand_core v0.2.2 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking humantime v1.1.1 [INFO] [stderr] Compiling memchr v2.1.1 [INFO] [stderr] Checking rand v0.5.5 [INFO] [stderr] Checking rustc-demangle v0.1.9 [INFO] [stderr] Compiling syn v0.11.11 [INFO] [stderr] Checking itoa v0.4.3 [INFO] [stderr] Checking either v1.5.0 [INFO] [stderr] Checking cast v0.2.2 [INFO] [stderr] Checking termcolor v1.0.4 [INFO] [stderr] Compiling pest v1.0.6 [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking itertools v0.7.8 [INFO] [stderr] Checking term v0.5.1 [INFO] [stderr] Checking rand v0.4.3 [INFO] [stderr] Checking same-file v1.0.4 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking walkdir v2.2.6 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking csv-core v0.1.4 [INFO] [stderr] Checking nom v4.1.1 [INFO] [stderr] Compiling backtrace-sys v0.1.24 [INFO] [stderr] Compiling quote v0.6.9 [INFO] [stderr] Compiling syn v0.15.18 [INFO] [stderr] Checking uuid v0.7.1 [INFO] [stderr] Checking num-integer v0.1.39 [INFO] [stderr] Checking criterion-stats v0.2.5 [INFO] [stderr] Checking itertools-num v0.1.2 [INFO] [stderr] Compiling pest_derive v1.0.8 [INFO] [stderr] Checking criterion-plot v0.2.5 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking simplelog v0.5.3 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking env_logger v0.5.13 [INFO] [stderr] Checking bincode v1.0.1 [INFO] [stderr] Checking serde_json v1.0.32 [INFO] [stderr] Checking csv v1.0.2 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Checking handlebars v0.32.4 [INFO] [stderr] Compiling serde_derive v1.0.80 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking criterion v0.2.5 [INFO] [stderr] Checking iridium v0.0.33 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/comment_parsers.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// Looks for a comment start [INFO] [stdout] 5 | | /// Examples: [INFO] [stdout] | |_------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/directive_parsers.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | /// Will try to parse out any of the Directive forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:233:1 [INFO] [stdout] | [INFO] [stdout] 233 | /// Will try to parse out any of the Instruction forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Parser for all numbers, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 8 | | /// #100 [INFO] [stdout] | |_-------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / /// Parser for all floats, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 31 | | /// #100.0 [INFO] [stdout] | |_---------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/cluster/message.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/cluster/message.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/client.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(mut hello) = IridiumMessage::hello(alias, &self.bind_port.clone().unwrap()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | ... let mut cmgr_lock = cmgr.read().unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut cmgr = connection_manager.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 61 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 41 | pub event: VMEventType, [INFO] [stdout] 42 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 43 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/cluster/message.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_IridiumMessage` [INFO] [stdout] 10 | /// These are the message types that cluster nodes can exchange between themselves [INFO] [stdout] 11 | pub enum IridiumMessage { [INFO] [stdout] | -------------- `IridiumMessage` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/cluster/message.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_IridiumMessage` [INFO] [stdout] 10 | /// These are the message types that cluster nodes can exchange between themselves [INFO] [stdout] 11 | pub enum IridiumMessage { [INFO] [stdout] | -------------- `IridiumMessage` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::str::::trim_end` that must be used [INFO] [stdout] --> src/remote/client.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_end(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the trimmed string as a new slice, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 80 | let _ = buf.trim_end(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repl/mod.rs:308:46 [INFO] [stdout] | [INFO] [stdout] 308 | let addr = ip.to_owned() + ":" + port.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | let mut vm = VM::new() [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | let mut rx = repl.rx_pipe.take(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:108:21 [INFO] [stdout] | [INFO] [stdout] 108 | let mut vm = VM::new() [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/iridium.rs:112:21 [INFO] [stdout] | [INFO] [stdout] 112 | let mut rx = repl.rx_pipe.take(); [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `PIE_HEADER_LENGTH` and `PIE_HEADER_PREFIX` [INFO] [stdout] --> benches/iridium.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | use iridium::assembler::{PIE_HEADER_LENGTH, PIE_HEADER_PREFIX}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/comment_parsers.rs:4:1 [INFO] [stdout] | [INFO] [stdout] 4 | / /// Looks for a comment start [INFO] [stdout] 5 | | /// Examples: [INFO] [stdout] | |_------------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/directive_parsers.rs:40:1 [INFO] [stdout] | [INFO] [stdout] 40 | /// Will try to parse out any of the Directive forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/instruction_parsers.rs:233:1 [INFO] [stdout] | [INFO] [stdout] 233 | /// Will try to parse out any of the Instruction forms [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/label_parsers.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | /// Looks for a user-defined label, such as `label1:` [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:7:1 [INFO] [stdout] | [INFO] [stdout] 7 | / /// Parser for all numbers, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 8 | | /// #100 [INFO] [stdout] | |_-------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/assembler/operand_parsers.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | / /// Parser for all floats, which have to be prefaced with `#` in our assembly language: [INFO] [stdout] 31 | | /// #100.0 [INFO] [stdout] | |_---------^ [INFO] [stdout] | | [INFO] [stdout] | rustdoc does not generate documentation for macro invocations [INFO] [stdout] | [INFO] [stdout] = help: to document an item produced by a macro, the macro must produce the documentation as part of its expansion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/cluster/message.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Serialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/cluster/message.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = note: using a cfg inside a derive macro will use the cfgs from the destination crate and not the ones from the defining crate [INFO] [stdout] = help: try referring to `Deserialize` crate for guidance on how handle this unexpected cfg [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/client.rs:53:27 [INFO] [stdout] | [INFO] [stdout] 53 | if let Ok(mut hello) = IridiumMessage::hello(alias, &self.bind_port.clone().unwrap()) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:30:33 [INFO] [stdout] | [INFO] [stdout] 30 | ... let mut cmgr_lock = cmgr.read().unwrap(); [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/cluster/server.rs:14:13 [INFO] [stdout] | [INFO] [stdout] 14 | let mut cmgr = connection_manager.clone(); [INFO] [stdout] | ----^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `buf` is never read [INFO] [stdout] --> src/assembler/mod.rs:61:5 [INFO] [stdout] | [INFO] [stdout] 41 | pub struct Assembler { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 61 | buf: [u8; 4], [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Assembler` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `symbol_type` is never read [INFO] [stdout] --> src/assembler/symbols.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 2 | pub struct Symbol { [INFO] [stdout] | ------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 5 | symbol_type: SymbolType, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Symbol` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `at` and `application_id` are never read [INFO] [stdout] --> src/vm.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct VMEvent { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 41 | pub event: VMEventType, [INFO] [stdout] 42 | at: DateTime, [INFO] [stdout] | ^^ [INFO] [stdout] 43 | application_id: Uuid, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VMEvent` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/cluster/message.rs:9:10 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_IridiumMessage` [INFO] [stdout] 10 | /// These are the message types that cluster nodes can exchange between themselves [INFO] [stdout] 11 | pub enum IridiumMessage { [INFO] [stdout] | -------------- `IridiumMessage` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/cluster/message.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | #[derive(Serialize, Deserialize, Debug)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_IridiumMessage` [INFO] [stdout] 10 | /// These are the message types that cluster nodes can exchange between themselves [INFO] [stdout] 11 | pub enum IridiumMessage { [INFO] [stdout] | -------------- `IridiumMessage` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::str::::trim_end` that must be used [INFO] [stdout] --> src/remote/client.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | buf.trim_end(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this returns the trimmed string as a new slice, without modifying the original [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 80 | let _ = buf.trim_end(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/repl/mod.rs:308:46 [INFO] [stdout] | [INFO] [stdout] 308 | let addr = ip.to_owned() + ":" + port.clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.39s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.2.5, nom v4.1.1 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 2` [INFO] running `Command { std: "docker" "inspect" "e9d40a14fcff7d0283bd649f4eb41440d235c6499c5ae06b7f32e08029e7043e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9d40a14fcff7d0283bd649f4eb41440d235c6499c5ae06b7f32e08029e7043e", kill_on_drop: false }` [INFO] [stdout] e9d40a14fcff7d0283bd649f4eb41440d235c6499c5ae06b7f32e08029e7043e