[INFO] cloning repository https://github.com/freiguy1/rust-notes [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/freiguy1/rust-notes" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffreiguy1%2Frust-notes", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffreiguy1%2Frust-notes'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1eaf624fdfd461889b8debfde6d08807695cdd13 [INFO] checking freiguy1/rust-notes against master#cb40c25f6aebb637163d26bf76a680ed6e5d1eda for pr-156157-1 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffreiguy1%2Frust-notes" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/freiguy1/rust-notes [INFO] finished tweaking git repo https://github.com/freiguy1/rust-notes [INFO] tweaked toml for git repo https://github.com/freiguy1/rust-notes written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/freiguy1/rust-notes on toolchain cb40c25f6aebb637163d26bf76a680ed6e5d1eda [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cb40c25f6aebb637163d26bf76a680ed6e5d1eda" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/freiguy1/rust-notes already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+cb40c25f6aebb637163d26bf76a680ed6e5d1eda" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded unicode-xid v0.2.1 [INFO] [stderr] Downloaded serde_json v1.0.59 [INFO] [stderr] Downloaded version_check v0.9.2 [INFO] [stderr] Downloaded sha-1 v0.8.2 [INFO] [stderr] Downloaded opaque-debug v0.2.3 [INFO] [stderr] Downloaded itoa v0.4.6 [INFO] [stderr] Downloaded strsim v0.9.3 [INFO] [stderr] Downloaded quick-error v2.0.0 [INFO] [stderr] Downloaded digest v0.8.1 [INFO] [stderr] Downloaded cfg-if v0.1.10 [INFO] [stderr] Downloaded pest_generator v2.1.3 [INFO] [stderr] Downloaded thread_local v1.0.1 [INFO] [stderr] Downloaded byte-tools v0.3.1 [INFO] [stderr] Downloaded lazy_static v1.4.0 [INFO] [stderr] Downloaded maplit v1.0.2 [INFO] [stderr] Downloaded block-padding v0.1.5 [INFO] [stderr] Downloaded block-buffer v0.7.3 [INFO] [stderr] Downloaded fake-simd v0.1.2 [INFO] [stderr] Downloaded serde_derive v1.0.117 [INFO] [stderr] Downloaded quote v1.0.7 [INFO] [stderr] Downloaded pest_derive v2.1.0 [INFO] [stderr] Downloaded serde v1.0.117 [INFO] [stderr] Downloaded getopts v0.2.21 [INFO] [stderr] Downloaded unicode-width v0.1.8 [INFO] [stderr] Downloaded bitflags v1.2.1 [INFO] [stderr] Downloaded generic-array v0.12.3 [INFO] [stderr] Downloaded byteorder v1.3.4 [INFO] [stderr] Downloaded memchr v2.3.4 [INFO] [stderr] Downloaded typenum v1.12.0 [INFO] [stderr] Downloaded ucd-trie v0.1.3 [INFO] [stderr] Downloaded unicase v2.6.0 [INFO] [stderr] Downloaded pest_meta v2.1.3 [INFO] [stderr] Downloaded log v0.4.11 [INFO] [stderr] Downloaded docopt v1.1.0 [INFO] [stderr] Downloaded proc-macro2 v1.0.24 [INFO] [stderr] Downloaded ryu v1.0.5 [INFO] [stderr] Downloaded handlebars v3.5.1 [INFO] [stderr] Downloaded pest v2.1.3 [INFO] [stderr] Downloaded pulldown-cmark v0.8.0 [INFO] [stderr] Downloaded aho-corasick v0.7.15 [INFO] [stderr] Downloaded syn v1.0.51 [INFO] [stderr] Downloaded regex v1.4.2 [INFO] [stderr] Downloaded regex-syntax v0.6.21 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+cb40c25f6aebb637163d26bf76a680ed6e5d1eda" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b9a043d764b449fff0ca2761b43cfa67bbe41a1b5e81bd6b208f69ab88771a2c [INFO] running `Command { std: "docker" "start" "-a" "b9a043d764b449fff0ca2761b43cfa67bbe41a1b5e81bd6b208f69ab88771a2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b9a043d764b449fff0ca2761b43cfa67bbe41a1b5e81bd6b208f69ab88771a2c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9a043d764b449fff0ca2761b43cfa67bbe41a1b5e81bd6b208f69ab88771a2c", kill_on_drop: false }` [INFO] [stdout] b9a043d764b449fff0ca2761b43cfa67bbe41a1b5e81bd6b208f69ab88771a2c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+cb40c25f6aebb637163d26bf76a680ed6e5d1eda" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a301e9db539fef9cf4e3b60db2767ac1587ca4eaf5fa5966bb2a393741ce74f2 [INFO] running `Command { std: "docker" "start" "-a" "a301e9db539fef9cf4e3b60db2767ac1587ca4eaf5fa5966bb2a393741ce74f2", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.51 [INFO] [stderr] Compiling serde_derive v1.0.117 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling serde v1.0.117 [INFO] [stderr] Compiling ucd-trie v0.1.3 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling pest v2.1.3 [INFO] [stderr] Compiling maplit v1.0.2 [INFO] [stderr] Compiling serde_json v1.0.59 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking aho-corasick v0.7.15 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking regex-syntax v0.6.21 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling pulldown-cmark v0.8.0 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking quick-error v2.0.0 [INFO] [stderr] Checking strsim v0.9.3 [INFO] [stderr] Compiling pest_meta v2.1.3 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking regex v1.4.2 [INFO] [stderr] Compiling pest_generator v2.1.3 [INFO] [stderr] Compiling pest_derive v2.1.0 [INFO] [stderr] Checking docopt v1.1.0 [INFO] [stderr] Checking handlebars v3.5.1 [INFO] [stderr] Checking rust-notes v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:52:29 [INFO] [stdout] | [INFO] [stdout] 52 | let dest_path = dest.clone().join(&relative); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 52 - let dest_path = dest.clone().join(&relative); [INFO] [stdout] 52 + let dest_path = dest.join(&relative); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/file_type/mod.rs:73:42 [INFO] [stdout] | [INFO] [stdout] 73 | let mut temp = PathBuf::from(path.clone().parent().unwrap()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 73 - let mut temp = PathBuf::from(path.clone().parent().unwrap()); [INFO] [stdout] 73 + let mut temp = PathBuf::from(path.parent().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/util.rs:53:87 [INFO] [stdout] | [INFO] [stdout] 53 | fn my_relative_from<'a, P: ?Sized + AsRef>(&'a self, base: &'a P) -> Option<&Path>; [INFO] [stdout] | -- -- ^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the lifetime is named here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 53 | fn my_relative_from<'a, P: ?Sized + AsRef>(&'a self, base: &'a P) -> Option<&'a Path>; [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/util.rs:57:87 [INFO] [stdout] | [INFO] [stdout] 57 | fn my_relative_from<'a, P: ?Sized + AsRef>(&'a self, base: &'a P) -> Option<&Path> { [INFO] [stdout] | -- -- ^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the lifetime is named here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 57 | fn my_relative_from<'a, P: ?Sized + AsRef>(&'a self, base: &'a P) -> Option<&'a Path> { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.19s [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/main.rs:52:29 [INFO] [stdout] | [INFO] [stdout] 52 | let dest_path = dest.clone().join(&relative); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 52 - let dest_path = dest.clone().join(&relative); [INFO] [stdout] 52 + let dest_path = dest.join(&relative); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/file_type/mod.rs:73:42 [INFO] [stdout] | [INFO] [stdout] 73 | let mut temp = PathBuf::from(path.clone().parent().unwrap()); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the type `std::path::Path` does not implement `Clone`, so calling `clone` on `&std::path::Path` copies the reference, which does not do anything and can be removed [INFO] [stdout] help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] 73 - let mut temp = PathBuf::from(path.clone().parent().unwrap()); [INFO] [stdout] 73 + let mut temp = PathBuf::from(path.parent().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/util.rs:53:87 [INFO] [stdout] | [INFO] [stdout] 53 | fn my_relative_from<'a, P: ?Sized + AsRef>(&'a self, base: &'a P) -> Option<&Path>; [INFO] [stdout] | -- -- ^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the lifetime is named here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 53 | fn my_relative_from<'a, P: ?Sized + AsRef>(&'a self, base: &'a P) -> Option<&'a Path>; [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/util.rs:57:87 [INFO] [stdout] | [INFO] [stdout] 57 | fn my_relative_from<'a, P: ?Sized + AsRef>(&'a self, base: &'a P) -> Option<&Path> { [INFO] [stdout] | -- -- ^^^^^ the same lifetime is elided here [INFO] [stdout] | | | [INFO] [stdout] | | the lifetime is named here [INFO] [stdout] | the lifetime is named here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 57 | fn my_relative_from<'a, P: ?Sized + AsRef>(&'a self, base: &'a P) -> Option<&'a Path> { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "a301e9db539fef9cf4e3b60db2767ac1587ca4eaf5fa5966bb2a393741ce74f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a301e9db539fef9cf4e3b60db2767ac1587ca4eaf5fa5966bb2a393741ce74f2", kill_on_drop: false }` [INFO] [stdout] a301e9db539fef9cf4e3b60db2767ac1587ca4eaf5fa5966bb2a393741ce74f2