[INFO] cloning repository https://github.com/arlept/mtklogo
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/arlept/mtklogo" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farlept%2Fmtklogo", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farlept%2Fmtklogo'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] e97f51944be9f6dbafff5b1d619341e1fa97dc4c
[INFO] checking arlept/mtklogo/e97f51944be9f6dbafff5b1d619341e1fa97dc4c against master#c756124775121dea0e640652c5ee3c89e3dd0eb4 for pr-154971
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Farlept%2Fmtklogo" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/arlept/mtklogo
[INFO] finished tweaking git repo https://github.com/arlept/mtklogo
[INFO] tweaked toml for git repo https://github.com/arlept/mtklogo written to /workspace/builds/worker-3-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/arlept/mtklogo on toolchain c756124775121dea0e640652c5ee3c89e3dd0eb4
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c756124775121dea0e640652c5ee3c89e3dd0eb4" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/arlept/mtklogo already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+c756124775121dea0e640652c5ee3c89e3dd0eb4" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: unused manifest key: package.maintenance
[INFO] [stderr] warning: unused manifest key: package.respository
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded miniz-sys v0.1.11
[INFO] [stderr]   Downloaded miniz_oxide v0.2.0
[INFO] [stderr]   Downloaded flate2 v1.0.6
[INFO] [stderr]   Downloaded miniz_oxide_c_api v0.2.0
[INFO] [stderr]   Downloaded libc v0.2.46
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+c756124775121dea0e640652c5ee3c89e3dd0eb4" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 1cb5359f18e5fbe9e9f77d87331a9413afb5ad1564c04151c4fa31c597f41469
[INFO] running `Command { std: "docker" "start" "-a" "1cb5359f18e5fbe9e9f77d87331a9413afb5ad1564c04151c4fa31c597f41469", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "1cb5359f18e5fbe9e9f77d87331a9413afb5ad1564c04151c4fa31c597f41469", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "1cb5359f18e5fbe9e9f77d87331a9413afb5ad1564c04151c4fa31c597f41469", kill_on_drop: false }`
[INFO] [stdout] 1cb5359f18e5fbe9e9f77d87331a9413afb5ad1564c04151c4fa31c597f41469
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+c756124775121dea0e640652c5ee3c89e3dd0eb4" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 7cc310df62ec6b68a21d2eca1fc6548e176bb1e5f5809d0f2de57e74b31302c8
[INFO] running `Command { std: "docker" "start" "-a" "7cc310df62ec6b68a21d2eca1fc6548e176bb1e5f5809d0f2de57e74b31302c8", kill_on_drop: false }`
[INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024`
[INFO] [stderr] warning: unused manifest key: package.maintenance
[INFO] [stderr] warning: unused manifest key: package.respository
[INFO] [stderr]    Compiling num-traits v0.2.6
[INFO] [stderr]    Compiling num-integer v0.1.39
[INFO] [stderr]    Compiling libc v0.2.46
[INFO] [stderr]    Compiling cc v1.0.28
[INFO] [stderr]     Checking adler32 v1.0.3
[INFO] [stderr]    Compiling crc32fast v1.1.2
[INFO] [stderr]     Checking byteorder v1.2.7
[INFO] [stderr]     Checking inflate v0.4.4
[INFO] [stderr]     Checking deflate v0.7.19
[INFO] [stderr]    Compiling miniz-sys v0.1.11
[INFO] [stderr]     Checking num-iter v0.1.37
[INFO] [stderr]     Checking png v0.12.0
[INFO] [stderr]     Checking flate2 v1.0.6
[INFO] [stderr]     Checking mtklogo v0.1.2 (/opt/rustwide/workdir)
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> src/utils/image.rs:89:85
[INFO] [stdout]    |
[INFO] [stdout] 89 | pub fn rgba_to_bgra<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<(Vec<u8>)> {
[INFO] [stdout]    |                                                                                     ^       ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 89 - pub fn rgba_to_bgra<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<(Vec<u8>)> {
[INFO] [stdout] 89 + pub fn rgba_to_bgra<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<Vec<u8> > {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> src/utils/image.rs:101:71
[INFO] [stdout]     |
[INFO] [stdout] 101 | pub fn u32be_to_u32le<R: Read>(mut reader: R, words: usize) -> Result<(Vec<u8>)> {
[INFO] [stdout]     |                                                                       ^       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 101 - pub fn u32be_to_u32le<R: Read>(mut reader: R, words: usize) -> Result<(Vec<u8>)> {
[INFO] [stdout] 101 + pub fn u32be_to_u32le<R: Read>(mut reader: R, words: usize) -> Result<Vec<u8> > {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> src/utils/image.rs:112:87
[INFO] [stdout]     |
[INFO] [stdout] 112 | pub fn rgba_to_rgb565<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<(Vec<u8>)> {
[INFO] [stdout]     |                                                                                       ^       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 112 - pub fn rgba_to_rgb565<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<(Vec<u8>)> {
[INFO] [stdout] 112 + pub fn rgba_to_rgb565<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<Vec<u8> > {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> src/utils/mod.rs:20:51
[INFO] [stdout]    |
[INFO] [stdout] 20 | pub fn load_raw<R: Read>(mut reader: R) -> Result<(Vec<u8>)> {
[INFO] [stdout]    |                                                   ^       ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 20 - pub fn load_raw<R: Read>(mut reader: R) -> Result<(Vec<u8>)> {
[INFO] [stdout] 20 + pub fn load_raw<R: Read>(mut reader: R) -> Result<Vec<u8> > {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> src/utils/image.rs:89:85
[INFO] [stdout]    |
[INFO] [stdout] 89 | pub fn rgba_to_bgra<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<(Vec<u8>)> {
[INFO] [stdout]    |                                                                                     ^       ^
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 89 - pub fn rgba_to_bgra<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<(Vec<u8>)> {
[INFO] [stdout] 89 + pub fn rgba_to_bgra<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<Vec<u8> > {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> src/utils/image.rs:101:71
[INFO] [stdout]     |
[INFO] [stdout] 101 | pub fn u32be_to_u32le<R: Read>(mut reader: R, words: usize) -> Result<(Vec<u8>)> {
[INFO] [stdout]     |                                                                       ^       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 101 - pub fn u32be_to_u32le<R: Read>(mut reader: R, words: usize) -> Result<(Vec<u8>)> {
[INFO] [stdout] 101 + pub fn u32be_to_u32le<R: Read>(mut reader: R, words: usize) -> Result<Vec<u8> > {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]    --> src/utils/image.rs:112:87
[INFO] [stdout]     |
[INFO] [stdout] 112 | pub fn rgba_to_rgb565<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<(Vec<u8>)> {
[INFO] [stdout]     |                                                                                       ^       ^
[INFO] [stdout]     |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]     |
[INFO] [stdout] 112 - pub fn rgba_to_rgb565<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<(Vec<u8>)> {
[INFO] [stdout] 112 + pub fn rgba_to_rgb565<O: ByteOrder, R: Read>(mut reader: R, w: u32, h: u32) -> Result<Vec<u8> > {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary parentheses around type
[INFO] [stdout]   --> src/utils/mod.rs:20:51
[INFO] [stdout]    |
[INFO] [stdout] 20 | pub fn load_raw<R: Read>(mut reader: R) -> Result<(Vec<u8>)> {
[INFO] [stdout]    |                                                   ^       ^
[INFO] [stdout]    |
[INFO] [stdout] help: remove these parentheses
[INFO] [stdout]    |
[INFO] [stdout] 20 - pub fn load_raw<R: Read>(mut reader: R) -> Result<(Vec<u8>)> {
[INFO] [stdout] 20 + pub fn load_raw<R: Read>(mut reader: R) -> Result<Vec<u8> > {
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/utils/image.rs:32:63
[INFO] [stdout]    |
[INFO] [stdout] 32 |             &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(rgba.clone())),
[INFO] [stdout]    |                                                               ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/utils/image.rs:46:65
[INFO] [stdout]    |
[INFO] [stdout] 46 |             &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(device.clone())),
[INFO] [stdout]    |                                                                 ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/utils/image.rs:32:63
[INFO] [stdout]    |
[INFO] [stdout] 32 |             &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(rgba.clone())),
[INFO] [stdout]    |                                                               ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed
[INFO] [stdout]    = note: `#[warn(noop_method_call)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing
[INFO] [stdout]   --> src/utils/image.rs:46:65
[INFO] [stdout]    |
[INFO] [stdout] 46 |             &ColorMode::Rgba(Endian::Big) => Ok(Vec::from(device.clone())),
[INFO] [stdout]    |                                                                 ^^^^^^^^ help: remove this redundant call
[INFO] [stdout]    |
[INFO] [stdout]    = note: the type `[u8]` does not implement `Clone`, so calling `clone` on `&[u8]` copies the reference, which does not do anything and can be removed
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary trailing semicolon
[INFO] [stdout]   --> tests/integration_test.rs:95:6
[INFO] [stdout]    |
[INFO] [stdout] 95 |     };
[INFO] [stdout]    |      ^ help: remove this semicolon
[INFO] [stdout]    |
[INFO] [stdout]    = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 3.81s
[INFO] running `Command { std: "docker" "inspect" "7cc310df62ec6b68a21d2eca1fc6548e176bb1e5f5809d0f2de57e74b31302c8", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "7cc310df62ec6b68a21d2eca1fc6548e176bb1e5f5809d0f2de57e74b31302c8", kill_on_drop: false }`
[INFO] [stdout] 7cc310df62ec6b68a21d2eca1fc6548e176bb1e5f5809d0f2de57e74b31302c8
