[INFO] fetching crate redis-event 1.2.1... [INFO] checking redis-event-1.2.1 against master#49b6ac01d6f4c3da812039ae846407a20961aa4c for pr-154887 [INFO] extracting crate redis-event 1.2.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate redis-event 1.2.1 [INFO] finished tweaking crates.io crate redis-event 1.2.1 [INFO] tweaked toml for crates.io crate redis-event 1.2.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate redis-event 1.2.1 on toolchain 49b6ac01d6f4c3da812039ae846407a20961aa4c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+49b6ac01d6f4c3da812039ae846407a20961aa4c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+49b6ac01d6f4c3da812039ae846407a20961aa4c" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 203 packages to latest compatible versions [INFO] [stderr] Adding num-bigint v0.2.6 (available: v0.4.6) [INFO] [stderr] Adding rand v0.7.3 (available: v0.10.1) [INFO] [stderr] Adding redis v0.17.0 (available: v1.2.0) [INFO] [stderr] Adding serial_test v0.3.2 (available: v3.4.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+49b6ac01d6f4c3da812039ae846407a20961aa4c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serial_test_derive v0.3.2 [INFO] [stderr] Downloaded redis v0.17.0 [INFO] [stderr] Downloaded serial_test v0.3.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+49b6ac01d6f4c3da812039ae846407a20961aa4c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c46725d7a6f1970f67602fd2116067d9757f7e89c4dcb72f10c7d550380c1f74 [INFO] running `Command { std: "docker" "start" "-a" "c46725d7a6f1970f67602fd2116067d9757f7e89c4dcb72f10c7d550380c1f74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c46725d7a6f1970f67602fd2116067d9757f7e89c4dcb72f10c7d550380c1f74", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c46725d7a6f1970f67602fd2116067d9757f7e89c4dcb72f10c7d550380c1f74", kill_on_drop: false }` [INFO] [stdout] c46725d7a6f1970f67602fd2116067d9757f7e89c4dcb72f10c7d550380c1f74 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+49b6ac01d6f4c3da812039ae846407a20961aa4c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e5c2f0ad33f01c0d88bd0d4dd7e447efc0eeff5262a833218fcccb7d0722d1b4 [INFO] running `Command { std: "docker" "start" "-a" "e5c2f0ad33f01c0d88bd0d4dd7e447efc0eeff5262a833218fcccb7d0722d1b4", kill_on_drop: false }` [INFO] [stderr] Checking value-bag v1.12.0 [INFO] [stderr] Compiling openssl-sys v0.9.113 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling openssl v0.10.77 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling async-io v2.6.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Checking async-task v4.7.1 [INFO] [stderr] Checking piper v0.2.5 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Checking lock_api v0.3.4 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling serial_test_derive v0.3.2 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking itoa v0.4.8 [INFO] [stderr] Checking sha1 v0.6.1 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v3.4.2 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Checking serial_test v0.3.2 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking combine v4.6.7 [INFO] [stderr] Checking tokio-tls v0.3.1 [INFO] [stderr] Checking redis-event v1.2.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: value assigned to `meta` is never read [INFO] [stdout] --> src/rdb.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 167 | meta.db = _db; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/cmd/streams.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 83 | for arg in iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to iterate over `iter` remove the call to `next` [INFO] [stdout] | [INFO] [stdout] 83 - for arg in iter.next() { [INFO] [stdout] 83 + for arg in iter.by_ref() { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 83 - for arg in iter.next() { [INFO] [stdout] 83 + if let Some(arg) = iter.next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/cmd/streams.rs:172:16 [INFO] [stdout] | [INFO] [stdout] 172 | for arg in iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to iterate over `iter` remove the call to `next` [INFO] [stdout] | [INFO] [stdout] 172 - for arg in iter.next() { [INFO] [stdout] 172 + for arg in iter.by_ref() { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 172 - for arg in iter.next() { [INFO] [stdout] 172 + if let Some(arg) = iter.next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/io.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(input: &mut dyn Read) -> CountReader { [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(input: &mut dyn Read) -> CountReader<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking polling v3.11.0 [INFO] [stderr] Checking async-global-executor v2.4.1 [INFO] [stderr] Checking async-std v1.13.2 [INFO] [stderr] Checking async-native-tls v0.3.3 [INFO] [stderr] Checking redis v0.17.0 [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/tests.rs:829:16 [INFO] [stdout] | [INFO] [stdout] 829 | panic!(err); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 829 | panic!("{}", err); [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 829 - panic!(err); [INFO] [stdout] 829 + std::panic::panic_any(err); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/tests.rs:868:16 [INFO] [stdout] | [INFO] [stdout] 868 | panic!(error) [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 868 | panic!("{}", error) [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 868 - panic!(error) [INFO] [stdout] 868 + std::panic::panic_any(error) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `meta` is never read [INFO] [stdout] --> src/rdb.rs:167:21 [INFO] [stdout] | [INFO] [stdout] 167 | meta.db = _db; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/cmd/streams.rs:83:16 [INFO] [stdout] | [INFO] [stdout] 83 | for arg in iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to iterate over `iter` remove the call to `next` [INFO] [stdout] | [INFO] [stdout] 83 - for arg in iter.next() { [INFO] [stdout] 83 + for arg in iter.by_ref() { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 83 - for arg in iter.next() { [INFO] [stdout] 83 + if let Some(arg) = iter.next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/cmd/streams.rs:172:16 [INFO] [stdout] | [INFO] [stdout] 172 | for arg in iter.next() { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to iterate over `iter` remove the call to `next` [INFO] [stdout] | [INFO] [stdout] 172 - for arg in iter.next() { [INFO] [stdout] 172 + for arg in iter.by_ref() { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 172 - for arg in iter.next() { [INFO] [stdout] 172 + if let Some(arg) = iter.next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/io.rs:33:30 [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(input: &mut dyn Read) -> CountReader { [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 33 | pub(crate) fn new(input: &mut dyn Read) -> CountReader<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> src/resp.rs:163:32 [INFO] [stdout] | [INFO] [stdout] 163 | Err(err) => panic!(err), [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 163 | Err(err) => panic!("{}", err), [INFO] [stdout] | +++++ [INFO] [stdout] help: or use std::panic::panic_any instead [INFO] [stdout] | [INFO] [stdout] 163 - Err(err) => panic!(err), [INFO] [stdout] 163 + Err(err) => std::panic::panic_any(err), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::slice::::contains` that must be used [INFO] [stdout] --> src/tests.rs:290:33 [INFO] [stdout] | [INFO] [stdout] 290 | ... vec.contains(&val.as_ref()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 290 | let _ = vec.contains(&val.as_ref()); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.14s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: redis v0.17.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "e5c2f0ad33f01c0d88bd0d4dd7e447efc0eeff5262a833218fcccb7d0722d1b4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e5c2f0ad33f01c0d88bd0d4dd7e447efc0eeff5262a833218fcccb7d0722d1b4", kill_on_drop: false }` [INFO] [stdout] e5c2f0ad33f01c0d88bd0d4dd7e447efc0eeff5262a833218fcccb7d0722d1b4