[INFO] fetching crate irclap 0.1.0... [INFO] testing irclap-0.1.0 against try#dec9417b8611e34e787a3e4c37686b5131f9e5c5 for pr-154210-1 [INFO] extracting crate irclap 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] started tweaking crates.io crate irclap 0.1.0 [INFO] finished tweaking crates.io crate irclap 0.1.0 [INFO] tweaked toml for crates.io crate irclap 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate irclap 0.1.0 on toolchain dec9417b8611e34e787a3e4c37686b5131f9e5c5 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+dec9417b8611e34e787a3e4c37686b5131f9e5c5" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+dec9417b8611e34e787a3e4c37686b5131f9e5c5" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 172 packages to latest compatible versions [INFO] [stderr] Adding clap v2.34.0 (available: v4.6.0) [INFO] [stderr] Adding futures v0.1.31 (available: v0.3.32) [INFO] [stderr] Adding irc v0.13.6 (available: v1.1.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+dec9417b8611e34e787a3e4c37686b5131f9e5c5" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+dec9417b8611e34e787a3e4c37686b5131f9e5c5" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e6fb95bfb5f1a67ca59d8481725b60f1f648407c45faa083f70f595201aea03d [INFO] running `Command { std: "docker" "start" "-a" "e6fb95bfb5f1a67ca59d8481725b60f1f648407c45faa083f70f595201aea03d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e6fb95bfb5f1a67ca59d8481725b60f1f648407c45faa083f70f595201aea03d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e6fb95bfb5f1a67ca59d8481725b60f1f648407c45faa083f70f595201aea03d", kill_on_drop: false }` [INFO] [stdout] e6fb95bfb5f1a67ca59d8481725b60f1f648407c45faa083f70f595201aea03d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+dec9417b8611e34e787a3e4c37686b5131f9e5c5" "build" "--frozen" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa17f383345bbaa61ddf31baae3e2723da142d016edc154b97d795210555b013 [INFO] running `Command { std: "docker" "start" "-a" "fa17f383345bbaa61ddf31baae3e2723da142d016edc154b97d795210555b013", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling cfg-if v0.1.10 [INFO] [stderr] Compiling futures v0.1.31 [INFO] [stderr] Compiling maybe-uninit v2.0.0 [INFO] [stderr] Compiling semver-parser v0.7.0 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling cc v1.2.59 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling lock_api v0.3.4 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling encoding_index_tests v0.1.4 [INFO] [stderr] Compiling iovec v0.1.4 [INFO] [stderr] Compiling num_cpus v1.17.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling openssl v0.10.76 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling net2 v0.2.39 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling bytes v0.4.12 [INFO] [stderr] Compiling native-tls v0.2.18 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling gimli v0.32.3 [INFO] [stderr] Compiling miniz_oxide v0.8.9 [INFO] [stderr] Compiling rustc-demangle v0.1.27 [INFO] [stderr] Compiling encoding-index-tradchinese v1.20141219.5 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling smallvec v0.6.14 [INFO] [stderr] Compiling mio v0.6.23 [INFO] [stderr] Compiling encoding-index-korean v1.20141219.5 [INFO] [stderr] Compiling rustc_version v0.2.3 [INFO] [stderr] Compiling encoding-index-simpchinese v1.20141219.5 [INFO] [stderr] Compiling encoding-index-japanese v1.20141219.5 [INFO] [stderr] Compiling encoding-index-singlebyte v1.20141219.5 [INFO] [stderr] Compiling scoped-tls v0.1.2 [INFO] [stderr] Compiling crossbeam-queue v0.2.3 [INFO] [stderr] Compiling parking_lot_core v0.6.3 [INFO] [stderr] Compiling parking_lot v0.9.0 [INFO] [stderr] Compiling slab v0.3.0 [INFO] [stderr] Compiling encoding v0.2.33 [INFO] [stderr] Compiling toml v0.4.10 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling bufstream v0.1.4 [INFO] [stderr] Compiling yaml-rust v0.3.5 [INFO] [stderr] Compiling crossbeam-deque v0.7.4 [INFO] [stderr] Compiling mio-uds v0.6.8 [INFO] [stderr] Compiling tokio-executor v0.1.10 [INFO] [stderr] Compiling tokio-io v0.1.13 [INFO] [stderr] Compiling tokio-sync v0.1.8 [INFO] [stderr] Compiling openssl-sys v0.9.112 [INFO] [stderr] Compiling tokio-timer v0.1.2 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Compiling tokio-threadpool v0.1.18 [INFO] [stderr] Compiling tokio-codec v0.1.2 [INFO] [stderr] Compiling tokio-current-thread v0.1.7 [INFO] [stderr] Compiling tokio-reactor v0.1.12 [INFO] [stderr] Compiling tokio-timer v0.2.13 [INFO] [stderr] Compiling tokio-mockstream v1.1.0 [INFO] [stderr] Compiling tokio-uds v0.2.7 [INFO] [stderr] Compiling tokio-udp v0.1.6 [INFO] [stderr] Compiling tokio-tcp v0.1.4 [INFO] [stderr] Compiling tokio-fs v0.1.7 [INFO] [stderr] Compiling tokio v0.1.22 [INFO] [stderr] Compiling tokio-core v0.1.18 [INFO] [stderr] Compiling addr2line v0.25.1 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling backtrace v0.3.76 [INFO] [stderr] Compiling failure v0.1.8 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tokio-tls v0.2.1 [INFO] [stderr] Compiling irc v0.13.6 [INFO] [stderr] Compiling irclap v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:91:86 [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:94:45 [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:162:19 [INFO] [stdout] | [INFO] [stdout] 162 | for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 162 - for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] 162 + while let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 162 - for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] 162 + if let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 37.70s [INFO] running `Command { std: "docker" "inspect" "fa17f383345bbaa61ddf31baae3e2723da142d016edc154b97d795210555b013", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa17f383345bbaa61ddf31baae3e2723da142d016edc154b97d795210555b013", kill_on_drop: false }` [INFO] [stdout] fa17f383345bbaa61ddf31baae3e2723da142d016edc154b97d795210555b013 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+dec9417b8611e34e787a3e4c37686b5131f9e5c5" "test" "--frozen" "--no-run" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a87e23268d52de864af49e99cbab53bd3055a5e5131584b4665a99f73800b472 [INFO] running `Command { std: "docker" "start" "-a" "a87e23268d52de864af49e99cbab53bd3055a5e5131584b4665a99f73800b472", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling irclap v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:91:86 [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:94:45 [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:162:19 [INFO] [stdout] | [INFO] [stdout] 162 | for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 162 - for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] 162 + while let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 162 - for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] 162 + if let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/echo.rs:19:67 [INFO] [stdout] | [INFO] [stdout] 19 | fn echo_matches<'a>(matches: clap::ArgMatches<'a>, responder: Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 19 | fn echo_matches<'a>(matches: clap::ArgMatches<'a>, responder: Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:11:12 [INFO] [stdout] | [INFO] [stdout] 11 | #![feature(conservative_impl_trait)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:91:86 [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> examples/echo.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | responder.send_message(&message); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 26 | let _ = responder.send_message(&message); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/lib.rs:94:45 [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 94 | let rstream = Box::new(resp) as Box; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/lib.rs:162:19 [INFO] [stdout] | [INFO] [stdout] 162 | for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 162 - for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] 162 + while let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 162 - for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stdout] 162 + if let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 1.86s [INFO] running `Command { std: "docker" "inspect" "a87e23268d52de864af49e99cbab53bd3055a5e5131584b4665a99f73800b472", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a87e23268d52de864af49e99cbab53bd3055a5e5131584b4665a99f73800b472", kill_on_drop: false }` [INFO] [stdout] a87e23268d52de864af49e99cbab53bd3055a5e5131584b4665a99f73800b472 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+dec9417b8611e34e787a3e4c37686b5131f9e5c5" "test" "--frozen", kill_on_drop: false }` [INFO] [stdout] 095a2953c4ce48fe797229d6563c2ca108b9f045887e106359884ae61460be8f [INFO] running `Command { std: "docker" "start" "-a" "095a2953c4ce48fe797229d6563c2ca108b9f045887e106359884ae61460be8f", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] warning: the feature `conservative_impl_trait` has been stable since 1.26.0 and no longer requires an attribute to enable [INFO] [stderr] --> src/lib.rs:11:12 [INFO] [stderr] | [INFO] [stderr] 11 | #![feature(conservative_impl_trait)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(stable_features)]` on by default [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/lib.rs:91:86 [INFO] [stderr] | [INFO] [stderr] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 91 | impl IrclapCommandProcessor for F where F: for<'af> Fn(clap::ArgMatches<'af>, Box) { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> src/lib.rs:94:45 [INFO] [stderr] | [INFO] [stderr] 94 | let rstream = Box::new(resp) as Box; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 94 | let rstream = Box::new(resp) as Box; [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stderr] --> src/lib.rs:162:19 [INFO] [stderr] | [INFO] [stderr] 162 | for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stderr] help: to check pattern in a loop use `while let` [INFO] [stderr] | [INFO] [stderr] 162 - for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stderr] 162 + while let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stderr] | [INFO] [stderr] help: consider using `if let` to clear intent [INFO] [stderr] | [INFO] [stderr] 162 - for (a, v) in arg_tuple_opt(arg, value) { [INFO] [stderr] 162 + if let Some((a, v)) = arg_tuple_opt(arg, value) { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `irclap` (lib) generated 4 warnings (run `cargo fix --lib -p irclap` to apply 2 suggestions) [INFO] [stderr] warning: `irclap` (lib test) generated 4 warnings (4 duplicates) [INFO] [stderr] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stderr] --> examples/echo.rs:19:67 [INFO] [stderr] | [INFO] [stderr] 19 | fn echo_matches<'a>(matches: clap::ArgMatches<'a>, responder: Box) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stderr] = note: for more information, see [INFO] [stderr] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stderr] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stderr] | [INFO] [stderr] 19 | fn echo_matches<'a>(matches: clap::ArgMatches<'a>, responder: Box) { [INFO] [stderr] | +++ [INFO] [stderr] [INFO] [stderr] warning: unused `Result` that must be used [INFO] [stderr] --> examples/echo.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | responder.send_message(&message); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stderr] help: use `let _ = ...` to ignore the resulting value [INFO] [stderr] | [INFO] [stderr] 26 | let _ = responder.send_message(&message); [INFO] [stderr] | +++++++ [INFO] [stderr] [INFO] [stderr] warning: `irclap` (example "echo") generated 2 warnings (run `cargo fix --example "echo" -p irclap` to apply 1 suggestion) [INFO] [stderr] Finished `test` profile [unoptimized + debuginfo] target(s) in 0.21s [INFO] [stderr] Running unittests src/lib.rs (/opt/rustwide/target/debug/deps/irclap-dfcf299c756d6ea3) [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test irc_util::test::can_strip_botname_from_msg ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s [INFO] [stdout] [INFO] [stderr] Doc-tests irclap [INFO] [stdout] [INFO] [stdout] running 1 test [INFO] [stdout] test src/lib.rs - IrclapSimpleContextMapping::user_only (line 131) ... ok [INFO] [stdout] [INFO] [stdout] test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.69s [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "095a2953c4ce48fe797229d6563c2ca108b9f045887e106359884ae61460be8f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "095a2953c4ce48fe797229d6563c2ca108b9f045887e106359884ae61460be8f", kill_on_drop: false }` [INFO] [stdout] 095a2953c4ce48fe797229d6563c2ca108b9f045887e106359884ae61460be8f