[INFO] fetching crate sodium-rust 2.1.2... [INFO] checking sodium-rust-2.1.2 against master#bbe853615821442ef11d6cd42a30a73432b38d89 for pr-154205 [INFO] extracting crate sodium-rust 2.1.2 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate sodium-rust 2.1.2 [INFO] finished tweaking crates.io crate sodium-rust 2.1.2 [INFO] tweaked toml for crates.io crate sodium-rust 2.1.2 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate sodium-rust 2.1.2 on toolchain bbe853615821442ef11d6cd42a30a73432b38d89 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 67 packages to latest compatible versions [INFO] [stderr] Adding criterion v0.3.6 (available: v0.8.2) [INFO] [stderr] Adding env_logger v0.9.3 (available: v0.11.10) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded criterion-plot v0.4.5 [INFO] [stderr] Downloaded half v1.8.3 [INFO] [stderr] Downloaded serde_cbor v0.11.2 [INFO] [stderr] Downloaded env_logger v0.9.3 [INFO] [stderr] Downloaded criterion v0.3.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5c9c8ec1ea562526dd46757e2a716902d22ff6ad0a7ec8c57bdc72ffb3138ebd [INFO] running `Command { std: "docker" "start" "-a" "5c9c8ec1ea562526dd46757e2a716902d22ff6ad0a7ec8c57bdc72ffb3138ebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5c9c8ec1ea562526dd46757e2a716902d22ff6ad0a7ec8c57bdc72ffb3138ebd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5c9c8ec1ea562526dd46757e2a716902d22ff6ad0a7ec8c57bdc72ffb3138ebd", kill_on_drop: false }` [INFO] [stdout] 5c9c8ec1ea562526dd46757e2a716902d22ff6ad0a7ec8c57bdc72ffb3138ebd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b7600ce443544e5a4e37d4610153ef6b893706b82a2b826c9d5f22c9942068dd [INFO] running `Command { std: "docker" "start" "-a" "b7600ce443544e5a4e37d4610153ef6b893706b82a2b826c9d5f22c9942068dd", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling autocfg v1.5.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking itoa v1.0.18 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking ryu v1.0.23 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking oorandom v11.1.5 [INFO] [stderr] Checking humantime v2.3.0 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking sodium-rust v2.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:489:39 [INFO] [stdout] | [INFO] [stdout] 489 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 489 - for firing in &data.firing_op { [INFO] [stdout] 489 + while let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 489 - for firing in &data.firing_op { [INFO] [stdout] 489 + if let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking criterion-plot v0.4.5 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.3.6 [INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/impl_/stream.rs:489:39 [INFO] [stdout] | [INFO] [stdout] 489 | for firing in &data.firing_op { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 489 - for firing in &data.firing_op { [INFO] [stdout] 489 + while let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 489 - for firing in &data.firing_op { [INFO] [stdout] 489 + if let Some(firing) = &data.firing_op { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.87s [INFO] running `Command { std: "docker" "inspect" "b7600ce443544e5a4e37d4610153ef6b893706b82a2b826c9d5f22c9942068dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7600ce443544e5a4e37d4610153ef6b893706b82a2b826c9d5f22c9942068dd", kill_on_drop: false }` [INFO] [stdout] b7600ce443544e5a4e37d4610153ef6b893706b82a2b826c9d5f22c9942068dd