[INFO] fetching crate bytekey2 0.4.5... [INFO] checking bytekey2-0.4.5 against master#bbe853615821442ef11d6cd42a30a73432b38d89 for pr-154205 [INFO] extracting crate bytekey2 0.4.5 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate bytekey2 0.4.5 [INFO] finished tweaking crates.io crate bytekey2 0.4.5 [INFO] tweaked toml for crates.io crate bytekey2 0.4.5 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate bytekey2 0.4.5 on toolchain bbe853615821442ef11d6cd42a30a73432b38d89 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded utf-8 v0.7.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f3a61dcabda2df3974b71d4f93d67ff15e701ddd17cafcf280be10659d625226 [INFO] running `Command { std: "docker" "start" "-a" "f3a61dcabda2df3974b71d4f93d67ff15e701ddd17cafcf280be10659d625226", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f3a61dcabda2df3974b71d4f93d67ff15e701ddd17cafcf280be10659d625226", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f3a61dcabda2df3974b71d4f93d67ff15e701ddd17cafcf280be10659d625226", kill_on_drop: false }` [INFO] [stdout] f3a61dcabda2df3974b71d4f93d67ff15e701ddd17cafcf280be10659d625226 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+bbe853615821442ef11d6cd42a30a73432b38d89" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] be034cd323e71866b742c6fa31f19d14fbb46a546bafb590488b607769d8667f [INFO] running `Command { std: "docker" "start" "-a" "be034cd323e71866b742c6fa31f19d14fbb46a546bafb590488b607769d8667f", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling zerocopy v0.8.47 [INFO] [stderr] Checking cfg-if v1.0.4 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling unicode-ident v1.0.24 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking utf-8 v0.7.6 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking bytekey2 v0.4.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/de.rs:196:31 [INFO] [stdout] | [INFO] [stdout] 196 | let f: f32 = unsafe { transmute(val ^ t) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 196 - let f: f32 = unsafe { transmute(val ^ t) }; [INFO] [stdout] 196 + let f: f32 = unsafe { f32::from_bits(i32::cast_unsigned(val ^ t)) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/de.rs:206:31 [INFO] [stdout] | [INFO] [stdout] 206 | let f: f64 = unsafe { transmute(val ^ t) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 206 - let f: f64 = unsafe { transmute(val ^ t) }; [INFO] [stdout] 206 + let f: f64 = unsafe { f64::from_bits(i64::cast_unsigned(val ^ t)) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 461 | { [INFO] [stdout] 462 | impl<'de, 'a, R> serde::de::EnumAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] ... [INFO] [stdout] 480 | impl<'de, 'a, R> serde::de::VariantAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `VariantAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/ser.rs:454:28 [INFO] [stdout] | [INFO] [stdout] 454 | let val = unsafe { transmute::(v) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 454 - let val = unsafe { transmute::(v) }; [INFO] [stdout] 454 + let val = unsafe { f32::to_bits(v).cast_signed() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/ser.rs:466:28 [INFO] [stdout] | [INFO] [stdout] 466 | let val = unsafe { transmute::(v) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 466 - let val = unsafe { transmute::(v) }; [INFO] [stdout] 466 + let val = unsafe { f64::to_bits(v).cast_signed() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/de.rs:196:31 [INFO] [stdout] | [INFO] [stdout] 196 | let f: f32 = unsafe { transmute(val ^ t) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 196 - let f: f32 = unsafe { transmute(val ^ t) }; [INFO] [stdout] 196 + let f: f32 = unsafe { f32::from_bits(i32::cast_unsigned(val ^ t)) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/de.rs:206:31 [INFO] [stdout] | [INFO] [stdout] 206 | let f: f64 = unsafe { transmute(val ^ t) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 206 - let f: f64 = unsafe { transmute(val ^ t) }; [INFO] [stdout] 206 + let f: f64 = unsafe { f64::from_bits(i64::cast_unsigned(val ^ t)) }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:462:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] 461 | { [INFO] [stdout] 462 | impl<'de, 'a, R> serde::de::EnumAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^---------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `EnumAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/de.rs:480:9 [INFO] [stdout] | [INFO] [stdout] 453 | / fn deserialize_enum( [INFO] [stdout] 454 | | self, [INFO] [stdout] 455 | | _name: &'static str, [INFO] [stdout] 456 | | _fields: &'static [&'static str], [INFO] [stdout] ... | [INFO] [stdout] 459 | | where [INFO] [stdout] 460 | | V: Visitor<'de>, [INFO] [stdout] | |________________________- move the `impl` block outside of this method `deserialize_enum` [INFO] [stdout] ... [INFO] [stdout] 480 | impl<'de, 'a, R> serde::de::VariantAccess<'de> for &'a mut Deserializer [INFO] [stdout] | ^^^^^^^^^^^^^^^^^------------------------^^^^^^^^^^^^^^^^^^------------^^^ [INFO] [stdout] | | | [INFO] [stdout] | | `Deserializer` is not local [INFO] [stdout] | `VariantAccess` is not local [INFO] [stdout] | [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/ser.rs:454:28 [INFO] [stdout] | [INFO] [stdout] 454 | let val = unsafe { transmute::(v) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 454 - let val = unsafe { transmute::(v) }; [INFO] [stdout] 454 + let val = unsafe { f32::to_bits(v).cast_signed() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/ser.rs:466:28 [INFO] [stdout] | [INFO] [stdout] 466 | let val = unsafe { transmute::(v) }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 466 - let val = unsafe { transmute::(v) }; [INFO] [stdout] 466 + let val = unsafe { f64::to_bits(v).cast_signed() }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.67s [INFO] running `Command { std: "docker" "inspect" "be034cd323e71866b742c6fa31f19d14fbb46a546bafb590488b607769d8667f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "be034cd323e71866b742c6fa31f19d14fbb46a546bafb590488b607769d8667f", kill_on_drop: false }` [INFO] [stdout] be034cd323e71866b742c6fa31f19d14fbb46a546bafb590488b607769d8667f