[INFO] cloning repository https://github.com/macdonaldo/monkey [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/macdonaldo/monkey" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmacdonaldo%2Fmonkey", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmacdonaldo%2Fmonkey'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1728597c8942f215429d4c6f17c8d74587f226da [INFO] checking macdonaldo/monkey against try#4907eac94165faff6c5e5e015670b1c584275f7b for pr-154149 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fmacdonaldo%2Fmonkey" "/workspace/builds/worker-7-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/macdonaldo/monkey [INFO] removed 0 missing tests [INFO] finished tweaking git repo https://github.com/macdonaldo/monkey [INFO] tweaked toml for git repo https://github.com/macdonaldo/monkey written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/macdonaldo/monkey on toolchain 4907eac94165faff6c5e5e015670b1c584275f7b [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4907eac94165faff6c5e5e015670b1c584275f7b" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/macdonaldo/monkey already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4907eac94165faff6c5e5e015670b1c584275f7b" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+4907eac94165faff6c5e5e015670b1c584275f7b" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] dc6f4db772beba307c20ca77f88657b94cf8c7254a713ed917c02aea36bf1399 [INFO] running `Command { std: "docker" "start" "-a" "dc6f4db772beba307c20ca77f88657b94cf8c7254a713ed917c02aea36bf1399", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "dc6f4db772beba307c20ca77f88657b94cf8c7254a713ed917c02aea36bf1399", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dc6f4db772beba307c20ca77f88657b94cf8c7254a713ed917c02aea36bf1399", kill_on_drop: false }` [INFO] [stdout] dc6f4db772beba307c20ca77f88657b94cf8c7254a713ed917c02aea36bf1399 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+4907eac94165faff6c5e5e015670b1c584275f7b" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbc88845abcdc7e7f7b3a92f550be3afb0bc80beda7da9aecb7ceaac49d582f8 [INFO] running `Command { std: "docker" "start" "-a" "cbc88845abcdc7e7f7b3a92f550be3afb0bc80beda7da9aecb7ceaac49d582f8", kill_on_drop: false }` [INFO] [stderr] Checking monkey v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> tests/parser.rs:787:45 [INFO] [stdout] | [INFO] [stdout] 787 | for (expr, expected) in parameters.iter().zip(expected_params.iter()).next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to iterate over `parameters.iter().zip(expected_params.iter())` remove the call to `next` [INFO] [stdout] | [INFO] [stdout] 787 - for (expr, expected) in parameters.iter().zip(expected_params.iter()).next() { [INFO] [stdout] 787 + for (expr, expected) in parameters.iter().zip(expected_params.iter()).by_ref() { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 787 - for (expr, expected) in parameters.iter().zip(expected_params.iter()).next() { [INFO] [stdout] 787 + if let Some((expr, expected)) = parameters.iter().zip(expected_params.iter()).next() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.51s [INFO] running `Command { std: "docker" "inspect" "cbc88845abcdc7e7f7b3a92f550be3afb0bc80beda7da9aecb7ceaac49d582f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbc88845abcdc7e7f7b3a92f550be3afb0bc80beda7da9aecb7ceaac49d582f8", kill_on_drop: false }` [INFO] [stdout] cbc88845abcdc7e7f7b3a92f550be3afb0bc80beda7da9aecb7ceaac49d582f8