[INFO] fetching crate hoymiles-rs 1.2.1... [INFO] checking hoymiles-rs-1.2.1 against master#a33907a7a5381473eec8bcfa0c56e05a856a911c for pr-151539 [INFO] extracting crate hoymiles-rs 1.2.1 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate hoymiles-rs 1.2.1 [INFO] finished tweaking crates.io crate hoymiles-rs 1.2.1 [INFO] tweaked toml for crates.io crate hoymiles-rs 1.2.1 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate hoymiles-rs 1.2.1 on toolchain a33907a7a5381473eec8bcfa0c56e05a856a911c [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a33907a7a5381473eec8bcfa0c56e05a856a911c" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate hoymiles-rs 1.2.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+a33907a7a5381473eec8bcfa0c56e05a856a911c" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serde_derive v1.0.202 [INFO] [stderr] Downloaded parking_lot v0.12.2 [INFO] [stderr] Downloaded serde v1.0.202 [INFO] [stderr] Downloaded syn v2.0.64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:61361fe0aef631f17e9d025a70c5a647956f8c671dd02950a60ad3f5cc5526d7" "/opt/rustwide/cargo-home/bin/cargo" "+a33907a7a5381473eec8bcfa0c56e05a856a911c" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] bb1ff11b5e667cd15c7bb7e4ce06d6ca465e5fbace49984a2e95bcda21334c62 [INFO] running `Command { std: "docker" "start" "-a" "bb1ff11b5e667cd15c7bb7e4ce06d6ca465e5fbace49984a2e95bcda21334c62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "bb1ff11b5e667cd15c7bb7e4ce06d6ca465e5fbace49984a2e95bcda21334c62", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bb1ff11b5e667cd15c7bb7e4ce06d6ca465e5fbace49984a2e95bcda21334c62", kill_on_drop: false }` [INFO] [stdout] bb1ff11b5e667cd15c7bb7e4ce06d6ca465e5fbace49984a2e95bcda21334c62 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:61361fe0aef631f17e9d025a70c5a647956f8c671dd02950a60ad3f5cc5526d7" "/opt/rustwide/cargo-home/bin/cargo" "+a33907a7a5381473eec8bcfa0c56e05a856a911c" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a99ea6fa236b8c0adaf0c5b0a1bd3efa23b92b8cd1970d0deaaffe73a44fbb18 [INFO] running `Command { std: "docker" "start" "-a" "a99ea6fa236b8c0adaf0c5b0a1bd3efa23b92b8cd1970d0deaaffe73a44fbb18", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.82 [INFO] [stderr] Compiling either v1.12.0 [INFO] [stderr] Checking bytes v1.6.0 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling cc v1.0.98 [INFO] [stderr] Compiling serde v1.0.202 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Compiling linux-raw-sys v0.4.14 [INFO] [stderr] Compiling bitflags v2.5.0 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling itertools v0.10.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling home v0.5.9 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Compiling regex-syntax v0.8.3 [INFO] [stderr] Compiling equivalent v1.0.1 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_json v1.0.117 [INFO] [stderr] Compiling unicode-segmentation v1.11.0 [INFO] [stderr] Compiling fastrand v2.1.0 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking parking_lot v0.12.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking anstyle-query v1.0.3 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling lazy_static v1.4.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Compiling syn v2.0.64 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking clap_lex v0.7.0 [INFO] [stderr] Compiling openssl-sys v0.9.102 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Compiling indexmap v2.2.6 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking dirs-sys v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.2 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking dirs v4.0.0 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Compiling which v4.4.2 [INFO] [stderr] Compiling tempfile v3.10.1 [INFO] [stderr] Compiling prost-build v0.9.0 [INFO] [stderr] Checking matchers v0.0.1 [INFO] [stderr] Compiling prost-derive v0.9.0 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Compiling prost v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.202 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.5.4 [INFO] [stderr] Checking prost-types v0.9.0 [INFO] [stderr] Checking tokio v1.37.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling hoymiles-rs v1.2.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking clap v4.5.4 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking tracing-serde v0.1.3 [INFO] [stderr] Checking csv v1.3.0 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking tracing-subscriber v0.2.25 [INFO] [stderr] Checking hyper v0.14.28 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/components/power/mod.rs:39:39 [INFO] [stdout] | [INFO] [stdout] 39 | for record in &power_data { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 39 - for record in &power_data { [INFO] [stdout] 39 + while let Ok(record) = &power_data { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 39 - for record in &power_data { [INFO] [stdout] 39 + if let Ok(record) = &power_data { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `&Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/components/power/mod.rs:39:39 [INFO] [stdout] | [INFO] [stdout] 39 | for record in &power_data { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 39 - for record in &power_data { [INFO] [stdout] 39 + while let Ok(record) = &power_data { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 39 - for record in &power_data { [INFO] [stdout] 39 + if let Ok(record) = &power_data { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.28s [INFO] running `Command { std: "docker" "inspect" "a99ea6fa236b8c0adaf0c5b0a1bd3efa23b92b8cd1970d0deaaffe73a44fbb18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a99ea6fa236b8c0adaf0c5b0a1bd3efa23b92b8cd1970d0deaaffe73a44fbb18", kill_on_drop: false }` [INFO] [stdout] a99ea6fa236b8c0adaf0c5b0a1bd3efa23b92b8cd1970d0deaaffe73a44fbb18