[INFO] cloning repository https://github.com/JaredArrowood/Homework-4 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/JaredArrowood/Homework-4" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaredArrowood%2FHomework-4", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaredArrowood%2FHomework-4'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] ac8ec323fb8e5e57aa94ec3ff0dcaeebe18bc955 [INFO] checking JaredArrowood/Homework-4/ac8ec323fb8e5e57aa94ec3ff0dcaeebe18bc955 against master#da2544bfbe84df7b24d83c029c74299ebf6112c6 for pr-149681 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FJaredArrowood%2FHomework-4" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/JaredArrowood/Homework-4 [INFO] finished tweaking git repo https://github.com/JaredArrowood/Homework-4 [INFO] tweaked toml for git repo https://github.com/JaredArrowood/Homework-4 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/JaredArrowood/Homework-4 on toolchain da2544bfbe84df7b24d83c029c74299ebf6112c6 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da2544bfbe84df7b24d83c029c74299ebf6112c6" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/JaredArrowood/Homework-4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+da2544bfbe84df7b24d83c029c74299ebf6112c6" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:845e597a41426bbf2703be69acdb67d10b6de511142d05cba7bbe119c898b2c7" "/opt/rustwide/cargo-home/bin/cargo" "+da2544bfbe84df7b24d83c029c74299ebf6112c6" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a021aeb2774e8fd199b3290b550030a538dd22a5f4a3553104034bb68463cc57 [INFO] running `Command { std: "docker" "start" "-a" "a021aeb2774e8fd199b3290b550030a538dd22a5f4a3553104034bb68463cc57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a021aeb2774e8fd199b3290b550030a538dd22a5f4a3553104034bb68463cc57", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a021aeb2774e8fd199b3290b550030a538dd22a5f4a3553104034bb68463cc57", kill_on_drop: false }` [INFO] [stdout] a021aeb2774e8fd199b3290b550030a538dd22a5f4a3553104034bb68463cc57 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:845e597a41426bbf2703be69acdb67d10b6de511142d05cba7bbe119c898b2c7" "/opt/rustwide/cargo-home/bin/cargo" "+da2544bfbe84df7b24d83c029c74299ebf6112c6" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 14e9f4d7492c103ff0918a7e151e1ca61b15d81dd08dfa7c11d3318aad5f3054 [INFO] running `Command { std: "docker" "start" "-a" "14e9f4d7492c103ff0918a7e151e1ca61b15d81dd08dfa7c11d3318aad5f3054", kill_on_drop: false }` [INFO] [stderr] Checking homework4 v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | if(_n == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 6 - if(_n == 0) [INFO] [stdout] 6 + if _n == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | if(_n == 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - if(_n == 1) [INFO] [stdout] 11 + if _n == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | if(string == rev_string) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - if(string == rev_string) [INFO] [stdout] 28 + if string == rev_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:39:7 [INFO] [stdout] | [INFO] [stdout] 39 | if(_n >= vec.len()) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - if(_n >= vec.len()) [INFO] [stdout] 39 + if _n >= vec.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:60:11 [INFO] [stdout] | [INFO] [stdout] 60 | if(*count > max_count) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if(*count > max_count) [INFO] [stdout] 60 + if *count > max_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:66:7 [INFO] [stdout] | [INFO] [stdout] 66 | if(max_count == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - if(max_count == 0) [INFO] [stdout] 66 + if max_count == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:79:7 [INFO] [stdout] | [INFO] [stdout] 79 | if(_arr1.len() != _arr2.len()) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 79 - if(_arr1.len() != _arr2.len()) [INFO] [stdout] 79 + if _arr1.len() != _arr2.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:147:11 [INFO] [stdout] | [INFO] [stdout] 147 | if(self.entries.iter().any(|entry| entry.name == _name)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 147 - if(self.entries.iter().any(|entry| entry.name == _name)) [INFO] [stdout] 147 + if self.entries.iter().any(|entry| entry.name == _name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:152:11 [INFO] [stdout] | [INFO] [stdout] 152 | if(parts.len() != 3 || parts[0].len() != 3 || parts[1].len() != 3 || parts[2].len() != 4 || [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 155 | !parts[2].chars().all(|c| c.is_digit(10))) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 152 ~ if parts.len() != 3 || parts[0].len() != 3 || parts[1].len() != 3 || parts[2].len() != 4 || [INFO] [stdout] 153 | !parts[0].chars().all(|c| c.is_digit(10)) || [INFO] [stdout] 154 | !parts[1].chars().all(|c| c.is_digit(10)) || [INFO] [stdout] 155 ~ !parts[2].chars().all(|c| c.is_digit(10)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:159:11 [INFO] [stdout] | [INFO] [stdout] 159 | if(_is_listed && self.entries.iter().any(|entry| entry.number == _number && entry.is_listed)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 159 - if(_is_listed && self.entries.iter().any(|entry| entry.number == _number && entry.is_listed)) [INFO] [stdout] 159 + if _is_listed && self.entries.iter().any(|entry| entry.number == _number && entry.is_listed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:178:15 [INFO] [stdout] | [INFO] [stdout] 178 | if(entry.name == _name && entry.is_listed) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 178 - if(entry.name == _name && entry.is_listed) [INFO] [stdout] 178 + if entry.name == _name && entry.is_listed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:6:7 [INFO] [stdout] | [INFO] [stdout] 6 | if(_n == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 6 - if(_n == 0) [INFO] [stdout] 6 + if _n == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:11:7 [INFO] [stdout] | [INFO] [stdout] 11 | if(_n == 1) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 11 - if(_n == 1) [INFO] [stdout] 11 + if _n == 1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:28:7 [INFO] [stdout] | [INFO] [stdout] 28 | if(string == rev_string) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 28 - if(string == rev_string) [INFO] [stdout] 28 + if string == rev_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:39:7 [INFO] [stdout] | [INFO] [stdout] 39 | if(_n >= vec.len()) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 39 - if(_n >= vec.len()) [INFO] [stdout] 39 + if _n >= vec.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:60:11 [INFO] [stdout] | [INFO] [stdout] 60 | if(*count > max_count) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 60 - if(*count > max_count) [INFO] [stdout] 60 + if *count > max_count [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:66:7 [INFO] [stdout] | [INFO] [stdout] 66 | if(max_count == 0) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 66 - if(max_count == 0) [INFO] [stdout] 66 + if max_count == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:79:7 [INFO] [stdout] | [INFO] [stdout] 79 | if(_arr1.len() != _arr2.len()) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 79 - if(_arr1.len() != _arr2.len()) [INFO] [stdout] 79 + if _arr1.len() != _arr2.len() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:147:11 [INFO] [stdout] | [INFO] [stdout] 147 | if(self.entries.iter().any(|entry| entry.name == _name)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 147 - if(self.entries.iter().any(|entry| entry.name == _name)) [INFO] [stdout] 147 + if self.entries.iter().any(|entry| entry.name == _name) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:152:11 [INFO] [stdout] | [INFO] [stdout] 152 | if(parts.len() != 3 || parts[0].len() != 3 || parts[1].len() != 3 || parts[2].len() != 4 || [INFO] [stdout] | ^ [INFO] [stdout] ... [INFO] [stdout] 155 | !parts[2].chars().all(|c| c.is_digit(10))) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 152 ~ if parts.len() != 3 || parts[0].len() != 3 || parts[1].len() != 3 || parts[2].len() != 4 || [INFO] [stdout] 153 | !parts[0].chars().all(|c| c.is_digit(10)) || [INFO] [stdout] 154 | !parts[1].chars().all(|c| c.is_digit(10)) || [INFO] [stdout] 155 ~ !parts[2].chars().all(|c| c.is_digit(10)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:159:11 [INFO] [stdout] | [INFO] [stdout] 159 | if(_is_listed && self.entries.iter().any(|entry| entry.number == _number && entry.is_listed)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 159 - if(_is_listed && self.entries.iter().any(|entry| entry.number == _number && entry.is_listed)) [INFO] [stdout] 159 + if _is_listed && self.entries.iter().any(|entry| entry.number == _number && entry.is_listed) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around `if` condition [INFO] [stdout] --> src/lib.rs:178:15 [INFO] [stdout] | [INFO] [stdout] 178 | if(entry.name == _name && entry.is_listed) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 178 - if(entry.name == _name && entry.is_listed) [INFO] [stdout] 178 + if entry.name == _name && entry.is_listed [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.37s [INFO] running `Command { std: "docker" "inspect" "14e9f4d7492c103ff0918a7e151e1ca61b15d81dd08dfa7c11d3318aad5f3054", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "14e9f4d7492c103ff0918a7e151e1ca61b15d81dd08dfa7c11d3318aad5f3054", kill_on_drop: false }` [INFO] [stdout] 14e9f4d7492c103ff0918a7e151e1ca61b15d81dd08dfa7c11d3318aad5f3054