[INFO] cloning repository https://github.com/EdMcBane/rustyworld
[INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/EdMcBane/rustyworld" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdMcBane%2Frustyworld", kill_on_drop: false }`
[INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdMcBane%2Frustyworld'...
[INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }`
[INFO] [stdout] 2e9a5ab1ba800b625ef1a9f90863d31126e6f8fb
[INFO] checking EdMcBane/rustyworld against master#24139cf844095e574708faf406034dc78cb39143 for pr-149518-1
[INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FEdMcBane%2Frustyworld" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }`
[INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'...
[INFO] [stderr] done.
[INFO] started tweaking git repo https://github.com/EdMcBane/rustyworld
[INFO] finished tweaking git repo https://github.com/EdMcBane/rustyworld
[INFO] tweaked toml for git repo https://github.com/EdMcBane/rustyworld written to /workspace/builds/worker-4-tc1/source/Cargo.toml
[INFO] validating manifest of git repo https://github.com/EdMcBane/rustyworld on toolchain 24139cf844095e574708faf406034dc78cb39143
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+24139cf844095e574708faf406034dc78cb39143" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate git repo https://github.com/EdMcBane/rustyworld already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+24139cf844095e574708faf406034dc78cb39143" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]     Blocking waiting for file lock on package cache
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded quote v1.0.35
[INFO] [stderr]   Downloaded thiserror-impl v1.0.58
[INFO] [stderr]   Downloaded proc-macro2 v1.0.79
[INFO] [stderr]   Downloaded windows-targets v0.52.4
[INFO] [stderr]   Downloaded peeking_take_while v0.1.2
[INFO] [stderr]   Downloaded strsim v0.8.0
[INFO] [stderr]   Downloaded strsim v0.10.0
[INFO] [stderr]   Downloaded wayland-sys v0.28.6
[INFO] [stderr]   Downloaded proc-macro-hack v0.5.20+deprecated
[INFO] [stderr]   Downloaded raw-window-handle v0.3.4
[INFO] [stderr]   Downloaded arr_macro_impl v0.1.3
[INFO] [stderr]   Downloaded shlex v0.1.1
[INFO] [stderr]   Downloaded wayland-scanner v0.28.6
[INFO] [stderr]   Downloaded unicode-width v0.1.11
[INFO] [stderr]   Downloaded wayland-commons v0.28.6
[INFO] [stderr]   Downloaded ndk v0.6.0
[INFO] [stderr]   Downloaded xml-rs v0.8.19
[INFO] [stderr]   Downloaded wayland-client v0.28.6
[INFO] [stderr]   Downloaded indexmap v2.2.5
[INFO] [stderr]   Downloaded num-bigint v0.4.4
[INFO] [stderr]   Downloaded wayland-protocols v0.28.6
[INFO] [stderr]   Downloaded combine v4.6.6
[INFO] [stderr]   Downloaded hashbrown v0.14.3
[INFO] [stderr]   Downloaded sdl2 v0.35.2
[INFO] [stderr]   Downloaded clap v2.34.0
[INFO] [stderr]   Downloaded bindgen v0.56.0
[INFO] [stderr]   Downloaded nix v0.20.0
[INFO] [stderr]   Downloaded nix v0.23.2
[INFO] [stderr]   Downloaded regex v1.10.3
[INFO] [stderr]   Downloaded ndk-sys v0.3.0
[INFO] [stderr]   Downloaded syn v2.0.53
[INFO] [stderr]   Downloaded oboe-sys v0.4.5
[INFO] [stderr]   Downloaded nom v5.1.3
[INFO] [stderr]   Downloaded rustix v0.38.32
[INFO] [stderr]   Downloaded regex-syntax v0.8.2
[INFO] [stderr]   Downloaded memchr v2.7.1
[INFO] [stderr]   Downloaded cc v1.0.90
[INFO] [stderr]   Downloaded windows_aarch64_gnullvm v0.52.4
[INFO] [stderr]   Downloaded windows_x86_64_gnullvm v0.52.4
[INFO] [stderr]   Downloaded bumpalo v3.15.4
[INFO] [stderr]   Downloaded minifb v0.19.3
[INFO] [stderr]   Downloaded alsa v0.6.0
[INFO] [stderr]   Downloaded darling_core v0.13.4
[INFO] [stderr]   Downloaded bytes v1.5.0
[INFO] [stderr]   Downloaded stdweb v0.1.3
[INFO] [stderr]   Downloaded env_logger v0.8.4
[INFO] [stderr]   Downloaded coreaudio-rs v0.10.0
[INFO] [stderr]   Downloaded parking_lot v0.11.2
[INFO] [stderr]   Downloaded xkb v0.2.1
[INFO] [stderr]   Downloaded textwrap v0.11.0
[INFO] [stderr]   Downloaded xkbcommon-sys v0.7.5
[INFO] [stderr]   Downloaded num-rational v0.4.1
[INFO] [stderr]   Downloaded mach v0.3.2
[INFO] [stderr]   Downloaded jobserver v0.1.28
[INFO] [stderr]   Downloaded oboe v0.4.6
[INFO] [stderr]   Downloaded libc v0.2.153
[INFO] [stderr]   Downloaded lock_api v0.4.11
[INFO] [stderr]   Downloaded windows_aarch64_msvc v0.52.4
[INFO] [stderr]   Downloaded windows_x86_64_msvc v0.52.4
[INFO] [stderr]   Downloaded windows_x86_64_gnu v0.52.4
[INFO] [stderr]   Downloaded windows_i686_gnu v0.52.4
[INFO] [stderr]   Downloaded redox_syscall v0.2.16
[INFO] [stderr]   Downloaded windows_i686_msvc v0.52.4
[INFO] [stderr]   Downloaded num-complex v0.4.5
[INFO] [stderr]   Downloaded either v1.10.0
[INFO] [stderr]   Downloaded ansi_term v0.12.1
[INFO] [stderr]   Downloaded ndk-glue v0.6.2
[INFO] [stderr]   Downloaded parking_lot_core v0.8.6
[INFO] [stderr]   Downloaded arr_macro v0.1.3
[INFO] [stderr]   Downloaded cty v0.2.2
[INFO] [stderr]   Downloaded fastrand v2.0.1
[INFO] [stderr]   Downloaded downcast-rs v1.2.0
[INFO] [stderr]   Downloaded autocfg v1.1.0
[INFO] [stderr]   Downloaded cpal v0.13.5
[INFO] [stderr]   Downloaded wayland-cursor v0.28.6
[INFO] [stderr]   Downloaded cexpr v0.4.0
[INFO] [stderr]   Downloaded darling v0.13.4
[INFO] [stderr]   Downloaded thiserror v1.0.58
[INFO] [stderr]   Downloaded version-compare v0.1.1
[INFO] [stderr]   Downloaded raw-window-handle v0.4.3
[INFO] [stderr]   Downloaded num-iter v0.1.44
[INFO] [stderr]   Downloaded ndk-macro v0.3.0
[INFO] [stderr]   Downloaded winapi-util v0.1.6
[INFO] [stderr]   Downloaded num-derive v0.3.3
[INFO] [stderr]   Downloaded which v3.1.1
[INFO] [stderr]   Downloaded num v0.4.1
[INFO] [stderr]   Downloaded darling_macro v0.13.4
[INFO] [stderr]   Downloaded sdl2-sys v0.35.2
[INFO] [stderr]   Downloaded rodio v0.14.0
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:845e597a41426bbf2703be69acdb67d10b6de511142d05cba7bbe119c898b2c7" "/opt/rustwide/cargo-home/bin/cargo" "+24139cf844095e574708faf406034dc78cb39143" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 0e64fbc00640fffeed8469f17a93cbd60cbf5ba69925e6894762d599d568d61c
[INFO] running `Command { std: "docker" "start" "-a" "0e64fbc00640fffeed8469f17a93cbd60cbf5ba69925e6894762d599d568d61c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "0e64fbc00640fffeed8469f17a93cbd60cbf5ba69925e6894762d599d568d61c", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0e64fbc00640fffeed8469f17a93cbd60cbf5ba69925e6894762d599d568d61c", kill_on_drop: false }`
[INFO] [stdout] 0e64fbc00640fffeed8469f17a93cbd60cbf5ba69925e6894762d599d568d61c
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:845e597a41426bbf2703be69acdb67d10b6de511142d05cba7bbe119c898b2c7" "/opt/rustwide/cargo-home/bin/cargo" "+24139cf844095e574708faf406034dc78cb39143" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 40ca8ba21f207dd2830cc2bf384d903bc651a1bb99fb6ba79a7e0c2d9cb9edbb
[INFO] running `Command { std: "docker" "start" "-a" "40ca8ba21f207dd2830cc2bf384d903bc651a1bb99fb6ba79a7e0c2d9cb9edbb", kill_on_drop: false }`
[INFO] [stderr]    Compiling libc v0.2.153
[INFO] [stderr]    Compiling proc-macro2 v1.0.79
[INFO] [stderr]    Compiling unicode-ident v1.0.12
[INFO] [stderr]    Compiling autocfg v1.1.0
[INFO] [stderr]    Compiling pkg-config v0.3.30
[INFO] [stderr]     Checking cfg-if v1.0.0
[INFO] [stderr]    Compiling memchr v2.7.1
[INFO] [stderr]     Checking bitflags v1.3.2
[INFO] [stderr]    Compiling version_check v0.9.4
[INFO] [stderr]    Compiling glob v0.3.1
[INFO] [stderr]    Compiling xml-rs v0.8.19
[INFO] [stderr]    Compiling nom v5.1.3
[INFO] [stderr]    Compiling clang-sys v1.7.0
[INFO] [stderr]    Compiling aho-corasick v1.1.3
[INFO] [stderr]    Compiling regex-syntax v0.8.2
[INFO] [stderr]     Checking smallvec v1.13.2
[INFO] [stderr]    Compiling num-traits v0.2.18
[INFO] [stderr]    Compiling unicode-width v0.1.11
[INFO] [stderr]    Compiling libloading v0.8.3
[INFO] [stderr]    Compiling textwrap v0.11.0
[INFO] [stderr]    Compiling quote v1.0.35
[INFO] [stderr]    Compiling wayland-sys v0.28.6
[INFO] [stderr]    Compiling wayland-scanner v0.28.6
[INFO] [stderr]    Compiling bindgen v0.56.0
[INFO] [stderr]    Compiling strsim v0.8.0
[INFO] [stderr]    Compiling log v0.4.21
[INFO] [stderr]    Compiling termcolor v1.4.1
[INFO] [stderr]    Compiling humantime v2.1.0
[INFO] [stderr]    Compiling atty v0.2.14
[INFO] [stderr]    Compiling vec_map v0.8.2
[INFO] [stderr]    Compiling ansi_term v0.12.1
[INFO] [stderr]    Compiling which v3.1.1
[INFO] [stderr]    Compiling clap v2.34.0
[INFO] [stderr]    Compiling memoffset v0.6.5
[INFO] [stderr]    Compiling shlex v0.1.1
[INFO] [stderr]    Compiling peeking_take_while v0.1.2
[INFO] [stderr]     Checking once_cell v1.19.0
[INFO] [stderr]    Compiling lazy_static v1.4.0
[INFO] [stderr]    Compiling lazycell v1.3.0
[INFO] [stderr]    Compiling rustc-hash v1.1.0
[INFO] [stderr]    Compiling wayland-client v0.28.6
[INFO] [stderr]    Compiling cexpr v0.4.0
[INFO] [stderr]     Checking nix v0.20.0
[INFO] [stderr]    Compiling alsa-sys v0.3.1
[INFO] [stderr]    Compiling lock_api v0.4.11
[INFO] [stderr]    Compiling parking_lot_core v0.8.6
[INFO] [stderr]    Compiling regex-automata v0.4.6
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]    Compiling jobserver v0.1.28
[INFO] [stderr]    Compiling syn v2.0.53
[INFO] [stderr]    Compiling num-bigint v0.4.4
[INFO] [stderr]     Checking instant v0.1.12
[INFO] [stderr]    Compiling rustix v0.38.32
[INFO] [stderr]     Checking downcast-rs v1.2.0
[INFO] [stderr]    Compiling proc-macro-hack v0.5.20+deprecated
[INFO] [stderr]    Compiling syn v1.0.109
[INFO] [stderr]    Compiling thiserror v1.0.58
[INFO] [stderr]     Checking scopeguard v1.2.0
[INFO] [stderr]    Compiling cc v1.0.90
[INFO] [stderr]     Checking nix v0.23.2
[INFO] [stderr]    Compiling wayland-protocols v0.28.6
[INFO] [stderr]    Compiling x11-dl v2.21.0
[INFO] [stderr]    Compiling num-rational v0.4.1
[INFO] [stderr]    Compiling cpal v0.13.5
[INFO] [stderr]     Checking linux-raw-sys v0.4.13
[INFO] [stderr]    Compiling regex v1.10.3
[INFO] [stderr]     Checking cty v0.2.2
[INFO] [stderr]     Checking bitflags v2.5.0
[INFO] [stderr]     Checking wayland-commons v0.28.6
[INFO] [stderr]    Compiling env_logger v0.8.4
[INFO] [stderr]     Checking raw-window-handle v0.4.3
[INFO] [stderr]    Compiling minifb v0.19.3
[INFO] [stderr]     Checking parking_lot v0.11.2
[INFO] [stderr]     Checking fastrand v2.0.1
[INFO] [stderr]     Checking alsa v0.6.0
[INFO] [stderr]     Checking xcursor v0.3.5
[INFO] [stderr]     Checking wayland-cursor v0.28.6
[INFO] [stderr]     Checking tempfile v3.10.1
[INFO] [stderr]     Checking raw-window-handle v0.3.4
[INFO] [stderr]     Checking num-iter v0.1.44
[INFO] [stderr]     Checking num-complex v0.4.5
[INFO] [stderr]     Checking either v1.10.0
[INFO] [stderr]     Checking byteorder v1.5.0
[INFO] [stderr]     Checking itertools v0.10.5
[INFO] [stderr]     Checking num v0.4.1
[INFO] [stderr]    Compiling thiserror-impl v1.0.58
[INFO] [stderr]    Compiling xkbcommon-sys v0.7.5
[INFO] [stderr]     Checking rodio v0.14.0
[INFO] [stderr]     Checking xkb v0.2.1
[INFO] [stderr]    Compiling arr_macro_impl v0.1.3
[INFO] [stderr]     Checking arr_macro v0.1.3
[INFO] [stderr]     Checking rustyworld v0.1.0 (/opt/rustwide/workdir)
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/vm.rs:372:23
[INFO] [stdout]     |
[INFO] [stdout] 372 |         for res_id in &part.video2_id {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 372 -         for res_id in &part.video2_id {
[INFO] [stdout] 372 +         while let Some(res_id) = &part.video2_id {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 372 -         for res_id in &part.video2_id {
[INFO] [stdout] 372 +         if let Some(res_id) = &part.video2_id {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: for loop over a `&Option`. This is more readably written as an `if let` statement
[INFO] [stdout]    --> src/vm.rs:372:23
[INFO] [stdout]     |
[INFO] [stdout] 372 |         for res_id in &part.video2_id {
[INFO] [stdout]     |                       ^^^^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = note: `#[warn(for_loops_over_fallibles)]` on by default
[INFO] [stdout] help: to check pattern in a loop use `while let`
[INFO] [stdout]     |
[INFO] [stdout] 372 -         for res_id in &part.video2_id {
[INFO] [stdout] 372 +         while let Some(res_id) = &part.video2_id {
[INFO] [stdout]     |
[INFO] [stdout] help: consider using `if let` to clear intent
[INFO] [stdout]     |
[INFO] [stdout] 372 -         for res_id in &part.video2_id {
[INFO] [stdout] 372 +         if let Some(res_id) = &part.video2_id {
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 26s
[INFO] running `Command { std: "docker" "inspect" "40ca8ba21f207dd2830cc2bf384d903bc651a1bb99fb6ba79a7e0c2d9cb9edbb", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "40ca8ba21f207dd2830cc2bf384d903bc651a1bb99fb6ba79a7e0c2d9cb9edbb", kill_on_drop: false }`
[INFO] [stdout] 40ca8ba21f207dd2830cc2bf384d903bc651a1bb99fb6ba79a7e0c2d9cb9edbb
