[INFO] fetching crate vector-expr 0.4.0... [INFO] checking vector-expr-0.4.0 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate vector-expr 0.4.0 into /workspace/builds/worker-4-tc2/source [INFO] removed /workspace/builds/worker-4-tc2/source/.cargo/config.toml [INFO] removed /workspace/builds/worker-4-tc2/source/rust-toolchain.toml [INFO] started tweaking crates.io crate vector-expr 0.4.0 [INFO] finished tweaking crates.io crate vector-expr 0.4.0 [INFO] tweaked toml for crates.io crate vector-expr 0.4.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate vector-expr 0.4.0 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 34 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 86f270fbe4db8f99c64d04baf1ebf61a29153d5497b8ed81a76a952b33a5667c [INFO] running `Command { std: "docker" "start" "-a" "86f270fbe4db8f99c64d04baf1ebf61a29153d5497b8ed81a76a952b33a5667c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "86f270fbe4db8f99c64d04baf1ebf61a29153d5497b8ed81a76a952b33a5667c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "86f270fbe4db8f99c64d04baf1ebf61a29153d5497b8ed81a76a952b33a5667c", kill_on_drop: false }` [INFO] [stdout] 86f270fbe4db8f99c64d04baf1ebf61a29153d5497b8ed81a76a952b33a5667c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0735a383b38352dc1803f6d9ae58aac5a66672cb64323cd29c019d7d2302722 [INFO] running `Command { std: "docker" "start" "-a" "b0735a383b38352dc1803f6d9ae58aac5a66672cb64323cd29c019d7d2302722", kill_on_drop: false }` [INFO] [stderr] Compiling pest_generator v2.8.3 [INFO] [stderr] Compiling pest_derive v2.8.3 [INFO] [stderr] Checking vector-expr v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/parse.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 47 | .filter(|p| (p.as_rule() == Rule::real_variable)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - .filter(|p| (p.as_rule() == Rule::real_variable)) [INFO] [stdout] 47 + .filter(|p| p.as_rule() == Rule::real_variable ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/parse.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | .filter(|p| (p.as_rule() == Rule::str_variable)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - .filter(|p| (p.as_rule() == Rule::str_variable)) [INFO] [stdout] 55 + .filter(|p| p.as_rule() == Rule::str_variable ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/parse.rs:47:25 [INFO] [stdout] | [INFO] [stdout] 47 | .filter(|p| (p.as_rule() == Rule::real_variable)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 47 - .filter(|p| (p.as_rule() == Rule::real_variable)) [INFO] [stdout] 47 + .filter(|p| p.as_rule() == Rule::real_variable ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around closure body [INFO] [stdout] --> src/parse.rs:55:25 [INFO] [stdout] | [INFO] [stdout] 55 | .filter(|p| (p.as_rule() == Rule::str_variable)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 55 - .filter(|p| (p.as_rule() == Rule::str_variable)) [INFO] [stdout] 55 + .filter(|p| p.as_rule() == Rule::str_variable ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/parse.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | if let Ok(value) = literal_str.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/parse.rs:113:36 [INFO] [stdout] | [INFO] [stdout] 113 | if let Ok(value) = literal_str.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vector-expr` (lib) due to 1 previous error; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: irrefutable `if let` pattern [INFO] [stdout] --> src/parse.rs:113:20 [INFO] [stdout] | [INFO] [stdout] 113 | if let Ok(value) = literal_str.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this pattern will always match, so the `if let` is useless [INFO] [stdout] = help: consider replacing the `if let` with a `let` [INFO] [stdout] = note: `#[warn(irrefutable_let_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/parse.rs:113:36 [INFO] [stdout] | [INFO] [stdout] 113 | if let Ok(value) = literal_str.parse::() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `vector-expr` (lib test) due to 1 previous error; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b0735a383b38352dc1803f6d9ae58aac5a66672cb64323cd29c019d7d2302722", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0735a383b38352dc1803f6d9ae58aac5a66672cb64323cd29c019d7d2302722", kill_on_drop: false }` [INFO] [stdout] b0735a383b38352dc1803f6d9ae58aac5a66672cb64323cd29c019d7d2302722