[INFO] fetching crate requiem-router 0.2.4... [INFO] checking requiem-router-0.2.4 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate requiem-router 0.2.4 into /workspace/builds/worker-2-tc2/source [INFO] started tweaking crates.io crate requiem-router 0.2.4 [INFO] finished tweaking crates.io crate requiem-router 0.2.4 [INFO] tweaked toml for crates.io crate requiem-router 0.2.4 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate requiem-router 0.2.4 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] [stderr] Adding bytestring v0.1.5 (available: v1.5.0) [INFO] [stderr] Adding http v0.2.12 (available: v1.3.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 33fec65ff9d71457aa45503a1834dcd3b7055d54e7ba569ed267bbe48954c393 [INFO] running `Command { std: "docker" "start" "-a" "33fec65ff9d71457aa45503a1834dcd3b7055d54e7ba569ed267bbe48954c393", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "33fec65ff9d71457aa45503a1834dcd3b7055d54e7ba569ed267bbe48954c393", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "33fec65ff9d71457aa45503a1834dcd3b7055d54e7ba569ed267bbe48954c393", kill_on_drop: false }` [INFO] [stdout] 33fec65ff9d71457aa45503a1834dcd3b7055d54e7ba569ed267bbe48954c393 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e9448189b414682919ac3bd41845754a9115060c53488d6fd2b319f97c909561 [INFO] running `Command { std: "docker" "start" "-a" "e9448189b414682919ac3bd41845754a9115060c53488d6fd2b319f97c909561", kill_on_drop: false }` [INFO] [stderr] Checking bytestring v0.1.5 [INFO] [stderr] Checking requiem-router v0.2.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/url.rs:34:37 [INFO] [stdout] | [INFO] [stdout] 34 | static DEFAULT_QUOTER: Quoter = { Quoter::new(b"@:", b"/+") }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 34 - static DEFAULT_QUOTER: Quoter = { Quoter::new(b"@:", b"/+") }; [INFO] [stdout] 34 + static DEFAULT_QUOTER: Quoter = Quoter::new(b"@:", b"/+") ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary braces around block return value [INFO] [stdout] --> src/url.rs:34:37 [INFO] [stdout] | [INFO] [stdout] 34 | static DEFAULT_QUOTER: Quoter = { Quoter::new(b"@:", b"/+") }; [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_braces)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these braces [INFO] [stdout] | [INFO] [stdout] 34 - static DEFAULT_QUOTER: Quoter = { Quoter::new(b"@:", b"/+") }; [INFO] [stdout] 34 + static DEFAULT_QUOTER: Quoter = Quoter::new(b"@:", b"/+") ; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `resource` is never read [INFO] [stdout] --> src/router.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct ResourceInfo { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 9 | resource: ResourceId, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResourceInfo` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/de.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | let v = self.path[0].parse().map_err( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 204 | parse_single_value!(deserialize_string, visit_string, "String"); [INFO] [stdout] | --------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] = note: this error originates in the macro `parse_single_value` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/de.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | let v = self.path[0].parse().map_err( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 205 | parse_single_value!(deserialize_byte_buf, visit_string, "String"); [INFO] [stdout] | ----------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `parse_single_value` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/de.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | let v = self.value.parse().map_err( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 299 | parse_value!(deserialize_string, visit_string, "String"); [INFO] [stdout] | -------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `parse_value` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/de.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | let v = self.value.parse().map_err( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 300 | parse_value!(deserialize_byte_buf, visit_string, "String"); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `parse_value` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/path.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn iter(&self) -> PathIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 161 | pub fn iter(&self) -> PathIter<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:297:40 [INFO] [stdout] | [INFO] [stdout] 297 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:329:44 [INFO] [stdout] | [INFO] [stdout] 329 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:416:40 [INFO] [stdout] | [INFO] [stdout] 416 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:455:44 [INFO] [stdout] | [INFO] [stdout] 455 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `requiem-router` (lib) due to 4 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: struct `Id` is never constructed [INFO] [stdout] --> src/de.rs:494:12 [INFO] [stdout] | [INFO] [stdout] 494 | struct Id { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `resource` is never read [INFO] [stdout] --> src/router.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 8 | pub struct ResourceInfo { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 9 | resource: ResourceId, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ResourceInfo` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/de.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | let v = self.path[0].parse().map_err( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 204 | parse_single_value!(deserialize_string, visit_string, "String"); [INFO] [stdout] | --------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] = note: this error originates in the macro `parse_single_value` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/de.rs:27:25 [INFO] [stdout] | [INFO] [stdout] 27 | let v = self.path[0].parse().map_err( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 205 | parse_single_value!(deserialize_byte_buf, visit_string, "String"); [INFO] [stdout] | ----------------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `parse_single_value` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/de.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | let v = self.value.parse().map_err( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 299 | parse_value!(deserialize_string, visit_string, "String"); [INFO] [stdout] | -------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `parse_value` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/de.rs:273:21 [INFO] [stdout] | [INFO] [stdout] 273 | let v = self.value.parse().map_err( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 300 | parse_value!(deserialize_byte_buf, visit_string, "String"); [INFO] [stdout] | ---------------------------------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this error originates in the macro `parse_value` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/path.rs:161:17 [INFO] [stdout] | [INFO] [stdout] 161 | pub fn iter(&self) -> PathIter { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 161 | pub fn iter(&self) -> PathIter<'_, T> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:297:40 [INFO] [stdout] | [INFO] [stdout] 297 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:329:44 [INFO] [stdout] | [INFO] [stdout] 329 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:416:40 [INFO] [stdout] | [INFO] [stdout] 416 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resource.rs:455:44 [INFO] [stdout] | [INFO] [stdout] 455 | path.add(names[idx].clone(), segments[idx]); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `requiem-router` (lib test) due to 4 previous errors; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e9448189b414682919ac3bd41845754a9115060c53488d6fd2b319f97c909561", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9448189b414682919ac3bd41845754a9115060c53488d6fd2b319f97c909561", kill_on_drop: false }` [INFO] [stdout] e9448189b414682919ac3bd41845754a9115060c53488d6fd2b319f97c909561