[INFO] fetching crate phar 0.0.3... [INFO] checking phar-0.0.3 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate phar 0.0.3 into /workspace/builds/worker-3-tc2/source [INFO] started tweaking crates.io crate phar 0.0.3 [INFO] finished tweaking crates.io crate phar 0.0.3 [INFO] tweaked toml for crates.io crate phar 0.0.3 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate phar 0.0.3 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding auto_enums v0.7.12 (available: v0.8.7) [INFO] [stderr] Adding bzip2 v0.4.4 (available: v0.6.1) [INFO] [stderr] Adding digest v0.9.0 (available: v0.10.7) [INFO] [stderr] Adding itertools v0.9.0 (available: v0.14.0) [INFO] [stderr] Adding md-5 v0.9.1 (available: v0.10.6) [INFO] [stderr] Adding sha-1 v0.9.8 (available: v0.10.1) [INFO] [stderr] Adding sha2 v0.9.9 (available: v0.10.9) [INFO] [stderr] Adding typed-builder v0.8.0 (available: v0.23.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 979db7b951bf75241c83fb6b45d597ac33c6be43b869f18e0f5c30f10798cf72 [INFO] running `Command { std: "docker" "start" "-a" "979db7b951bf75241c83fb6b45d597ac33c6be43b869f18e0f5c30f10798cf72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "979db7b951bf75241c83fb6b45d597ac33c6be43b869f18e0f5c30f10798cf72", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "979db7b951bf75241c83fb6b45d597ac33c6be43b869f18e0f5c30f10798cf72", kill_on_drop: false }` [INFO] [stdout] 979db7b951bf75241c83fb6b45d597ac33c6be43b869f18e0f5c30f10798cf72 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fe8906e262bbdd533c9690a18433e706cda90be6da3a278ff28cbd119dfc026f [INFO] running `Command { std: "docker" "start" "-a" "fe8906e262bbdd533c9690a18433e706cda90be6da3a278ff28cbd119dfc026f", kill_on_drop: false }` [INFO] [stderr] Compiling auto_enums_derive v0.7.12 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking shallow-tees v0.1.1 [INFO] [stderr] Checking takes v0.1.0 [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Checking md-5 v0.9.1 [INFO] [stderr] Checking sha-1 v0.9.8 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Compiling derive_utils v0.11.2 [INFO] [stderr] Compiling auto_enums_core v0.7.12 [INFO] [stderr] Compiling typed-builder v0.8.0 [INFO] [stderr] Checking auto_enums v0.7.12 [INFO] [stderr] Checking phar v0.0.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/reader.rs:162:30 [INFO] [stdout] | [INFO] [stdout] 162 | F: FnMut(&[u8], &mut (dyn Read)) -> Result<()>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 162 - F: FnMut(&[u8], &mut (dyn Read)) -> Result<()>, [INFO] [stdout] 162 + F: FnMut(&[u8], &mut dyn Read ) -> Result<()>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/reader.rs:170:30 [INFO] [stdout] | [INFO] [stdout] 170 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 170 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 170 + F: FnMut(&[u8], &mut dyn Read ) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | F: FnMut(&[u8], &mut (dyn Read)) -> Result<()>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - F: FnMut(&[u8], &mut (dyn Read)) -> Result<()>, [INFO] [stdout] 59 + F: FnMut(&[u8], &mut dyn Read) -> Result<()>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:68:30 [INFO] [stdout] | [INFO] [stdout] 68 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 68 + F: FnMut(&[u8], &mut dyn Read) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:145:30 [INFO] [stdout] | [INFO] [stdout] 145 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 145 + F: FnMut(&[u8], &mut dyn Read) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:222:30 [INFO] [stdout] | [INFO] [stdout] 222 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 222 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 222 + F: FnMut(&[u8], &mut dyn Read) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:294:30 [INFO] [stdout] | [INFO] [stdout] 294 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 294 + F: FnMut(&[u8], &mut dyn Read) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:316:70 [INFO] [stdout] | [INFO] [stdout] 316 | fn adapted_reader<'t>(flag: u32, read: impl Read + 't) -> Result> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 316 - fn adapted_reader<'t>(flag: u32, read: impl Read + 't) -> Result> { [INFO] [stdout] 316 + fn adapted_reader<'t>(flag: u32, read: impl Read + 't) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/reader.rs:162:30 [INFO] [stdout] | [INFO] [stdout] 162 | F: FnMut(&[u8], &mut (dyn Read)) -> Result<()>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 162 - F: FnMut(&[u8], &mut (dyn Read)) -> Result<()>, [INFO] [stdout] 162 + F: FnMut(&[u8], &mut dyn Read ) -> Result<()>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/reader.rs:170:30 [INFO] [stdout] | [INFO] [stdout] 170 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 170 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 170 + F: FnMut(&[u8], &mut dyn Read ) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:59:30 [INFO] [stdout] | [INFO] [stdout] 59 | F: FnMut(&[u8], &mut (dyn Read)) -> Result<()>, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 59 - F: FnMut(&[u8], &mut (dyn Read)) -> Result<()>, [INFO] [stdout] 59 + F: FnMut(&[u8], &mut dyn Read) -> Result<()>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:68:30 [INFO] [stdout] | [INFO] [stdout] 68 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 68 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 68 + F: FnMut(&[u8], &mut dyn Read) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:145:30 [INFO] [stdout] | [INFO] [stdout] 145 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 145 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 145 + F: FnMut(&[u8], &mut dyn Read) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:222:30 [INFO] [stdout] | [INFO] [stdout] 222 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 222 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 222 + F: FnMut(&[u8], &mut dyn Read) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:294:30 [INFO] [stdout] | [INFO] [stdout] 294 | F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 294 - F: FnMut(&[u8], &mut (dyn Read)) -> Result, [INFO] [stdout] 294 + F: FnMut(&[u8], &mut dyn Read) -> Result, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/read/index.rs:316:70 [INFO] [stdout] | [INFO] [stdout] 316 | fn adapted_reader<'t>(flag: u32, read: impl Read + 't) -> Result> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 316 - fn adapted_reader<'t>(flag: u32, read: impl Read + 't) -> Result> { [INFO] [stdout] 316 + fn adapted_reader<'t>(flag: u32, read: impl Read + 't) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/read/section.rs:33:27 [INFO] [stdout] | [INFO] [stdout] 33 | .take(len.try_into().expect("u32 <= usize")) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/read/section.rs:33:27 [INFO] [stdout] | [INFO] [stdout] 33 | .take(len.try_into().expect("u32 <= usize")) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `phar` (lib test) due to 1 previous error; 8 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `phar` (lib) due to 1 previous error; 8 warnings emitted [INFO] running `Command { std: "docker" "inspect" "fe8906e262bbdd533c9690a18433e706cda90be6da3a278ff28cbd119dfc026f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fe8906e262bbdd533c9690a18433e706cda90be6da3a278ff28cbd119dfc026f", kill_on_drop: false }` [INFO] [stdout] fe8906e262bbdd533c9690a18433e706cda90be6da3a278ff28cbd119dfc026f