[INFO] fetching crate oox 0.1.0... [INFO] checking oox-0.1.0 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate oox 0.1.0 into /workspace/builds/worker-2-tc2/source [INFO] started tweaking crates.io crate oox 0.1.0 [INFO] finished tweaking crates.io crate oox 0.1.0 [INFO] tweaked toml for crates.io crate oox 0.1.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate oox 0.1.0 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 58 packages to latest compatible versions [INFO] [stderr] Adding quick-xml v0.17.2 (available: v0.38.4) [INFO] [stderr] Adding simple_logger v1.16.0 (available: v5.1.0) [INFO] [stderr] Adding strum v0.17.1 (available: v0.27.2) [INFO] [stderr] Adding strum_macros v0.17.1 (available: v0.27.2) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (available: v0.10.2+wasi-snapshot-preview1) [INFO] [stderr] Adding zip v0.5.13 (available: v6.0.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1b25b69357423fad5c4cabc7b56a90e15c0ff7a899ee7edc8b1de1ff41090ccd [INFO] running `Command { std: "docker" "start" "-a" "1b25b69357423fad5c4cabc7b56a90e15c0ff7a899ee7edc8b1de1ff41090ccd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1b25b69357423fad5c4cabc7b56a90e15c0ff7a899ee7edc8b1de1ff41090ccd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1b25b69357423fad5c4cabc7b56a90e15c0ff7a899ee7edc8b1de1ff41090ccd", kill_on_drop: false }` [INFO] [stdout] 1b25b69357423fad5c4cabc7b56a90e15c0ff7a899ee7edc8b1de1ff41090ccd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1d8e715600552a98cd536c69d6915cff7ff32d7371d6b8895ebd92e241d67284 [INFO] running `Command { std: "docker" "start" "-a" "1d8e715600552a98cd536c69d6915cff7ff32d7371d6b8895ebd92e241d67284", kill_on_drop: false }` [INFO] [stderr] Compiling bzip2-sys v0.1.13+1.0.8 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Compiling time-macros v0.2.24 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking colored v1.9.4 [INFO] [stderr] Checking quick-xml v0.17.2 [INFO] [stderr] Checking strum v0.17.1 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking zip v0.5.13 [INFO] [stderr] Checking simple_logger v1.16.0 [INFO] [stderr] Compiling strum_macros v0.17.1 [INFO] [stderr] Checking oox v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/audiovideo.rs:8:55 [INFO] [stdout] | [INFO] [stdout] 8 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 8 - pub type Result = ::std::result::Result>; [INFO] [stdout] 8 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/coordsys.rs:7:55 [INFO] [stdout] | [INFO] [stdout] 7 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 7 - pub type Result = ::std::result::Result>; [INFO] [stdout] 7 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/picture.rs:7:55 [INFO] [stdout] | [INFO] [stdout] 7 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 7 - pub type Result = ::std::result::Result>; [INFO] [stdout] 7 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/sharedstylesheet.rs:15:55 [INFO] [stdout] | [INFO] [stdout] 15 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 15 - pub type Result = ::std::result::Result>; [INFO] [stdout] 15 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/text/bodyformatting.rs:14:55 [INFO] [stdout] | [INFO] [stdout] 14 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 14 - pub type Result = ::std::result::Result>; [INFO] [stdout] 14 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/text/runformatting.rs:13:55 [INFO] [stdout] | [INFO] [stdout] 13 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - pub type Result = ::std::result::Result>; [INFO] [stdout] 13 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/relationship.rs:8:55 [INFO] [stdout] | [INFO] [stdout] 8 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 8 - pub type Result = ::std::result::Result>; [INFO] [stdout] 8 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/pptx/package.rs:33:64 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_file(pptx_path: &Path) -> Result> { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 33 - pub fn from_file(pptx_path: &Path) -> Result> { [INFO] [stdout] 33 + pub fn from_file(pptx_path: &Path) -> Result> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/audiovideo.rs:8:55 [INFO] [stdout] | [INFO] [stdout] 8 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 8 - pub type Result = ::std::result::Result>; [INFO] [stdout] 8 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/coordsys.rs:7:55 [INFO] [stdout] | [INFO] [stdout] 7 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 7 - pub type Result = ::std::result::Result>; [INFO] [stdout] 7 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/picture.rs:7:55 [INFO] [stdout] | [INFO] [stdout] 7 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 7 - pub type Result = ::std::result::Result>; [INFO] [stdout] 7 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/sharedstylesheet.rs:15:55 [INFO] [stdout] | [INFO] [stdout] 15 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 15 - pub type Result = ::std::result::Result>; [INFO] [stdout] 15 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/text/bodyformatting.rs:14:55 [INFO] [stdout] | [INFO] [stdout] 14 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 14 - pub type Result = ::std::result::Result>; [INFO] [stdout] 14 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/drawingml/text/runformatting.rs:13:55 [INFO] [stdout] | [INFO] [stdout] 13 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 13 - pub type Result = ::std::result::Result>; [INFO] [stdout] 13 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around type [INFO] [stdout] --> src/shared/relationship.rs:8:55 [INFO] [stdout] | [INFO] [stdout] 8 | pub type Result = ::std::result::Result>; [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 8 - pub type Result = ::std::result::Result>; [INFO] [stdout] 8 + pub type Result = ::std::result::Result>; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: ControlFlow, Option> [INFO] [stdout] --> src/docx/wml/document.rs:5174:22 [INFO] [stdout] | [INFO] [stdout] 5174 | let rel_id = xml_node.attributes.get("r:id").map(|value| value.parse()).transpose()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result, Infallible> [INFO] [stdout] --> src/docx/wml/document.rs:5174:22 [INFO] [stdout] | [INFO] [stdout] 5174 | let rel_id = xml_node.attributes.get("r:id").map(|value| value.parse()).transpose()?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/docx/wml/document.rs:5174:66 [INFO] [stdout] | [INFO] [stdout] 5174 | let rel_id = xml_node.attributes.get("r:id").map(|value| value.parse()).transpose()?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/pptx/package.rs:131:19 [INFO] [stdout] | [INFO] [stdout] 131 | pub fn slides(&self) -> Slides { [INFO] [stdout] | ^^^^^ ^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 131 | pub fn slides(&self) -> Slides<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/pptx/pml/animation.rs:3093:39 [INFO] [stdout] | [INFO] [stdout] 3093 | .and_then(|value| value.parse().map_err(Into::into))?; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: ControlFlow, String> [INFO] [stdout] --> src/pptx/pml/animation.rs:3242:28 [INFO] [stdout] | [INFO] [stdout] 3242 | let spid = xml_node [INFO] [stdout] | ____________________________^ [INFO] [stdout] 3243 | | .attributes [INFO] [stdout] 3244 | | .get("spid") [INFO] [stdout] 3245 | | .ok_or_else(|| MissingAttributeError::new(xml_node.name.clone(), "spid"))? [INFO] [stdout] 3246 | | .parse()?; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/pptx/pml/animation.rs:3242:28 [INFO] [stdout] | [INFO] [stdout] 3242 | let spid = xml_node [INFO] [stdout] | ____________________________^ [INFO] [stdout] 3243 | | .attributes [INFO] [stdout] 3244 | | .get("spid") [INFO] [stdout] 3245 | | .ok_or_else(|| MissingAttributeError::new(xml_node.name.clone(), "spid"))? [INFO] [stdout] 3246 | | .parse()?; [INFO] [stdout] | |____________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: ControlFlow, String> [INFO] [stdout] --> src/pptx/pml/slides.rs:2586:44 [INFO] [stdout] | [INFO] [stdout] 2586 | "spid" => self.shape_id = Some(value.as_ref().parse()?), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/pptx/pml/slides.rs:2586:44 [INFO] [stdout] | [INFO] [stdout] 2586 | "spid" => self.shape_id = Some(value.as_ref().parse()?), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `oox` (lib test) due to 8 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "1d8e715600552a98cd536c69d6915cff7ff32d7371d6b8895ebd92e241d67284", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1d8e715600552a98cd536c69d6915cff7ff32d7371d6b8895ebd92e241d67284", kill_on_drop: false }` [INFO] [stdout] 1d8e715600552a98cd536c69d6915cff7ff32d7371d6b8895ebd92e241d67284