[INFO] fetching crate json-surf 0.9.0... [INFO] checking json-surf-0.9.0 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate json-surf 0.9.0 into /workspace/builds/worker-7-tc2/source [INFO] started tweaking crates.io crate json-surf 0.9.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate json-surf 0.9.0 [INFO] tweaked toml for crates.io crate json-surf 0.9.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate json-surf 0.9.0 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate json-surf 0.9.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] d519795503a5a529aa07b2742132e9cc39666d14beee2234e02a1ef378154106 [INFO] running `Command { std: "docker" "start" "-a" "d519795503a5a529aa07b2742132e9cc39666d14beee2234e02a1ef378154106", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "d519795503a5a529aa07b2742132e9cc39666d14beee2234e02a1ef378154106", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d519795503a5a529aa07b2742132e9cc39666d14beee2234e02a1ef378154106", kill_on_drop: false }` [INFO] [stdout] d519795503a5a529aa07b2742132e9cc39666d14beee2234e02a1ef378154106 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d127027faac3abd2804ae290b0e12e8b285bead7854081f991d166645dcfa298 [INFO] running `Command { std: "docker" "start" "-a" "d127027faac3abd2804ae290b0e12e8b285bead7854081f991d166645dcfa298", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling syn v1.0.39 [INFO] [stderr] Compiling crossbeam-utils v0.7.2 [INFO] [stderr] Compiling memoffset v0.5.5 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling serde_derive v1.0.115 [INFO] [stderr] Compiling num-traits v0.2.12 [INFO] [stderr] Compiling crossbeam-epoch v0.8.2 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Compiling pin-project-internal v0.4.23 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking ppv-lite86 v0.2.9 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Checking once_cell v1.4.1 [INFO] [stderr] Compiling rayon-core v1.8.0 [INFO] [stderr] Compiling proc-macro-hack v0.5.18 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Checking futures-channel v0.3.5 [INFO] [stderr] Compiling num-integer v0.1.43 [INFO] [stderr] Checking adler v0.2.3 [INFO] [stderr] Compiling nix v0.14.1 [INFO] [stderr] Checking gimli v0.22.0 [INFO] [stderr] Compiling rayon v1.4.0 [INFO] [stderr] Checking object v0.20.0 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling snap v1.0.1 [INFO] [stderr] Checking miniz_oxide v0.4.1 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking combine v4.3.1 [INFO] [stderr] Checking utf8-ranges v1.0.4 [INFO] [stderr] Checking regex-syntax v0.4.2 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking either v1.6.0 [INFO] [stderr] Checking bitpacking v0.8.2 [INFO] [stderr] Checking owned-read v0.4.1 [INFO] [stderr] Checking owning_ref v0.4.1 [INFO] [stderr] Checking crc32fast v1.2.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking murmurhash32 v0.2.0 [INFO] [stderr] Checking crossbeam-channel v0.4.3 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking htmlescape v0.3.1 [INFO] [stderr] Checking smallvec v1.4.2 [INFO] [stderr] Checking levenshtein_automata v0.2.0 [INFO] [stderr] Checking tantivy-fst v0.3.0 [INFO] [stderr] Checking unidecode v0.3.0 [INFO] [stderr] Checking getrandom v0.1.14 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking inotify-sys v0.1.3 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking inotify v0.7.1 [INFO] [stderr] Checking filetime v0.2.12 [INFO] [stderr] Checking crossbeam v0.7.3 [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking ordered-float v1.1.0 [INFO] [stderr] Checking census v0.4.0 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Checking chrono v0.4.15 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking addr2line v0.13.0 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking fail v0.4.0 [INFO] [stderr] Checking tempfile v3.1.0 [INFO] [stderr] Checking mio-extras v2.0.6 [INFO] [stderr] Checking backtrace v0.3.50 [INFO] [stderr] Checking notify v4.0.15 [INFO] [stderr] Checking atomicwrites v0.2.5 [INFO] [stderr] Compiling darling_core v0.10.2 [INFO] [stderr] Compiling synstructure v0.12.4 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling darling_macro v0.10.2 [INFO] [stderr] Checking tantivy-query-grammar v0.13.0 [INFO] [stderr] Compiling darling v0.10.2 [INFO] [stderr] Compiling derive_builder_core v0.9.0 [INFO] [stderr] Checking failure v0.1.8 [INFO] [stderr] Checking pin-project v0.4.23 [INFO] [stderr] Compiling derive_builder v0.9.0 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking symspell v0.4.1 [INFO] [stderr] Checking futures-executor v0.3.5 [INFO] [stderr] Checking futures v0.3.5 [INFO] [stderr] Checking rust-stemmers v1.2.0 [INFO] [stderr] Checking uuid v0.8.1 [INFO] [stderr] Checking serde-value v0.6.0 [INFO] [stderr] Checking tantivy v0.13.0 [INFO] [stderr] Checking json-surf v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/errors.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Fail, Clone, Serialize)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_IndexError` [INFO] [stdout] 17 | #[fail(display = "Message: {}", message)] [INFO] [stdout] 18 | pub struct IndexError { [INFO] [stdout] | ---------- `IndexError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/errors.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Fail, Clone, Serialize)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_IndexError` [INFO] [stdout] 17 | #[fail(display = "Message: {}", message)] [INFO] [stdout] 18 | pub struct IndexError { [INFO] [stdout] | ---------- `IndexError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/registry.rs:882:9 [INFO] [stdout] | [INFO] [stdout] 882 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 882 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> examples/00_usage.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 158 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> examples/01_helloworld.rs:196:9 [INFO] [stdout] | [INFO] [stdout] 196 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 196 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/seed.rs:126:20 [INFO] [stdout] | [INFO] [stdout] 126 | let path = PathBuf::from_str(&path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/seed.rs:127:17 [INFO] [stdout] | [INFO] [stdout] 127 | assert!(path.is_ok()); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/seed.rs:128:20 [INFO] [stdout] | [INFO] [stdout] 128 | let path = path.ok().unwrap(); [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/seed.rs:147:20 [INFO] [stdout] | [INFO] [stdout] 147 | let path = PathBuf::from_str(&path).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/errors.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Fail, Clone, Serialize)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Fail` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_Fail_FOR_IndexError` [INFO] [stdout] 17 | #[fail(display = "Message: {}", message)] [INFO] [stdout] 18 | pub struct IndexError { [INFO] [stdout] | ---------- `IndexError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/errors.rs:16:17 [INFO] [stdout] | [INFO] [stdout] 16 | #[derive(Debug, Fail, Clone, Serialize)] [INFO] [stdout] | ^--- [INFO] [stdout] | | [INFO] [stdout] | `Display` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_DERIVE_failure_core_fmt_Display_FOR_IndexError` [INFO] [stdout] 17 | #[fail(display = "Message: {}", message)] [INFO] [stdout] 18 | pub struct IndexError { [INFO] [stdout] | ---------- `IndexError` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Fail` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Fail` may come from an old version of the `failure_derive` crate, try updating your dependency with `cargo update -p failure_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Fail` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/errors.rs:136:20 [INFO] [stdout] | [INFO] [stdout] 136 | let path = PathBuf::from_str("doesnotexist").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/registry.rs:882:9 [INFO] [stdout] | [INFO] [stdout] 882 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 882 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `finish` that must be used [INFO] [stdout] --> src/registry.rs:1671:13 [INFO] [stdout] | [INFO] [stdout] 1671 | state.finish(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1671 | let _ = state.finish(); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `json-surf` (lib test) due to 5 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d127027faac3abd2804ae290b0e12e8b285bead7854081f991d166645dcfa298", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d127027faac3abd2804ae290b0e12e8b285bead7854081f991d166645dcfa298", kill_on_drop: false }` [INFO] [stdout] d127027faac3abd2804ae290b0e12e8b285bead7854081f991d166645dcfa298