[INFO] fetching crate imposter-pass 0.3.0... [INFO] checking imposter-pass-0.3.0 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate imposter-pass 0.3.0 into /workspace/builds/worker-3-tc2/source [INFO] started tweaking crates.io crate imposter-pass 0.3.0 [INFO] finished tweaking crates.io crate imposter-pass 0.3.0 [INFO] tweaked toml for crates.io crate imposter-pass 0.3.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate imposter-pass 0.3.0 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate imposter-pass 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95400e7a8461815ef4cda4c37b0136bdd5c274d2a9d2e16c3417fc7d17a7d629 [INFO] running `Command { std: "docker" "start" "-a" "95400e7a8461815ef4cda4c37b0136bdd5c274d2a9d2e16c3417fc7d17a7d629", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95400e7a8461815ef4cda4c37b0136bdd5c274d2a9d2e16c3417fc7d17a7d629", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95400e7a8461815ef4cda4c37b0136bdd5c274d2a9d2e16c3417fc7d17a7d629", kill_on_drop: false }` [INFO] [stdout] 95400e7a8461815ef4cda4c37b0136bdd5c274d2a9d2e16c3417fc7d17a7d629 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 335f9b3b59bfbb1872bfd116741f2b7879730780b463477e646cd91c36a03d89 [INFO] running `Command { std: "docker" "start" "-a" "335f9b3b59bfbb1872bfd116741f2b7879730780b463477e646cd91c36a03d89", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.30 [INFO] [stderr] Compiling libc v0.2.71 [INFO] [stderr] Compiling serde v1.0.111 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.2 [INFO] [stderr] Compiling proc-macro-error v1.0.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking rpassword v4.0.5 [INFO] [stderr] Checking clap v2.33.1 [INFO] [stderr] Compiling syn-mid v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.111 [INFO] [stderr] Compiling thiserror-impl v1.0.19 [INFO] [stderr] Compiling structopt-derive v0.4.7 [INFO] [stderr] Checking thiserror v1.0.19 [INFO] [stderr] Checking structopt v0.3.14 [INFO] [stderr] Checking serde_json v1.0.53 [INFO] [stderr] Checking imposter-pass v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/cli.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / /// The password store to use. [INFO] [stdout] 89 | | /// [INFO] [stdout] 90 | | /// This may be a json object mapping password paths to values, or it may be a file path to use for the password store [INFO] [stdout] 91 | | #[structopt(long, env = "IMPOSTER_PASS_STORE")] [INFO] [stdout] 92 | | pub store: Option, [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/store.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Clone, Default, Debug, Serialize, Deserialize, Hash, PartialEq, Eq)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Store` [INFO] [stdout] 9 | #[serde(transparent)] [INFO] [stdout] 10 | pub struct Store { [INFO] [stdout] | ----- `Store` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/store.rs:8:44 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Clone, Default, Debug, Serialize, Deserialize, Hash, PartialEq, Eq)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Store` [INFO] [stdout] 9 | #[serde(transparent)] [INFO] [stdout] 10 | pub struct Store { [INFO] [stdout] | ----- `Store` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/store.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | &mut self, [INFO] [stdout] | ^^^^^^^^^ the lifetime is elided here [INFO] [stdout] 140 | path: impl AsRef, [INFO] [stdout] 141 | ) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 141 | ) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `imposter-pass` (bin "imposter-pass") due to 1 previous error; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/cli.rs:88:5 [INFO] [stdout] | [INFO] [stdout] 88 | / /// The password store to use. [INFO] [stdout] 89 | | /// [INFO] [stdout] 90 | | /// This may be a json object mapping password paths to values, or it may be a file path to use for the password store [INFO] [stdout] 91 | | #[structopt(long, env = "IMPOSTER_PASS_STORE")] [INFO] [stdout] 92 | | pub store: Option, [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/store.rs:8:33 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Clone, Default, Debug, Serialize, Deserialize, Hash, PartialEq, Eq)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Serialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_SERIALIZE_FOR_Store` [INFO] [stdout] 9 | #[serde(transparent)] [INFO] [stdout] 10 | pub struct Store { [INFO] [stdout] | ----- `Store` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Serialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Serialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Serialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/store.rs:8:44 [INFO] [stdout] | [INFO] [stdout] 8 | #[derive(Clone, Default, Debug, Serialize, Deserialize, Hash, PartialEq, Eq)] [INFO] [stdout] | ^---------- [INFO] [stdout] | | [INFO] [stdout] | `Deserialize` is not local [INFO] [stdout] | move the `impl` block outside of this constant `_IMPL_DESERIALIZE_FOR_Store` [INFO] [stdout] 9 | #[serde(transparent)] [INFO] [stdout] 10 | pub struct Store { [INFO] [stdout] | ----- `Store` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Deserialize` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Deserialize` may come from an old version of the `serde_derive` crate, try updating your dependency with `cargo update -p serde_derive` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: items in an anonymous const item (`const _: () = { ... }`) are treated as in the same scope as the anonymous const's declaration for the purpose of this lint [INFO] [stdout] = note: this warning originates in the derive macro `Deserialize` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/store.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | &mut self, [INFO] [stdout] | ^^^^^^^^^ the lifetime is elided here [INFO] [stdout] 140 | path: impl AsRef, [INFO] [stdout] 141 | ) -> Result> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 141 | ) -> Result> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `imposter-pass` (bin "imposter-pass" test) due to 1 previous error; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "335f9b3b59bfbb1872bfd116741f2b7879730780b463477e646cd91c36a03d89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "335f9b3b59bfbb1872bfd116741f2b7879730780b463477e646cd91c36a03d89", kill_on_drop: false }` [INFO] [stdout] 335f9b3b59bfbb1872bfd116741f2b7879730780b463477e646cd91c36a03d89