[INFO] fetching crate env-convert 0.1.1... [INFO] checking env-convert-0.1.1 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate env-convert 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] started tweaking crates.io crate env-convert 0.1.1 [INFO] finished tweaking crates.io crate env-convert 0.1.1 [INFO] tweaked toml for crates.io crate env-convert 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate env-convert 0.1.1 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 06bee6112476d95b5c76a2b622c26749864bae5abac85c66975f94861863ac42 [INFO] running `Command { std: "docker" "start" "-a" "06bee6112476d95b5c76a2b622c26749864bae5abac85c66975f94861863ac42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "06bee6112476d95b5c76a2b622c26749864bae5abac85c66975f94861863ac42", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "06bee6112476d95b5c76a2b622c26749864bae5abac85c66975f94861863ac42", kill_on_drop: false }` [INFO] [stdout] 06bee6112476d95b5c76a2b622c26749864bae5abac85c66975f94861863ac42 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fee0b9337c9c039792ee398d8b48cf5a828815d1b2d8e88fff19403cff1bd28 [INFO] running `Command { std: "docker" "start" "-a" "3fee0b9337c9c039792ee398d8b48cf5a828815d1b2d8e88fff19403cff1bd28", kill_on_drop: false }` [INFO] [stderr] Checking env-convert v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/lib.rs:37:36 [INFO] [stdout] | [INFO] [stdout] 37 | fn from(value: EnvVar) -> Self { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 38 | | Ok(value.env_value) [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/lib.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | Ok(value.env_value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `env-convert` (lib) due to 2 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/lib.rs:37:36 [INFO] [stdout] | [INFO] [stdout] 37 | fn from(value: EnvVar) -> Self { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 38 | | Ok(value.env_value) [INFO] [stdout] 39 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/lib.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | Ok(value.env_value) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/tests.rs:26:33 [INFO] [stdout] | [INFO] [stdout] 26 | let str: Result = get_default_env_var("UNSET_ENV_VAR", "default var".to_owned()).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/tests.rs:27:16 [INFO] [stdout] | [INFO] [stdout] 27 | assert_eq!(str.unwrap(), "default var".to_owned()); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/tests.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | let result: Result= get_default_env_var(key, default_value).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/tests.rs:44:16 [INFO] [stdout] | [INFO] [stdout] 44 | assert_eq!(result.unwrap(), value.to_owned()); [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/tests.rs:45:26 [INFO] [stdout] | [INFO] [stdout] 45 | assert_eq!(str, value.clone().to_owned()); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `env-convert` (lib test) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3fee0b9337c9c039792ee398d8b48cf5a828815d1b2d8e88fff19403cff1bd28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fee0b9337c9c039792ee398d8b48cf5a828815d1b2d8e88fff19403cff1bd28", kill_on_drop: false }` [INFO] [stdout] 3fee0b9337c9c039792ee398d8b48cf5a828815d1b2d8e88fff19403cff1bd28