[INFO] fetching crate diff-man 0.1.7... [INFO] checking diff-man-0.1.7 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate diff-man 0.1.7 into /workspace/builds/worker-4-tc2/source [INFO] started tweaking crates.io crate diff-man 0.1.7 [INFO] finished tweaking crates.io crate diff-man 0.1.7 [INFO] tweaked toml for crates.io crate diff-man 0.1.7 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate diff-man 0.1.7 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate diff-man 0.1.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3935dee8c7ca91a827dab9dc48835746f00ffdfc325dc402e4df14a2132650d7 [INFO] running `Command { std: "docker" "start" "-a" "3935dee8c7ca91a827dab9dc48835746f00ffdfc325dc402e4df14a2132650d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3935dee8c7ca91a827dab9dc48835746f00ffdfc325dc402e4df14a2132650d7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3935dee8c7ca91a827dab9dc48835746f00ffdfc325dc402e4df14a2132650d7", kill_on_drop: false }` [INFO] [stdout] 3935dee8c7ca91a827dab9dc48835746f00ffdfc325dc402e4df14a2132650d7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3301b6ff323c68fbe3ce02acec1ddfa0a0e3406d1a921b948e29ed7790e49203 [INFO] running `Command { std: "docker" "start" "-a" "3301b6ff323c68fbe3ce02acec1ddfa0a0e3406d1a921b948e29ed7790e49203", kill_on_drop: false }` [INFO] [stderr] Checking clap_lex v0.7.3 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking clap_builder v4.5.21 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking clap v4.5.21 [INFO] [stderr] Checking diff-man v0.1.7 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `core::panic` [INFO] [stdout] --> src/diff.rs:283:10 [INFO] [stdout] | [INFO] [stdout] 283 | use {core::panic, std::fs}; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `kind` and `reason` are never read [INFO] [stdout] --> src/diff.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 125 | pub struct DiffError { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 126 | kind: DiffErrorKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] 127 | reason: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DiffError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `kind`, `reason`, and `line` are never read [INFO] [stdout] --> src/parser.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct ParseError { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 20 | kind: ParseErrorKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] 21 | reason: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 22 | line: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/diff.rs:406:25 [INFO] [stdout] | [INFO] [stdout] 406 | let comp_root = PathBuf::from_str("test_data/composition").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/diff.rs:424:25 [INFO] [stdout] | [INFO] [stdout] 424 | let comp_root = PathBuf::from_str("test_data/composition").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/diff.rs:425:9 [INFO] [stdout] | [INFO] [stdout] 425 | com.revert(&comp_root); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 425 | let _ = com.revert(&comp_root); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/diff.rs:445:25 [INFO] [stdout] | [INFO] [stdout] 445 | let comp_root = PathBuf::from_str("test_data/composition").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/diff.rs:446:9 [INFO] [stdout] | [INFO] [stdout] 446 | com.apply(&comp_root); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 446 | let _ = com.apply(&comp_root); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/diff.rs:463:25 [INFO] [stdout] | [INFO] [stdout] 463 | let comp_root = PathBuf::from_str("test_data/composition").unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/diff.rs:464:9 [INFO] [stdout] | [INFO] [stdout] 464 | com.revert(&comp_root); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 464 | let _ = com.revert(&comp_root); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/parser.rs:244:32 [INFO] [stdout] | [INFO] [stdout] 244 | let path = PathBuf::from_str(file_path_a).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `short_test_data` should have an upper case name [INFO] [stdout] --> src/parser.rs:521:11 [INFO] [stdout] | [INFO] [stdout] 521 | const short_test_data: &str = r#"diff --git a/tests/vm.rs b/tests/vm.rs [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_upper_case_globals)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] help: convert the identifier to upper case [INFO] [stdout] | [INFO] [stdout] 521 - const short_test_data: &str = r#"diff --git a/tests/vm.rs b/tests/vm.rs [INFO] [stdout] 521 + const SHORT_TEST_DATA: &str = r#"diff --git a/tests/vm.rs b/tests/vm.rs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diff-man` (lib test) due to 5 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `kind` and `reason` are never read [INFO] [stdout] --> src/diff.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 125 | pub struct DiffError { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] 126 | kind: DiffErrorKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] 127 | reason: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DiffError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `kind`, `reason`, and `line` are never read [INFO] [stdout] --> src/parser.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 19 | pub struct ParseError { [INFO] [stdout] | ---------- fields in this struct [INFO] [stdout] 20 | kind: ParseErrorKind, [INFO] [stdout] | ^^^^ [INFO] [stdout] 21 | reason: String, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 22 | line: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ParseError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/parser.rs:244:32 [INFO] [stdout] | [INFO] [stdout] 244 | let path = PathBuf::from_str(file_path_a).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `diff-man` (lib) due to 1 previous error; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3301b6ff323c68fbe3ce02acec1ddfa0a0e3406d1a921b948e29ed7790e49203", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3301b6ff323c68fbe3ce02acec1ddfa0a0e3406d1a921b948e29ed7790e49203", kill_on_drop: false }` [INFO] [stdout] 3301b6ff323c68fbe3ce02acec1ddfa0a0e3406d1a921b948e29ed7790e49203