[INFO] fetching crate bash-builtins 0.4.1... [INFO] checking bash-builtins-0.4.1 against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] extracting crate bash-builtins 0.4.1 into /workspace/builds/worker-3-tc2/source [INFO] started tweaking crates.io crate bash-builtins 0.4.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate bash-builtins 0.4.1 [INFO] tweaked toml for crates.io crate bash-builtins 0.4.1 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] validating manifest of crates.io crate bash-builtins 0.4.1 on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate bash-builtins 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 944882b1c683cede8693c94afd6559ba9db2928811f3bb1b352c9ed9d5cbfef0 [INFO] running `Command { std: "docker" "start" "-a" "944882b1c683cede8693c94afd6559ba9db2928811f3bb1b352c9ed9d5cbfef0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "944882b1c683cede8693c94afd6559ba9db2928811f3bb1b352c9ed9d5cbfef0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "944882b1c683cede8693c94afd6559ba9db2928811f3bb1b352c9ed9d5cbfef0", kill_on_drop: false }` [INFO] [stdout] 944882b1c683cede8693c94afd6559ba9db2928811f3bb1b352c9ed9d5cbfef0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6f923e290320b27c79dc4c17618b05a6c8c5c2b1595df6e1470be07582554108 [INFO] running `Command { std: "docker" "start" "-a" "6f923e290320b27c79dc4c17618b05a6c8c5c2b1595df6e1470be07582554108", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.74 [INFO] [stderr] Compiling serde_json v1.0.66 [INFO] [stderr] Compiling libc v0.2.101 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Compiling trybuild v1.0.43 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking assert_matches v1.5.0 [INFO] [stderr] Compiling serde_derive v1.0.127 [INFO] [stderr] Compiling bash_builtins_macro v0.2.0 [INFO] [stderr] Checking bash-builtins v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: field `nentries` is never read [INFO] [stdout] --> src/ffi.rs:118:13 [INFO] [stdout] | [INFO] [stdout] 115 | pub struct HashTable { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 118 | pub nentries: c_int, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result<&Path, Infallible> [INFO] [stdout] --> src/convert.rs:100:58 [INFO] [stdout] | [INFO] [stdout] 100 | fn from_cstr(s: &'a CStr) -> Result { [INFO] [stdout] | __________________________________________________________^ [INFO] [stdout] 101 | | Ok(std::path::Path::new(OsStr::from_bytes(s.to_bytes()))) [INFO] [stdout] 102 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result<&Path, Infallible> [INFO] [stdout] --> src/convert.rs:101:9 [INFO] [stdout] | [INFO] [stdout] 101 | Ok(std::path::Path::new(OsStr::from_bytes(s.to_bytes()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/convert.rs:109:58 [INFO] [stdout] | [INFO] [stdout] 109 | fn from_cstr(s: &'a CStr) -> Result { [INFO] [stdout] | __________________________________________________________^ [INFO] [stdout] 110 | | Ok(Self::from(OsStr::from_bytes(s.to_bytes()))) [INFO] [stdout] 111 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/convert.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | Ok(Self::from(OsStr::from_bytes(s.to_bytes()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result<&OsStr, Infallible> [INFO] [stdout] --> src/convert.rs:118:58 [INFO] [stdout] | [INFO] [stdout] 118 | fn from_cstr(s: &'a CStr) -> Result { [INFO] [stdout] | __________________________________________________________^ [INFO] [stdout] 119 | | Ok(OsStr::from_bytes(s.to_bytes())) [INFO] [stdout] 120 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result<&OsStr, Infallible> [INFO] [stdout] --> src/convert.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | Ok(OsStr::from_bytes(s.to_bytes())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/convert.rs:127:58 [INFO] [stdout] | [INFO] [stdout] 127 | fn from_cstr(s: &'a CStr) -> Result { [INFO] [stdout] | __________________________________________________________^ [INFO] [stdout] 128 | | Ok(OsString::from_vec(s.to_bytes().into())) [INFO] [stdout] 129 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/convert.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | Ok(OsString::from_vec(s.to_bytes().into())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/variables/assoc.rs:87:37 [INFO] [stdout] | [INFO] [stdout] 87 | pub(super) unsafe fn new(table: &ffi::HashTable) -> AssocItemsIterator { [INFO] [stdout] | ^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 87 | pub(super) unsafe fn new(table: &ffi::HashTable) -> AssocItemsIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/variables/dynvars.rs:165:22 [INFO] [stdout] | [INFO] [stdout] 165 | match unsafe { (*STATE.as_ptr()).lock() } { [INFO] [stdout] | ^^^^^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function pointer comparisons do not produce meaningful results since their addresses are not guaranteed to be unique [INFO] [stdout] --> src/variables/dynvars.rs:181:40 [INFO] [stdout] | [INFO] [stdout] 181 | if !shell_var.is_null() && (*shell_var).dynamic_value == read_var { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: the address of the same function can vary between different codegen units [INFO] [stdout] = note: furthermore, different functions could have the same address after being merged together [INFO] [stdout] = note: for more information visit [INFO] [stdout] = note: `#[warn(unpredictable_function_pointer_comparisons)]` on by default [INFO] [stdout] help: refactor your code, or use `std::ptr::fn_addr_eq` to suppress the lint [INFO] [stdout] | [INFO] [stdout] 181 - if !shell_var.is_null() && (*shell_var).dynamic_value == read_var { [INFO] [stdout] 181 + if !shell_var.is_null() && std::ptr::fn_addr_eq((*shell_var).dynamic_value, read_var as unsafe extern "C" fn(*mut ShellVar) -> *const ShellVar) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bash-builtins` (lib) due to 8 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "6f923e290320b27c79dc4c17618b05a6c8c5c2b1595df6e1470be07582554108", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6f923e290320b27c79dc4c17618b05a6c8c5c2b1595df6e1470be07582554108", kill_on_drop: false }` [INFO] [stdout] 6f923e290320b27c79dc4c17618b05a6c8c5c2b1595df6e1470be07582554108