[INFO] cloning repository https://github.com/samuwen/re_flog [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/samuwen/re_flog" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuwen%2Fre_flog", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuwen%2Fre_flog'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] b6698709239e7d2607609f7087697a3c837d73d7 [INFO] checking samuwen/re_flog against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fsamuwen%2Fre_flog" "/workspace/builds/worker-1-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/samuwen/re_flog [INFO] finished tweaking git repo https://github.com/samuwen/re_flog [INFO] tweaked toml for git repo https://github.com/samuwen/re_flog written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/samuwen/re_flog on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/samuwen/re_flog already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7b939bb5ffbfaae51319371a1f4fe9119e9b56ec8e656cdd97a523f520eff976 [INFO] running `Command { std: "docker" "start" "-a" "7b939bb5ffbfaae51319371a1f4fe9119e9b56ec8e656cdd97a523f520eff976", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7b939bb5ffbfaae51319371a1f4fe9119e9b56ec8e656cdd97a523f520eff976", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7b939bb5ffbfaae51319371a1f4fe9119e9b56ec8e656cdd97a523f520eff976", kill_on_drop: false }` [INFO] [stdout] 7b939bb5ffbfaae51319371a1f4fe9119e9b56ec8e656cdd97a523f520eff976 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0e2ea8a9f1ef58e180338266a99e6599a3a505fd78fee97765c189720e7a5623 [INFO] running `Command { std: "docker" "start" "-a" "0e2ea8a9f1ef58e180338266a99e6599a3a505fd78fee97765c189720e7a5623", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Compiling libc v0.2.118 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling indexmap v1.8.0 [INFO] [stderr] Compiling miniz_oxide v0.4.4 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling rustversion v1.0.6 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Compiling generic-array v0.14.5 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling heck v0.4.0 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Compiling time-macros v0.2.3 [INFO] [stderr] Checking num_threads v0.1.3 [INFO] [stderr] Checking regex-syntax v0.6.25 [INFO] [stderr] Checking os_str_bytes v6.0.0 [INFO] [stderr] Checking textwrap v0.14.2 [INFO] [stderr] Checking glob v0.3.0 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking cpufeatures v0.2.1 [INFO] [stderr] Checking termcolor v1.1.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking flate2 v1.0.22 [INFO] [stderr] Checking time v0.3.7 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking block-buffer v0.10.2 [INFO] [stderr] Checking crypto-common v0.1.3 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking regex v1.5.4 [INFO] [stderr] Checking sha-1 v0.10.0 [INFO] [stderr] Compiling thiserror-impl v1.0.30 [INFO] [stderr] Compiling clap_derive v3.1.0 [INFO] [stderr] Compiling derive-getters v0.2.0 [INFO] [stderr] Checking thiserror v1.0.30 [INFO] [stderr] Checking flexi_logger v0.22.3 [INFO] [stderr] Checking clap v3.1.0 [INFO] [stderr] Checking re_flog v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `f` [INFO] [stdout] --> src/structures/index.rs:532:13 [INFO] [stdout] | [INFO] [stdout] 532 | let f = IndexFile::from_disk().unwrap(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_f` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | Add { pathspec: Vec }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | sha: Sha, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / #[clap(short = 'm')] [INFO] [stdout] 32 | | messages: Option>, [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | sha: Sha, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / #[clap(short = 'm')] [INFO] [stdout] 38 | | message: Option>, [INFO] [stdout] | |____________________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / #[clap(short = 'p')] [INFO] [stdout] 40 | | parent: Option>, [INFO] [stdout] | |________________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / /// The file to hash [INFO] [stdout] 45 | | file: String, [INFO] [stdout] | |____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | Init { destination: Option }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | ReadTree { sha: Sha }, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | files: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / #[clap(help = halp_str())] [INFO] [stdout] 77 | | r#ref: String, [INFO] [stdout] | |_____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | new_value: Sha, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / ... /// Writes a tree object that represents a subdirectory . This can be used to write the tree object for a subproject that i... [INFO] [stdout] 86 | | ... prefix: Option, [INFO] [stdout] | |____________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/commit.rs:211:27 [INFO] [stdout] | [INFO] [stdout] 211 | let sha = data.parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/commit.rs:216:27 [INFO] [stdout] | [INFO] [stdout] 216 | let sha = data.parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/ref_file.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | let sha = buf.trim().parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/sha.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | whole.parse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/sha.rs:85:53 [INFO] [stdout] | [INFO] [stdout] 85 | fn from_str(s: &str) -> Result { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 86 | | if s.len() < 4 { [INFO] [stdout] 87 | | let msg = format!( [INFO] [stdout] 88 | | "fatal: ambiguous argument '{}': unknown revision or path not in the working tree.", [INFO] [stdout] ... | [INFO] [stdout] 114 | | Ok(Self { bytes: out }) [INFO] [stdout] 115 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/structures/sha.rs:100:34 [INFO] [stdout] | [INFO] [stdout] 100 | for dir_entry in read_dir(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 - for dir_entry in read_dir(path) { [INFO] [stdout] 100 + while let Ok(dir_entry) = read_dir(path) { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 100 | for dir_entry in read_dir(path)? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 - for dir_entry in read_dir(path) { [INFO] [stdout] 100 + if let Ok(dir_entry) = read_dir(path) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/sha.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | Ok(Self { bytes: out }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `re_flog` (bin "re_flog") due to 19 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | Add { pathspec: Vec }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | sha: Sha, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / #[clap(short = 'm')] [INFO] [stdout] 32 | | messages: Option>, [INFO] [stdout] | |_____________________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | sha: Sha, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / #[clap(short = 'm')] [INFO] [stdout] 38 | | message: Option>, [INFO] [stdout] | |____________________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | / #[clap(short = 'p')] [INFO] [stdout] 40 | | parent: Option>, [INFO] [stdout] | |________________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / /// The file to hash [INFO] [stdout] 45 | | file: String, [INFO] [stdout] | |____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:51:12 [INFO] [stdout] | [INFO] [stdout] 51 | Init { destination: Option }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:63:16 [INFO] [stdout] | [INFO] [stdout] 63 | ReadTree { sha: Sha }, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:72:9 [INFO] [stdout] | [INFO] [stdout] 72 | files: Vec, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / #[clap(help = halp_str())] [INFO] [stdout] 77 | | r#ref: String, [INFO] [stdout] | |_____________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | new_value: Sha, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/argparser.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | / ... /// Writes a tree object that represents a subdirectory . This can be used to write the tree object for a subproject that i... [INFO] [stdout] 86 | | ... prefix: Option, [INFO] [stdout] | |____________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/commands/write_tree.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | write_tree(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 30 | let _ = write_tree(false); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/commit.rs:211:27 [INFO] [stdout] | [INFO] [stdout] 211 | let sha = data.parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/commit.rs:216:27 [INFO] [stdout] | [INFO] [stdout] 216 | let sha = data.parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/git_objects.rs:157:19 [INFO] [stdout] | [INFO] [stdout] 157 | let sha = "6312c14f195ad8be7dfe2fd682c9b6b6bc71c9a3".parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/structures/git_objects.rs:158:9 [INFO] [stdout] | [INFO] [stdout] 158 | read_from_disk(sha); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 158 | let _ = read_from_disk(sha); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/ref_file.rs:41:19 [INFO] [stdout] | [INFO] [stdout] 41 | let sha = buf.trim().parse().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/sha.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | whole.parse().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/sha.rs:85:53 [INFO] [stdout] | [INFO] [stdout] 85 | fn from_str(s: &str) -> Result { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 86 | | if s.len() < 4 { [INFO] [stdout] 87 | | let msg = format!( [INFO] [stdout] 88 | | "fatal: ambiguous argument '{}': unknown revision or path not in the working tree.", [INFO] [stdout] ... | [INFO] [stdout] 114 | | Ok(Self { bytes: out }) [INFO] [stdout] 115 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over a `Result`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/structures/sha.rs:100:34 [INFO] [stdout] | [INFO] [stdout] 100 | for dir_entry in read_dir(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 100 - for dir_entry in read_dir(path) { [INFO] [stdout] 100 + while let Ok(dir_entry) = read_dir(path) { [INFO] [stdout] | [INFO] [stdout] help: consider unwrapping the `Result` with `?` to iterate over its contents [INFO] [stdout] | [INFO] [stdout] 100 | for dir_entry in read_dir(path)? { [INFO] [stdout] | + [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 100 - for dir_entry in read_dir(path) { [INFO] [stdout] 100 + if let Ok(dir_entry) = read_dir(path) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/structures/sha.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | Ok(Self { bytes: out }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `re_flog` (bin "re_flog" test) due to 20 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "0e2ea8a9f1ef58e180338266a99e6599a3a505fd78fee97765c189720e7a5623", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e2ea8a9f1ef58e180338266a99e6599a3a505fd78fee97765c189720e7a5623", kill_on_drop: false }` [INFO] [stdout] 0e2ea8a9f1ef58e180338266a99e6599a3a505fd78fee97765c189720e7a5623