[INFO] cloning repository https://github.com/pgoodjohn/todo-rust-cli [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/pgoodjohn/todo-rust-cli" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpgoodjohn%2Ftodo-rust-cli", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpgoodjohn%2Ftodo-rust-cli'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 20681412842fc3e1109ef65f837256c7a8518800 [INFO] checking pgoodjohn/todo-rust-cli against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fpgoodjohn%2Ftodo-rust-cli" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/pgoodjohn/todo-rust-cli [INFO] finished tweaking git repo https://github.com/pgoodjohn/todo-rust-cli [INFO] tweaked toml for git repo https://github.com/pgoodjohn/todo-rust-cli written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/pgoodjohn/todo-rust-cli on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/pgoodjohn/todo-rust-cli already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c070b6d6badf4b4d75fc3f36c9c0c1e75e11d40d6bc67d3cbab98f73cb2910b3 [INFO] running `Command { std: "docker" "start" "-a" "c070b6d6badf4b4d75fc3f36c9c0c1e75e11d40d6bc67d3cbab98f73cb2910b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c070b6d6badf4b4d75fc3f36c9c0c1e75e11d40d6bc67d3cbab98f73cb2910b3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c070b6d6badf4b4d75fc3f36c9c0c1e75e11d40d6bc67d3cbab98f73cb2910b3", kill_on_drop: false }` [INFO] [stdout] c070b6d6badf4b4d75fc3f36c9c0c1e75e11d40d6bc67d3cbab98f73cb2910b3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d13548687ee721bda7aa1785fcb7e39a1a68f0c24506d421703b299ab8b8e197 [INFO] running `Command { std: "docker" "start" "-a" "d13548687ee721bda7aa1785fcb7e39a1a68f0c24506d421703b299ab8b8e197", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.21 [INFO] [stderr] Compiling syn v1.0.41 [INFO] [stderr] Compiling libc v0.2.77 [INFO] [stderr] Compiling pkg-config v0.3.18 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling unicode-segmentation v1.6.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking linked-hash-map v0.5.3 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking fallible-streaming-iterator v0.1.9 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Checking smallvec v1.4.2 [INFO] [stderr] Checking lru-cache v0.1.2 [INFO] [stderr] Compiling libsqlite3-sys v0.20.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking rusqlite v0.24.0 [INFO] [stderr] Compiling structopt-derive v0.4.10 [INFO] [stderr] Checking structopt v0.3.17 [INFO] [stderr] Checking todo v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `id`, `todo`, and `checked` are never read [INFO] [stdout] --> src/main.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | struct Todo { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 19 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 20 | todo: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 21 | checked: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Todo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | command: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / #[structopt(short = "t", long = "text")] [INFO] [stdout] 12 | | text: Option, [INFO] [stdout] | |________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | initDatabase(conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = initDatabase(conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | listTodos(conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 33 | let _ = listTodos(conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | listAllTodos(conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 35 | let _ = listAllTodos(conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | checkTodo(args.id.unwrap(), conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 37 | let _ = checkTodo(args.id.unwrap(), conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | addTodo(args.text.unwrap(), conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 39 | let _ = addTodo(args.text.unwrap(), conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initDatabase` should have a snake case name [INFO] [stdout] --> src/main.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 47 | fn initDatabase(connection: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `init_database` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `listAllTodos` should have a snake case name [INFO] [stdout] --> src/main.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn listAllTodos(connection: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `list_all_todos` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `checkTodo` should have a snake case name [INFO] [stdout] --> src/main.rs:78:4 [INFO] [stdout] | [INFO] [stdout] 78 | fn checkTodo(todoIdentifier: i32, conn: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `check_todo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `todoIdentifier` should have a snake case name [INFO] [stdout] --> src/main.rs:78:14 [INFO] [stdout] | [INFO] [stdout] 78 | fn checkTodo(todoIdentifier: i32, conn: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `todo_identifier` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `addTodo` should have a snake case name [INFO] [stdout] --> src/main.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fn addTodo(text: String, conn: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `add_todo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `listTodos` should have a snake case name [INFO] [stdout] --> src/main.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | fn listTodos(conn: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `list_todos` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id`, `todo`, and `checked` are never read [INFO] [stdout] --> src/main.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 18 | struct Todo { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 19 | id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] 20 | todo: String, [INFO] [stdout] | ^^^^ [INFO] [stdout] 21 | checked: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Todo` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/main.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | command: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/main.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | / #[structopt(short = "t", long = "text")] [INFO] [stdout] 12 | | text: Option, [INFO] [stdout] | |________________________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | initDatabase(conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 31 | let _ = initDatabase(conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | listTodos(conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 33 | let _ = listTodos(conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | listAllTodos(conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 35 | let _ = listAllTodos(conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | checkTodo(args.id.unwrap(), conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 37 | let _ = checkTodo(args.id.unwrap(), conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/main.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | addTodo(args.text.unwrap(), conn); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 39 | let _ = addTodo(args.text.unwrap(), conn); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `initDatabase` should have a snake case name [INFO] [stdout] --> src/main.rs:47:4 [INFO] [stdout] | [INFO] [stdout] 47 | fn initDatabase(connection: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `init_database` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `listAllTodos` should have a snake case name [INFO] [stdout] --> src/main.rs:59:4 [INFO] [stdout] | [INFO] [stdout] 59 | fn listAllTodos(connection: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^ help: convert the identifier to snake case: `list_all_todos` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `checkTodo` should have a snake case name [INFO] [stdout] --> src/main.rs:78:4 [INFO] [stdout] | [INFO] [stdout] 78 | fn checkTodo(todoIdentifier: i32, conn: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `check_todo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `todoIdentifier` should have a snake case name [INFO] [stdout] --> src/main.rs:78:14 [INFO] [stdout] | [INFO] [stdout] 78 | fn checkTodo(todoIdentifier: i32, conn: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: convert the identifier to snake case: `todo_identifier` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `addTodo` should have a snake case name [INFO] [stdout] --> src/main.rs:87:4 [INFO] [stdout] | [INFO] [stdout] 87 | fn addTodo(text: String, conn: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^ help: convert the identifier to snake case: `add_todo` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `listTodos` should have a snake case name [INFO] [stdout] --> src/main.rs:94:4 [INFO] [stdout] | [INFO] [stdout] 94 | fn listTodos(conn: Connection) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^ help: convert the identifier to snake case: `list_todos` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `todo` (bin "todo" test) due to 2 previous errors; 12 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `todo` (bin "todo") due to 2 previous errors; 12 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d13548687ee721bda7aa1785fcb7e39a1a68f0c24506d421703b299ab8b8e197", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d13548687ee721bda7aa1785fcb7e39a1a68f0c24506d421703b299ab8b8e197", kill_on_drop: false }` [INFO] [stdout] d13548687ee721bda7aa1785fcb7e39a1a68f0c24506d421703b299ab8b8e197