[INFO] cloning repository https://github.com/lantice3720/shulker_engine [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/lantice3720/shulker_engine" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flantice3720%2Fshulker_engine", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flantice3720%2Fshulker_engine'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 49a115b1cae1996e3a9188a8a2b75fd39a190689 [INFO] checking lantice3720/shulker_engine against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Flantice3720%2Fshulker_engine" "/workspace/builds/worker-4-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/lantice3720/shulker_engine [INFO] finished tweaking git repo https://github.com/lantice3720/shulker_engine [INFO] tweaked toml for git repo https://github.com/lantice3720/shulker_engine written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/lantice3720/shulker_engine on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/lantice3720/shulker_engine already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4021b52a42842ab7753c79dabfed4d2bad7aa365f095d058d0c65d038f356a8d [INFO] running `Command { std: "docker" "start" "-a" "4021b52a42842ab7753c79dabfed4d2bad7aa365f095d058d0c65d038f356a8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4021b52a42842ab7753c79dabfed4d2bad7aa365f095d058d0c65d038f356a8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4021b52a42842ab7753c79dabfed4d2bad7aa365f095d058d0c65d038f356a8d", kill_on_drop: false }` [INFO] [stdout] 4021b52a42842ab7753c79dabfed4d2bad7aa365f095d058d0c65d038f356a8d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8f353e4af0b6f0d8c23b0c26922f398a2b044f12cd48b3f59ddb12d1bec51eca [INFO] running `Command { std: "docker" "start" "-a" "8f353e4af0b6f0d8c23b0c26922f398a2b044f12cd48b3f59ddb12d1bec51eca", kill_on_drop: false }` [INFO] [stderr] Checking bytemuck v1.23.0 [INFO] [stderr] Compiling matrixmultiply v0.3.10 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling typenum v1.18.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling nalgebra-macros v0.2.2 [INFO] [stderr] Checking safe_arch v0.7.4 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking wide v0.7.32 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking simba v0.9.0 [INFO] [stderr] Checking nalgebra v0.33.2 [INFO] [stderr] Checking shulker_engine v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Axis` [INFO] [stdout] --> src/physics/player.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::physics::{Axis, Vec3, Vec3f, Vec3i, AABB}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ModifierOperation` [INFO] [stdout] --> src/physics/world.rs:3:30 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::physics::player::{ModifierOperation, Player}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/lib.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 5 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Axis` [INFO] [stdout] --> src/physics/player.rs:2:22 [INFO] [stdout] | [INFO] [stdout] 2 | use crate::physics::{Axis, Vec3, Vec3f, Vec3i, AABB}; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `ModifierOperation` [INFO] [stdout] --> src/physics/world.rs:3:30 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::physics::player::{ModifierOperation, Player}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `open` [INFO] [stdout] --> src/physics/block.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | open, [INFO] [stdout] | ^^^^ help: try ignoring the field: `open: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `facing` [INFO] [stdout] --> src/physics/block.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | facing, [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `facing: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/physics/player.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | let mut velocity = self.velocity; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `collide_velocity` [INFO] [stdout] --> src/physics/player.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | let collide_velocity = Vec3f( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_collide_velocity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `open` [INFO] [stdout] --> src/physics/block.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | open, [INFO] [stdout] | ^^^^ help: try ignoring the field: `open: _` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `facing` [INFO] [stdout] --> src/physics/block.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | facing, [INFO] [stdout] | ^^^^^^ help: try ignoring the field: `facing: _` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/physics/player.rs:139:13 [INFO] [stdout] | [INFO] [stdout] 139 | let mut velocity = self.velocity; [INFO] [stdout] | ----^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `collide_velocity` [INFO] [stdout] --> src/physics/player.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | let collide_velocity = Vec3f( [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_collide_velocity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/physics/player.rs:220:30 [INFO] [stdout] | [INFO] [stdout] 220 | for add_modifiers in self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 220 - for add_modifiers in self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] 220 + while let Some(add_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 220 - for add_modifiers in self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] 220 + if let Some(add_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/physics/player.rs:228:40 [INFO] [stdout] | [INFO] [stdout] 228 | for multiply_base_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 228 - for multiply_base_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] 228 + while let Some(multiply_base_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 228 - for multiply_base_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] 228 + if let Some(multiply_base_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/physics/player.rs:234:41 [INFO] [stdout] | [INFO] [stdout] 234 | for multiply_total_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 234 - for multiply_total_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] 234 + while let Some(multiply_total_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 234 - for multiply_total_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] 234 + if let Some(multiply_total_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/physics/player.rs:220:30 [INFO] [stdout] | [INFO] [stdout] 220 | for add_modifiers in self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(for_loops_over_fallibles)]` on by default [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 220 - for add_modifiers in self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] 220 + while let Some(add_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 220 - for add_modifiers in self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] 220 + if let Some(add_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::Add) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/physics/player.rs:228:40 [INFO] [stdout] | [INFO] [stdout] 228 | for multiply_base_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 228 - for multiply_base_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] 228 + while let Some(multiply_base_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 228 - for multiply_base_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] 228 + if let Some(multiply_base_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::MultiplyBase) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: for loop over an `Option`. This is more readably written as an `if let` statement [INFO] [stdout] --> src/physics/player.rs:234:41 [INFO] [stdout] | [INFO] [stdout] 234 | for multiply_total_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: to check pattern in a loop use `while let` [INFO] [stdout] | [INFO] [stdout] 234 - for multiply_total_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] 234 + while let Some(multiply_total_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] | [INFO] [stdout] help: consider using `if let` to clear intent [INFO] [stdout] | [INFO] [stdout] 234 - for multiply_total_modifiers in self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] 234 + if let Some(multiply_total_modifiers) = self.modifiers_by_operation.get(&ModifierOperation::MultiplyTotal) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/physics/player.rs:247:26 [INFO] [stdout] | [INFO] [stdout] 247 | modifiers.insert(id.parse().unwrap(), value); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: Result [INFO] [stdout] --> src/physics/player.rs:247:26 [INFO] [stdout] | [INFO] [stdout] 247 | modifiers.insert(id.parse().unwrap(), value); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shulker_engine` (lib test) due to 1 previous error; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `shulker_engine` (lib) due to 1 previous error; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "8f353e4af0b6f0d8c23b0c26922f398a2b044f12cd48b3f59ddb12d1bec51eca", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8f353e4af0b6f0d8c23b0c26922f398a2b044f12cd48b3f59ddb12d1bec51eca", kill_on_drop: false }` [INFO] [stdout] 8f353e4af0b6f0d8c23b0c26922f398a2b044f12cd48b3f59ddb12d1bec51eca