[INFO] cloning repository https://github.com/fabianschuiki/bender [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/fabianschuiki/bender" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffabianschuiki%2Fbender", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffabianschuiki%2Fbender'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 71c6a9c9764dc65a27649c24ac4146308dbc7c89 [INFO] checking fabianschuiki/bender against try#4f260f0f20b3133d20cfb50353c0221943af5796+rustflags=-Dunmustuse_in_always_ok for pr-148577 [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Ffabianschuiki%2Fbender" "/workspace/builds/worker-5-tc2/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc2/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/fabianschuiki/bender [INFO] finished tweaking git repo https://github.com/fabianschuiki/bender [INFO] tweaked toml for git repo https://github.com/fabianschuiki/bender written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/fabianschuiki/bender on toolchain 4f260f0f20b3133d20cfb50353c0221943af5796 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/fabianschuiki/bender already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] [stderr] Adding tabwriter v1.4.1 [INFO] [stderr] Adding unicode-width v0.2.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] baa6868195c86604f3e3745500a4dbed51b6a286030a1e3a1e7cde319f59539c [INFO] running `Command { std: "docker" "start" "-a" "baa6868195c86604f3e3745500a4dbed51b6a286030a1e3a1e7cde319f59539c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "baa6868195c86604f3e3745500a4dbed51b6a286030a1e3a1e7cde319f59539c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "baa6868195c86604f3e3745500a4dbed51b6a286030a1e3a1e7cde319f59539c", kill_on_drop: false }` [INFO] [stdout] baa6868195c86604f3e3745500a4dbed51b6a286030a1e3a1e7cde319f59539c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dunmustuse_in_always_ok" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:4848fb76d95f26979359cc7e45710b1dbc8f3acb7aeedee7c460d7702230f228" "/opt/rustwide/cargo-home/bin/cargo" "+4f260f0f20b3133d20cfb50353c0221943af5796" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1e2f2f279966f3ed5309898ffe2b027261ec652e5b466b145b2bae766fc6eb4 [INFO] running `Command { std: "docker" "start" "-a" "c1e2f2f279966f3ed5309898ffe2b027261ec652e5b466b145b2bae766fc6eb4", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.82 [INFO] [stderr] Checking futures v0.1.30 [INFO] [stderr] Compiling log v0.4.13 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Compiling serde v1.0.120 [INFO] [stderr] Compiling memoffset v0.5.6 [INFO] [stderr] Compiling generic-array v0.14.4 [INFO] [stderr] Checking scoped-tls v0.1.2 [INFO] [stderr] Compiling syn v1.0.58 [INFO] [stderr] Checking ucd-trie v0.1.3 [INFO] [stderr] Checking smallvec v0.6.14 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking crossbeam-queue v0.2.3 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Checking subtle v2.4.0 [INFO] [stderr] Compiling serde_derive v1.0.120 [INFO] [stderr] Checking dtoa v0.4.7 [INFO] [stderr] Checking unicode-width v0.2.2 [INFO] [stderr] Checking pest v2.1.3 [INFO] [stderr] Checking itoa v0.4.7 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking itertools v0.9.0 [INFO] [stderr] Checking typed-arena v2.0.1 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking tabwriter v1.4.1 [INFO] [stderr] Checking pathdiff v0.2.0 [INFO] [stderr] Checking crossbeam-epoch v0.8.2 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking crossbeam-deque v0.7.3 [INFO] [stderr] Checking blake2 v0.9.1 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking net2 v0.2.37 [INFO] [stderr] Checking parking_lot_core v0.6.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Checking bytes v0.4.12 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking parking_lot v0.9.0 [INFO] [stderr] Checking semver-parser v0.10.2 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking tokio-executor v0.1.10 [INFO] [stderr] Checking tokio-io v0.1.13 [INFO] [stderr] Checking tokio-sync v0.1.8 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking tokio-threadpool v0.1.18 [INFO] [stderr] Checking tokio-current-thread v0.1.7 [INFO] [stderr] Checking tokio-timer v0.2.13 [INFO] [stderr] Checking semver v0.11.0 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking tokio-reactor v0.1.12 [INFO] [stderr] Checking tokio-codec v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.7 [INFO] [stderr] Checking tokio-uds v0.2.7 [INFO] [stderr] Checking tokio-udp v0.1.6 [INFO] [stderr] Checking tokio-tcp v0.1.4 [INFO] [stderr] Checking tokio v0.1.22 [INFO] [stderr] Checking tokio-core v0.1.18 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Checking tokio-process v0.1.6 [INFO] [stderr] Checking serde_yaml v0.8.15 [INFO] [stderr] Checking serde_json v1.0.61 [INFO] [stderr] Checking bender v0.22.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/cmd/script.rs:827:6 [INFO] [stdout] | [INFO] [stdout] 827 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/cmd/script.rs:827:6 [INFO] [stdout] | [INFO] [stdout] 827 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/config.rs:350:61 [INFO] [stdout] | [INFO] [stdout] 350 | fn from_str(s: &str) -> std::result::Result { [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 351 | | Ok(PartialDependency { [INFO] [stdout] 352 | | path: None, [INFO] [stdout] 353 | | git: None, [INFO] [stdout] ... | [INFO] [stdout] 356 | | }) [INFO] [stdout] 357 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/config.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 351 | / Ok(PartialDependency { [INFO] [stdout] 352 | | path: None, [INFO] [stdout] 353 | | git: None, [INFO] [stdout] 354 | | rev: None, [INFO] [stdout] 355 | | version: Some(s.into()), [INFO] [stdout] 356 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/config.rs:350:61 [INFO] [stdout] | [INFO] [stdout] 350 | fn from_str(s: &str) -> std::result::Result { [INFO] [stdout] | _____________________________________________________________^ [INFO] [stdout] 351 | | Ok(PartialDependency { [INFO] [stdout] 352 | | path: None, [INFO] [stdout] 353 | | git: None, [INFO] [stdout] ... | [INFO] [stdout] 356 | | }) [INFO] [stdout] 357 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = note: requested on the command line with `-D unmustuse-in-always-ok` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: this type will no longer be must used: std::result::Result [INFO] [stdout] --> src/config.rs:351:9 [INFO] [stdout] | [INFO] [stdout] 351 | / Ok(PartialDependency { [INFO] [stdout] 352 | | path: None, [INFO] [stdout] 353 | | git: None, [INFO] [stdout] 354 | | rev: None, [INFO] [stdout] 355 | | version: Some(s.into()), [INFO] [stdout] 356 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resolver.rs:133:48 [INFO] [stdout] | [INFO] [stdout] 133 | let rev = gv.revs[pick].clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: call to `.clone()` on a reference in this situation does nothing [INFO] [stdout] --> src/resolver.rs:133:48 [INFO] [stdout] | [INFO] [stdout] 133 | let rev = gv.revs[pick].clone(); [INFO] [stdout] | ^^^^^^^^ help: remove this redundant call [INFO] [stdout] | [INFO] [stdout] = note: the type `str` does not implement `Clone`, so calling `clone` on `&str` copies the reference, which does not do anything and can be removed [INFO] [stdout] = note: `#[warn(noop_method_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&PathBuf` instead of cloning the inner type [INFO] [stdout] --> src/sess.rs:999:61 [INFO] [stdout] | [INFO] [stdout] 999 | ... .map(|p| self.sess.intern_path(p.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&PathBuf` instead of cloning the inner type [INFO] [stdout] --> src/sess.rs:999:61 [INFO] [stdout] | [INFO] [stdout] 999 | ... .map(|p| self.sess.intern_path(p.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(suspicious_double_ref_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/src.rs:151:41 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|(k, v)| (k.clone(), v.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `.clone()` on a double reference, which returns `&str` instead of cloning the inner type [INFO] [stdout] --> src/src.rs:151:41 [INFO] [stdout] | [INFO] [stdout] 151 | .map(|(k, v)| (k.clone(), v.clone())) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `bender` (bin "bender") due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `bender` (bin "bender" test) due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c1e2f2f279966f3ed5309898ffe2b027261ec652e5b466b145b2bae766fc6eb4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1e2f2f279966f3ed5309898ffe2b027261ec652e5b466b145b2bae766fc6eb4", kill_on_drop: false }` [INFO] [stdout] c1e2f2f279966f3ed5309898ffe2b027261ec652e5b466b145b2bae766fc6eb4